156046 2016-03-30 16:27:52 -0700 Need to expose makeAllShadowRootsOpen in WKWebProcessPlugInScriptWorld. 2016-03-30 20:56:28 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang webkit-unassigned andersca commit-queue mitz rniwa sam oldest_to_newest 1179228 0 yongjun_zhang 2016-03-30 16:27:52 -0700 http://trac.webkit.org/changeset/195686 added C SPI WKBundleScriptWorldMakeAllShadowRootsOpen, we should also expose makeAllShadowRootsOpen in WebKit ObjC SPI. 1179230 1 275235 yongjun_zhang 2016-03-30 16:32:33 -0700 Created attachment 275235 Patch. 1179231 2 yongjun_zhang 2016-03-30 16:33:37 -0700 <rdar://problem/23183183> 1179281 3 275235 mitz 2016-03-30 18:30:02 -0700 Comment on attachment 275235 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=275235&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.h:41 > +- (void)makeAllShadowRootsOpen; WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA) 1179305 4 275258 yongjun_zhang 2016-03-30 19:57:49 -0700 Created attachment 275258 Address review comment before landing. 1179314 5 275258 commit-queue 2016-03-30 20:56:24 -0700 Comment on attachment 275258 Address review comment before landing. Clearing flags on attachment: 275258 Committed r198881: <http://trac.webkit.org/changeset/198881> 1179315 6 commit-queue 2016-03-30 20:56:28 -0700 All reviewed patches have been landed. Closing bug. 275235 2016-03-30 16:32:33 -0700 2016-03-30 19:57:49 -0700 Patch. shadow_root_open.patch text/plain 2278 yongjun_zhang Y29tbWl0IGM3MjhkNzkzNjhjOTU1NzJiZDhjZjhiZDkwNTZmZTk5MTg0YWMzNDYKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBXZWQgTWFyIDMw IDEzOjU0OjAxIDIwMTYgLTA3MDAKCiAgICBOZWVkIHRvIGV4cG9zZSBtYWtlQWxsU2hhZG93Um9v dHNPcGVuIGluIFdLV2ViUHJvY2Vzc1BsdWdJblNjcmlwdFdvcmxkLgogICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjA0NgoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBlYzVlODU5 Li42YWE0ZjViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDMtMzAgIFlvbmdq dW4gWmhhbmcgIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KKworICAgICAgICBOZWVkIHRvIGV4 cG9zZSBtYWtlQWxsU2hhZG93Um9vdHNPcGVuIGluIFdLV2ViUHJvY2Vzc1BsdWdJblNjcmlwdFdv cmxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2 MDQ2CisKKyAgICAgICAgQWRkIGFuIFNQSSBtYWtlQWxsU2hhZG93Um9vdHNPcGVuIG1ldGhvZCBp biBXS1dlYlByb2Nlc3NQbHVnSW5TY3JpcHRXb3JsZC4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJ L0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJblNjcmlwdFdvcmxkLmg6CisgICAgICAgICogV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luU2NyaXB0V29y bGQubW06CisgICAgICAgICgtW1dLV2ViUHJvY2Vzc1BsdWdJblNjcmlwdFdvcmxkIG1ha2VBbGxT aGFkb3dSb290c09wZW5dKToKKwogMjAxNi0wMy0zMCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4 ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSByZWZlcmVuY2VzIGluc3RlYWQgb2YgcG9p bnRlcnMgaW4gc2Nyb2xsYmFyLXJlbGF0ZWQgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0lu U2NyaXB0V29ybGQuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUv QVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJblNjcmlwdFdvcmxkLmgKaW5kZXggZWEzMGUzYy4u ZDg1NGFjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luU2NyaXB0V29ybGQuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nl c3NQbHVnSW5TY3JpcHRXb3JsZC5oCkBAIC0zOCw2ICszOCw3IEBAIFdLX0NMQVNTX0FWQUlMQUJM RSgxMF8xMCwgOF8wKQogQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5LCBjb3B5KSBOU1N0 cmluZyAqbmFtZTsKIAogLSAodm9pZCljbGVhcldyYXBwZXJzOworLSAodm9pZCltYWtlQWxsU2hh ZG93Um9vdHNPcGVuOwogCiBAZW5kCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJblNjcmlwdFdv cmxkLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29j b2EvV0tXZWJQcm9jZXNzUGx1Z0luU2NyaXB0V29ybGQubW0KaW5kZXggMmEyZGVkOC4uNmMxMDYx ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B UEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luU2NyaXB0V29ybGQubW0KKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1 Z0luU2NyaXB0V29ybGQubW0KQEAgLTU2LDYgKzU2LDExIEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJL aXQ7CiAgICAgX3dvcmxkLT5jbGVhcldyYXBwZXJzKCk7CiB9CiAKKy0gKHZvaWQpbWFrZUFsbFNo YWRvd1Jvb3RzT3BlbgoreworICAgIF93b3JsZC0+bWFrZUFsbFNoYWRvd1Jvb3RzT3BlbigpOwor fQorCiAtIChOU1N0cmluZyAqKW5hbWUKIHsKICAgICByZXR1cm4gX3dvcmxkLT5uYW1lKCk7Cg== 275258 2016-03-30 19:57:49 -0700 2016-03-30 20:56:24 -0700 Address review comment before landing. shadow_root.patch text/plain 2314 yongjun_zhang Y29tbWl0IDE3ZjkyZjMzZGYzMzhhZTExOTg4MjdiN2ExMDJhOWI4Mzg2ZDE1MDgKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBXZWQgTWFyIDMw IDEzOjU0OjAxIDIwMTYgLTA3MDAKCiAgICBOZWVkIHRvIGV4cG9zZSBtYWtlQWxsU2hhZG93Um9v dHNPcGVuIGluIFdLV2ViUHJvY2Vzc1BsdWdJblNjcmlwdFdvcmxkLgogICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjA0NgoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBlYzVlODU5 Li5mMWE5YjRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDMtMzAgIFlvbmdq dW4gWmhhbmcgIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KKworICAgICAgICBOZWVkIHRvIGV4 cG9zZSBtYWtlQWxsU2hhZG93Um9vdHNPcGVuIGluIFdLV2ViUHJvY2Vzc1BsdWdJblNjcmlwdFdv cmxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2 MDQ2CisKKyAgICAgICAgQWRkIGFuIFNQSSBtYWtlQWxsU2hhZG93Um9vdHNPcGVuIG1ldGhvZCBp biBXS1dlYlByb2Nlc3NQbHVnSW5TY3JpcHRXb3JsZC4KKworICAgICAgICBSZXZpZXdlZCBieSBE YW4gQmVybnN0ZWluLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkv Q29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luU2NyaXB0V29ybGQuaDoKKyAgICAgICAgKiBXZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVnSW5TY3JpcHRXb3Js ZC5tbToKKyAgICAgICAgKC1bV0tXZWJQcm9jZXNzUGx1Z0luU2NyaXB0V29ybGQgbWFrZUFsbFNo YWRvd1Jvb3RzT3Blbl0pOgorCiAyMDE2LTAzLTMwICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhm aWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIHJlZmVyZW5jZXMgaW5zdGVhZCBvZiBwb2lu dGVycyBpbiBzY3JvbGxiYXItcmVsYXRlZCBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVnSW5T Y3JpcHRXb3JsZC5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B UEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luU2NyaXB0V29ybGQuaAppbmRleCBlYTMwZTNjLi5i NDg5YzdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVu ZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVnSW5TY3JpcHRXb3JsZC5oCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vz c1BsdWdJblNjcmlwdFdvcmxkLmgKQEAgLTM4LDYgKzM4LDcgQEAgV0tfQ0xBU1NfQVZBSUxBQkxF KDEwXzEwLCA4XzApCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGNvcHkpIE5TU3Ry aW5nICpuYW1lOwogCiAtICh2b2lkKWNsZWFyV3JhcHBlcnM7CistICh2b2lkKW1ha2VBbGxTaGFk b3dSb290c09wZW4gV0tfQVZBSUxBQkxFKFdLX01BQ19UQkEsIFdLX0lPU19UQkEpOwogCiBAZW5k CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUv QVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJblNjcmlwdFdvcmxkLm1tIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0lu U2NyaXB0V29ybGQubW0KaW5kZXggMmEyZGVkOC4uNmMxMDYxZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNz UGx1Z0luU2NyaXB0V29ybGQubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Jbmpl Y3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luU2NyaXB0V29ybGQubW0KQEAg LTU2LDYgKzU2LDExIEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAgICAgX3dvcmxkLT5jbGVh cldyYXBwZXJzKCk7CiB9CiAKKy0gKHZvaWQpbWFrZUFsbFNoYWRvd1Jvb3RzT3BlbgoreworICAg IF93b3JsZC0+bWFrZUFsbFNoYWRvd1Jvb3RzT3BlbigpOworfQorCiAtIChOU1N0cmluZyAqKW5h bWUKIHsKICAgICByZXR1cm4gX3dvcmxkLT5uYW1lKCk7Cg==