156036 2016-03-30 13:01:13 -0700 Fix Content-Range requests when not using the NetworkCache with NetworkSession 2016-04-05 18:37:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen commit-queue jer.noble oldest_to_newest 1179159 0 achristensen 2016-03-30 13:01:13 -0700 Fix Content-Range requests when not using the NetworkCache with NetworkSession 1179165 1 275215 achristensen 2016-03-30 13:14:05 -0700 Created attachment 275215 Patch 1179339 2 275215 sam 2016-03-30 23:03:09 -0700 Comment on attachment 275215 Patch Test case? 1179465 3 achristensen 2016-03-31 10:42:10 -0700 I looked into writing an automated test case, but this is only needed when the NetworkCache is disabled, which is not true for WebKitTestRunner, and when loading from the network, which is not true for TestWebKitAPI. Doing the manual test in the radar certainly shows that this fixes a problem with videos on WK2 apps with the NetworkCache disabled. 1180202 4 275215 darin 2016-04-03 12:35:22 -0700 Comment on attachment 275215 Patch Could you please add a regression test? 1180432 5 275562 achristensen 2016-04-04 11:39:32 -0700 Created attachment 275562 Patch 1180440 6 achristensen 2016-04-04 11:53:16 -0700 (In reply to comment #4) > Comment on attachment 275215 [details] > Patch > > Could you please add a regression test? I don't think it is reasonable to do this because this is to fix a compatibility bug with a program that does not use the NetworkCache, which is not possible with a program that is linked with a recent version of WebKit. 1181120 7 275562 commit-queue 2016-04-05 18:37:10 -0700 Comment on attachment 275562 Patch Clearing flags on attachment: 275562 Committed r199090: <http://trac.webkit.org/changeset/199090> 1181121 8 commit-queue 2016-04-05 18:37:13 -0700 All reviewed patches have been landed. Closing bug. 275215 2016-03-30 13:14:05 -0700 2016-04-04 11:39:29 -0700 Patch bug-156036-20160330131409.patch text/plain 1927 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODg1MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAzLTMwICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IFJhbmdl IHJlcXVlc3RzIHdoZW4gbm90IHVzaW5nIHRoZSBOZXR3b3JrQ2FjaGUgd2l0aCBOZXR3b3JrU2Vz c2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2 MDM2CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI1MzM0OTM5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3 b3JrU2Vzc2lvbkNvY29hLm1tOgorICAgICAgICAoLVtXS05ldHdvcmtTZXNzaW9uRGVsZWdhdGUg VVJMU2Vzc2lvbjpkYXRhVGFzazp3aWxsQ2FjaGVSZXNwb25zZTpjb21wbGV0aW9uSGFuZGxlcjpd KToKKyAgICAgICAgRG9uJ3QgY2FjaGUgYW55IHJlc3BvbnNlcyB3aXRoIENvbnRlbnQtUmFuZ2Ug aGVhZGVycyB0byB3b3JrIGFyb3VuZCByZGFyOi8vcHJvYmxlbS8yMDAwMTk4NS4KKyAgICAgICAg VGhpcyBpcyBzaW1pbGFyIHRvIHRoZSB3b3JrYXJvdW5kIGluIHNob3VsZENhY2hlUmVzcG9uc2Ug aW4gV2ViQ29yZU5TVVJMU2Vzc2lvbi5tbQorCiAyMDE2LTAzLTMwICBNeWxlcyBDLiBNYXhmaWVs ZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIHJlZmVyZW5jZXMgaW5zdGVh ZCBvZiBwb2ludGVycyBpbiBzY3JvbGxiYXItcmVsYXRlZCBjb2RlCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9u Q29jb2EubW0JKHJldmlzaW9uIDE5ODgwNykKKysrIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTI1Niw2 ICsyNTYsMTYgQEAgLSAodm9pZClVUkxTZXNzaW9uOihOU1VSTFNlc3Npb24gKilzZXNzaQogICAg IH0KIH0KIAorLSAodm9pZClVUkxTZXNzaW9uOihOU1VSTFNlc3Npb24gKilzZXNzaW9uIGRhdGFU YXNrOihOU1VSTFNlc3Npb25EYXRhVGFzayAqKWRhdGFUYXNrIHdpbGxDYWNoZVJlc3BvbnNlOihO U0NhY2hlZFVSTFJlc3BvbnNlICopcHJvcG9zZWRSZXNwb25zZSBjb21wbGV0aW9uSGFuZGxlcjoo dm9pZCAoXikoTlNDYWNoZWRVUkxSZXNwb25zZSAqIF9OdWxsYWJsZSBjYWNoZWRSZXNwb25zZSkp Y29tcGxldGlvbkhhbmRsZXIKK3sKKyAgICAvLyBGSVhNRTogcmVtb3ZlIGlmIDxyZGFyOi8vcHJv YmxlbS8yMDAwMTk4NT4gaXMgZXZlciByZXNvbHZlZC4KKyAgICBpZiAoW3Byb3Bvc2VkUmVzcG9u c2UucmVzcG9uc2UgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihhbGxIZWFkZXJGaWVsZHMp XQorICAgICAgICAmJiBbWyhpZClwcm9wb3NlZFJlc3BvbnNlLnJlc3BvbnNlIGFsbEhlYWRlckZp ZWxkc10gb2JqZWN0Rm9yS2V5OkAiQ29udGVudC1SYW5nZSJdKQorICAgICAgICBjb21wbGV0aW9u SGFuZGxlcihuaWwpOworICAgIGVsc2UKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIocHJvcG9z ZWRSZXNwb25zZSk7Cit9CisKIEBlbmQKIAogbmFtZXNwYWNlIFdlYktpdCB7Cg== 275562 2016-04-04 11:39:32 -0700 2016-04-05 18:37:10 -0700 Patch bug-156036-20160404113952.patch text/plain 3043 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTAxMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA0LTA0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IFJhbmdl IHJlcXVlc3RzIHdoZW4gbm90IHVzaW5nIHRoZSBOZXR3b3JrQ2FjaGUgd2l0aCBOZXR3b3JrU2Vz c2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2 MDM2CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI1MzM0OTM5CisgCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0 d29ya1Nlc3Npb25Db2NvYS5tbToKKyAgICAgICAgKC1bV0tOZXR3b3JrU2Vzc2lvbkRlbGVnYXRl IFVSTFNlc3Npb246ZGF0YVRhc2s6d2lsbENhY2hlUmVzcG9uc2U6Y29tcGxldGlvbkhhbmRsZXI6 XSk6CisgICAgICAgIERvbid0IGNhY2hlIGFueSByZXNwb25zZXMgd2l0aCBDb250ZW50LVJhbmdl IGhlYWRlcnMgdG8gd29yayBhcm91bmQgcmRhcjovL3Byb2JsZW0vMjAwMDE5ODUuCisgICAgICAg IFRoaXMgaXMgc2ltaWxhciB0byB0aGUgd29ya2Fyb3VuZCBpbiBzaG91bGRDYWNoZVJlc3BvbnNl IGluIFdlYkNvcmVOU1VSTFNlc3Npb24ubW0KKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Nlc3Np b246Ok5ldHdvcmtTZXNzaW9uKToKKyAgICAgICAgSWYgd2UgYXJlIHVzaW5nIHRoZSBOZXR3b3Jr Q2FjaGUsIHRoZW4gZG9uJ3QgdXNlIENGTmV0d29yaydzIGNhY2hlLgorCiAyMDE2LTA0LTA0ICBK b29uZ2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBG aXggYnVpbGQgYnJlYWsgc2luY2UgcjE5ODgwMApJbmRleDogU291cmNlL1dlYktpdDIvTmV0d29y a1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCShy ZXZpc2lvbiAxOTkwMDcpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9O ZXR3b3JrU2Vzc2lvbkNvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw3IEBACiAj aW1wb3J0ICJDdXN0b21Qcm90b2NvbE1hbmFnZXIuaCIKICNpbXBvcnQgIkRhdGFSZWZlcmVuY2Uu aCIKICNpbXBvcnQgIkRvd25sb2FkLmgiCisjaW1wb3J0ICJOZXR3b3JrQ2FjaGUuaCIKICNpbXBv cnQgIk5ldHdvcmtMb2FkLmgiCiAjaW1wb3J0ICJOZXR3b3JrUHJvY2Vzcy5oIgogI2ltcG9ydCAi U2Vzc2lvblRyYWNrZXIuaCIKQEAgLTEyNSw2ICsxMjYsMTYgQEAgLSAodm9pZClVUkxTZXNzaW9u OihOU1VSTFNlc3Npb24gKilzZXNzaQogICAgIH0KIH0KIAorLSAodm9pZClVUkxTZXNzaW9uOihO U1VSTFNlc3Npb24gKilzZXNzaW9uIGRhdGFUYXNrOihOU1VSTFNlc3Npb25EYXRhVGFzayAqKWRh dGFUYXNrIHdpbGxDYWNoZVJlc3BvbnNlOihOU0NhY2hlZFVSTFJlc3BvbnNlICopcHJvcG9zZWRS ZXNwb25zZSBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoTlNDYWNoZWRVUkxSZXNwb25zZSAq IF9OdWxsYWJsZSBjYWNoZWRSZXNwb25zZSkpY29tcGxldGlvbkhhbmRsZXIKK3sKKyAgICAvLyBG SVhNRTogcmVtb3ZlIGlmIDxyZGFyOi8vcHJvYmxlbS8yMDAwMTk4NT4gaXMgZXZlciByZXNvbHZl ZC4KKyAgICBpZiAoW3Byb3Bvc2VkUmVzcG9uc2UucmVzcG9uc2UgcmVzcG9uZHNUb1NlbGVjdG9y OkBzZWxlY3RvcihhbGxIZWFkZXJGaWVsZHMpXQorICAgICAgICAmJiBbWyhpZClwcm9wb3NlZFJl c3BvbnNlLnJlc3BvbnNlIGFsbEhlYWRlckZpZWxkc10gb2JqZWN0Rm9yS2V5OkAiQ29udGVudC1S YW5nZSJdKQorICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihuaWwpOworICAgIGVsc2UKKyAgICAg ICAgY29tcGxldGlvbkhhbmRsZXIocHJvcG9zZWRSZXNwb25zZSk7Cit9CisKIC0gKHZvaWQpVVJM U2Vzc2lvbjooTlNVUkxTZXNzaW9uICopc2Vzc2lvbiB0YXNrOihOU1VSTFNlc3Npb25UYXNrICop dGFzayBkaWRSZWNlaXZlQ2hhbGxlbmdlOihOU1VSTEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlICop Y2hhbGxlbmdlIGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShOU1VSTFNlc3Npb25BdXRoQ2hh bGxlbmdlRGlzcG9zaXRpb24gZGlzcG9zaXRpb24sIE5TVVJMQ3JlZGVudGlhbCAqY3JlZGVudGlh bCkpY29tcGxldGlvbkhhbmRsZXIKIHsKICAgICBhdXRvIHN0b3JlZENyZWRlbnRpYWxzID0gc2Vz c2lvbi5jb25maWd1cmF0aW9uLlVSTENyZWRlbnRpYWxTdG9yYWdlID8gV2ViQ29yZTo6U3RvcmVk Q3JlZGVudGlhbHM6OkFsbG93U3RvcmVkQ3JlZGVudGlhbHMgOiBXZWJDb3JlOjpTdG9yZWRDcmVk ZW50aWFsczo6RG9Ob3RBbGxvd1N0b3JlZENyZWRlbnRpYWxzOwpAQCAtMzEyLDYgKzMyMyw5IEBA IE5ldHdvcmtTZXNzaW9uOjpOZXR3b3JrU2Vzc2lvbihUeXBlIHR5cGUKIAogICAgIE5TVVJMU2Vz c2lvbkNvbmZpZ3VyYXRpb24gKmNvbmZpZ3VyYXRpb24gPSBjb25maWd1cmF0aW9uRm9yVHlwZSh0 eXBlKTsKIAorICAgIGlmIChOZXR3b3JrQ2FjaGU6OnNpbmdsZXRvbigpLmlzRW5hYmxlZCgpKQor ICAgICAgICBjb25maWd1cmF0aW9uLlVSTENhY2hlID0gbmlsOworICAgIAogICAgIGlmIChhdXRv JiBkYXRhID0gZ2xvYmFsU291cmNlQXBwbGljYXRpb25BdWRpdFRva2VuRGF0YSgpKQogICAgICAg ICBjb25maWd1cmF0aW9uLl9zb3VyY2VBcHBsaWNhdGlvbkF1ZGl0VG9rZW5EYXRhID0gKE5TRGF0 YSAqKWRhdGEuZ2V0KCk7CiAgICAgCg==