155996 2016-03-29 16:49:42 -0700 Add a style for Data Detectors links 2016-03-30 16:09:56 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica dino sam thorton oldest_to_newest 1178863 0 enrica 2016-03-29 16:49:42 -0700 Based on indication from the data detection engine, we should style some of the links differently. rdar://problem/25343514 1179198 1 275226 enrica 2016-03-30 14:57:42 -0700 Created attachment 275226 Patch 1179206 2 275226 sam 2016-03-30 15:10:52 -0700 Comment on attachment 275226 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275226&action=review > Source/WebCore/editing/cocoa/DataDetection.mm:55 > +const char *dataDetectorsLinkStyle = "-webkit-text-decoration-color:rgb(199, 199, 204); color:initial;"; * on the wrong side. > Source/WebCore/editing/cocoa/DataDetection.mm:332 > + isSubResult = length > 1; Is it really necessary for this calculation to happen in this function? Seems like it would be cleaner to do it at the call site. 1179207 3 enrica 2016-03-30 15:14:56 -0700 > > Source/WebCore/editing/cocoa/DataDetection.mm:332 > > + isSubResult = length > 1; > > Is it really necessary for this calculation to happen in this function? > Seems like it would be cleaner to do it at the call site. I believe it makes more sense to do it inside the function where we decide what is a sub result. 1179208 4 enrica 2016-03-30 15:16:48 -0700 (In reply to comment #3) > > > Source/WebCore/editing/cocoa/DataDetection.mm:332 > > > + isSubResult = length > 1; > > > > Is it really necessary for this calculation to happen in this function? > > Seems like it would be cleaner to do it at the call site. > I believe it makes more sense to do it inside the function where we decide > what is a sub result. Actually, I think you're correct. I'll change it. 1179224 5 enrica 2016-03-30 16:09:56 -0700 Committed revision 198864. 275226 2016-03-30 14:57:42 -0700 2016-03-30 15:10:52 -0700 Patch new-ddlink-style.txt text/plain 6287 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODg1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE2LTAzLTMwICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgc3R5bGUgZm9yIERh dGEgRGV0ZWN0b3JzIGxpbmtzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU1OTk2CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI1MzQzNTE0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFzZWQgb24gaW5k aWNhdGlvbiBmcm9tIHRoZSBkYXRhIGRldGVjdGlvbiBlbmdpbmUsCisgICAgICAgIHdlIHN0eWxl IHNvbWUgb2YgdGhlIGxpbmtzIGRpZmZlcmVudGx5LgorCisgICAgICAgICogZWRpdGluZy9jb2Nv YS9EYXRhRGV0ZWN0aW9uLm1tOgorICAgICAgICAoV2ViQ29yZTo6ZGF0YURldGVjdG9yVHlwZUZv ckNhdGVnb3J5KToKKyAgICAgICAgKFdlYkNvcmU6OmRhdGFEZXRlY3RvclN0cmluZ0ZvclBhdGgp OgorICAgICAgICAoV2ViQ29yZTo6RGF0YURldGVjdGlvbjo6ZGV0ZWN0Q29udGVudEluUmFuZ2Up OgorICAgICAgICAqIHBsYXRmb3JtL2NvY29hL0RhdGFEZXRlY3RvcnNDb3JlU29mdExpbmsuaDoK KyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9EYXRhRGV0ZWN0b3JzQ29yZVNvZnRMaW5rLm1tOgor CiAyMDE2LTAzLTMwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgRml4IFdpbmRvd3MgRVdTIGFmdGVyIHIxOTg3NjYKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvY29jb2EvRGF0YURldGVjdGlvbi5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0RhdGFEZXRlY3Rpb24ubW0JKHJldmlzaW9uIDE5ODg1 NikKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRGF0YURldGVjdGlvbi5tbQkod29y a2luZyBjb3B5KQpAQCAtNTIsNiArNTIsNyBAQAogY29uc3QgY2hhciAqZGF0YURldGVjdG9yc1VS TFNjaGVtZSA9ICJ4LWFwcGxlLWRhdGEtZGV0ZWN0b3JzIjsKIGNvbnN0IGNoYXIgKmRhdGFEZXRl Y3RvcnNBdHRyaWJ1dGVUeXBlS2V5ID0gIngtYXBwbGUtZGF0YS1kZXRlY3RvcnMtdHlwZSI7CiBj b25zdCBjaGFyICpkYXRhRGV0ZWN0b3JzQXR0cmlidXRlUmVzdWx0S2V5ID0gIngtYXBwbGUtZGF0 YS1kZXRlY3RvcnMtcmVzdWx0IjsKK2NvbnN0IGNoYXIgKmRhdGFEZXRlY3RvcnNMaW5rU3R5bGUg PSAiLXdlYmtpdC10ZXh0LWRlY29yYXRpb24tY29sb3I6cmdiKDE5OSwgMTk5LCAyMDQpOyBjb2xv cjppbml0aWFsOyI7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtMzI1LDkgKzMyNiwxMCBA QCBzdGF0aWMgTlNTdHJpbmcgKmRhdGFEZXRlY3RvclR5cGVGb3JDYXRlCiAgICAgfQogfQogCi1z dGF0aWMgU3RyaW5nIGRhdGFEZXRlY3RvclN0cmluZ0ZvclBhdGgoTlNJbmRleFBhdGgqIHBhdGgp CitzdGF0aWMgU3RyaW5nIGRhdGFEZXRlY3RvclN0cmluZ0ZvclBhdGgoTlNJbmRleFBhdGgqIHBh dGgsIGJvb2wmIGlzU3ViUmVzdWx0KQogewogICAgIE5TVUludGVnZXIgbGVuZ3RoID0gcGF0aC5s ZW5ndGg7CisgICAgaXNTdWJSZXN1bHQgPSBsZW5ndGggPiAxOwogICAgIAogICAgIHN3aXRjaCAo bGVuZ3RoKSB7CiAgICAgY2FzZSAwOgpAQCAtNTUzLDcgKzU1NSw4IEBAIE5TQXJyYXkgKkRhdGFE ZXRlY3Rpb246OmRldGVjdENvbnRlbnRJblIKICAgICAgICAgaWYgKCFyZXN1bHRSYW5nZXMuc2l6 ZSgpKQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgTlNTdHJpbmcgKmlkZW50aWZp ZXIgPSBkYXRhRGV0ZWN0b3JTdHJpbmdGb3JQYXRoKGluZGV4UGF0aHNbcmVzdWx0SW5kZXhdLmdl dCgpKTsKKyAgICAgICAgYm9vbCBpc1N1YlJlc3VsdCA9IGZhbHNlOworICAgICAgICBOU1N0cmlu ZyAqaWRlbnRpZmllciA9IGRhdGFEZXRlY3RvclN0cmluZ0ZvclBhdGgoaW5kZXhQYXRoc1tyZXN1 bHRJbmRleF0uZ2V0KCksIGlzU3ViUmVzdWx0KTsKICAgICAgICAgTlNTdHJpbmcgKmNvcnJlc3Bv bmRpbmdVUkwgPSBjb25zdHJ1Y3RVUkxTdHJpbmdGb3JSZXN1bHQoY29yZVJlc3VsdCwgaWRlbnRp ZmllciwgcmVmZXJlbmNlRGF0ZSwgKE5TVGltZVpvbmUgKil0eiwgdHlwZXMpOwogICAgICAgICBi b29sIGRpZE1vZGlmeURPTSA9IGZhbHNlOwogICAgICAgICAKQEAgLTU3NSw2ICs1NzgsNyBAQCBO U0FycmF5ICpEYXRhRGV0ZWN0aW9uOjpkZXRlY3RDb250ZW50SW5SCiAgICAgICAgIH0KICAgICAg ICAgCiAgICAgICAgIGxhc3RNb2RpZmllZFF1ZXJ5T2Zmc2V0ID0gcXVlcnlSYW5nZS5lbmQ7Cisg ICAgICAgIEJPT0wgc2hvdWxkVXNlTGlnaHRMaW5rcyA9IHNvZnRMaW5rX0RhdGFEZXRlY3RvcnND b3JlX0REU2hvdWxkVXNlTGlnaHRMaW5rc0ZvclJlc3VsdChjb3JlUmVzdWx0LCBpc1N1YlJlc3Vs dCk7CiAKICAgICAgICAgZm9yIChhdXRvJiByYW5nZSA6IHJlc3VsdFJhbmdlcykgewogICAgICAg ICAgICAgTm9kZSogcGFyZW50Tm9kZSA9IHJhbmdlLT5zdGFydENvbnRhaW5lcigpLnBhcmVudE5v ZGUoKTsKQEAgLTYwNSwxMCArNjA5LDEzIEBAIE5TQXJyYXkgKkRhdGFEZXRlY3Rpb246OmRldGVj dENvbnRlbnRJblIKICAgICAgICAgICAgIFJlZlB0cjxIVE1MQW5jaG9yRWxlbWVudD4gYW5jaG9y RWxlbWVudCA9IEhUTUxBbmNob3JFbGVtZW50OjpjcmVhdGUoZG9jdW1lbnQpOwogICAgICAgICAg ICAgYW5jaG9yRWxlbWVudC0+c2V0SHJlZihjb3JyZXNwb25kaW5nVVJMKTsKICAgICAgICAgICAg IGFuY2hvckVsZW1lbnQtPnNldERpcigibHRyIik7Ci0gICAgICAgICAgICBSZWZQdHI8QXR0cj4g Y29sb3IgPSBkb3duY2FzdDxFbGVtZW50PihwYXJlbnROb2RlKS0+Z2V0QXR0cmlidXRlTm9kZSgi Y29sb3IiKTsKLSAgICAgICAgICAgIGlmIChjb2xvcikKLSAgICAgICAgICAgICAgICBhbmNob3JF bGVtZW50LT5zZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpzdHlsZUF0dHIsIGNvbG9yLT5zdHlsZSgp LT5jc3NUZXh0KCkpOwotICAgICAgICAgICAgCisgICAgICAgICAgICBpZiAoc2hvdWxkVXNlTGln aHRMaW5rcykKKyAgICAgICAgICAgICAgICBhbmNob3JFbGVtZW50LT5zZXRBdHRyaWJ1dGUoSFRN TE5hbWVzOjpzdHlsZUF0dHIsIGRhdGFEZXRlY3RvcnNMaW5rU3R5bGUpOworICAgICAgICAgICAg ZWxzZSB7CisgICAgICAgICAgICAgICAgUmVmUHRyPEF0dHI+IGNvbG9yID0gZG93bmNhc3Q8RWxl bWVudD4ocGFyZW50Tm9kZSktPmdldEF0dHJpYnV0ZU5vZGUoImNvbG9yIik7CisgICAgICAgICAg ICAgICAgaWYgKGNvbG9yKQorICAgICAgICAgICAgICAgICAgICBhbmNob3JFbGVtZW50LT5zZXRB dHRyaWJ1dGUoSFRNTE5hbWVzOjpzdHlsZUF0dHIsIGNvbG9yLT5zdHlsZSgpLT5jc3NUZXh0KCkp OworICAgICAgICAgICAgfQogICAgICAgICAgICAgYW5jaG9yRWxlbWVudC0+Tm9kZTo6YXBwZW5k Q2hpbGQobmV3Tm9kZSwgQVNTRVJUX05PX0VYQ0VQVElPTik7CiAgICAgICAgICAgICBwYXJlbnRO b2RlLT5pbnNlcnRCZWZvcmUoYW5jaG9yRWxlbWVudCwgJmN1cnJlbnRUZXh0Tm9kZSwgQVNTRVJU X05PX0VYQ0VQVElPTik7CiAgICAgICAgICAgICAvLyBBZGQgYSBzcGVjaWFsIGF0dHJpYnV0ZSB0 byBtYXJrIHRoaXMgVVJMaWZpY2F0aW9uIGFzIHRoZSByZXN1bHQgb2YgZGF0YSBkZXRlY3RvcnMu CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9EYXRhRGV0ZWN0b3JzQ29yZVNv ZnRMaW5rLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvRGF0 YURldGVjdG9yc0NvcmVTb2Z0TGluay5oCShyZXZpc2lvbiAxOTg4NTYpCisrKyBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jb2NvYS9EYXRhRGV0ZWN0b3JzQ29yZVNvZnRMaW5rLmgJKHdvcmtpbmcg Y29weSkKQEAgLTUxLDYgKzUxLDcgQEAgU09GVF9MSU5LX0ZVTkNUSU9OX0ZPUl9IRUFERVIoV2Vi Q29yZSwgRAogU09GVF9MSU5LX0ZVTkNUSU9OX0ZPUl9IRUFERVIoV2ViQ29yZSwgRGF0YURldGVj dG9yc0NvcmUsIEREVVJMVGFwQW5kSG9sZFNjaGVtZXMsIE5TQXJyYXkgKiwgKCksICgpKQogU09G VF9MSU5LX0ZVTkNUSU9OX0ZPUl9IRUFERVIoV2ViQ29yZSwgRGF0YURldGVjdG9yc0NvcmUsIERE U2hvdWxkSW1tZWRpYXRlbHlTaG93QWN0aW9uU2hlZXRGb3JVUkwsIEJPT0wsIChOU1VSTCAqdXJs KSwgKHVybCkpCiBTT0ZUX0xJTktfRlVOQ1RJT05fRk9SX0hFQURFUihXZWJDb3JlLCBEYXRhRGV0 ZWN0b3JzQ29yZSwgRERTaG91bGRJbW1lZGlhdGVseVNob3dBY3Rpb25TaGVldEZvclJlc3VsdCwg Qk9PTCwgKEREUmVzdWx0UmVmIHJlc3VsdCksIChyZXN1bHQpKQorU09GVF9MSU5LX0ZVTkNUSU9O X0ZPUl9IRUFERVIoV2ViQ29yZSwgRGF0YURldGVjdG9yc0NvcmUsIEREU2hvdWxkVXNlTGlnaHRM aW5rc0ZvclJlc3VsdCwgQk9PTCwgKEREUmVzdWx0UmVmIHJlc3VsdCwgQk9PTCBleHRyYWN0ZWRG cm9tU2lnbmF0dXJlKSwgKHJlc3VsdCwgZXh0cmFjdGVkRnJvbVNpZ25hdHVyZSkpCiBTT0ZUX0xJ TktfUE9JTlRFUl9GT1JfSEVBREVSKFdlYkNvcmUsIERhdGFEZXRlY3RvcnNDb3JlLCBEREJpbmRl ckh0dHBVUkxLZXksIENGU3RyaW5nUmVmKQogU09GVF9MSU5LX1BPSU5URVJfRk9SX0hFQURFUihX ZWJDb3JlLCBEYXRhRGV0ZWN0b3JzQ29yZSwgRERCaW5kZXJXZWJVUkxLZXksIENGU3RyaW5nUmVm KQogU09GVF9MSU5LX1BPSU5URVJfRk9SX0hFQURFUihXZWJDb3JlLCBEYXRhRGV0ZWN0b3JzQ29y ZSwgRERCaW5kZXJNYWlsVVJMS2V5LCBDRlN0cmluZ1JlZikKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2NvY29hL0RhdGFEZXRlY3RvcnNDb3JlU29mdExpbmsubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvRGF0YURldGVjdG9yc0NvcmVTb2Z0TGlu ay5tbQkocmV2aXNpb24gMTk4ODU2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2Ev RGF0YURldGVjdG9yc0NvcmVTb2Z0TGluay5tbQkod29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAs NyBAQCBTT0ZUX0xJTktfRlVOQ1RJT05fRk9SX1NPVVJDRShXZWJDb3JlLCBECiBTT0ZUX0xJTktf RlVOQ1RJT05fRk9SX1NPVVJDRShXZWJDb3JlLCBEYXRhRGV0ZWN0b3JzQ29yZSwgRERVUkxUYXBB bmRIb2xkU2NoZW1lcywgTlNBcnJheSAqLCAoKSwgKCkpCiBTT0ZUX0xJTktfRlVOQ1RJT05fRk9S X1NPVVJDRShXZWJDb3JlLCBEYXRhRGV0ZWN0b3JzQ29yZSwgRERTaG91bGRJbW1lZGlhdGVseVNo b3dBY3Rpb25TaGVldEZvclVSTCwgQk9PTCwgKE5TVVJMICp1cmwpLCAodXJsKSkKIFNPRlRfTElO S19GVU5DVElPTl9GT1JfU09VUkNFKFdlYkNvcmUsIERhdGFEZXRlY3RvcnNDb3JlLCBERFNob3Vs ZEltbWVkaWF0ZWx5U2hvd0FjdGlvblNoZWV0Rm9yUmVzdWx0LCBCT09MLCAoRERSZXN1bHRSZWYg cmVzdWx0KSwgKHJlc3VsdCkpCitTT0ZUX0xJTktfRlVOQ1RJT05fRk9SX1NPVVJDRShXZWJDb3Jl LCBEYXRhRGV0ZWN0b3JzQ29yZSwgRERTaG91bGRVc2VMaWdodExpbmtzRm9yUmVzdWx0LCBCT09M LCAoRERSZXN1bHRSZWYgcmVzdWx0LCBCT09MIGV4dHJhY3RlZEZyb21TaWduYXR1cmUpLCAocmVz dWx0LCBleHRyYWN0ZWRGcm9tU2lnbmF0dXJlKSkKIFNPRlRfTElOS19QT0lOVEVSX0ZPUl9TT1VS Q0UoV2ViQ29yZSwgRGF0YURldGVjdG9yc0NvcmUsIEREQmluZGVySHR0cFVSTEtleSwgQ0ZTdHJp bmdSZWYpCiBTT0ZUX0xJTktfUE9JTlRFUl9GT1JfU09VUkNFKFdlYkNvcmUsIERhdGFEZXRlY3Rv cnNDb3JlLCBEREJpbmRlcldlYlVSTEtleSwgQ0ZTdHJpbmdSZWYpCiBTT0ZUX0xJTktfUE9JTlRF Ul9GT1JfU09VUkNFKFdlYkNvcmUsIERhdGFEZXRlY3RvcnNDb3JlLCBEREJpbmRlck1haWxVUkxL ZXksIENGU3RyaW5nUmVmKQo=