155992 2016-03-29 16:06:00 -0700 Implement logging for RELEASE_BASSERT_WITH_MESSAGE() in BAssert.h 2016-06-12 06:08:27 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 155409 1 ddkilzer ddkilzer commit-queue ggaren krollin saam oldest_to_newest 1178848 0 ddkilzer 2016-03-29 16:06:00 -0700 For Bug 155409, I added RELEASE_BASSERT_WITH_MESSAGE() in BAssert.h, but it doesn't actually log anything. This bug is to implement logging for RELEASE_BASSERT_WITH_MESSAGE() in BAssert.h. 1179373 1 275273 ddkilzer 2016-03-31 03:40:25 -0700 Created attachment 275273 Patch v1 1179374 2 commit-queue 2016-03-31 03:41:12 -0700 Attachment 275273 did not pass style-queue: ERROR: Source/bmalloc/bmalloc/BAssert.h:79: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1179443 3 275273 ggaren 2016-03-31 09:37:04 -0700 Comment on attachment 275273 Patch v1 r=me I guess this is OK. Do we need this? It looks like we'll only use it for soft linking failures. Are we suffering from soft linking failures we need to diagnose? A problem with heavy and complex ASSERT macros is that they destroy the CPU context at the point of assertion failure, so they make crash reports much less useful. So, I guess I can say OK to RELEASE_BASSERT_WITH_MESSAGE for soft linking because it's only a small part of the project, but this is an idiom I'd like to avoid using very much. 1180191 4 275505 ddkilzer 2016-04-03 11:00:28 -0700 Created attachment 275505 Patch v2 1180192 5 ddkilzer 2016-04-03 11:01:33 -0700 (In reply to comment #3) > Comment on attachment 275273 [details] > Patch v1 > > r=me > > I guess this is OK. > > Do we need this? It looks like we'll only use it for soft linking failures. > Are we suffering from soft linking failures we need to diagnose? > > A problem with heavy and complex ASSERT macros is that they destroy the CPU > context at the point of assertion failure, so they make crash reports much > less useful. > > So, I guess I can say OK to RELEASE_BASSERT_WITH_MESSAGE for soft linking > because it's only a small part of the project, but this is an idiom I'd like > to avoid using very much. Patch v2 only does the extra logging in Debug builds, so Release builds won't destroy CPU context. 1180193 6 commit-queue 2016-04-03 11:01:37 -0700 Attachment 275505 did not pass style-queue: ERROR: Source/bmalloc/bmalloc/BAssert.h:82: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1201064 7 275505 ggaren 2016-06-09 17:20:26 -0700 Comment on attachment 275505 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=275505&action=review r=me > Source/bmalloc/bmalloc/BAssert.h:72 > +#define BMALLOC_LOGGING_PREFIX "#BM: " Might as well throw in the full "bmalloc:" here if we can. 1201361 8 275505 ddkilzer 2016-06-10 13:45:37 -0700 Comment on attachment 275505 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=275505&action=review >> Source/bmalloc/bmalloc/BAssert.h:72 >> +#define BMALLOC_LOGGING_PREFIX "#BM: " > > Might as well throw in the full "bmalloc:" here if we can. I'll change this. I was mimicking what was done in Source/WTF/wtf/Assertions.h: #define WTF_LOGGING_PREFIX "#WK: " 1201558 9 ddkilzer 2016-06-11 04:45:31 -0700 Committed r201969: <http://trac.webkit.org/changeset/201969> 275273 2016-03-31 03:40:25 -0700 2016-04-03 11:00:25 -0700 Patch v1 bug-155992-20160331034028.patch text/plain 6324 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4ODg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggZmMwZWM0Yzc3ZDk3ZDEz ZTk5MTVhNzFhY2JlMGI3NzI3Y2NlNTc5ZC4uYTdkYmYzMWYyM2FlMDVhNWI2YmNiNGE2ZGI3YTRj Njg0YzJmODlhYSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE2LTAzLTMxICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IGxvZ2dp bmcgZm9yIFJFTEVBU0VfQkFTU0VSVF9XSVRIX01FU1NBR0UoKSBpbiBCQXNzZXJ0LmgKKyAgICAg ICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTU1OTkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogYm1hbGxvYy9CQXNzZXJ0Lmg6CisgICAgICAgIChC TE9HX0VSUk9SKTogQWRkIG1ldGhvZCB0byBhbHdheXMgbG9nIGVycm9yIG1lc3NhZ2VzLgorICAg ICAgICAoUkVMRUFTRV9CQVNTRVJUX1dJVEhfTUVTU0FHRSk6IFVzZSBCTE9HX0VSUk9SKCkgdG8g aW1wbGVtZW50CisgICAgICAgIGxvZ2dpbmcuCisgICAgICAgICogYm1hbGxvYy9CUGxhdGZvcm0u aDoKKyAgICAgICAgKEJQTEFURk9STV9NQUMpOiBBZGQuCisgICAgICAgIChCVVNFKTogQWRkIEJV U0UoKSBtYWNyby4KKyAgICAgICAgKEJBVFRSSUJVVEVfUFJJTlRGKTogQWRkLgorICAgICAgICAo QlVTRV9PU19MT0cpOiBBZGQuCisgICAgICAgICogYm1hbGxvYy9Mb2dnaW5nLmNwcDoKKyAgICAg ICAgKGJtYWxsb2M6OnJlcG9ydEFzc2VydGlvbkZhaWx1cmVXaXRoTWVzc2FnZSk6IEFkZC4gIExv Z3MgdG8KKyAgICAgICAgc3RkZXJyLgorICAgICAgICAqIGJtYWxsb2MvTG9nZ2luZy5oOgorICAg ICAgICAoYm1hbGxvYzo6cmVwb3J0QXNzZXJ0aW9uRmFpbHVyZVdpdGhNZXNzYWdlKTogQWRkIGRl Y2xhcmF0aW9uLgorCiAyMDE2LTAzLTI5ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5j b20+CiAKICAgICAgICAgYm1hbGxvYzogc3VwcG9ydCBwaHlzaWNhbCBwYWdlIHNpemVzIHRoYXQg ZG9uJ3QgbWF0Y2ggdGhlIHZpcnR1YWwgcGFnZSBzaXplICh0YWtlIDIpCmRpZmYgLS1naXQgYS9T b3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JBc3NlcnQuaCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2Mv QkFzc2VydC5oCmluZGV4IDcxNzRlMDQxNDQ2OGZhMWM0ZDBkZGQwZTRlYTY0NWE4NDI1ZmUwY2Mu LjEzNWM3YjAyMWYwMzhjMjE5NWEzY2IyNjcwNDMzM2FkOWE5MDJiMDggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9ibWFsbG9jL2JtYWxsb2MvQkFzc2VydC5oCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxs b2MvQkFzc2VydC5oCkBAIC0yMCwxMyArMjAsMTggQEAKICAqIFBST0ZJVFM7IE9SIEJVU0lORVNT IElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKICAqIE9GIExJ QUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAog ICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZ IE9VVCBPRiBUSEUgVVNFCi0gKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0Yg VEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLiAKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVW RU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAog I2lmbmRlZiBCQXNzZXJ0X2gKICNkZWZpbmUgQkFzc2VydF9oCiAKICNpbmNsdWRlICJCUGxhdGZv cm0uaCIKKyNpbmNsdWRlICJMb2dnaW5nLmgiCisKKyNpZiBCVVNFKE9TX0xPRykKKyNpbmNsdWRl IDxvcy9sb2cuaD4KKyNlbmRpZgogCiAjaWYgZGVmaW5lZChOREVCVUcpICYmIEJPUyhEQVJXSU4p CiAKQEAgLTYzLDEwICs2OCwyMSBAQAogCiAjZGVmaW5lIFJFTEVBU0VfQkFTU0VSVCh4KSBCQVNT RVJUX0lNUEwoeCkKIAotLy8gRklYTUU6IEltcGxlbWVudCBsb2dnaW5nOiA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMTU1OTkyPgotI2RlZmluZSBSRUxFQVNFX0JBU1NFUlRfV0lUSF9NRVNTQUdFKHgs IGYsIC4uLikgQkFTU0VSVF9JTVBMKHgpCisjaWYgQlVTRShPU19MT0cpCisjZGVmaW5lIEJNQUxM T0NfTE9HR0lOR19QUkVGSVggIiNCTTogIgorI2RlZmluZSBCTE9HX0VSUk9SKGZvcm1hdCwgLi4u KSBvc19sb2dfZXJyb3IoT1NfTE9HX0RFRkFVTFQsIEJNQUxMT0NfTE9HR0lOR19QUkVGSVggZm9y bWF0LCBfX1ZBX0FSR1NfXykKKyNlbHNlCisjZGVmaW5lIEJMT0dfRVJST1IoZm9ybWF0LCAuLi4p IGJtYWxsb2M6OnJlcG9ydEFzc2VydGlvbkZhaWx1cmVXaXRoTWVzc2FnZShfX0ZJTEVfXywgX19M SU5FX18sIF9fUFJFVFRZX0ZVTkNUSU9OX18sIGZvcm1hdCwgX19WQV9BUkdTX18pCisjZW5kaWYK KworI2RlZmluZSBSRUxFQVNFX0JBU1NFUlRfV0lUSF9NRVNTQUdFKHgsIGZvcm1hdCwgLi4uKSBk byB7IFwKKyAgICBpZiAoISh4KSkgeyBcCisgICAgICAgIEJMT0dfRVJST1IoIkFTU0VSVElPTiBG QUlMRUQ6ICIgI3ggIiA6OiAiIGZvcm1hdCwgIyNfX1ZBX0FSR1NfXyk7IFwKKyAgICAgICAgQkNS QVNIKCk7IFwKKyAgICB9IFwKK30gd2hpbGUgKDApOwogCi0jZGVmaW5lIFVOVVNFRCh4KSAodm9p ZCl4CisjZGVmaW5lIFVOVVNFRCh4KSAoKHZvaWQpeCkKIAogLy8gPT09PT0gUmVsZWFzZSBidWls ZCA9PT09PQogCkBAIC04NSw3ICsxMDEsNyBAQAogCiAjZGVmaW5lIEJBU1NFUlQoeCkgQkFTU0VS VF9JTVBMKHgpCiAKLSNkZWZpbmUgSUZfREVCVUcoeCkgeAorI2RlZmluZSBJRl9ERUJVRyh4KSAo eCkKIAogI2VuZGlmIC8vICFkZWZpbmVkKE5ERUJVRykKIApkaWZmIC0tZ2l0IGEvU291cmNlL2Jt YWxsb2MvYm1hbGxvYy9CUGxhdGZvcm0uaCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQlBsYXRm b3JtLmgKaW5kZXggYWYzOWEyNTkzMWMwNzljZDRhNDk0YzQyODc4MmU2M2NlYmVhYWZmMi4uMWVi OGI5NTNiYjhiZDA1OGU1OTgxODZlOWRlNTY1ZTI5OGQ5MDc4OSAxMDA2NDQKLS0tIGEvU291cmNl L2JtYWxsb2MvYm1hbGxvYy9CUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9j L0JQbGF0Zm9ybS5oCkBAIC0yNywxOCArMjcsMTQgQEAKICNkZWZpbmUgQlBsYXRmb3JtX2gKIAog I2lmZGVmIF9fQVBQTEVfXworI2luY2x1ZGUgPEF2YWlsYWJpbGl0eS5oPgorI2luY2x1ZGUgPEF2 YWlsYWJpbGl0eU1hY3Jvcy5oPgogI2luY2x1ZGUgPFRhcmdldENvbmRpdGlvbmFscy5oPgogI2Vu ZGlmCiAKICNkZWZpbmUgQlBMQVRGT1JNKFBMQVRGT1JNKSAoZGVmaW5lZCBCUExBVEZPUk1fIyNQ TEFURk9STSAmJiBCUExBVEZPUk1fIyNQTEFURk9STSkKICNkZWZpbmUgQk9TKE9TKSAoZGVmaW5l ZCBCT1NfIyNPUyAmJiBCT1NfIyNPUykKIAotI2lmICgoZGVmaW5lZChUQVJHRVRfT1NfRU1CRURE RUQpICYmIFRBUkdFVF9PU19FTUJFRERFRCkgXAotICAgIHx8IChkZWZpbmVkKFRBUkdFVF9PU19J UEhPTkUpICYmIFRBUkdFVF9PU19JUEhPTkUpIFwKLSAgICB8fCAoZGVmaW5lZChUQVJHRVRfSVBI T05FX1NJTVVMQVRPUikgJiYgVEFSR0VUX0lQSE9ORV9TSU1VTEFUT1IpKQotI2RlZmluZSBCUExB VEZPUk1fSU9TIDEKLSNlbmRpZgotCiAjaWZkZWYgX19BUFBMRV9fCiAjZGVmaW5lIEJPU19EQVJX SU4gMQogI2VuZGlmCkBAIC00Nyw2ICs0MywxOSBAQAogI2RlZmluZSBCT1NfVU5JWCAxCiAjZW5k aWYKIAorI2lmIEJPUyhEQVJXSU4pICYmICgoZGVmaW5lZChUQVJHRVRfT1NfRU1CRURERUQpICYm IFRBUkdFVF9PU19FTUJFRERFRCkgXAorICAgIHx8IChkZWZpbmVkKFRBUkdFVF9PU19JUEhPTkUp ICYmIFRBUkdFVF9PU19JUEhPTkUpIFwKKyAgICB8fCAoZGVmaW5lZChUQVJHRVRfSVBIT05FX1NJ TVVMQVRPUikgJiYgVEFSR0VUX0lQSE9ORV9TSU1VTEFUT1IpKQorI2RlZmluZSBCUExBVEZPUk1f SU9TIDEKKyNlbGlmIEJPUyhEQVJXSU4pICYmIGRlZmluZWQoVEFSR0VUX09TX01BQykgJiYgVEFS R0VUX09TX01BQworI2RlZmluZSBCUExBVEZPUk1fTUFDIDEKKyNlbmRpZgorCisvKiA9PT09IFBv bGljeSBkZWNpc2lvbiBtYWNyb3M6IHRoZXNlIGRlZmluZSBwb2xpY3kgY2hvaWNlcyBmb3IgYSBw YXJ0aWN1bGFyIHBvcnQuID09PT0gKi8KKworLyogQlVTRSgpIC0gdXNlIGEgcGFydGljdWxhciB0 aGlyZC1wYXJ0eSBsaWJyYXJ5IG9yIG9wdGlvbmFsIE9TIHNlcnZpY2UgKi8KKyNkZWZpbmUgQlVT RShGRUFUVVJFKSAoZGVmaW5lZCBCVVNFXyMjRkVBVFVSRSAmJiBCVVNFXyMjRkVBVFVSRSkKKwog LyogPT09PSBQbGF0Zm9ybSBhZGFwdGF0aW9uIG1hY3JvczogdGhlc2UgZGVzY3JpYmUgcHJvcGVy dGllcyBvZiB0aGUgdGFyZ2V0IGVudmlyb25tZW50LiA9PT09ICovCiAKIC8qIEJDUFUoKSAtIHRo ZSB0YXJnZXQgQ1BVIGFyY2hpdGVjdHVyZSAqLwpAQCAtMTgxLDQgKzE5MCwxMCBAQAogCiAjZW5k aWYgLyogQVJNICovCiAKKyNkZWZpbmUgQkFUVFJJQlVURV9QUklOVEYoZm9ybWF0U3RyaW5nQXJn dW1lbnQsIGV4dHJhQXJndW1lbnRzKSBfX2F0dHJpYnV0ZV9fKChfX2Zvcm1hdF9fKHByaW50Ziwg Zm9ybWF0U3RyaW5nQXJndW1lbnQsIGV4dHJhQXJndW1lbnRzKSkpCisKKyNpZiAoQlBMQVRGT1JN KE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEyMDApIHx8IChC UExBVEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDAw MDApCisjZGVmaW5lIEJVU0VfT1NfTE9HIDEKKyNlbmRpZgorCiAjZW5kaWYgLy8gQlBsYXRmb3Jt X2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvTG9nZ2luZy5jcHAgYi9Tb3Vy Y2UvYm1hbGxvYy9ibWFsbG9jL0xvZ2dpbmcuY3BwCmluZGV4IDAzZWNiNmQzMTE4MjljYTkzMjU0 ODQwOWY3OTgxMTA1YWZlNmU2NzkuLjgwNGQ5NWE0OThkMTM3NDg0ZDQxMDdkZDRmZmFjODNmMDA5 OGVkNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvTG9nZ2luZy5jcHAKKysr IGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Mb2dnaW5nLmNwcApAQCAtMjYsNiArMjYsOSBAQAog I2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRlICJCUGxhdGZvcm0uaCIKIAorI2luY2x1ZGUg PHN0ZGFyZy5oPgorI2luY2x1ZGUgPHN0ZGlvLmg+CisKICNpZiBCUExBVEZPUk0oSU9TKQogI2lu Y2x1ZGUgPG1hY2gvZXhjZXB0aW9uX3R5cGVzLmg+CiAjaW5jbHVkZSA8b2JqYy9vYmpjLmg+CkBA IC00Niw0ICs0OSwxNSBAQCB2b2lkIGxvZ1ZNRmFpbHVyZSgpCiAjZW5kaWYKIH0KIAorI2lmICFC VVNFKE9TX0xPRykKK3ZvaWQgcmVwb3J0QXNzZXJ0aW9uRmFpbHVyZVdpdGhNZXNzYWdlKGNvbnN0 IGNoYXIqIGZpbGUsIGludCBsaW5lLCBjb25zdCBjaGFyKiBmdW5jdGlvbiwgY29uc3QgY2hhciog Zm9ybWF0LCAuLi4pCit7CisgICAgdmFfbGlzdCBhcmdzOworICAgIHZhX3N0YXJ0KGFyZ3MsIGZv cm1hdCk7CisgICAgdmZwcmludGYoc3RkZXJyLCBmb3JtYXQsIGFyZ3MpOworICAgIHZhX2VuZChh cmdzKTsKKyAgICBmcHJpbnRmKHN0ZGVyciwgIiVzKCVkKSA6ICVzXG4iLCBmaWxlLCBsaW5lLCBm dW5jdGlvbik7Cit9CisjZW5kaWYKKwogfSAvLyBuYW1lc3BhY2UgYm1hbGxvYwpkaWZmIC0tZ2l0 IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Mb2dnaW5nLmggYi9Tb3VyY2UvYm1hbGxvYy9ibWFs bG9jL0xvZ2dpbmcuaAppbmRleCA0ZjlmM2UxYTgwYzZhNmQ0MjE5NzA0MmEzODBiZjU0NDIxNGQ0 YmFjLi5jNDZjNzUxMjIwZmY4OGUwNzkyOGVmODBiNmVjYzAxZThjNjlkNzZlIDEwMDY0NAotLS0g YS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0xvZ2dpbmcuaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9i bWFsbG9jL0xvZ2dpbmcuaApAQCAtMjYsMTAgKzI2LDE0IEBACiAjaWZuZGVmIExvZ2dpbmdfaAog I2RlZmluZSBMb2dnaW5nX2gKIAorI2luY2x1ZGUgIkJQbGF0Zm9ybS5oIgorCiBuYW1lc3BhY2Ug Ym1hbGxvYyB7CiAKIHZvaWQgbG9nVk1GYWlsdXJlKCk7CiAKK3ZvaWQgcmVwb3J0QXNzZXJ0aW9u RmFpbHVyZVdpdGhNZXNzYWdlKGNvbnN0IGNoYXIqIGZpbGUsIGludCBsaW5lLCBjb25zdCBjaGFy KiBmdW5jdGlvbiwgY29uc3QgY2hhciogZm9ybWF0LCAuLi4pIEJBVFRSSUJVVEVfUFJJTlRGKDQs IDUpOworCiB9IC8vIG5hbWVzcGFjZSBibWFsbG9jCiAKICNlbmRpZiAvLyBMb2dnaW5nX2gK 275505 2016-04-03 11:00:28 -0700 2016-06-12 06:08:27 -0700 Patch v2 bug-155992-20160403110034.patch text/plain 6446 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4OTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggZmMwZWM0Yzc3ZDk3ZDEz ZTk5MTVhNzFhY2JlMGI3NzI3Y2NlNTc5ZC4uMzE0NjVjMDMzNDZmOTY3ZmM0ZDA2ZjkyODY3Mjdl ZmNmOWQ1NTc1NyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE2LTA0LTAzICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IGxvZ2dp bmcgZm9yIFJFTEVBU0VfQkFTU0VSVF9XSVRIX01FU1NBR0UoKSBpbiBCQXNzZXJ0LmgKKyAgICAg ICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTU1OTkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogYm1hbGxvYy9CQXNzZXJ0Lmg6CisgICAgICAgIChC TE9HX0VSUk9SKTogQWRkIG1ldGhvZCB0byBhbHdheXMgbG9nIGVycm9yIG1lc3NhZ2VzLgorICAg ICAgICAoUkVMRUFTRV9CQVNTRVJUX1dJVEhfTUVTU0FHRSk6IFVzZSBCTE9HX0VSUk9SKCkgdG8g aW1wbGVtZW50CisgICAgICAgIGxvZ2dpbmcgaW4gRGVidWcgYnVpbGRzLgorICAgICAgICAqIGJt YWxsb2MvQlBsYXRmb3JtLmg6CisgICAgICAgIChCUExBVEZPUk1fTUFDKTogQWRkLgorICAgICAg ICAoQlVTRSk6IEFkZCBCVVNFKCkgbWFjcm8uCisgICAgICAgIChCQVRUUklCVVRFX1BSSU5URik6 IEFkZC4KKyAgICAgICAgKEJVU0VfT1NfTE9HKTogQWRkLgorICAgICAgICAqIGJtYWxsb2MvTG9n Z2luZy5jcHA6CisgICAgICAgIChibWFsbG9jOjpyZXBvcnRBc3NlcnRpb25GYWlsdXJlV2l0aE1l c3NhZ2UpOiBBZGQuICBMb2dzIHRvCisgICAgICAgIHN0ZGVyci4KKyAgICAgICAgKiBibWFsbG9j L0xvZ2dpbmcuaDoKKyAgICAgICAgKGJtYWxsb2M6OnJlcG9ydEFzc2VydGlvbkZhaWx1cmVXaXRo TWVzc2FnZSk6IEFkZCBkZWNsYXJhdGlvbi4KKwogMjAxNi0wMy0yOSAgR2VvZmZyZXkgR2FyZW4g IDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIGJtYWxsb2M6IHN1cHBvcnQgcGh5c2ljYWwg cGFnZSBzaXplcyB0aGF0IGRvbid0IG1hdGNoIHRoZSB2aXJ0dWFsIHBhZ2Ugc2l6ZSAodGFrZSAy KQpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CQXNzZXJ0LmggYi9Tb3VyY2Uv Ym1hbGxvYy9ibWFsbG9jL0JBc3NlcnQuaAppbmRleCA3MTc0ZTA0MTQ0NjhmYTFjNGQwZGRkMGU0 ZWE2NDVhODQyNWZlMGNjLi40OGU3MjY2YWU1ZmU4ZWNiYmIxNDU0ODZkNjdhNWY3MTVhN2RiZDc1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JBc3NlcnQuaAorKysgYi9Tb3Vy Y2UvYm1hbGxvYy9ibWFsbG9jL0JBc3NlcnQuaApAQCAtMjAsMTMgKzIwLDE4IEBACiAgKiBQUk9G SVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkg VEhFT1JZCiAgKiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFC SUxJVFksIE9SIFRPUlQKICAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFS SVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQotICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZF TiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4gCisgKiBPRiBU SElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0gg REFNQUdFLgogICovCiAKICNpZm5kZWYgQkFzc2VydF9oCiAjZGVmaW5lIEJBc3NlcnRfaAogCiAj aW5jbHVkZSAiQlBsYXRmb3JtLmgiCisjaW5jbHVkZSAiTG9nZ2luZy5oIgorCisjaWYgQlVTRShP U19MT0cpCisjaW5jbHVkZSA8b3MvbG9nLmg+CisjZW5kaWYKIAogI2lmIGRlZmluZWQoTkRFQlVH KSAmJiBCT1MoREFSV0lOKQogCkBAIC02MywxMCArNjgsMjUgQEAKIAogI2RlZmluZSBSRUxFQVNF X0JBU1NFUlQoeCkgQkFTU0VSVF9JTVBMKHgpCiAKLS8vIEZJWE1FOiBJbXBsZW1lbnQgbG9nZ2lu ZzogPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE1NTk5Mj4KLSNkZWZpbmUgUkVMRUFTRV9CQVNTRVJU X1dJVEhfTUVTU0FHRSh4LCBmLCAuLi4pIEJBU1NFUlRfSU1QTCh4KQorI2lmIEJVU0UoT1NfTE9H KQorI2RlZmluZSBCTUFMTE9DX0xPR0dJTkdfUFJFRklYICIjQk06ICIKKyNkZWZpbmUgQkxPR19F UlJPUihmb3JtYXQsIC4uLikgb3NfbG9nX2Vycm9yKE9TX0xPR19ERUZBVUxULCBCTUFMTE9DX0xP R0dJTkdfUFJFRklYIGZvcm1hdCwgX19WQV9BUkdTX18pCisjZWxzZQorI2RlZmluZSBCTE9HX0VS Uk9SKGZvcm1hdCwgLi4uKSBibWFsbG9jOjpyZXBvcnRBc3NlcnRpb25GYWlsdXJlV2l0aE1lc3Nh Z2UoX19GSUxFX18sIF9fTElORV9fLCBfX1BSRVRUWV9GVU5DVElPTl9fLCBmb3JtYXQsIF9fVkFf QVJHU19fKQorI2VuZGlmCisKKyNpZiBkZWZpbmVkKE5ERUJVRykKKyNkZWZpbmUgUkVMRUFTRV9C QVNTRVJUX1dJVEhfTUVTU0FHRSh4LCBmb3JtYXQsIC4uLikgQkFTU0VSVF9JTVBMKHgpCisjZWxz ZQorI2RlZmluZSBSRUxFQVNFX0JBU1NFUlRfV0lUSF9NRVNTQUdFKHgsIGZvcm1hdCwgLi4uKSBk byB7IFwKKyAgICBpZiAoISh4KSkgeyBcCisgICAgICAgIEJMT0dfRVJST1IoIkFTU0VSVElPTiBG QUlMRUQ6ICIgI3ggIiA6OiAiIGZvcm1hdCwgIyNfX1ZBX0FSR1NfXyk7IFwKKyAgICAgICAgQkNS QVNIKCk7IFwKKyAgICB9IFwKK30gd2hpbGUgKDApOworI2VuZGlmCiAKLSNkZWZpbmUgVU5VU0VE KHgpICh2b2lkKXgKKyNkZWZpbmUgVU5VU0VEKHgpICgodm9pZCl4KQogCiAvLyA9PT09PSBSZWxl YXNlIGJ1aWxkID09PT09CiAKQEAgLTg1LDcgKzEwNSw3IEBACiAKICNkZWZpbmUgQkFTU0VSVCh4 KSBCQVNTRVJUX0lNUEwoeCkKIAotI2RlZmluZSBJRl9ERUJVRyh4KSB4CisjZGVmaW5lIElGX0RF QlVHKHgpICh4KQogCiAjZW5kaWYgLy8gIWRlZmluZWQoTkRFQlVHKQogCmRpZmYgLS1naXQgYS9T b3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxv Yy9CUGxhdGZvcm0uaAppbmRleCBhZjM5YTI1OTMxYzA3OWNkNGE0OTRjNDI4NzgyZTYzY2ViZWFh ZmYyLi4xZWI4Yjk1M2JiOGJkMDU4ZTU5ODE4NmU5ZGU1NjVlMjk4ZDkwNzg5IDEwMDY0NAotLS0g YS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9ibWFsbG9j L2JtYWxsb2MvQlBsYXRmb3JtLmgKQEAgLTI3LDE4ICsyNywxNCBAQAogI2RlZmluZSBCUGxhdGZv cm1faAogCiAjaWZkZWYgX19BUFBMRV9fCisjaW5jbHVkZSA8QXZhaWxhYmlsaXR5Lmg+CisjaW5j bHVkZSA8QXZhaWxhYmlsaXR5TWFjcm9zLmg+CiAjaW5jbHVkZSA8VGFyZ2V0Q29uZGl0aW9uYWxz Lmg+CiAjZW5kaWYKIAogI2RlZmluZSBCUExBVEZPUk0oUExBVEZPUk0pIChkZWZpbmVkIEJQTEFU Rk9STV8jI1BMQVRGT1JNICYmIEJQTEFURk9STV8jI1BMQVRGT1JNKQogI2RlZmluZSBCT1MoT1Mp IChkZWZpbmVkIEJPU18jI09TICYmIEJPU18jI09TKQogCi0jaWYgKChkZWZpbmVkKFRBUkdFVF9P U19FTUJFRERFRCkgJiYgVEFSR0VUX09TX0VNQkVEREVEKSBcCi0gICAgfHwgKGRlZmluZWQoVEFS R0VUX09TX0lQSE9ORSkgJiYgVEFSR0VUX09TX0lQSE9ORSkgXAotICAgIHx8IChkZWZpbmVkKFRB UkdFVF9JUEhPTkVfU0lNVUxBVE9SKSAmJiBUQVJHRVRfSVBIT05FX1NJTVVMQVRPUikpCi0jZGVm aW5lIEJQTEFURk9STV9JT1MgMQotI2VuZGlmCi0KICNpZmRlZiBfX0FQUExFX18KICNkZWZpbmUg Qk9TX0RBUldJTiAxCiAjZW5kaWYKQEAgLTQ3LDYgKzQzLDE5IEBACiAjZGVmaW5lIEJPU19VTklY IDEKICNlbmRpZgogCisjaWYgQk9TKERBUldJTikgJiYgKChkZWZpbmVkKFRBUkdFVF9PU19FTUJF RERFRCkgJiYgVEFSR0VUX09TX0VNQkVEREVEKSBcCisgICAgfHwgKGRlZmluZWQoVEFSR0VUX09T X0lQSE9ORSkgJiYgVEFSR0VUX09TX0lQSE9ORSkgXAorICAgIHx8IChkZWZpbmVkKFRBUkdFVF9J UEhPTkVfU0lNVUxBVE9SKSAmJiBUQVJHRVRfSVBIT05FX1NJTVVMQVRPUikpCisjZGVmaW5lIEJQ TEFURk9STV9JT1MgMQorI2VsaWYgQk9TKERBUldJTikgJiYgZGVmaW5lZChUQVJHRVRfT1NfTUFD KSAmJiBUQVJHRVRfT1NfTUFDCisjZGVmaW5lIEJQTEFURk9STV9NQUMgMQorI2VuZGlmCisKKy8q ID09PT0gUG9saWN5IGRlY2lzaW9uIG1hY3JvczogdGhlc2UgZGVmaW5lIHBvbGljeSBjaG9pY2Vz IGZvciBhIHBhcnRpY3VsYXIgcG9ydC4gPT09PSAqLworCisvKiBCVVNFKCkgLSB1c2UgYSBwYXJ0 aWN1bGFyIHRoaXJkLXBhcnR5IGxpYnJhcnkgb3Igb3B0aW9uYWwgT1Mgc2VydmljZSAqLworI2Rl ZmluZSBCVVNFKEZFQVRVUkUpIChkZWZpbmVkIEJVU0VfIyNGRUFUVVJFICYmIEJVU0VfIyNGRUFU VVJFKQorCiAvKiA9PT09IFBsYXRmb3JtIGFkYXB0YXRpb24gbWFjcm9zOiB0aGVzZSBkZXNjcmli ZSBwcm9wZXJ0aWVzIG9mIHRoZSB0YXJnZXQgZW52aXJvbm1lbnQuID09PT0gKi8KIAogLyogQkNQ VSgpIC0gdGhlIHRhcmdldCBDUFUgYXJjaGl0ZWN0dXJlICovCkBAIC0xODEsNCArMTkwLDEwIEBA CiAKICNlbmRpZiAvKiBBUk0gKi8KIAorI2RlZmluZSBCQVRUUklCVVRFX1BSSU5URihmb3JtYXRT dHJpbmdBcmd1bWVudCwgZXh0cmFBcmd1bWVudHMpIF9fYXR0cmlidXRlX18oKF9fZm9ybWF0X18o cHJpbnRmLCBmb3JtYXRTdHJpbmdBcmd1bWVudCwgZXh0cmFBcmd1bWVudHMpKSkKKworI2lmIChC UExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTIw MCkgfHwgKEJQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVE ID49IDEwMDAwMCkKKyNkZWZpbmUgQlVTRV9PU19MT0cgMQorI2VuZGlmCisKICNlbmRpZiAvLyBC UGxhdGZvcm1faApkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Mb2dnaW5nLmNw cCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvTG9nZ2luZy5jcHAKaW5kZXggMDNlY2I2ZDMxMTgy OWNhOTMyNTQ4NDA5Zjc5ODExMDVhZmU2ZTY3OS4uODA0ZDk1YTQ5OGQxMzc0ODRkNDEwN2RkNGZm YWM4M2YwMDk4ZWQ2ZiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Mb2dnaW5n LmNwcAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0xvZ2dpbmcuY3BwCkBAIC0yNiw2ICsy Niw5IEBACiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIkJQbGF0Zm9ybS5oIgogCisj aW5jbHVkZSA8c3RkYXJnLmg+CisjaW5jbHVkZSA8c3RkaW8uaD4KKwogI2lmIEJQTEFURk9STShJ T1MpCiAjaW5jbHVkZSA8bWFjaC9leGNlcHRpb25fdHlwZXMuaD4KICNpbmNsdWRlIDxvYmpjL29i amMuaD4KQEAgLTQ2LDQgKzQ5LDE1IEBAIHZvaWQgbG9nVk1GYWlsdXJlKCkKICNlbmRpZgogfQog CisjaWYgIUJVU0UoT1NfTE9HKQordm9pZCByZXBvcnRBc3NlcnRpb25GYWlsdXJlV2l0aE1lc3Nh Z2UoY29uc3QgY2hhciogZmlsZSwgaW50IGxpbmUsIGNvbnN0IGNoYXIqIGZ1bmN0aW9uLCBjb25z dCBjaGFyKiBmb3JtYXQsIC4uLikKK3sKKyAgICB2YV9saXN0IGFyZ3M7CisgICAgdmFfc3RhcnQo YXJncywgZm9ybWF0KTsKKyAgICB2ZnByaW50ZihzdGRlcnIsIGZvcm1hdCwgYXJncyk7CisgICAg dmFfZW5kKGFyZ3MpOworICAgIGZwcmludGYoc3RkZXJyLCAiJXMoJWQpIDogJXNcbiIsIGZpbGUs IGxpbmUsIGZ1bmN0aW9uKTsKK30KKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBibWFsbG9jCmRp ZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0xvZ2dpbmcuaCBiL1NvdXJjZS9ibWFs bG9jL2JtYWxsb2MvTG9nZ2luZy5oCmluZGV4IDRmOWYzZTFhODBjNmE2ZDQyMTk3MDQyYTM4MGJm NTQ0MjE0ZDRiYWMuLmM0NmM3NTEyMjBmZjg4ZTA3OTI4ZWY4MGI2ZWNjMDFlOGM2OWQ3NmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvTG9nZ2luZy5oCisrKyBiL1NvdXJjZS9i bWFsbG9jL2JtYWxsb2MvTG9nZ2luZy5oCkBAIC0yNiwxMCArMjYsMTQgQEAKICNpZm5kZWYgTG9n Z2luZ19oCiAjZGVmaW5lIExvZ2dpbmdfaAogCisjaW5jbHVkZSAiQlBsYXRmb3JtLmgiCisKIG5h bWVzcGFjZSBibWFsbG9jIHsKIAogdm9pZCBsb2dWTUZhaWx1cmUoKTsKIAordm9pZCByZXBvcnRB c3NlcnRpb25GYWlsdXJlV2l0aE1lc3NhZ2UoY29uc3QgY2hhciogZmlsZSwgaW50IGxpbmUsIGNv bnN0IGNoYXIqIGZ1bmN0aW9uLCBjb25zdCBjaGFyKiBmb3JtYXQsIC4uLikgQkFUVFJJQlVURV9Q UklOVEYoNCwgNSk7CisKIH0gLy8gbmFtZXNwYWNlIGJtYWxsb2MKIAogI2VuZGlmIC8vIExvZ2dp bmdfaAo=