155982 2016-03-29 12:43:55 -0700 JSC::Debugger cleanup after recent changes 2016-03-29 13:12:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1178755 0 joepeck 2016-03-29 12:43:55 -0700 * SUMMARY JSC::Debugger cleanup after recent changes. 1. Debugger should not start out assuming breakpoints are active. 2. Debugger does not need to recompile JS when enabling the Sampling Profiler! And I believe all ports are using the new sampling profiler! 1178756 1 275120 joepeck 2016-03-29 12:45:52 -0700 Created attachment 275120 [PATCH] Proposed Fix 1178761 2 275120 mark.lam 2016-03-29 12:50:56 -0700 Comment on attachment 275120 [PATCH] Proposed Fix r=me 1178762 3 275120 saam 2016-03-29 12:51:33 -0700 Comment on attachment 275120 [PATCH] Proposed Fix LGTM too. Nice catch 1178771 4 275120 commit-queue 2016-03-29 13:12:17 -0700 Comment on attachment 275120 [PATCH] Proposed Fix Clearing flags on attachment: 275120 Committed r198791: <http://trac.webkit.org/changeset/198791> 1178772 5 commit-queue 2016-03-29 13:12:20 -0700 All reviewed patches have been landed. Closing bug. 275120 2016-03-29 12:45:52 -0700 2016-03-29 13:12:17 -0700 [PATCH] Proposed Fix debugger-cleanup.patch text/plain 1813 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDNkMTJkMTguLjE5ZDFlMzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTAzLTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgSlNDOjpEZWJ1Z2dlciBjbGVhbnVw IGFmdGVyIHJlY2VudCBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTU5ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyLmNwcDoKKyAgICAgICAgKEpTQzo6RGVi dWdnZXI6OkRlYnVnZ2VyKToKKyAgICAgICAgSW5pdGlhbGl6ZSB3aXRoIGJyZWFrcG9pbnRzIGRp c2FibGVkLiBXZWIgSW5zcGVjdG9yIGFsd2F5cyBpbmZvcm1zCisgICAgICAgIHRoZSBiYWNrZW5k IGlmIGl0IHNob3VsZCBlbmFibGUgb3IgZGlzYWJsZSBicmVha3BvaW50cyBvbiBzdGFydHVwLgor CisgICAgICAgIChKU0M6OkRlYnVnZ2VyOjpzZXRQcm9maWxpbmdDbGllbnQpOgorICAgICAgICBX aGVuIHVzaW5nIHRoZSBTYW1wbGluZyBwcm9maWxlciB3ZSBkbyBub3QgbmVlZCB0byByZWNvbXBp bGUuCisKKzIwMTYtMDMtMjkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K KwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBXZSBzaG91bGQgaGF2ZSBhIHdheSB0byBjYXB0dXJl IGhlYXAgc25hcHNob3RzIHByb2dyYW1hdGljYWxseS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDQwNwogICAgICAgICA8cmRhcjovL3Byb2JsZW0v MjQ3MjYyOTI+CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVi dWdnZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcApp bmRleCBiOGQ3MTYwLi43MTZhNjVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGVidWdnZXIvRGVidWdnZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dl ci9EZWJ1Z2dlci5jcHAKQEAgLTExOCw3ICsxMTgsNyBAQCBEZWJ1Z2dlcjo6RGVidWdnZXIoVk0m IHZtKQogICAgICwgbV9wYXVzZU9uRXhjZXB0aW9uc1N0YXRlKERvbnRQYXVzZU9uRXhjZXB0aW9u cykKICAgICAsIG1fcGF1c2VPbk5leHRTdGF0ZW1lbnQoZmFsc2UpCiAgICAgLCBtX2lzUGF1c2Vk KGZhbHNlKQotICAgICwgbV9icmVha3BvaW50c0FjdGl2YXRlZCh0cnVlKQorICAgICwgbV9icmVh a3BvaW50c0FjdGl2YXRlZChmYWxzZSkKICAgICAsIG1faGFzSGFuZGxlckZvckV4Y2VwdGlvbkNh bGxiYWNrKGZhbHNlKQogICAgICwgbV9zdXBwcmVzc0FsbFBhdXNlcyhmYWxzZSkKICAgICAsIG1f c3RlcHBpbmdNb2RlKFN0ZXBwaW5nTW9kZURpc2FibGVkKQpAQCAtMjMyLDggKzIzMiw2IEBAIHZv aWQgRGVidWdnZXI6OnNldFByb2ZpbGluZ0NsaWVudChQcm9maWxpbmdDbGllbnQqIGNsaWVudCkK IHsKICAgICBBU1NFUlQoISFtX3Byb2ZpbGluZ0NsaWVudCAhPSAhIWNsaWVudCk7CiAgICAgbV9w cm9maWxpbmdDbGllbnQgPSBjbGllbnQ7Ci0KLSAgICByZWNvbXBpbGVBbGxKU0Z1bmN0aW9ucygp OwogfQogCiBkb3VibGUgRGVidWdnZXI6OndpbGxFdmFsdWF0ZVNjcmlwdCgpCg==