155973 2016-03-29 10:05:40 -0700 REGRESSION (r196813): Missing plug-in placeholder is missing 2016-03-31 09:49:34 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan mmaxfield simon.fraser webkit-bug-importer oldest_to_newest 1178693 0 zalan 2016-03-29 10:05:40 -0700 1, launch Safari (not having installed Flash yet) 2, go to www.badgerbadgerbadger.com (auto-playing looping Flash animation) "Missing Plug-in" button is missing. 1178694 1 zalan 2016-03-29 10:06:07 -0700 rdar://problem/25068392 1178699 2 275102 zalan 2016-03-29 10:21:36 -0700 Created attachment 275102 Patch 1178700 3 275102 aestes 2016-03-29 10:23:36 -0700 Comment on attachment 275102 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275102&action=review > Source/WebCore/ChangeLog:3 > + REGRESSION (r196813): Missing plug-in placeholder is missing :| 1178734 4 275102 commit-queue 2016-03-29 11:33:34 -0700 Comment on attachment 275102 Patch Clearing flags on attachment: 275102 Committed r198785: <http://trac.webkit.org/changeset/198785> 1178735 5 commit-queue 2016-03-29 11:33:38 -0700 All reviewed patches have been landed. Closing bug. 1178740 6 mmaxfield 2016-03-29 11:57:19 -0700 Please add a expected-to-be-different reftest. You can do this by naming the expected file mytest-expected-mismatch.html 1178747 7 zalan 2016-03-29 12:09:09 -0700 (In reply to comment #6) > Please add a expected-to-be-different reftest. You can do this by naming the > expected file mytest-expected-mismatch.html I am not much of a fan of -mismatch, but I guess it's better than no test. 1179452 8 zalan 2016-03-31 09:49:34 -0700 LayoutTests/plugins/missing-plugin-placeholder.html Committed r198898: <http://trac.webkit.org/changeset/198898> 275102 2016-03-29 10:21:36 -0700 2016-03-29 11:33:34 -0700 Patch bug-155973-20160329102140.patch text/plain 2208 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGJhZjBiMmU2MWJkZDhl MjUyZjE2MWM3ZTYyOTkyMTdlYmQ3ZDU0Yy4uOWMwOTA4NjM4OTI0ZTA1MDIzNmYwNzJjZmRiMTll N2MwMDJlOWU4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTAzLTI5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE5Njgx Myk6IE1pc3NpbmcgcGx1Zy1pbiBwbGFjZWhvbGRlciBpcyBtaXNzaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU5NzMKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzI1MDY4MzkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFNob3cgdW5hdmFpbGFibGUgcGx1Z2luIGluZGljYXRvciB3aGVuIFVuYXZh aWxhYmxlUGx1Z2luSW5kaWNhdG9yU3RhdGUgKHVuaW5pdGlhbGl6ZWQsIGhpZGRlbiwgdmlzaWJs ZSkgaXMgbm90IHNldCB0byBoaWRkZW4gZXhwbGljaXRseS4KKyAgICAgICAgSXQgbWF0Y2hlcyBw cmUtMTk2ODEzIGJlaGF2aW91ci4KKworICAgICAgICBVbmFibGUgdG8gdGVzdC4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJFbWJlZGRlZE9iamVjdC5oOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyRW1iZWRkZWRPYmplY3Q6OnNob3dzVW5hdmFpbGFibGVQbHVnaW5JbmRpY2F0b3IpOgor CiAyMDE2LTAzLTI5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAg SW5saW5lIFdlYkZ1bGxTY3JlZW5WaWRlb1Jvb3RWaWV3Q29udHJvbGxlci5tCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRW1iZWRkZWRPYmplY3QuaCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbWJlZGRlZE9iamVjdC5oCmluZGV4IGNjYjgzYjE3 NzQ3ZmU2MGNkNDFiNWQ3YzY3ZTcyN2Y4NTdhNGRjYmMuLjFhNjE1ZWRmZGZiNjQ2MTUzN2IwNzkw YzIxMGYxNTI0ZDI2NzQxNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJFbWJlZGRlZE9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJFbWJlZGRlZE9iamVjdC5oCkBAIC01MCw3ICs1MCw2IEBAIHB1YmxpYzoKICAgICBXRUJDT1JF X0VYUE9SVCB2b2lkIHNldFBsdWdpblVuYXZhaWxhYmlsaXR5UmVhc29uV2l0aERlc2NyaXB0aW9u KFBsdWdpblVuYXZhaWxhYmlsaXR5UmVhc29uLCBjb25zdCBTdHJpbmcmIGRlc2NyaXB0aW9uKTsK IAogICAgIGJvb2wgaXNQbHVnaW5VbmF2YWlsYWJsZSgpIGNvbnN0IHsgcmV0dXJuIG1faXNQbHVn aW5VbmF2YWlsYWJsZTsgfQotICAgIGJvb2wgc2hvd3NVbmF2YWlsYWJsZVBsdWdpbkluZGljYXRv cigpIGNvbnN0IHsgcmV0dXJuIGlzUGx1Z2luVW5hdmFpbGFibGUoKSAmJiBtX2lzVW5hdmFpbGFi bGVQbHVnaW5JbmRpY2F0b3JTdGF0ZSA9PSBVbmF2YWlsYWJsZVBsdWdpbkluZGljYXRvclN0YXRl OjpWaXNpYmxlOyB9CiAKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIHNldFVuYXZhaWxhYmxlUGx1 Z2luSW5kaWNhdG9ySXNIaWRkZW4oYm9vbCk7CiAKQEAgLTczLDYgKzcyLDcgQEAgcHJpdmF0ZToK ICAgICBjb25zdCBjaGFyKiByZW5kZXJOYW1lKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gIlJl bmRlckVtYmVkZGVkT2JqZWN0IjsgfQogICAgIGJvb2wgaXNFbWJlZGRlZE9iamVjdCgpIGNvbnN0 IGZpbmFsIHsgcmV0dXJuIHRydWU7IH0KIAorICAgIGJvb2wgc2hvd3NVbmF2YWlsYWJsZVBsdWdp bkluZGljYXRvcigpIGNvbnN0IHsgcmV0dXJuIGlzUGx1Z2luVW5hdmFpbGFibGUoKSAmJiBtX2lz VW5hdmFpbGFibGVQbHVnaW5JbmRpY2F0b3JTdGF0ZSAhPSBVbmF2YWlsYWJsZVBsdWdpbkluZGlj YXRvclN0YXRlOjpIaWRkZW47IH0KICAgICB2b2lkIHBhaW50U25hcHNob3RJbWFnZShQYWludElu Zm8mLCBjb25zdCBMYXlvdXRQb2ludCYsIEltYWdlJik7CiAgICAgdm9pZCBwYWludENvbnRlbnRz KFBhaW50SW5mbyYsIGNvbnN0IExheW91dFBvaW50JikgZmluYWw7CiAK