155963 2016-03-28 21:12:02 -0700 Web Automation: Add SPI to tell whether an NSEvent was synthesized for automation 2016-03-29 13:21:43 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1178621 0 bburg 2016-03-28 21:12:02 -0700 It was Joe's Idea. 1178622 1 webkit-bug-importer 2016-03-28 21:12:54 -0700 <rdar://problem/25405747> 1178683 2 275099 bburg 2016-03-29 09:24:50 -0700 Created attachment 275099 Proposed Fix 1178685 3 275099 timothy 2016-03-29 09:47:38 -0700 Comment on attachment 275099 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=275099&action=review > Source/WebKit2/UIProcess/API/Cocoa/_WKAutomationSession.h:43 > +- (BOOL)eventWasSynthesizedForAutomation:(NSEvent *)event; I think this needs to be: wasEventSynthesizedForAutomation: > Source/WebKit2/UIProcess/Automation/WebAutomationSession.h:117 > + bool eventWasSynthesizedForAutomation(NSEvent *); Ditto. 1178778 4 bburg 2016-03-29 13:21:43 -0700 Committed: <http://trac.webkit.org/changeset/198793> 275099 2016-03-29 09:24:50 -0700 2016-03-29 09:47:38 -0700 Proposed Fix bug-155963-20160329092454.patch text/plain 5576 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWI1ZDQwOTFmYWNmMmU3 NGQ4ZTcyYjEzOTkxM2QyNmRhNThjNzBjNi4uN2MyOWVjMzEyMGIxNmJiODA4NDI2OWI2ZTg5YWM0 OGFjZDFkZjJkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE2LTAzLTI5ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBBdXRvbWF0aW9uOiBBZGQg U1BJIHRvIHRlbGwgd2hldGhlciBhbiBOU0V2ZW50IHdhcyBzeW50aGVzaXplZCBmb3IgYXV0b21h dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1 OTYzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNTQwNTc0Nz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUYWcgYWxsIE5TRXZlbnRzIHRoYXQgd2Vy ZSBzeW50aGVzaXplZCB3aXRoIGFuIGFzc29jaWF0ZWQgb2JqZWN0IGJlZm9yZSBzZW5kaW5nLgor ICAgICAgICBEbyBhbGwgYXNzb2NpYXRlZCBvYmplY3Qgd29yayBiZWxvdyB0aGUgQVBJIGxheWVy IHNvIHdlIGRvbid0IGdldCBpbnRvIHRyb3VibGUKKyAgICAgICAgdXNpbmcgdGhpbmdzIHRoYXQg bWF5IGJlIGd1YXJkZWQgYnkgV0tfQVBJX0VOQUJMRUQuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL0NvY29hL19XS0F1dG9tYXRpb25TZXNzaW9uLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9Db2NvYS9fV0tBdXRvbWF0aW9uU2Vzc2lvbi5tbToKKyAgICAgICAgKC1bX1dLQXV0b21hdGlv blNlc3Npb24gZXZlbnRXYXNTeW50aGVzaXplZEZvckF1dG9tYXRpb246XSk6CisgICAgICAgIEZv cndhcmQgdG8gdGhlIHdyYXBwZWQgc2Vzc2lvbiBvYmplY3QuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5oOgorICAgICAgICAqIFVJUHJvY2Vz cy9Db2NvYS9XZWJBdXRvbWF0aW9uU2Vzc2lvbkNvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpX ZWJBdXRvbWF0aW9uU2Vzc2lvbjo6c2VuZFN5bnRoZXNpemVkRXZlbnRzVG9QYWdlKToKKyAgICAg ICAgVGFnIG91dGdvaW5nIE5TRXZlbnRzIHdpdGggdGhlIHNlc3Npb24gaWRlbnRpZmllciBhcyBh biBhc3NvY2lhdGVkIG9iamVjdC4KKworICAgICAgICAoV2ViS2l0OjpXZWJBdXRvbWF0aW9uU2Vz c2lvbjo6ZXZlbnRXYXNTeW50aGVzaXplZEZvckF1dG9tYXRpb24pOgorICAgICAgICBDaGVja2lu ZyBhbiBpbmNvbWluZyBOU0V2ZW50IHRvIHNlZSBpZiBpdHMgYXNzb2NpYXRlZCBvYmplY3QgaXMg dGhlIHNlc3Npb24gaWRlbnRpZmllci4KKwogMjAxNi0wMy0yOCAgQnJpYW4gQnVyZyAgPGJidXJn QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgQXV0b21hdGlvbjogaW1wbGVtZW50IEF1dG9tYXRp b24ucGVyZm9ybU1vdXNlSW50ZXJhY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQ29jb2EvX1dLQXV0b21hdGlvblNlc3Npb24uaCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLQXV0b21hdGlvblNlc3Npb24uaAppbmRleCBmNmZiYzcw NDEwZjgzNzQwOTlhZjYwMmIwZTIwZWQyNjJmN2Q5NDU5Li4wYTM2MDczY2ZkY2NhZmE5YjQ4NmMy YmRhNDExMTA2ZTk4ZTg4NDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL19XS0F1dG9tYXRpb25TZXNzaW9uLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9fV0tBdXRvbWF0aW9uU2Vzc2lvbi5oCkBAIC00MCw2ICs0MCw4IEBA IFdLX0NMQVNTX0FWQUlMQUJMRShXS19NQUNfVEJBLCBXS19JT1NfVEJBKQogQHByb3BlcnR5IChu b25hdG9taWMsIHdlYWspIGlkIDxfV0tBdXRvbWF0aW9uU2Vzc2lvbkRlbGVnYXRlPiBkZWxlZ2F0 ZTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSwgZ2V0dGVyPWlzUGFpcmVkKSBCT09M IHBhaXJlZDsKIAorLSAoQk9PTClldmVudFdhc1N5bnRoZXNpemVkRm9yQXV0b21hdGlvbjooTlNF dmVudCAqKWV2ZW50OworCiBAZW5kCiAKIE5TX0FTU1VNRV9OT05OVUxMX0VORApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tBdXRvbWF0aW9uU2Vzc2lv bi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLQXV0b21hdGlvblNl c3Npb24ubW0KaW5kZXggNDI4NGJhNDkyYWYxNDUwOGFlMzFlZDAyMGU0YjQ5ODA4ZTI4OWZiOS4u ZDJmZGI5YmYxZDcwMTk4N2ZjMDk0YzU3Njk3N2M3MDY3MGRjNmM1MSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tBdXRvbWF0aW9uU2Vzc2lvbi5tbQor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0F1dG9tYXRpb25TZXNz aW9uLm1tCkBAIC04Myw2ICs4MywxMSBAQCAtIChCT09MKWlzUGFpcmVkCiAgICAgcmV0dXJuIF9z ZXNzaW9uLT5pc1BhaXJlZCgpOwogfQogCistIChCT09MKWV2ZW50V2FzU3ludGhlc2l6ZWRGb3JB dXRvbWF0aW9uOihOU0V2ZW50ICopZXZlbnQKK3sKKyAgICByZXR1cm4gX3Nlc3Npb24tPmV2ZW50 V2FzU3ludGhlc2l6ZWRGb3JBdXRvbWF0aW9uKGV2ZW50KTsKK30KKwogI3ByYWdtYSBtYXJrIFdL T2JqZWN0IHByb3RvY29sIGltcGxlbWVudGF0aW9uCiAKIC0gKEFQSTo6T2JqZWN0JilfYXBpT2Jq ZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJB dXRvbWF0aW9uU2Vzc2lvbi5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dG9tYXRpb24v V2ViQXV0b21hdGlvblNlc3Npb24uaAppbmRleCBlMjljMjVlNWEzNjMxNzM1NWZlMjM4NzYxZWFj ZGUxNTQ0NDcxMTNjLi4xNDdmMmU1OWQ1MGZhY2Y5Njk0Njg2MWNlNmJkNTZlMjkxMzA4ZWM5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0 aW9uU2Vzc2lvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRvbWF0aW9uL1dl YkF1dG9tYXRpb25TZXNzaW9uLmgKQEAgLTU0LDYgKzU0LDcgQEAgY2xhc3MgSW50UG9pbnQ7CiAK ICNpZiBVU0UoQVBQS0lUKQogT0JKQ19DTEFTUyBOU0FycmF5OworT0JKQ19DTEFTUyBOU0V2ZW50 OwogI2VuZGlmCiAKIG5hbWVzcGFjZSBXZWJLaXQgewpAQCAtMTEyLDYgKzExMywxMCBAQCBwdWJs aWM6CiAgICAgdm9pZCBtZXNzYWdlT2ZDdXJyZW50SmF2YVNjcmlwdERpYWxvZyhJbnNwZWN0b3I6 OkVycm9yU3RyaW5nJiwgY29uc3QgU3RyaW5nJiBicm93c2luZ0NvbnRleHRIYW5kbGUsIFN0cmlu ZyogdGV4dCkgb3ZlcnJpZGU7CiAgICAgdm9pZCBzZXRVc2VySW5wdXRGb3JDdXJyZW50SmF2YVNj cmlwdFByb21wdChJbnNwZWN0b3I6OkVycm9yU3RyaW5nJiwgY29uc3QgU3RyaW5nJiBicm93c2lu Z0NvbnRleHRIYW5kbGUsIGNvbnN0IFN0cmluZyYgdGV4dCkgb3ZlcnJpZGU7CiAKKyNpZiBVU0Uo QVBQS0lUKQorICAgIGJvb2wgZXZlbnRXYXNTeW50aGVzaXplZEZvckF1dG9tYXRpb24oTlNFdmVu dCAqKTsKKyNlbmRpZgorCiBwcml2YXRlOgogICAgIFdlYlBhZ2VQcm94eSogd2ViUGFnZVByb3h5 Rm9ySGFuZGxlKGNvbnN0IFN0cmluZyYpOwogICAgIFN0cmluZyBoYW5kbGVGb3JXZWJQYWdlUHJv eHkoY29uc3QgV2ViUGFnZVByb3h5Jik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQ29jb2EvV2ViQXV0b21hdGlvblNlc3Npb25Db2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9Db2NvYS9XZWJBdXRvbWF0aW9uU2Vzc2lvbkNvY29hLm1tCmluZGV4IDY5MjY3 MTAxN2JmYmM3OTVjODgyNTA3NTE4MjU0YzkwZDY0ZDFhZGQuLjEzNDZlYWJjZDk5NjgyYTA1NTkw Yzk0ZGI5MzExOWJkMzA5MDViMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9Db2NvYS9XZWJBdXRvbWF0aW9uU2Vzc2lvbkNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9Db2NvYS9XZWJBdXRvbWF0aW9uU2Vzc2lvbkNvY29hLm1tCkBAIC0zOSwxNyAr MzksMjQgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAKICNpZiBVU0UoQVBQS0lUKQogCitzdGF0aWMg Y29uc3Qgdm9pZCAqc3ludGhlc2l6ZWRBdXRvbWF0aW9uRXZlbnRBc3NvY2lhdGVkT2JqZWN0S2V5 ID0gJnN5bnRoZXNpemVkQXV0b21hdGlvbkV2ZW50QXNzb2NpYXRlZE9iamVjdEtleTsKKwogdm9p ZCBXZWJBdXRvbWF0aW9uU2Vzc2lvbjo6c2VuZFN5bnRoZXNpemVkRXZlbnRzVG9QYWdlKFdlYlBh Z2VQcm94eSYgcGFnZSwgTlNBcnJheSAqZXZlbnRzVG9TZW5kKQogewogICAgIE5TV2luZG93ICp3 aW5kb3cgPSBwYWdlLnBsYXRmb3JtV2luZG93KCk7CiAKICAgICBmb3IgKE5TRXZlbnQgKmV2ZW50 IGluIGV2ZW50c1RvU2VuZCkgewotICAgICAgICAvLyBGSVhNRTogPGh0dHBzOi8vd3d3LndlYmtp dC5vcmcvYi8xNTU5NjM+IFNldCBhbiBhc3NvY2lhdGVkIG9iamVjdCB3aXRoIGEgcGVyLXNlc3Np b24gaWRlbnRpZmllci4KLSAgICAgICAgLy8gVGhpcyB3aWxsIGFsbG93IGEgV2ViS2l0MiBjbGll bnQgdG8gdGVsbCBhcGFydCBldmVudHMgc3ludGhlc2l6ZWQgb24gYmVoYWxmIG9mIGFuIGF1dG9t YXRpb24gY29tbWFuZC4KKyAgICAgICAgb2JqY19zZXRBc3NvY2lhdGVkT2JqZWN0KGV2ZW50LCAm c3ludGhlc2l6ZWRBdXRvbWF0aW9uRXZlbnRBc3NvY2lhdGVkT2JqZWN0S2V5LCBtX3Nlc3Npb25J ZGVudGlmaWVyLCBPQkpDX0FTU09DSUFUSU9OX1JFVEFJTl9OT05BVE9NSUMpOwogICAgICAgICBb d2luZG93IHNlbmRFdmVudDpldmVudF07CiAgICAgfQogfQogCitib29sIFdlYkF1dG9tYXRpb25T ZXNzaW9uOjpldmVudFdhc1N5bnRoZXNpemVkRm9yQXV0b21hdGlvbihOU0V2ZW50ICpldmVudCkK K3sKKyAgICBOU1N0cmluZyAqc2VuZGVyU2Vzc2lvbklkZW50aWZpZXIgPSBvYmpjX2dldEFzc29j aWF0ZWRPYmplY3QoZXZlbnQsICZzeW50aGVzaXplZEF1dG9tYXRpb25FdmVudEFzc29jaWF0ZWRP YmplY3RLZXkpOworICAgIHJldHVybiBbc2VuZGVyU2Vzc2lvbklkZW50aWZpZXIgaXNFcXVhbFRv U3RyaW5nOm1fc2Vzc2lvbklkZW50aWZpZXJdOworfQorCiB2b2lkIFdlYkF1dG9tYXRpb25TZXNz aW9uOjpwbGF0Zm9ybVNpbXVsYXRlTW91c2VJbnRlcmFjdGlvbihXZWJQYWdlUHJveHkmIHBhZ2Us IGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiB2aWV3UG9zaXRpb24sIEluc3BlY3Rvcjo6UHJvdG9j b2w6OkF1dG9tYXRpb246Ok1vdXNlSW50ZXJhY3Rpb24gaW50ZXJhY3Rpb24sIEluc3BlY3Rvcjo6 UHJvdG9jb2w6OkF1dG9tYXRpb246Ok1vdXNlQnV0dG9uIGJ1dHRvbiwgV2ViRXZlbnQ6Ok1vZGlm aWVycyBrZXlNb2RpZmllcnMpCiB7CiAgICAgSW50UmVjdCB3aW5kb3dSZWN0Owo=