155927 2016-03-26 18:48:07 -0700 [TexMap] Trim redundant guards 2016-04-04 03:26:25 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 emanuele.aina webkit-unassigned commit-queue dino kondapallykalyan mrobinson ossy roger_fong zan oldest_to_newest 1178307 0 emanuele.aina 2016-03-26 18:48:07 -0700 [TexMap] Trim redundant guards 1178308 1 274993 emanuele.aina 2016-03-26 18:50:54 -0700 Created attachment 274993 Patch 1178309 2 commit-queue 2016-03-26 18:53:21 -0700 Attachment 274993 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1178384 3 274993 gyuyoung.kim 2016-03-27 22:43:48 -0700 Comment on attachment 274993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274993&action=review r- because of missing bug url in ChangeLog. > Source/WebCore/ChangeLog:4 > + Need the bug URL (OOPS!). Missing bug number. > Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:-114 > -#elif USE(TEXTURE_MAPPER) && !USE(COORDINATED_GRAPHICS_THREADED) It seems to me that TEXTIRE_MAPPER is always on, but COORDINATED_GRAPHICS_THREADED is able to be enabled only when ENABLE_OPENGL is on. So I wonder if this !USE(COORDINATED_GRAPHICS_THREADED) guard can be removed. 1179900 4 274993 emanuele.aina 2016-04-01 11:25:59 -0700 Comment on attachment 274993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274993&action=review >> Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:-114 >> -#elif USE(TEXTURE_MAPPER) && !USE(COORDINATED_GRAPHICS_THREADED) > > It seems to me that TEXTIRE_MAPPER is always on, but COORDINATED_GRAPHICS_THREADED is able to be enabled only when ENABLE_OPENGL is on. So I wonder if this !USE(COORDINATED_GRAPHICS_THREADED) guard can be removed. Indeed it seem there's no relation in the buildsystem between those two variable. That said, CoordinatedGraphicsState.h uses TextureMapperPlatformLayerProxy if COORDINATED_GRAPHICS_THREADED is enabled without checking for TEXTURE_MAPPER, which seems to support my assumption that COORDINATED_GRAPHICS_THREADED implies TEXTURE_MAPPER. Now that I'm looking at CoordinatedGraphicsScene.cpp it seems that COORDINATED_GRAPHICS even unconditionally depends on TEXTURE_MAPPER_GL as the TextureMapperGL type is used unguarded... 1179901 5 275422 emanuele.aina 2016-04-01 11:28:15 -0700 Created attachment 275422 Patch 1179904 6 emanuele.aina 2016-04-01 11:30:49 -0700 I've reuploaded after adding the missing bug reference in the ChangeLog. Sorry, I was assuming that using webkit-patch to open the bug and uploading the patch in a single step would have taken care of that (or I may just have missed the right option). 1179924 7 275422 zan 2016-04-01 13:42:42 -0700 Comment on attachment 275422 Patch Looks good. 1180327 8 275422 commit-queue 2016-04-04 02:33:46 -0700 Comment on attachment 275422 Patch Rejecting attachment 275422 from commit-queue. emanuele.aina@collabora.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1180334 9 275422 commit-queue 2016-04-04 03:26:19 -0700 Comment on attachment 275422 Patch Clearing flags on attachment: 275422 Committed r199001: <http://trac.webkit.org/changeset/199001> 1180335 10 commit-queue 2016-04-04 03:26:25 -0700 All reviewed patches have been landed. Closing bug. 274993 2016-03-26 18:50:54 -0700 2016-04-01 11:28:04 -0700 Patch bug-155927-20160327035055.patch text/plain 1710 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjNiZTU3NGZjZWI2YTM0 OWUwZmM0OGY1NmUyY2NhZDcyZWZjYjMzYi4uN2MyMDZjZDY2NTRhN2I0NTZlZTNlNDdiMWUwYTY5 Yzg2YjgxOGU1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE2LTAzLTI2ICBFbWFu dWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEuY29tPgogCisgICAgICAgIFtUZXhN YXBdIFRyaW0gcmVkdW5kYW50IGd1YXJkcworICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BT ISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRFByaXZhdGUuY3BwOiBEcm9wIHNvbWUg cmVkdW5kYW50CisgICAgICAgIGNoZWNrcyBpbiBwcmVwcm9jZXNzb3IgZ3VhcmRzLgorCisyMDE2 LTAzLTI2ICBFbWFudWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEuY29tPgorCiAg ICAgICAgIFJlbHkgb24gUGxhdGZvcm1MYXllciB0byBjaG9vc2UgdGhlIFRleHR1cmVNYXBwZXJQ bGF0Zm9ybUxheWVyIGltcGwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1NTkyNgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9HcmFwaGljc0NvbnRleHQzRFByaXZhdGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmNwcAppbmRleCBiMTM0ZjVh NzQxZDRmZDMwNWM2ODM1N2JkOTA4ODdkMTdjOGI3MzA1Li4xNWNkNGRmMDBjNzM1YzlmNDUwYWM2 YTIyODdhMTY2NTU2M2FmZWM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9HcmFwaGljc0NvbnRleHQzRFByaXZhdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZS5jcHAKQEAgLTM3LDcg KzM3LDcgQEAKICNpbmNsdWRlICJPcGVuR0xTaGltcy5oIgogI2VuZGlmCiAKLSNpZiBVU0UoVEVY VFVSRV9NQVBQRVIpICYmIFVTRShURVhUVVJFX01BUFBFUl9HTCkKKyNpZiBVU0UoVEVYVFVSRV9N QVBQRVJfR0wpCiAjaW5jbHVkZSA8dGV4bWFwL1RleHR1cmVNYXBwZXJHTC5oPgogI2VuZGlmCiAK QEAgLTExMSw3ICsxMTEsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6c3dhcEJ1 ZmZlcnNJZk5lZWRlZCgpCiAKICAgICBtX2NvbnRleHQtPm1hcmtMYXllckNvbXBvc2l0ZWQoKTsK IH0KLSNlbGlmIFVTRShURVhUVVJFX01BUFBFUikgJiYgIVVTRShDT09SRElOQVRFRF9HUkFQSElD U19USFJFQURFRCkKKyNlbGlmIFVTRShURVhUVVJFX01BUFBFUikKIHZvaWQgR3JhcGhpY3NDb250 ZXh0M0RQcml2YXRlOjpwYWludFRvVGV4dHVyZU1hcHBlcihUZXh0dXJlTWFwcGVyJiB0ZXh0dXJl TWFwcGVyLCBjb25zdCBGbG9hdFJlY3QmIHRhcmdldFJlY3QsIGNvbnN0IFRyYW5zZm9ybWF0aW9u TWF0cml4JiBtYXRyaXgsIGZsb2F0IG9wYWNpdHkpCiB7CiAgICAgaWYgKCFtX2dsQ29udGV4dCkK 275422 2016-04-01 11:28:15 -0700 2016-04-04 03:26:19 -0700 Patch bug-155927-20160401202819.patch text/plain 1731 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4OTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzU0OWRlODVmZTM3NjU5 YzBlYjkyNWZlOTBlMWI0NmUwNDZmNDQ3NS4uZWI5MmE1MDdlYzY3MjRkOWRjM2I3Y2M3ODg1N2Y5 OGRkYWI3YWM5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE2LTAzLTI2ICBFbWFu dWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEuY29tPgogCisgICAgICAgIFtUZXhN YXBdIFRyaW0gcmVkdW5kYW50IGd1YXJkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU1OTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRFBy aXZhdGUuY3BwOiBEcm9wIHNvbWUgcmVkdW5kYW50CisgICAgICAgIGNoZWNrcyBpbiBwcmVwcm9j ZXNzb3IgZ3VhcmRzLgorCisyMDE2LTAzLTI2ICBFbWFudWVsZSBBaW5hICA8ZW1hbnVlbGUuYWlu YUBjb2xsYWJvcmEuY29tPgorCiAgICAgICAgIFJlbHkgb24gUGxhdGZvcm1MYXllciB0byBjaG9v c2UgdGhlIFRleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVyIGltcGwKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTkyNgogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRFByaXZhdGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0RQcml2 YXRlLmNwcAppbmRleCBiMTM0ZjVhNzQxZDRmZDMwNWM2ODM1N2JkOTA4ODdkMTdjOGI3MzA1Li4x NWNkNGRmMDBjNzM1YzlmNDUwYWM2YTIyODdhMTY2NTU2M2FmZWM2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRFByaXZhdGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNE UHJpdmF0ZS5jcHAKQEAgLTM3LDcgKzM3LDcgQEAKICNpbmNsdWRlICJPcGVuR0xTaGltcy5oIgog I2VuZGlmCiAKLSNpZiBVU0UoVEVYVFVSRV9NQVBQRVIpICYmIFVTRShURVhUVVJFX01BUFBFUl9H TCkKKyNpZiBVU0UoVEVYVFVSRV9NQVBQRVJfR0wpCiAjaW5jbHVkZSA8dGV4bWFwL1RleHR1cmVN YXBwZXJHTC5oPgogI2VuZGlmCiAKQEAgLTExMSw3ICsxMTEsNyBAQCB2b2lkIEdyYXBoaWNzQ29u dGV4dDNEUHJpdmF0ZTo6c3dhcEJ1ZmZlcnNJZk5lZWRlZCgpCiAKICAgICBtX2NvbnRleHQtPm1h cmtMYXllckNvbXBvc2l0ZWQoKTsKIH0KLSNlbGlmIFVTRShURVhUVVJFX01BUFBFUikgJiYgIVVT RShDT09SRElOQVRFRF9HUkFQSElDU19USFJFQURFRCkKKyNlbGlmIFVTRShURVhUVVJFX01BUFBF UikKIHZvaWQgR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlOjpwYWludFRvVGV4dHVyZU1hcHBlcihU ZXh0dXJlTWFwcGVyJiB0ZXh0dXJlTWFwcGVyLCBjb25zdCBGbG9hdFJlY3QmIHRhcmdldFJlY3Qs IGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cml4JiBtYXRyaXgsIGZsb2F0IG9wYWNpdHkpCiB7CiAg ICAgaWYgKCFtX2dsQ29udGV4dCkK