155915 2016-03-25 19:46:13 -0700 Web Inspector: Sometimes clearing focused nodes in ProfileView leaves a dangling call stack that can never be removed 2016-03-25 20:45:05 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1178218 0 joepeck 2016-03-25 19:46:13 -0700 * SUMMARY Sometimes clearing focused nodes in ProfileView leaves a dangling call stack that can never be removed. * STEPS TO REPRODUCE 1. Inspect <http://apple.com> 2. Show Timeline tab 3. Reload 4. Select JavaScript & Events Timeline 5. Show "Call Trees" ProfileView 6. Option-Click to expand a large call stack 7. Right Click and "Focus" a function in the middle of the call stack 8. Click the "X" to Clear all Focuses => the original focused call stack is handling now from the top level, at the bottom 1178219 1 274967 joepeck 2016-03-25 19:48:13 -0700 Created attachment 274967 [PATCH] Proposed Fix 1178220 2 webkit-bug-importer 2016-03-25 19:50:30 -0700 <rdar://problem/25371770> 1178228 3 274967 commit-queue 2016-03-25 20:45:02 -0700 Comment on attachment 274967 [PATCH] Proposed Fix Clearing flags on attachment: 274967 Committed r198707: <http://trac.webkit.org/changeset/198707> 1178229 4 commit-queue 2016-03-25 20:45:05 -0700 All reviewed patches have been landed. Closing bug. 274967 2016-03-25 19:48:13 -0700 2016-03-25 20:45:02 -0700 [PATCH] Proposed Fix ugly.patch text/plain 5592 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE5NjRmMjQuLjE5YjhjN2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTAzLTI1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU29tZXRp bWVzIGNsZWFyaW5nIGZvY3VzZWQgbm9kZXMgaW4gUHJvZmlsZVZpZXcgbGVhdmVzIGEgZGFuZ2xp bmcgY2FsbCBzdGFjayB0aGF0IGNhbiBuZXZlciBiZSByZW1vdmVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU5MTUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvUHJv ZmlsZURhdGFHcmlkVHJlZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlRGF0YUdy aWRUcmVlLnByb3RvdHlwZS5hZGRGb2N1c05vZGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBy b2ZpbGVEYXRhR3JpZFRyZWUucHJvdG90eXBlLnJvbGxiYWNrRm9jdXNOb2RlKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5Qcm9maWxlRGF0YUdyaWRUcmVlLnByb3RvdHlwZS5jbGVhckZvY3VzTm9k ZXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlByb2ZpbGVEYXRhR3JpZFRyZWUucHJvdG90eXBl Ll9mb2N1c0NoYW5nZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlByb2ZpbGVEYXRhR3JpZFRy ZWUucHJvdG90eXBlLl9zYXZlRm9jdXNlZE5vZGVPcmlnaW5hbFBhcmVudCk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuUHJvZmlsZURhdGFHcmlkVHJlZS5wcm90b3R5cGUuX3Jlc3RvcmVGb2N1c2Vk Tm9kZVRvT3JpZ2luYWxQYXJlbnQpOgorICAgICAgICBCZSBhIGxpdHRsZSBtb3JlIGV4cGxpY2l0 IGFib3V0IHNhdmluZyBhbmQgcmVzb3RyaW5nIG5vZGVzLgorICAgICAgICBXaGVuIHJlc3Rvcmlu Zywgd29yayBhcm91bmQgYSBEYXRhR3JpZCBpc3N1ZSBieSB0ZW1wb3JhcmlseQorICAgICAgICBj b2xsYXBzaW5nIGFuZCBleHBhbmRpbmcgdGhlIHBhcnQgb2YgdGhlIG5vZGUgd2UgYXJlIGJlaW5n CisgICAgICAgIHJlYXR0YWNoZWQgdG8uIFRoaXMgaXMgYSBjaGVhcCB3b3JrYXJvdW5kIGZvciBh biBvdGhlcndpc2UKKyAgICAgICAgY29tcGxleCBEYXRhR3JpZCAvIERhdGFHcmlkVHJlZSBpc3N1 ZS4KKwogMjAxNi0wMy0yNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE9wZW4gUmVzb3VyY2UgRGlhbG9nIHNob3VsZCBub3Qg c3lzdGVtIGJlZXAgd2hlbiB1c2luZyBFbnRlciB0byBzZWxlY3QgYW4gaXRlbQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUHJvZmlsZURhdGFH cmlkVHJlZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1By b2ZpbGVEYXRhR3JpZFRyZWUuanMKaW5kZXggMDAwYjhmYy4uNWFlZDBhNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUHJvZmlsZURhdGFHcmlk VHJlZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Q cm9maWxlRGF0YUdyaWRUcmVlLmpzCkBAIC0xNTQsNyArMTU0LDcgQEAgV2ViSW5zcGVjdG9yLlBy b2ZpbGVEYXRhR3JpZFRyZWUgPSBjbGFzcyBQcm9maWxlRGF0YUdyaWRUcmVlIGV4dGVuZHMgV2Vi SW5zcGVjdG8KICAgICAgICAgY29uc29sZS5hc3NlcnQocHJvZmlsZURhdGFHcmlkTm9kZSBpbnN0 YW5jZW9mIFdlYkluc3BlY3Rvci5Qcm9maWxlRGF0YUdyaWROb2RlKTsKIAogICAgICAgICAvLyBT YXZlIHRoZSBvcmlnaW5hbCBwYXJlbnQgZm9yIHdoZW4gd2Ugcm9sbGJhY2suCi0gICAgICAgIHBy b2ZpbGVEYXRhR3JpZE5vZGUuX19wcmV2aW91c1BhcmVudCA9IHByb2ZpbGVEYXRhR3JpZE5vZGUu cGFyZW50ID09PSBwcm9maWxlRGF0YUdyaWROb2RlLmRhdGFHcmlkID8gdGhpcyA6IHByb2ZpbGVE YXRhR3JpZE5vZGUucGFyZW50OworICAgICAgICB0aGlzLl9zYXZlRm9jdXNlZE5vZGVPcmlnaW5h bFBhcmVudChwcm9maWxlRGF0YUdyaWROb2RlKTsKIAogICAgICAgICB0aGlzLl9mb2N1c05vZGVz LnB1c2gocHJvZmlsZURhdGFHcmlkTm9kZSk7CiAgICAgICAgIHRoaXMuX2ZvY3VzQ2hhbmdlZCgp OwpAQCAtMTcwLDYgKzE3MCw4IEBAIFdlYkluc3BlY3Rvci5Qcm9maWxlRGF0YUdyaWRUcmVlID0g Y2xhc3MgUHJvZmlsZURhdGFHcmlkVHJlZSBleHRlbmRzIFdlYkluc3BlY3RvCiAgICAgICAgIGlm IChpbmRleCA9PT0gLTEpCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgdGhpcy5fZm9j dXNQYXJlbnRzVG9FeHBhbmQgPSBbXTsKKwogICAgICAgICBmb3IgKGxldCBpID0gaW5kZXggKyAx OyBpIDwgdGhpcy5fZm9jdXNOb2Rlcy5sZW5ndGg7ICsraSkKICAgICAgICAgICAgIHRoaXMuX3Jl c3RvcmVGb2N1c2VkTm9kZVRvT3JpZ2luYWxQYXJlbnQodGhpcy5fZm9jdXNOb2Rlc1tpXSk7CiAK QEAgLTE4MCw2ICsxODIsOCBAQCBXZWJJbnNwZWN0b3IuUHJvZmlsZURhdGFHcmlkVHJlZSA9IGNs YXNzIFByb2ZpbGVEYXRhR3JpZFRyZWUgZXh0ZW5kcyBXZWJJbnNwZWN0bwogCiAgICAgY2xlYXJG b2N1c05vZGVzKCkKICAgICB7CisgICAgICAgIHRoaXMuX2ZvY3VzUGFyZW50c1RvRXhwYW5kID0g W107CisKICAgICAgICAgZm9yIChsZXQgcHJvZmlsZURhdGFHcmlkTm9kZSBvZiB0aGlzLl9mb2N1 c05vZGVzKQogICAgICAgICAgICAgdGhpcy5fcmVzdG9yZUZvY3VzZWROb2RlVG9PcmlnaW5hbFBh cmVudChwcm9maWxlRGF0YUdyaWROb2RlKTsKIApAQCAtMjI3LDE3ICsyMzEsMTkgQEAgV2ViSW5z cGVjdG9yLlByb2ZpbGVEYXRhR3JpZFRyZWUgPSBjbGFzcyBQcm9maWxlRGF0YUdyaWRUcmVlIGV4 dGVuZHMgV2ViSW5zcGVjdG8KICAgICBfZm9jdXNDaGFuZ2VkKCkKICAgICB7CiAgICAgICAgIGxl dCBwcm9maWxlRGF0YUdyaWROb2RlID0gdGhpcy5jdXJyZW50Rm9jdXNOb2RlOwotICAgICAgICBp ZiAocHJvZmlsZURhdGFHcmlkTm9kZSkgeworICAgICAgICBpZiAocHJvZmlsZURhdGFHcmlkTm9k ZSkKICAgICAgICAgICAgIHRoaXMuX3VwZGF0ZUN1cnJlbnRGb2N1c0RldGFpbHMocHJvZmlsZURh dGFHcmlkTm9kZSk7CiAKLSAgICAgICAgICAgIGlmIChwcm9maWxlRGF0YUdyaWROb2RlLnBhcmVu dCkKLSAgICAgICAgICAgICAgICBwcm9maWxlRGF0YUdyaWROb2RlLnBhcmVudC5yZW1vdmVDaGls ZChwcm9maWxlRGF0YUdyaWROb2RlKTsKLSAgICAgICAgfQotCiAgICAgICAgIC8vIEZJWE1FOiBU aGlzIHJlLWNyZWF0ZXMgdG9wIGxldmVsIGNoaWxkcmVuLCB3aXRob3V0IHJlbWVtYmVyaW5nIHRo ZWlyIGV4cGFuZGVkIC8gdW5leHBhbmRlZCBzdGF0ZS4KICAgICAgICAgdGhpcy5fcmVwb3B1bGF0 ZSgpOwogCiAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rv ci5Qcm9maWxlRGF0YUdyaWRUcmVlLkV2ZW50LkZvY3VzQ2hhbmdlZCk7CisKKyAgICAgICAgaWYg KHRoaXMuX2ZvY3VzUGFyZW50c1RvRXhwYW5kKSB7CisgICAgICAgICAgICBmb3IgKGxldCBwcm9m aWxlRGF0YUdyaWROb2RlIG9mIHRoaXMuX2ZvY3VzUGFyZW50c1RvRXhwYW5kKQorICAgICAgICAg ICAgICAgIHByb2ZpbGVEYXRhR3JpZE5vZGUuZXhwYW5kKCk7CisgICAgICAgICAgICB0aGlzLl9m b2N1c1BhcmVudHNUb0V4cGFuZCA9IG51bGw7CisgICAgICAgIH0KICAgICB9CiAKICAgICBfdXBk YXRlQ3VycmVudEZvY3VzRGV0YWlscyhmb2N1c0RhdGFHcmlkTm9kZSkKQEAgLTI1MCw4ICsyNTYs MzEgQEAgV2ViSW5zcGVjdG9yLlByb2ZpbGVEYXRhR3JpZFRyZWUgPSBjbGFzcyBQcm9maWxlRGF0 YUdyaWRUcmVlIGV4dGVuZHMgV2ViSW5zcGVjdG8KICAgICAgICAgdGhpcy5fY3VycmVudEZvY3Vz TnVtYmVyT2ZTYW1wbGVzID0gdGltZXN0YW1wc0luUmFuZ2UubGVuZ3RoOwogICAgIH0KIAorICAg IF9zYXZlRm9jdXNlZE5vZGVPcmlnaW5hbFBhcmVudChmb2N1c0RhdGFHcmlkTm9kZSkKKyAgICB7 CisgICAgICAgIGZvY3VzRGF0YUdyaWROb2RlLl9fcHJldmlvdXNQYXJlbnQgPSBmb2N1c0RhdGFH cmlkTm9kZS5wYXJlbnQ7CisgICAgICAgIGZvY3VzRGF0YUdyaWROb2RlLl9fcHJldmlvdXNQYXJl bnQucmVtb3ZlQ2hpbGQoZm9jdXNEYXRhR3JpZE5vZGUpOworICAgIH0KKwogICAgIF9yZXN0b3Jl Rm9jdXNlZE5vZGVUb09yaWdpbmFsUGFyZW50KGZvY3VzRGF0YUdyaWROb2RlKQogICAgIHsKKyAg ICAgICAgLy8gTk9URTogQSBEYXRhR3JpZFRyZWUgbWFpbnRhaW5zIGEgbGlzdCBvZiBjaGlsZHJl biBidXQgdGhvc2UKKyAgICAgICAgLy8gY2hpbGRyZW4gZ2V0IGFkb3B0ZWQgYnkgdGhlIERhdGFH cmlkIGluIFByb2ZpbGVWaWV3IGFuZAorICAgICAgICAvLyBhY3R1YWxseSBkaXNwbGF5ZWQuIFdo ZW4gd2UgZm9jdXNlZCB0aGlzIERhdGFHcmlkTm9kZSwgaXRzCisgICAgICAgIC8vIHBhcmVudCB3 YXMgcmVtb3ZlZCBmcm9tIHRoZSByZWFsIERhdGFHcmlkLCBidXQgaWYgaXQgd2FzIG5vdAorICAg ICAgICAvLyBhdCB0aGUgdG9wIGxldmVsIGl0IHdhcyBub3QgZGV0YWNoZWQuIFdoZW4gd2UgcmUt YXBwZW5kCisgICAgICAgIC8vIG91cnNlbHZlcyBvbnRvIHRoZSBwcmV2aW91cyBwYXJlbnQsIGlm IGl0IHN0aWxsIHRoaW5rcyBpdCBpcworICAgICAgICAvLyBhdHRhY2hlZCBhbmQgZXhwYW5kZWQg aXQgd2lsbCBhdHRhY2ggdXMgaW1tZWRpYXRlbHksIHdoaWNoCisgICAgICAgIC8vIGNhbiBjcmVh dGUgYW4gb3JwaGFuZWQgPHRyPiBpbiB0aGUgRGF0YUdyaWQgdGhhdCBpcyBub3Qgb25lCisgICAg ICAgIC8vIG9mIHRoZSBEYXRhR3JpZCdzIGltbWVkaWF0ZSBjaGlsZHJlbi4KKyAgICAgICAgLy8K KyAgICAgICAgLy8gV29ya2Fyb3VuZCB0aGlzIGJ5OgorICAgICAgICAvLyAgIC0gY29sbGFwc2lu ZyBvdXIgcGFyZW50IHRvIHByZXZlbnQgYXR0YWNoaW5nIHdoZW4gd2UgZ2V0IGFkZGVkLgorICAg ICAgICAvLyAgIC0gcmVwYXJlbnQgdG8gb3VyIHByZXZpb3VzIHBhcmVudC4KKyAgICAgICAgLy8g ICAtIGV4cGFuZGluZyBvdXIgcGFyZW50IGFmdGVyIHRoZSBEYXRhR3JpZCBoYXMgaGFkIGEgY2hh bmNlIHRvIHVwZGF0ZS4KKyAgICAgICAgZm9jdXNEYXRhR3JpZE5vZGUuX19wcmV2aW91c1BhcmVu dC5jb2xsYXBzZSgpOworICAgICAgICB0aGlzLl9mb2N1c1BhcmVudHNUb0V4cGFuZC5wdXNoKGZv Y3VzRGF0YUdyaWROb2RlLl9fcHJldmlvdXNQYXJlbnQpOworCiAgICAgICAgIGZvY3VzRGF0YUdy aWROb2RlLl9fcHJldmlvdXNQYXJlbnQuYXBwZW5kQ2hpbGQoZm9jdXNEYXRhR3JpZE5vZGUpOwog ICAgICAgICBmb2N1c0RhdGFHcmlkTm9kZS5fX3ByZXZpb3VzUGFyZW50ID0gdW5kZWZpbmVkOwog ICAgIH0K