155903 2016-03-25 14:48:34 -0700 [JSC] fix divide-by-zero in String.prototype.padStart/padEnd 2016-03-25 16:04:08 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 caitp webkit-unassigned commit-queue darin fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1178110 0 caitp 2016-03-25 14:48:34 -0700 [JSC] fix divide-by-zero in String.prototype.padStart/padEnd 1178111 1 274941 caitp 2016-03-25 14:49:15 -0700 Created attachment 274941 Patch 1178114 2 274941 fpizlo 2016-03-25 14:50:54 -0700 Comment on attachment 274941 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274941&action=review > Source/JavaScriptCore/tests/es6.yaml:-580 > -- path: es6/String.prototype_methods_String.prototype.padEnd.js > - cmd: runES6 :normal > -- path: es6/String.prototype_methods_String.prototype.padStart.js > - cmd: runES6 :normal Why is this moved? 1178117 3 274941 caitp 2016-03-25 14:52:43 -0700 Comment on attachment 274941 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274941&action=review >> Source/JavaScriptCore/tests/es6.yaml:-580 >> - cmd: runES6 :normal > > Why is this moved? Wanted to move this down to be near TODO regarding tests for future ES spec revisions 1178123 4 fpizlo 2016-03-25 15:02:51 -0700 (In reply to comment #3) > Comment on attachment 274941 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274941&action=review > > >> Source/JavaScriptCore/tests/es6.yaml:-580 > >> - cmd: runES6 :normal > > > > Why is this moved? > > Wanted to move this down to be near TODO regarding tests for future ES spec > revisions Can you move this back? This is meant to be a quick fix to make tests pass, so we shouldn't be making unrelated changes in this same patch. 1178126 5 274944 caitp 2016-03-25 15:05:18 -0700 Created attachment 274944 Patch 1178158 6 274944 commit-queue 2016-03-25 16:04:03 -0700 Comment on attachment 274944 Patch Clearing flags on attachment: 274944 Committed r198695: <http://trac.webkit.org/changeset/198695> 1178159 7 commit-queue 2016-03-25 16:04:08 -0700 All reviewed patches have been landed. Closing bug. 274941 2016-03-25 14:49:15 -0700 2016-03-25 15:05:12 -0700 Patch bug-155903-20160325174917.patch text/plain 2718 caitp U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 MGEwYzJlMTkxMTcwYTA4M2EwZWI0NDkxMTg3ZWM4MWQyMWRkOGEzLi4zZDNlODY0ZTFkNGU1Zjg3 NDNjYzQzNDkxZmRkZmFiZmYxY2FmMWVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNi0wMy0yNSAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29t PgorCisgICAgICAgIFtKU0NdIGZpeCBkaXZpZGUtYnktemVybyBpbiBTdHJpbmcucHJvdG90eXBl LnBhZFN0YXJ0L3BhZEVuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU1OTAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OnBh ZFN0cmluZyk6CisgICAgICAgICogdGVzdHMvZXM2LnlhbWw6CisKIDIwMTYtMDMtMjUgIEJyaWFu IEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogcHJvdG9j b2wgZ2VuZXJhdG9yIHNob3VsZCBwcmVmaXggQysrIGZpbGVuYW1lcyB3aXRoIHRoZSBwcm90b2Nv bCBncm91cApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5n UHJvdG90eXBlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3Rv dHlwZS5jcHAKaW5kZXggMWRmYzk4MDIyZmIzNGJkMGQ0YTc0NTFlZWRkMDU5OTZmNmUzYTIxNy4u MTk1MGRhY2NjNDBjNGY4MmY1OGM1N2IzM2IzMGU2ZjhmMWJjZmUxMiAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCkBAIC05MDAsOCAr OTAwLDggQEAgc3RhdGljIEVuY29kZWRKU1ZhbHVlIHBhZFN0cmluZyhFeGVjU3RhdGUmIGV4ZWMs IFN0cmluZ1BhZGRpbmdMb2NhdGlvbiBwYWRkaW5nTG8KICAgICAgICAgICAgIHJldHVybiBKU1Zh bHVlOjplbmNvZGUodGhyb3dPdXRPZk1lbW9yeUVycm9yKCZleGVjKSk7CiAgICAgfQogCi0gICAg aWYgKCFmaWxsZXIgfHwgZmlsbGVyLT5sZW5ndGgoKSA9PSAxKSB7Ci0gICAgICAgIFVDaGFyIGNo YXJhY3RlciA9IGZpbGxlciA/IGZpbGxlci0+dmlldygmZXhlYylbMF0gOiAnICc7CisgICAgaWYg KCFmaWxsZXIgfHwgZmlsbGVyLT5sZW5ndGgoKSA8PSAxKSB7CisgICAgICAgIFVDaGFyIGNoYXJh Y3RlciA9IGZpbGxlciAmJiBmaWxsZXItPmxlbmd0aCgpID8gZmlsbGVyLT52aWV3KCZleGVjKVsw XSA6ICcgJzsKICAgICAgICAgaWYgKCEoY2hhcmFjdGVyICYgfjB4ZmYpKQogICAgICAgICAgICAg ZmlsbGVyID0gcmVwZWF0Q2hhcmFjdGVyKGV4ZWMsIHN0YXRpY19jYXN0PExDaGFyPihjaGFyYWN0 ZXIpLCBmaWxsTGVuZ3RoKTsKICAgICAgICAgZWxzZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rlc3RzL2VzNi55YW1sIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL2Vz Ni55YW1sCmluZGV4IDIxNDA1MDQzNzNmYTQzYWY3MDEyNzAyOGI0N2FmNzU5OWJhYTIwNGYuLjBh NmNlMzA0YjFlNWE1NGY4Y2EwZjI3ODZhMDQ1NzY1NmM4NWVjMTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9lczYueWFtbAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvdGVzdHMvZXM2LnlhbWwKQEAgLTU3NCwxMCArNTc0LDYgQEAKICAgY21kOiBydW5FUzYgOm5v cm1hbAogLSBwYXRoOiBlczYvU3RyaW5nLnByb3RvdHlwZV9tZXRob2RzX1N0cmluZy5wcm90b3R5 cGUubm9ybWFsaXplLmpzCiAgIGNtZDogcnVuRVM2IDpub3JtYWwKLS0gcGF0aDogZXM2L1N0cmlu Zy5wcm90b3R5cGVfbWV0aG9kc19TdHJpbmcucHJvdG90eXBlLnBhZEVuZC5qcwotICBjbWQ6IHJ1 bkVTNiA6bm9ybWFsCi0tIHBhdGg6IGVzNi9TdHJpbmcucHJvdG90eXBlX21ldGhvZHNfU3RyaW5n LnByb3RvdHlwZS5wYWRTdGFydC5qcwotICBjbWQ6IHJ1bkVTNiA6bm9ybWFsCiAtIHBhdGg6IGVz Ni9TdHJpbmcucHJvdG90eXBlX21ldGhvZHNfU3RyaW5nLnByb3RvdHlwZS5yZXBlYXQuanMKICAg Y21kOiBydW5FUzYgOm5vcm1hbAogLSBwYXRoOiBlczYvU3RyaW5nLnByb3RvdHlwZV9tZXRob2Rz X1N0cmluZy5wcm90b3R5cGUuc3RhcnRzV2l0aC5qcwpAQCAtMTIzNiwzICsxMjMyLDcgQEAKICAg Y21kOiBydW5FUzYgOm5vcm1hbAogLSBwYXRoOiBlczYvT2JqZWN0X3N0YXRpY19tZXRob2RzX09i amVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3JzLXByb3h5LmpzCiAgIGNtZDogcnVuRVM2IDpm YWlsCistIHBhdGg6IGVzNi9TdHJpbmcucHJvdG90eXBlX21ldGhvZHNfU3RyaW5nLnByb3RvdHlw ZS5wYWRFbmQuanMKKyAgY21kOiBydW5FUzYgOm5vcm1hbAorLSBwYXRoOiBlczYvU3RyaW5nLnBy b3RvdHlwZV9tZXRob2RzX1N0cmluZy5wcm90b3R5cGUucGFkU3RhcnQuanMKKyAgY21kOiBydW5F UzYgOm5vcm1hbApcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 274944 2016-03-25 15:05:18 -0700 2016-03-25 16:04:03 -0700 Patch bug-155903-20160325180520.patch text/plain 1601 caitp U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 MGEwYzJlMTkxMTcwYTA4M2EwZWI0NDkxMTg3ZWM4MWQyMWRkOGEzLi5hZTE2ZmYyZmIxOTQ0MDNj NzIwMjI5ZTJlZDcyMGFkNjY5ZWZmMGNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wMy0yNSAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29t PgorCisgICAgICAgIFtKU0NdIGZpeCBkaXZpZGUtYnktemVybyBpbiBTdHJpbmcucHJvdG90eXBl LnBhZFN0YXJ0L3BhZEVuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU1OTAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OnBh ZFN0cmluZyk6CisKIDIwMTYtMDMtMjUgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogcHJvdG9jb2wgZ2VuZXJhdG9yIHNob3VsZCBwcmVmaXgg QysrIGZpbGVuYW1lcyB3aXRoIHRoZSBwcm90b2NvbCBncm91cApkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAKaW5kZXggMWRmYzk4MDIyZmIz NGJkMGQ0YTc0NTFlZWRkMDU5OTZmNmUzYTIxNy4uMTk1MGRhY2NjNDBjNGY4MmY1OGM1N2IzM2Iz MGU2ZjhmMWJjZmUxMiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv U3RyaW5nUHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9T dHJpbmdQcm90b3R5cGUuY3BwCkBAIC05MDAsOCArOTAwLDggQEAgc3RhdGljIEVuY29kZWRKU1Zh bHVlIHBhZFN0cmluZyhFeGVjU3RhdGUmIGV4ZWMsIFN0cmluZ1BhZGRpbmdMb2NhdGlvbiBwYWRk aW5nTG8KICAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUodGhyb3dPdXRPZk1lbW9y eUVycm9yKCZleGVjKSk7CiAgICAgfQogCi0gICAgaWYgKCFmaWxsZXIgfHwgZmlsbGVyLT5sZW5n dGgoKSA9PSAxKSB7Ci0gICAgICAgIFVDaGFyIGNoYXJhY3RlciA9IGZpbGxlciA/IGZpbGxlci0+ dmlldygmZXhlYylbMF0gOiAnICc7CisgICAgaWYgKCFmaWxsZXIgfHwgZmlsbGVyLT5sZW5ndGgo KSA8PSAxKSB7CisgICAgICAgIFVDaGFyIGNoYXJhY3RlciA9IGZpbGxlciAmJiBmaWxsZXItPmxl bmd0aCgpID8gZmlsbGVyLT52aWV3KCZleGVjKVswXSA6ICcgJzsKICAgICAgICAgaWYgKCEoY2hh cmFjdGVyICYgfjB4ZmYpKQogICAgICAgICAgICAgZmlsbGVyID0gcmVwZWF0Q2hhcmFjdGVyKGV4 ZWMsIHN0YXRpY19jYXN0PExDaGFyPihjaGFyYWN0ZXIpLCBmaWxsTGVuZ3RoKTsKICAgICAgICAg ZWxzZQo=