155892 2016-03-25 10:36:28 -0700 Web Inspector: Clicking a result in Quick Open dialog dismisses the dialog, does nothing 2016-03-25 13:57:09 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1178008 0 mattbaker 2016-03-25 10:36:28 -0700 * SUMMARY Clicking a result in Quick Open dialog dismisses the dialog, does nothing. The expected behavior is for the dialog's represented object to be set, and for the dialog to be dismissed (same as selecting an item using up/down arrows and hitting Enter). 1178009 1 webkit-bug-importer 2016-03-25 10:36:49 -0700 <rdar://problem/25361220> 1178016 2 274919 mattbaker 2016-03-25 10:54:17 -0700 Created attachment 274919 [Patch] Proposed Fix 1178097 3 274919 commit-queue 2016-03-25 13:57:05 -0700 Comment on attachment 274919 [Patch] Proposed Fix Clearing flags on attachment: 274919 Committed r198690: <http://trac.webkit.org/changeset/198690> 1178098 4 commit-queue 2016-03-25 13:57:09 -0700 All reviewed patches have been landed. Closing bug. 274919 2016-03-25 10:54:17 -0700 2016-03-25 13:57:05 -0700 [Patch] Proposed Fix bug-155892-20160325105418.patch text/plain 3838 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw ODAzYjA3Mzg4ODdhNWJhYmRkOGMzZTcxZTg4ZTMzNjQ0YmZkZDliLi5iMmFjNzdlNmM2ZTA5MDM5 ZmU4Yjc5OGVhY2M3NTk3ZDYyOGU4ZmY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNyBAQAogMjAxNi0wMy0yNSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xpY2tpbmcgYSByZXN1bHQgaW4gUXVpY2sgT3Bl biBkaWFsb2cgZGlzbWlzc2VzIHRoZSBkaWFsb2csIGRvZXMgbm90aGluZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1ODkyCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yNTM2MTIyMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvT3BlblJlc291cmNlRGlhbG9nLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLk9wZW5SZXNvdXJjZURpYWxvZyk6CisgICAgICAgIEFs bG93IHJlcGVhdCBzZWxlY3Rpb24gc28gY2xpY2tpbmcgYSBzZWxlY3RlZCBlbGVtZW50IG1ha2Vz IGEgc2VsZWN0aW9uCisgICAgICAgIGFuZCBkaXNtaXNzZXMgdGhlIGRpYWxvZy4KKworICAgICAg ICAoV2ViSW5zcGVjdG9yLk9wZW5SZXNvdXJjZURpYWxvZy5wcm90b3R5cGUuX3BvcHVsYXRlUmVz b3VyY2VUcmVlT3V0bGluZSk6CisgICAgICAgIFN1cHByZXNzIHNlbGVjdCBhbmQgZGVzZWxlY3Qu IE9ubHkgdXNlciBjbGlja3Mgc2hvdWxkIGNhdXNlIGEgc2VsZWN0aW9uIGV2ZW50LgorCisgICAg ICAgIChXZWJJbnNwZWN0b3IuT3BlblJlc291cmNlRGlhbG9nLnByb3RvdHlwZS5faGFuZGxlQmx1 ckV2ZW50KToKKyAgICAgICAgUHJldmVudCB0aGUgZGlhbG9nIGZyb20gYmVpbmcgZGlzbWlzc2Vk IGJlZm9yZSB0cmVlIGl0ZW0gc2VsZWN0aW9uIG9jY3Vycy4KKworICAgICAgICAoV2ViSW5zcGVj dG9yLk9wZW5SZXNvdXJjZURpYWxvZy5wcm90b3R5cGUuX3RyZWVTZWxlY3Rpb25EaWRDaGFuZ2Up OgorICAgICAgICBTZXQgdGhlIHJlcHJlc2VudGVkIG9iamVjdCAoZGlhbG9nIHJlc3VsdCkgYW5k IGRpc21pc3MuCisKKzIwMTYtMDMtMjUgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29t PgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNjcm9sbGluZy9zZWxlY3Rpb24gaXMgYnJva2Vu IGluIFF1aWNrIE9wZW4gZGlhbG9nIHJlc291cmNlIHRyZWUKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTg3NwogICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMjUzNTYxNDk+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9PcGVuUmVzb3VyY2VEaWFsb2cuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9PcGVuUmVzb3VyY2VEaWFsb2cuanMKaW5kZXggOWE2ZDY5NzQ3 YTZlMzA2OTQ1NGEwNDRjOGIzNDY3YjM2N2ZmNWI4My4uZWFjZmZkZjdjMzcxYjMzNzhiNWFlMjZm ZWQ3ZTg1MjkwNjI1NjMwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvT3BlblJlc291cmNlRGlhbG9nLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09wZW5SZXNvdXJjZURpYWxvZy5qcwpAQCAtNDks OSArNDksMTEgQEAgV2ViSW5zcGVjdG9yLk9wZW5SZXNvdXJjZURpYWxvZyA9IGNsYXNzIE9wZW5S ZXNvdXJjZURpYWxvZyBleHRlbmRzIFdlYkluc3BlY3Rvci4KICAgICAgICAgdGhpcy5fY2xlYXJJ Y29uRWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX2hhbmRsZUNsaWNrRXZl bnQuYmluZCh0aGlzKSk7CiAKICAgICAgICAgdGhpcy5fdHJlZU91dGxpbmUgPSBuZXcgV2ViSW5z cGVjdG9yLlRyZWVPdXRsaW5lKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoIm9sIikpOworICAgICAg ICB0aGlzLl90cmVlT3V0bGluZS5hbGxvd3NSZXBlYXRTZWxlY3Rpb24gPSB0cnVlOwogICAgICAg ICB0aGlzLl90cmVlT3V0bGluZS5kaXNjbG9zdXJlQnV0dG9ucyA9IGZhbHNlOwogICAgICAgICB0 aGlzLl90cmVlT3V0bGluZS5sYXJnZSA9IHRydWU7CiAKKyAgICAgICAgdGhpcy5fdHJlZU91dGxp bmUuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuVHJlZU91dGxpbmUuRXZlbnQuU2VsZWN0 aW9uRGlkQ2hhbmdlLCB0aGlzLl90cmVlU2VsZWN0aW9uRGlkQ2hhbmdlLCB0aGlzKTsKICAgICAg ICAgdGhpcy5fdHJlZU91dGxpbmUuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJmb2N1cyIsICgp ID0+IHt0aGlzLl9pbnB1dEVsZW1lbnQuZm9jdXMoKTt9KTsKIAogICAgICAgICB0aGlzLmVsZW1l bnQuYXBwZW5kQ2hpbGQodGhpcy5fdHJlZU91dGxpbmUuZWxlbWVudCk7CkBAIC05MCw3ICs5Miw3 IEBAIFdlYkluc3BlY3Rvci5PcGVuUmVzb3VyY2VEaWFsb2cgPSBjbGFzcyBPcGVuUmVzb3VyY2VE aWFsb2cgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuCiAgICAgICAgIH0KIAogICAgICAgICBpZiAodGhp cy5fdHJlZU91dGxpbmUuY2hpbGRyZW4ubGVuZ3RoKQotICAgICAgICAgICAgdGhpcy5fdHJlZU91 dGxpbmUuY2hpbGRyZW5bMF0uc2VsZWN0KHRydWUpOworICAgICAgICAgICAgdGhpcy5fdHJlZU91 dGxpbmUuY2hpbGRyZW5bMF0uc2VsZWN0KHRydWUsIGZhbHNlLCB0cnVlLCB0cnVlKTsKICAgICB9 CiAKICAgICBkaWRQcmVzZW50RGlhbG9nKCkKQEAgLTE2MSw2ICsxNjMsMTAgQEAgV2ViSW5zcGVj dG9yLk9wZW5SZXNvdXJjZURpYWxvZyA9IGNsYXNzIE9wZW5SZXNvdXJjZURpYWxvZyBleHRlbmRz IFdlYkluc3BlY3Rvci4KIAogICAgIF9oYW5kbGVCbHVyRXZlbnQoZXZlbnQpCiAgICAgeworICAg ICAgICAvLyBQcmV2ZW50IHRoZSBkaWFsb2cgZnJvbSBiZWluZyBkaXNtaXNzZWQgd2hpbGUgaGFu ZGxpbmcgYSB0cmVlIGl0ZW0gY2xpY2sgZXZlbnQuCisgICAgICAgIGlmIChldmVudC5yZWxhdGVk VGFyZ2V0ID09PSB0aGlzLl90cmVlT3V0bGluZS5lbGVtZW50KQorICAgICAgICAgICAgcmV0dXJu OworCiAgICAgICAgIHRoaXMuZGlzbWlzcygpOwogICAgIH0KIApAQCAtMjIxLDYgKzIyNywxOCBA QCBXZWJJbnNwZWN0b3IuT3BlblJlc291cmNlRGlhbG9nID0gY2xhc3MgT3BlblJlc291cmNlRGlh bG9nIGV4dGVuZHMgV2ViSW5zcGVjdG9yLgogICAgICAgICBpZiAodGhpcy5fdHJlZU91dGxpbmUu Y2hpbGRyZW4ubGVuZ3RoKQogICAgICAgICAgICAgdGhpcy5fdHJlZU91dGxpbmUuaGlkZGVuID0g ZmFsc2U7CiAgICAgfQorCisgICAgX3RyZWVTZWxlY3Rpb25EaWRDaGFuZ2UoZXZlbnQpCisgICAg eworICAgICAgICBsZXQgdHJlZUVsZW1lbnQgPSBldmVudC5kYXRhLnNlbGVjdGVkRWxlbWVudDsK KyAgICAgICAgaWYgKCF0cmVlRWxlbWVudCkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAg ICBpZiAoIWV2ZW50LmRhdGEuc2VsZWN0ZWRCeVVzZXIpCisgICAgICAgICAgICByZXR1cm47CisK KyAgICAgICAgdGhpcy5kaXNtaXNzKHRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0KTsKKyAg ICB9CiB9OwogCiBXZWJJbnNwZWN0b3IuT3BlblJlc291cmNlRGlhbG9nLk5vbkVtcHR5Q2xhc3NO YW1lID0gIm5vbi1lbXB0eSI7Cg==