155889 2016-03-25 10:19:04 -0700 WebKit.xcworkspace "All Source" scheme always copies OS X WebKitSystemInterface libraries 2016-03-27 22:07:08 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build iPhone / iPad iOS 9.3 RESOLVED FIXED P2 Normal --- 1 dbates dbates ap ddkilzer hofione lforschler oldest_to_newest 1177998 0 dbates 2016-03-25 10:19:04 -0700 The WebKit.xcworkspace "All Source" scheme always copies the OS X WebKitSystemInterface libraries regardless of the selected base SDK. We should copy the SDK-specific WebKitSystemInterface libraries. 1177999 1 274915 dbates 2016-03-25 10:21:25 -0700 Created attachment 274915 Patch 1178018 2 274915 ap 2016-03-25 10:56:05 -0700 Comment on attachment 274915 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274915&action=review > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12 > + scriptText = "&quot;$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory&quot; --wksi --sdk $SDKROOT"> How does this work? I thought that --sdk took names like "iphonesimulator", not paths. 1178039 3 dbates 2016-03-25 11:40:06 -0700 (In reply to comment #2) > > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12 > > + scriptText = "&quot;$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory&quot; --wksi --sdk $SDKROOT"> > > How does this work? I thought that --sdk took names like "iphonesimulator", > not paths. --sdk can take a path, just like the command line option of the same name for xcrun. The code in webkitdirs.pm knows how to reason about an SDK given as a path. 1178049 4 dbates 2016-03-25 11:48:14 -0700 > > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12 > > + scriptText = "&quot;$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory&quot; --wksi --sdk $SDKROOT"> > Will add &quot;s around $SDKROOT before landing as it may contain space characters. 1178374 5 dbates 2016-03-27 22:07:08 -0700 Committed r198727: <http://trac.webkit.org/changeset/198727> 274915 2016-03-25 10:21:25 -0700 2016-03-25 11:45:49 -0700 Patch bug-155889-20160325102127.patch text/plain 2089 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NjY3CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu Z2VMb2cKaW5kZXggNTdlNjMwMDgxMjZmNmI1OTM0M2I5MjgwNWM5YjVhNjA5ZTAyMDAyNy4uYTcx OTQ5OWY1Njg5ZGMxY2Q3N2FiNzE3YzUzZDk4OGZjNWVmNWVjZCAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTAzLTI1ICBEYW5pZWwg QmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWJLaXQueGN3b3Jrc3BhY2Ug IkFsbCBTb3VyY2UiIHNjaGVtZSBhbHdheXMgY29waWVzIE9TIFggV2ViS2l0U3lzdGVtSW50ZXJm YWNlIGxpYnJhcmllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU1ODg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4ZXMgYW4gaXNzdWUgd2hlcmUgYnVpbGRpbmcgdGhlICJBbGwgU291cmNlIiBzY2hl bWUgaW4gV2ViS2l0Lnhjd29ya3NwYWNlIHdvdWxkCisgICAgICAgIGFsd2F5cyBjb3B5IHRoZSBP UyBYIFdlYktpdFN5c3RlbUludGVyZmFjZSBsaWJyYXJpZXMgcmVnYXJkbGVzcyBvZiB0aGUgc2Vs ZWN0ZWQKKyAgICAgICAgYmFzZSBTREsuIEluIHBhcnRpY3VsYXIsIGl0IHdvdWxkIGNvcHkgdGhl IE9TIFggV2ViS2l0U3lzdGVtSW50ZXJmYWNlIGxpYnJhcmllcworICAgICAgICB3aGVuIGJ1aWxk aW5nIHdpdGggU0RLIGlwaG9uZXNpbXVsYXRvci4gV2ViS2l0Lnhjd29ya3NwYWNlIHNob3VsZCBj b3B5IHRoZSBTREstCisgICAgICAgIHNwZWNpZmljIFdlYktpdFN5c3RlbUludGVyZmFjZSBsaWJy YXJpZXMuCisKKyAgICAgICAgKiBXZWJLaXQueGN3b3Jrc3BhY2UveGNzaGFyZWRkYXRhL3hjc2No ZW1lcy9BbGwgU291cmNlLnhjc2NoZW1lOgorCisyMDE2LTAzLTI1ICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KKwogICAgICAgICBSRUdSRVNTSU9OIChyMTk3MzU4KTogV2ViS2l0 U3lzdGVtSW50ZXJmYWNlLmggY29waWVkIGludG8gZGlyZWN0b3J5IG5hbWVkICItLWxsdm0iCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU4MzgKIApk aWZmIC0tZ2l0IGEvV2ViS2l0Lnhjd29ya3NwYWNlL3hjc2hhcmVkZGF0YS94Y3NjaGVtZXMvQWxs IFNvdXJjZS54Y3NjaGVtZSBiL1dlYktpdC54Y3dvcmtzcGFjZS94Y3NoYXJlZGRhdGEveGNzY2hl bWVzL0FsbCBTb3VyY2UueGNzY2hlbWUKaW5kZXggOTRjN2ZiNzJlZGI3ZGM5MjY2MzJiODIyZDMy YTI3NzBmZWUyYjVmZS4uZmFhMjQ0ZjJkMTQyNDViN2E4MGQ4ZGU2OGRhNjEzMWFlNjcwZTA5MCAx MDA2NDQKLS0tIGEvV2ViS2l0Lnhjd29ya3NwYWNlL3hjc2hhcmVkZGF0YS94Y3NjaGVtZXMvQWxs IFNvdXJjZS54Y3NjaGVtZQkKKysrIGIvV2ViS2l0Lnhjd29ya3NwYWNlL3hjc2hhcmVkZGF0YS94 Y3NjaGVtZXMvQWxsIFNvdXJjZS54Y3NjaGVtZQkKQEAgLTksNyArOSw3IEBACiAgICAgICAgICAg ICBBY3Rpb25UeXBlID0gIlhjb2RlLklERVN0YW5kYXJkRXhlY3V0aW9uQWN0aW9uc0NvcmUuRXhl Y3V0aW9uQWN0aW9uVHlwZS5TaGVsbFNjcmlwdEFjdGlvbiI+CiAgICAgICAgICAgICA8QWN0aW9u Q29udGVudAogICAgICAgICAgICAgICAgdGl0bGUgPSAiUnVuIFNjcmlwdCIKLSAgICAgICAgICAg ICAgIHNjcmlwdFRleHQgPSAiJnF1b3Q7JFNSQ1JPT1QvLi4vLi4vVG9vbHMvU2NyaXB0cy9jb3B5 LXdlYmtpdGxpYnJhcmllcy10by1wcm9kdWN0LWRpcmVjdG9yeSZxdW90OyAtLXdrc2kiPgorICAg ICAgICAgICAgICAgc2NyaXB0VGV4dCA9ICImcXVvdDskU1JDUk9PVC8uLi8uLi9Ub29scy9TY3Jp cHRzL2NvcHktd2Via2l0bGlicmFyaWVzLXRvLXByb2R1Y3QtZGlyZWN0b3J5JnF1b3Q7IC0td2tz aSAtLXNkayAkU0RLUk9PVCI+CiAgICAgICAgICAgICAgICA8RW52aXJvbm1lbnRCdWlsZGFibGU+ CiAgICAgICAgICAgICAgICAgICA8QnVpbGRhYmxlUmVmZXJlbmNlCiAgICAgICAgICAgICAgICAg ICAgICBCdWlsZGFibGVJZGVudGlmaWVyID0gInByaW1hcnkiCg==