155855 2016-03-24 15:06:41 -0700 Create private builtin helper advanceStringIndexUnicode() for use by RegExp builtins 2016-03-24 15:35:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue keith_miller mark.lam saam webkit-bug-importer oldest_to_newest 1177772 0 msaboff 2016-03-24 15:06:41 -0700 Currently there is a advanceStringIndexUnicode function declared within the RegExp.prototype.match builtin. This should be factored out as a private builtin for use by other RegExp builtins. 1177773 1 msaboff 2016-03-24 15:07:03 -0700 a 1177774 2 webkit-bug-importer 2016-03-24 15:07:53 -0700 <rdar://problem/25347456> 1177776 3 274857 msaboff 2016-03-24 15:18:28 -0700 Created attachment 274857 Patch 1177780 4 274857 mark.lam 2016-03-24 15:20:09 -0700 Comment on attachment 274857 Patch r=me 1177790 5 274857 commit-queue 2016-03-24 15:35:36 -0700 Comment on attachment 274857 Patch Clearing flags on attachment: 274857 Committed r198647: <http://trac.webkit.org/changeset/198647> 1177791 6 commit-queue 2016-03-24 15:35:41 -0700 All reviewed patches have been landed. Closing bug. 274857 2016-03-24 15:18:28 -0700 2016-03-24 15:35:36 -0700 Patch 155855.patch text/plain 4752 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk4NjQyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE2LTAzLTI0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENyZWF0ZSBwcml2YXRlIGJ1aWx0aW4gaGVscGVyIGFkdmFuY2VTdHJpbmdJbmRleFVuaWNv ZGUoKSBmb3IgdXNlIGJ5IFJlZ0V4cCBidWlsdGlucworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1ODU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZWQgYWR2YW5jZVN0cmluZ0luZGV4VW5pY29kZSgp IGFzIGEgc2VwYXJhdGUgaGVscGVyLiAgQWRkZWQgaXQgYXMgYSBwcml2YXRlIGJ1aWx0aW4KKyAg ICAgICAgdG8gdGhlIEdsb2JhbE9iamVjdCBsaWtlIG90aGVyIHByaXZhdGUgYnVpbHRpbnMuCisK KyAgICAgICAgKiBidWlsdGlucy9SZWdFeHBQcm90b3R5cGUuanM6CisgICAgICAgIChhZHZhbmNl U3RyaW5nSW5kZXhVbmljb2RlKToKKyAgICAgICAgKG1hdGNoKToKKyAgICAgICAgKG1hdGNoLmFk dmFuY2VTdHJpbmdJbmRleFVuaWNvZGUpOiBEZWxldGVkLgorICAgICAgICAqIHJ1bnRpbWUvSlNH bG9iYWxPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpKU0dsb2JhbE9iamVjdDo6aW5pdCk6CisK IDIwMTYtMDMtMjQgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAg ICAgW0VTNl0gQWRkIFByb3h5IGJhc2VkIHRlc3RzIGZvciBSZWdFeHAucHJvdG90eXBlW0BAbWF0 Y2hdCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvUmVnRXhwUHJvdG90eXBl LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9SZWdFeHBQ cm90b3R5cGUuanMJKHJldmlzaW9uIDE5ODYyNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9i dWlsdGlucy9SZWdFeHBQcm90b3R5cGUuanMJKHdvcmtpbmcgY29weSkKQEAgLTIzLDI1ICsyMywy OSBAQAogICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJ TElUWSBPRiBTVUNIIERBTUFHRS4gCiAgKi8KIAotZnVuY3Rpb24gbWF0Y2goc3RyKQorZnVuY3Rp b24gYWR2YW5jZVN0cmluZ0luZGV4VW5pY29kZShzdHJpbmcsIHN0cmluZ0xlbmd0aCwgaW5kZXgp CiB7CisgICAgLy8gVGhpcyBmdW5jdGlvbiBpbXBsZW1lbnRzIEFkdmFuY2VTdHJpbmdJbmRleCBk ZXNjcmliZWQgaW4gRVM2IDIxLjIuNS4yLjMsIHN0ZXBzIDYtMTEuCisgICAgLy8gSXQgYXNzdW1l cyB0aGF0ICJ1bmljb2RlIiBpcyB0cnVlIGZvciBpdHMgY2FsbGVycy4KICAgICAidXNlIHN0cmlj dCI7CiAKLSAgICBmdW5jdGlvbiBhZHZhbmNlU3RyaW5nSW5kZXhVbmljb2RlKHN0cmluZywgc3Ry aW5nTGVuZ3RoLCBpbmRleCkKLSAgICB7Ci0gICAgICAgIGlmIChpbmRleCArIDEgPj0gc3RyaW5n TGVuZ3RoKQotICAgICAgICAgICAgcmV0dXJuIGluZGV4ICsgMTsKLQotICAgICAgICBsZXQgZmly c3QgPSBzdHJpbmcuQGNoYXJDb2RlQXQoaW5kZXgpOwotICAgICAgICBpZiAoZmlyc3QgPCAweEQ4 MDAgfHwgZmlyc3QgPiAweERCRkYpCi0gICAgICAgICAgICByZXR1cm4gaW5kZXggKyAxOwotCi0g ICAgICAgIGxldCBzZWNvbmQgPSBzdHJpbmcuQGNoYXJDb2RlQXQoaW5kZXggKyAxKTsKLSAgICAg ICAgaWYgKHNlY29uZCA8IDB4REMwMCB8fCBzZWNvbmQgPiAweERGRkYpCi0gICAgICAgICAgICBy ZXR1cm4gaW5kZXggKyAxOworICAgIGlmIChpbmRleCArIDEgPj0gc3RyaW5nTGVuZ3RoKQorICAg ICAgICByZXR1cm4gaW5kZXggKyAxOwogCi0gICAgICAgIHJldHVybiBpbmRleCArIDI7Ci0gICAg fQorICAgIGxldCBmaXJzdCA9IHN0cmluZy5AY2hhckNvZGVBdChpbmRleCk7CisgICAgaWYgKGZp cnN0IDwgMHhEODAwIHx8IGZpcnN0ID4gMHhEQkZGKQorICAgICAgICByZXR1cm4gaW5kZXggKyAx OworCisgICAgbGV0IHNlY29uZCA9IHN0cmluZy5AY2hhckNvZGVBdChpbmRleCArIDEpOworICAg IGlmIChzZWNvbmQgPCAweERDMDAgfHwgc2Vjb25kID4gMHhERkZGKQorICAgICAgICByZXR1cm4g aW5kZXggKyAxOworCisgICAgcmV0dXJuIGluZGV4ICsgMjsKK30KKworZnVuY3Rpb24gbWF0Y2go c3RyKQoreworICAgICJ1c2Ugc3RyaWN0IjsKIAogICAgIGlmICghKHRoaXMgaW5zdGFuY2VvZiBA T2JqZWN0KSkKICAgICAgICAgdGhyb3cgbmV3IEBUeXBlRXJyb3IoIlJlZ0V4cC5wcm90b3R5cGUu QEBtYXRjaCByZXF1aXJlcyB0aGF0IHx0aGlzfCBiZSBhbiBPYmplY3QiKTsKQEAgLTc1LDcgKzc5 LDcgQEAgZnVuY3Rpb24gbWF0Y2goc3RyKQogCiAgICAgICAgICAgICBpZiAoIXJlc3VsdFN0cmlu Zy5sZW5ndGgpIHsKICAgICAgICAgICAgICAgICBpZiAodW5pY29kZSkKLSAgICAgICAgICAgICAg ICAgICAgcmVnZXhwLmxhc3RJbmRleCA9IGFkdmFuY2VTdHJpbmdJbmRleFVuaWNvZGUoc3RyaW5n QXJnLCBzdHJpbmdMZW5ndGgsIHJlZ2V4cC5sYXN0SW5kZXgpOworICAgICAgICAgICAgICAgICAg ICByZWdleHAubGFzdEluZGV4ID0gQGFkdmFuY2VTdHJpbmdJbmRleFVuaWNvZGUoc3RyaW5nQXJn LCBzdHJpbmdMZW5ndGgsIHJlZ2V4cC5sYXN0SW5kZXgpOwogICAgICAgICAgICAgICAgIGVsc2UK ICAgICAgICAgICAgICAgICAgICAgcmVnZXhwLmxhc3RJbmRleCsrOwogICAgICAgICAgICAgfQpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0 LmNwcAkocmV2aXNpb24gMTk4NjI2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNHbG9iYWxPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OTAsNiArNTkwLDcgQEAgcHV0 RGlyZWN0V2l0aG91dFRyYW5zaXRpb24odm0sIHZtLnByb3BlcgogICAgICAgICBHbG9iYWxQcm9w ZXJ0eUluZm8odm0ucHJvcGVydHlOYW1lcy0+YnVpbHRpbk5hbWVzKCkucHJvbWlzZVJlYWN0aW9u Sm9iUHJpdmF0ZU5hbWUoKSwgSlNGdW5jdGlvbjo6Y3JlYXRlQnVpbHRpbkZ1bmN0aW9uKHZtLCBw cm9taXNlT3BlcmF0aW9uc1Byb21pc2VSZWFjdGlvbkpvYkNvZGVHZW5lcmF0b3Iodm0pLCB0aGlz KSwgRG9udEVudW0gfCBEb250RGVsZXRlIHwgUmVhZE9ubHkpLAogICAgICAgICBHbG9iYWxQcm9w ZXJ0eUluZm8odm0ucHJvcGVydHlOYW1lcy0+YnVpbHRpbk5hbWVzKCkucHJvbWlzZVJlc29sdmVU aGVuYWJsZUpvYlByaXZhdGVOYW1lKCksIEpTRnVuY3Rpb246OmNyZWF0ZUJ1aWx0aW5GdW5jdGlv bih2bSwgcHJvbWlzZU9wZXJhdGlvbnNQcm9taXNlUmVzb2x2ZVRoZW5hYmxlSm9iQ29kZUdlbmVy YXRvcih2bSksIHRoaXMpLCBEb250RW51bSB8IERvbnREZWxldGUgfCBSZWFkT25seSksCiAgICAg ICAgIEdsb2JhbFByb3BlcnR5SW5mbyh2bS5wcm9wZXJ0eU5hbWVzLT5idWlsdGluTmFtZXMoKS5J bnNwZWN0b3JJbnN0cnVtZW50YXRpb25Qcml2YXRlTmFtZSgpLCBJbnNwZWN0b3JJbnN0cnVtZW50 YXRpb25PYmplY3Q6OmNyZWF0ZSh2bSwgdGhpcywgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uT2Jq ZWN0OjpjcmVhdGVTdHJ1Y3R1cmUodm0sIHRoaXMsIG1fb2JqZWN0UHJvdG90eXBlLmdldCgpKSks IERvbnRFbnVtIHwgRG9udERlbGV0ZSB8IFJlYWRPbmx5KSwKKyAgICAgICAgR2xvYmFsUHJvcGVy dHlJbmZvKHZtLnByb3BlcnR5TmFtZXMtPmJ1aWx0aW5OYW1lcygpLmFkdmFuY2VTdHJpbmdJbmRl eFVuaWNvZGVQcml2YXRlTmFtZSgpLCBKU0Z1bmN0aW9uOjpjcmVhdGVCdWlsdGluRnVuY3Rpb24o dm0sIHJlZ0V4cFByb3RvdHlwZUFkdmFuY2VTdHJpbmdJbmRleFVuaWNvZGVDb2RlR2VuZXJhdG9y KHZtKSwgdGhpcyksIERvbnRFbnVtIHwgRG9udERlbGV0ZSB8IFJlYWRPbmx5KSwKICAgICAgICAg R2xvYmFsUHJvcGVydHlJbmZvKHZtLnByb3BlcnR5TmFtZXMtPk1hcFByaXZhdGVOYW1lLCBtYXBD b25zdHJ1Y3RvciwgRG9udEVudW0gfCBEb250RGVsZXRlIHwgUmVhZE9ubHkpLAogICAgICAgICBH bG9iYWxQcm9wZXJ0eUluZm8odm0ucHJvcGVydHlOYW1lcy0+YnVpbHRpbk5hbWVzKCkuZ2VuZXJh dG9yUmVzdW1lUHJpdmF0ZU5hbWUoKSwgSlNGdW5jdGlvbjo6Y3JlYXRlQnVpbHRpbkZ1bmN0aW9u KHZtLCBnZW5lcmF0b3JQcm90b3R5cGVHZW5lcmF0b3JSZXN1bWVDb2RlR2VuZXJhdG9yKHZtKSwg dGhpcyksIERvbnRFbnVtIHwgRG9udERlbGV0ZSB8IFJlYWRPbmx5KSwKICAgICAgICAgR2xvYmFs UHJvcGVydHlJbmZvKHZtLnByb3BlcnR5TmFtZXMtPmJ1aWx0aW5OYW1lcygpLnRoaXNUaW1lVmFs dWVQcml2YXRlTmFtZSgpLCBwcml2YXRlRnVuY1RoaXNUaW1lVmFsdWUsIERvbnRFbnVtIHwgRG9u dERlbGV0ZSB8IFJlYWRPbmx5KSwK