155853 2016-03-24 13:51:03 -0700 Web Inspector: Open Resource Dialog should not system beep when using Enter to select an item 2016-03-24 15:18:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1177763 0 joepeck 2016-03-24 13:51:03 -0700 * SUMMARY Open Resource Dialog should not system beep when using Enter to select an item. * STEPS TO REPRODUCE 1. Inspect this page 2. Shift-Cmd-O to show Open Resource Dialog 3. Type "a" 4. Hit Enter to commit that result => Navigates to resource with an unexpected system beep 1177764 1 webkit-bug-importer 2016-03-24 13:51:27 -0700 <rdar://problem/25345574> 1177765 2 274853 joepeck 2016-03-24 13:51:49 -0700 Created attachment 274853 [PATCH] Proposed Fix 1177777 3 274853 commit-queue 2016-03-24 15:18:49 -0700 Comment on attachment 274853 [PATCH] Proposed Fix Clearing flags on attachment: 274853 Committed r198644: <http://trac.webkit.org/changeset/198644> 1177778 4 commit-queue 2016-03-24 15:18:53 -0700 All reviewed patches have been landed. Closing bug. 274853 2016-03-24 13:51:49 -0700 2016-03-24 15:18:49 -0700 [PATCH] Proposed Fix better.patch text/plain 1576 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg4YWE0YzIuLjE5NjRmMjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTAzLTI0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogT3BlbiBS ZXNvdXJjZSBEaWFsb2cgc2hvdWxkIG5vdCBzeXN0ZW0gYmVlcCB3aGVuIHVzaW5nIEVudGVyIHRv IHNlbGVjdCBhbiBpdGVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTU4NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvT3BlblJlc291cmNlRGlhbG9nLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLk9wZW5SZXNvdXJjZURpYWxvZy5wcm90b3R5cGUuX2hhbmRsZUtl eWRvd25FdmVudCk6CisgICAgICAgIFByZXZlbnQgZGVmYXVsdCB3aGVuIGhhbmRsaW5nIEVudGVy IHdpdGggYSBzZWxlY3RlZCByZXN1bHQuCisKKzIwMTYtMDMtMjQgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZWR1Y2UgZm9y Y2VkIGxheW91dHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1NTg1MgogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjUzNDUxOTc+CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PcGVuUmVzb3VyY2VE aWFsb2cuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PcGVu UmVzb3VyY2VEaWFsb2cuanMKaW5kZXggN2VlOTBlMi4uOWE2ZDY5NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3BlblJlc291cmNlRGlhbG9n LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09wZW5S ZXNvdXJjZURpYWxvZy5qcwpAQCAtMTMyLDYgKzEzMiw3IEBAIFdlYkluc3BlY3Rvci5PcGVuUmVz b3VyY2VEaWFsb2cgPSBjbGFzcyBPcGVuUmVzb3VyY2VEaWFsb2cgZXh0ZW5kcyBXZWJJbnNwZWN0 b3IuCiAgICAgICAgIH0gZWxzZSBpZiAoZXZlbnQua2V5Q29kZSA9PT0gV2ViSW5zcGVjdG9yLktl eWJvYXJkU2hvcnRjdXQuS2V5LkVudGVyLmtleUNvZGUpIHsKICAgICAgICAgICAgIGlmICh0aGlz Ll90cmVlT3V0bGluZS5zZWxlY3RlZFRyZWVFbGVtZW50KSB7CiAgICAgICAgICAgICAgICAgdGhp cy5kaXNtaXNzKHRoaXMuX3RyZWVPdXRsaW5lLnNlbGVjdGVkVHJlZUVsZW1lbnQucmVwcmVzZW50 ZWRPYmplY3QpOworICAgICAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAg ICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogCg==