155845 2016-03-24 11:33:01 -0700 Fix internal iOS9 performance regression after r197572 2016-03-24 12:57:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen barraclough benjamin cdumez cmarcelo commit-queue webkit-bug-importer oldest_to_newest 1177719 0 achristensen 2016-03-24 11:33:01 -0700 Fix internal iOS9 performance regression after r197572 1177721 1 274847 achristensen 2016-03-24 11:34:47 -0700 Created attachment 274847 Patch 1177722 2 cdumez 2016-03-24 11:37:38 -0700 rdar://problem/25144924 1177723 3 274847 cdumez 2016-03-24 11:38:27 -0700 Comment on attachment 274847 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274847&action=review > Source/WTF/wtf/Platform.h:554 > +#if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 90000 how about 9.x ? You likely want to use < iOS10 instead. 1177724 4 274847 cdumez 2016-03-24 11:39:53 -0700 Comment on attachment 274847 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274847&action=review >> Source/WTF/wtf/Platform.h:554 >> +#if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 90000 > > how about 9.x ? > > You likely want to use < iOS10 instead. Can this be just: if __IPHONE_OS_VERSION_MIN_REQUIRED < 100000 #define USE_CFNETWORK 1 #endif ? 1177725 5 cdumez 2016-03-24 11:41:51 -0700 (In reply to comment #4) > Comment on attachment 274847 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274847&action=review > > >> Source/WTF/wtf/Platform.h:554 > >> +#if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 90000 > > > > how about 9.x ? > > > > You likely want to use < iOS10 instead. > > Can this be just: > if __IPHONE_OS_VERSION_MIN_REQUIRED < 100000 > #define USE_CFNETWORK 1 > #endif > > ? Actually, previous we had USE(APPLE_INTERNAL_SDK) as condition so I guess we should use: if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED < 100000 #define USE_CFNETWORK 1 #endif 1177731 6 274848 achristensen 2016-03-24 11:43:38 -0700 Created attachment 274848 Patch 1177733 7 274848 cdumez 2016-03-24 11:49:59 -0700 Comment on attachment 274848 Patch r=me, thanks. 1177754 8 274848 cdumez 2016-03-24 12:56:57 -0700 Comment on attachment 274848 Patch Clearing flags on attachment: 274848 Committed r198641: <http://trac.webkit.org/changeset/198641> 1177755 9 cdumez 2016-03-24 12:57:02 -0700 All reviewed patches have been landed. Closing bug. 274847 2016-03-24 11:34:47 -0700 2016-03-24 11:43:34 -0700 Patch bug-155845-20160324113448.patch text/plain 1088 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxOTg2MzYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTAzLTI0ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGlPUzkgcGVyZm9ybWFuY2Ug cmVncmVzc2lvbiBhZnRlciByMTk3NTcyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTU4NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorICAgICAgICBVc2UgQ0ZVUkxDb25u ZWN0aW9uIGluc3RlYWQgb2YgTlNVUkxDb25uZWN0aW9uIG9uIGludGVybmFsIGlPUzkgYnVpbGRz LgorCiAyMDE2LTAzLTIzICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAg ICAgIFNtYWxsUHRyU2V0IGxlYWtzIG1lbW9yeSBpbiBpdHMgbW92ZSBhc3NpZ25tZW50IG9wZXJh dG9yIHdoZW4gIXRoaXMtPmlzU21hbGwoKQpJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm0u aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAxOTg2 MjkpCisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC01NTEs NiArNTUxLDEwIEBACiAKICNpZiBQTEFURk9STShJT1MpCiAKKyNpZiBVU0UoQVBQTEVfSU5URVJO QUxfU0RLKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA8PSA5MDAwMAorI2Rl ZmluZSBVU0VfQ0ZORVRXT1JLIDEKKyNlbmRpZgorCiAjZGVmaW5lIEhBVkVfTkVUV09SS19FWFRF TlNJT04gMQogI2RlZmluZSBIQVZFX1JFQURMSU5FIDEKICNkZWZpbmUgVVNFX1VJS0lUX0VESVRJ TkcgMQo= 274848 2016-03-24 11:43:38 -0700 2016-03-24 12:56:57 -0700 Patch bug-155845-20160324114340.patch text/plain 1123 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxOTg2MzYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAzLTI0ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGlPUzkgcGVyZm9ybWFuY2Ug cmVncmVzc2lvbiBhZnRlciByMTk3NTcyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTU4NDUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI1MTQ0OTI0 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3Rm L1BsYXRmb3JtLmg6CisgICAgICAgIFVzZSBDRlVSTENvbm5lY3Rpb24gaW5zdGVhZCBvZiBOU1VS TENvbm5lY3Rpb24gb24gaW50ZXJuYWwgaU9TOSBidWlsZHMuCisKIDIwMTYtMDMtMjMgIFNhYW0g QmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgU21hbGxQdHJTZXQgbGVha3Mg bWVtb3J5IGluIGl0cyBtb3ZlIGFzc2lnbm1lbnQgb3BlcmF0b3Igd2hlbiAhdGhpcy0+aXNTbWFs bCgpCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDE5ODYyOSkKKysrIFNvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTU1MSw2ICs1NTEsMTAgQEAKIAogI2lmIFBM QVRGT1JNKElPUykKIAorI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspICYmIF9fSVBIT05FX09T X1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgMTAwMDAwCisjZGVmaW5lIFVTRV9DRk5FVFdPUksgMQor I2VuZGlmCisKICNkZWZpbmUgSEFWRV9ORVRXT1JLX0VYVEVOU0lPTiAxCiAjZGVmaW5lIEhBVkVf UkVBRExJTkUgMQogI2RlZmluZSBVU0VfVUlLSVRfRURJVElORyAxCg==