15584 2007-10-20 18:58:39 -0700 REGRESSION(r26696): GtkLauncher segfaults on WebCore::WidthIterator::advance 2007-10-21 09:42:07 -0700 1 1 1 Unclassified WebKit Text 523.x (Safari 3) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 jmalonzo mrowe darin mrowe oldest_to_newest 58949 0 jmalonzo 2007-10-20 18:58:39 -0700 GtkLauncher crashes on WebCore::WidthIterator::advance with a segmentation fault. This happens on select sites like google.com, wikipedia, but it doesn't seem to crash on http://planet.gnome.org. Steps to reproduce: 1) Launch GtkLauncher with ./WebKitBuild/Debug/WebKitTools/GtkLauncher/GtkLauncher 2) Crash. 58950 1 16751 jmalonzo 2007-10-20 19:00:47 -0700 Created attachment 16751 segfault backtrace backtrace 58951 2 16752 mrowe 2007-10-20 19:04:14 -0700 Created attachment 16752 Reduction I don't see the crash on launch as described, but I can reproduce this when searching Google for "bdash". I've attached a reduction of the page that demonstrates the crash. It appears to be a single Unicode character that is causing the problem. 58953 3 mrowe 2007-10-20 19:15:07 -0700 This was introduced in http://trac.webkit.org/projects/webkit/changeset/26696. 58959 4 16755 mrowe 2007-10-20 19:45:05 -0700 Created attachment 16755 Patch 58960 5 16755 darin 2007-10-20 19:47:59 -0700 Comment on attachment 16755 Patch Good fix. But we really should structure this so we don't call glyphDataForCharacter twice; it can be an expensive operation. If references make this too tricky, you can use a const GlyphData*. 58961 6 16755 hyatt 2007-10-20 19:49:37 -0700 Comment on attachment 16755 Patch r=me, although darin should maybe look at this when he gets a chance. 58962 7 mrowe 2007-10-20 19:51:47 -0700 Landed in r26837. 58966 8 mrowe 2007-10-20 19:58:04 -0700 Darin, GlyphPage::glyphDataForCharacter is always an array lookup so I wouldn't consider it an expensive operation. I landed it after Dave reviewed it on IRC, but I can go ahead and make the change you suggested if you would like. 59009 9 darin 2007-10-21 09:42:07 -0700 (In reply to comment #8) > Darin, GlyphPage::glyphDataForCharacter is always an array lookup so I wouldn't > consider it an expensive operation. I landed it after Dave reviewed it on IRC, > but I can go ahead and make the change you suggested if you would like. OK. I can live with this the way it is, I guess. 16751 2007-10-20 19:00:47 -0700 2007-10-20 19:01:14 -0700 segfault backtrace gdb.txt text/plain 6220 jmalonzo IzAgIDB4Yjc3ZTc1NWYgaW4gV2ViQ29yZTo6V2lkdGhJdGVyYXRvcjo6YWR2YW5jZSAodGhpcz0w eGJmZmY4NWE0LCBvZmZzZXQ9MTAsIGdseXBoQnVmZmVyPTB4MCkgYXQgLi4vLi4vLi4vV2ViQ29y ZS9wbGF0Zm9ybS9Gb250LmNwcDoxNjIKIzEgIDB4Yjc3ZTdjM2YgaW4gV2ViQ29yZTo6Rm9udDo6 ZmxvYXRXaWR0aEZvclNpbXBsZVRleHQgKHRoaXM9MHg4MjYyNGYwLCBydW49QDB4YmZmZjg3Njgs IHN0eWxlPUAweGJmZmY4NzcwLCBnbHlwaEJ1ZmZlcj0weDApIGF0IC4uLy4uLy4uL1dlYkNvcmUv cGxhdGZvcm0vRm9udC5jcHA6NzA1CiMyICAweGI3N2U3YzkzIGluIFdlYkNvcmU6OkZvbnQ6OmZs b2F0V2lkdGggKHRoaXM9MHg4MjYyNGYwLCBydW49QDB4YmZmZjg3NjgsIHN0eWxlPUAweGJmZmY4 NzcwKSBhdCAuLi8uLi8uLi9XZWJDb3JlL3BsYXRmb3JtL0ZvbnQuY3BwOjY5OAojMyAgMHhiNzdl N2NlOSBpbiBXZWJDb3JlOjpGb250Ojp3aWR0aCAodGhpcz0weDgyNjI0ZjAsIHJ1bj1AMHhiZmZm ODc2OCwgc3R5bGU9QDB4YmZmZjg3NzApIGF0IC4uLy4uLy4uL1dlYkNvcmUvcGxhdGZvcm0vRm9u dC5jcHA6NTE4CiM0ICAweGI3N2E2Mzg5IGluIFdlYkNvcmU6OlJlbmRlclRleHQ6OmNhbGNQcmVm V2lkdGhzICh0aGlzPTB4ODI2MjdiNCwgbGVhZFdpZHRoPTApIGF0IC4uLy4uLy4uL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRleHQuY3BwOjQxNQojNSAgMHhiNzdhMWM2ZiBpbiBXZWJDb3JlOjpS ZW5kZXJUZXh0OjptYXhQcmVmV2lkdGggKHRoaXM9MHg4MjYyN2I0KSBhdCAuLi8uLi8uLi9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcDo1MTEKIzYgIDB4Yjc3YTJiN2QgaW4gV2ViQ29y ZTo6UmVuZGVyVGV4dDo6d2lkdGggKHRoaXM9MHg4MjYyN2I0LCBmcm9tPTAsIGxlbj0xMCwgZj1A MHg4MjYyNGYwLCB4UG9zPTE2KSBhdCAuLi8uLi8uLi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU ZXh0LmNwcDoxMDIxCiM3ICAweGI3NmZiNjFkIGluIFdlYkNvcmU6OlJlbmRlckJsb2NrOjpmaW5k TmV4dExpbmVCcmVhayAodGhpcz0weDgyNjFkMmMsIHN0YXJ0PUAweGJmZmY4YzQwLCBiaWRpPUAw eGJmZmY4YjljKSBhdCAuLi8uLi8uLi9XZWJDb3JlL3JlbmRlcmluZy9iaWRpLmNwcDoxNzU5CiM4 ICAweGI3NmZkNWQzIGluIFdlYkNvcmU6OlJlbmRlckJsb2NrOjpsYXlvdXRJbmxpbmVDaGlsZHJl biAodGhpcz0weDgyNjFkMmMsIHJlbGF5b3V0Q2hpbGRyZW49dHJ1ZSwgcmVwYWludFRvcD1AMHhi ZmZmOGQ2MCwgcmVwYWludEJvdHRvbT1AMHhiZmZmOGQ1YykgYXQgLi4vLi4vLi4vV2ViQ29yZS9y ZW5kZXJpbmcvYmlkaS5jcHA6OTcwCiM5ICAweGI3NzIxMTJhIGluIFdlYkNvcmU6OlJlbmRlckJs b2NrOjpsYXlvdXRCbG9jayAodGhpcz0weDgyNjFkMmMsIHJlbGF5b3V0Q2hpbGRyZW49dHJ1ZSkg YXQgLi4vLi4vLi4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOjU4MAojMTAgMHhi NzcxMDE1ZSBpbiBXZWJDb3JlOjpSZW5kZXJCbG9jazo6bGF5b3V0ICh0aGlzPTB4ODI2MWQyYykg YXQgLi4vLi4vLi4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOjQ5MQojMTEgMHhi NzZmZGU1NSBpbiBXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OmxheW91dElmTmVlZGVkICh0aGlzPTB4 ODI2MWQyYykgYXQgLi4vLi4vLi4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0Lmg6NDgz CiMxMiAweGI3NzIwNzFlIGluIFdlYkNvcmU6OlJlbmRlckJsb2NrOjpsYXlvdXRCbG9ja0NoaWxk cmVuICh0aGlzPTB4ODFmMmE0NCwgcmVsYXlvdXRDaGlsZHJlbj10cnVlKSBhdCAuLi8uLi8uLi9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6MTIxMQojMTMgMHhiNzcyMTE0MiBpbiBX ZWJDb3JlOjpSZW5kZXJCbG9jazo6bGF5b3V0QmxvY2sgKHRoaXM9MHg4MWYyYTQ0LCByZWxheW91 dENoaWxkcmVuPXRydWUpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcDo1ODIKIzE0IDB4Yjc3MTAxNWUgaW4gV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmxheW91dCAo dGhpcz0weDgxZjJhNDQpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcDo0OTEKIzE1IDB4Yjc2ZmRlNTUgaW4gV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpsYXlvdXRJ Zk5lZWRlZCAodGhpcz0weDgxZjJhNDQpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlck9iamVjdC5oOjQ4MwojMTYgMHhiNzcyMDcxZSBpbiBXZWJDb3JlOjpSZW5kZXJCbG9jazo6 bGF5b3V0QmxvY2tDaGlsZHJlbiAodGhpcz0weDgxZjI5NWMsIHJlbGF5b3V0Q2hpbGRyZW49dHJ1 ZSkgYXQgLi4vLi4vLi4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOjEyMTEKIzE3 IDB4Yjc3MjExNDIgaW4gV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmxheW91dEJsb2NrICh0aGlzPTB4 ODFmMjk1YywgcmVsYXlvdXRDaGlsZHJlbj10cnVlKSBhdCAuLi8uLi8uLi9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9jay5jcHA6NTgyCiMxOCAweGI3NzEwMTVlIGluIFdlYkNvcmU6OlJlbmRl ckJsb2NrOjpsYXlvdXQgKHRoaXM9MHg4MWYyOTVjKSBhdCAuLi8uLi8uLi9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9jay5jcHA6NDkxCiMxOSAweGI3NmZkZTU1IGluIFdlYkNvcmU6OlJlbmRl ck9iamVjdDo6bGF5b3V0SWZOZWVkZWQgKHRoaXM9MHg4MWYyOTVjKSBhdCAuLi8uLi8uLi9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaDo0ODMKIzIwIDB4Yjc3MjA3MWUgaW4gV2ViQ29y ZTo6UmVuZGVyQmxvY2s6OmxheW91dEJsb2NrQ2hpbGRyZW4gKHRoaXM9MHg4MWYyODc0LCByZWxh eW91dENoaWxkcmVuPXRydWUpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJs b2NrLmNwcDoxMjExCiMyMSAweGI3NzIxMTQyIGluIFdlYkNvcmU6OlJlbmRlckJsb2NrOjpsYXlv dXRCbG9jayAodGhpcz0weDgxZjI4NzQsIHJlbGF5b3V0Q2hpbGRyZW49dHJ1ZSkgYXQgLi4vLi4v Li4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOjU4MgojMjIgMHhiNzcxMDE1ZSBp biBXZWJDb3JlOjpSZW5kZXJCbG9jazo6bGF5b3V0ICh0aGlzPTB4ODFmMjg3NCkgYXQgLi4vLi4v Li4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOjQ5MQojMjMgMHhiNzZmZGU1NSBp biBXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OmxheW91dElmTmVlZGVkICh0aGlzPTB4ODFmMjg3NCkg YXQgLi4vLi4vLi4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0Lmg6NDgzCiMyNCAweGI3 NmZjZDgxIGluIFdlYkNvcmU6OlJlbmRlckJsb2NrOjpsYXlvdXRJbmxpbmVDaGlsZHJlbiAodGhp cz0weDgxZjE4ZDQsIHJlbGF5b3V0Q2hpbGRyZW49dHJ1ZSwgcmVwYWludFRvcD1AMHhiZmZmOTZm MCwgcmVwYWludEJvdHRvbT1AMHhiZmZmOTZlYykgYXQgLi4vLi4vLi4vV2ViQ29yZS9yZW5kZXJp bmcvYmlkaS5jcHA6ODc3CiMyNSAweGI3NzIxMTJhIGluIFdlYkNvcmU6OlJlbmRlckJsb2NrOjps YXlvdXRCbG9jayAodGhpcz0weDgxZjE4ZDQsIHJlbGF5b3V0Q2hpbGRyZW49dHJ1ZSkgYXQgLi4v Li4vLi4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOjU4MAojMjYgMHhiNzcxMDE1 ZSBpbiBXZWJDb3JlOjpSZW5kZXJCbG9jazo6bGF5b3V0ICh0aGlzPTB4ODFmMThkNCkgYXQgLi4v Li4vLi4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOjQ5MQojMjcgMHhiNzZmZGU1 NSBpbiBXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OmxheW91dElmTmVlZGVkICh0aGlzPTB4ODFmMThk NCkgYXQgLi4vLi4vLi4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0Lmg6NDgzCiMyOCAw eGI3NzIwNzFlIGluIFdlYkNvcmU6OlJlbmRlckJsb2NrOjpsYXlvdXRCbG9ja0NoaWxkcmVuICh0 aGlzPTB4ODFmMTY2YywgcmVsYXlvdXRDaGlsZHJlbj10cnVlKSBhdCAuLi8uLi8uLi9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6MTIxMQojMjkgMHhiNzcyMTE0MiBpbiBXZWJDb3Jl OjpSZW5kZXJCbG9jazo6bGF5b3V0QmxvY2sgKHRoaXM9MHg4MWYxNjZjLCByZWxheW91dENoaWxk cmVuPXRydWUpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDo1 ODIKIzMwIDB4Yjc3MTAxNWUgaW4gV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmxheW91dCAodGhpcz0w eDgxZjE2NmMpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDo0 OTEKIzMxIDB4Yjc2ZmRlNTUgaW4gV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpsYXlvdXRJZk5lZWRl ZCAodGhpcz0weDgxZjE2NmMpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9i amVjdC5oOjQ4MwojMzIgMHhiNzcyMDcxZSBpbiBXZWJDb3JlOjpSZW5kZXJCbG9jazo6bGF5b3V0 QmxvY2tDaGlsZHJlbiAodGhpcz0weDgxMWYyZmMsIHJlbGF5b3V0Q2hpbGRyZW49dHJ1ZSkgYXQg Li4vLi4vLi4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOjEyMTEKIzMzIDB4Yjc3 MjExNDIgaW4gV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmxheW91dEJsb2NrICh0aGlzPTB4ODExZjJm YywgcmVsYXlvdXRDaGlsZHJlbj10cnVlKSBhdCAuLi8uLi8uLi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHA6NTgyCiMzNCAweGI3NzEwMTVlIGluIFdlYkNvcmU6OlJlbmRlckJsb2Nr OjpsYXlvdXQgKHRoaXM9MHg4MTFmMmZjKSBhdCAuLi8uLi8uLi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHA6NDkxCiMzNSAweGI3NmZkZTU1IGluIFdlYkNvcmU6OlJlbmRlck9iamVj dDo6bGF5b3V0SWZOZWVkZWQgKHRoaXM9MHg4MTFmMmZjKSBhdCAuLi8uLi8uLi9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuaDo0ODMKIzM2IDB4Yjc3MjA3MWUgaW4gV2ViQ29yZTo6UmVu ZGVyQmxvY2s6OmxheW91dEJsb2NrQ2hpbGRyZW4gKHRoaXM9MHg4MGFlYjg0LCByZWxheW91dENo aWxkcmVuPXRydWUpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cDoxMjExCiMzNyAweGI3NzIxMTQyIGluIFdlYkNvcmU6OlJlbmRlckJsb2NrOjpsYXlvdXRCbG9j ayAodGhpcz0weDgwYWViODQsIHJlbGF5b3V0Q2hpbGRyZW49dHJ1ZSkgYXQgLi4vLi4vLi4vV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOjU4MgojMzggMHhiNzcxMDE1ZSBpbiBXZWJD b3JlOjpSZW5kZXJCbG9jazo6bGF5b3V0ICh0aGlzPTB4ODBhZWI4NCkgYXQgLi4vLi4vLi4vV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOjQ5MQojMzkgMHhiNzdhZGM3OSBpbiBXZWJD b3JlOjpSZW5kZXJWaWV3OjpsYXlvdXQgKHRoaXM9MHg4MGFlYjg0KSBhdCAuLi8uLi8uLi9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcDoxMTEKIzQwIDB4Yjc2OWIxYmIgaW4gV2ViQ29y ZTo6RnJhbWVWaWV3OjpsYXlvdXQgKHRoaXM9MHg4MDllNjAwLCBhbGxvd1N1YnRyZWU9dHJ1ZSkg YXQgLi4vLi4vLi4vV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHA6NDM0CiM0MSAweGI3NjliNzBi IGluIFdlYkNvcmU6OkZyYW1lVmlldzo6bGF5b3V0VGltZXJGaXJlZCAodGhpcz0weDgwOWU2MDAp IGF0IC4uLy4uLy4uL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwOjY4NAojNDIgMHhiNzY5Yzlh NyBpbiBXZWJDb3JlOjpUaW1lcjxXZWJDb3JlOjpGcmFtZVZpZXc+OjpmaXJlZCAodGhpcz0weDgw YTY0MTQpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcGxhdGZvcm0vVGltZXIuaDo5OAojNDMgMHhiNzZl ZjU3ZiBpbiBXZWJDb3JlOjpUaW1lckJhc2U6OmZpcmVUaW1lcnMgKGZpcmVUaW1lPTExOTI5MzE3 MzkuODM2MTU0LCBmaXJpbmdUaW1lcnM9QDB4YmZmZmEwMWMpIGF0IC4uLy4uLy4uL1dlYkNvcmUv cGxhdGZvcm0vVGltZXIuY3BwOjMzNgojNDQgMHhiNzZlZjYwYyBpbiBXZWJDb3JlOjpUaW1lckJh c2U6OnNoYXJlZFRpbWVyRmlyZWQgKCkgYXQgLi4vLi4vLi4vV2ViQ29yZS9wbGF0Zm9ybS9UaW1l ci5jcHA6MzU3CiM0NSAweGI3ODAwZDY2IGluIHRpbWVvdXRfY2IgKCkgYXQgLi4vLi4vLi4vV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvU2hhcmVkVGltZXJMaW51eC5jcHA6NDgKIzQ2IDB4YjYzMTU2MTEg aW4gPz8gKCkgZnJvbSAvdXNyL2xpYi9saWJnbGliLTIuMC5zby4wCiM0NyAweDAwMDAwMDAwIGlu ID8/ICgpCg== 16752 2007-10-20 19:04:14 -0700 2007-10-20 19:04:14 -0700 Reduction bug-15584-reduction.html text/html 114 mrowe PGh0bWw+CjxoZWFkPgo8bWV0YSBodHRwLWVxdWl2PWNvbnRlbnQtdHlwZSBjb250ZW50PSJ0ZXh0 L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPgo8L2hlYWQ+Cjxib2R5PgrvvZ4KPC9ib2R5Pgo8L2h0bWw+ 16755 2007-10-20 19:45:05 -0700 2007-10-20 19:49:37 -0700 Patch bug-15584-v1.patch text/plain 1646 mrowe ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDhhM2JkYS4uYzYyMmU4ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwNy0xMC0yMCAgTWFyayBSb3dlICA8 bXJvd2VAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU4 NAorICAgICAgICBCdWcgMTU1ODQ6IFJFR1JFU1NJT04ocjI2Njk2KTogR3RrTGF1bmNoZXIgc2Vn ZmF1bHRzIG9uIFdlYkNvcmU6OldpZHRoSXRlcmF0b3I6OmFkdmFuY2UKKworICAgICAgICAqIHBs YXRmb3JtL0ZvbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6Z2x5cGhEYXRhRm9yQ2hh cmFjdGVyKTogSWYgdGhlIGZhbGxiYWNrIHBhZ2UgZXhpc3RzIGJ1dCBkb2VzIG5vdCBoYXZlIGEK KyAgICAgICAgZ2x5cGggZm9yIHRoZSBjaGFyYWN0ZXIsIGZhbGwgYmFjayB0byB0aGUgbWlzc2lu ZyBnbHlwaCBkYXRhIHJhdGhlciB0aGFuIHJldHVybmluZyBhbgorICAgICAgICBpbnZhbGlkIEds eXBoRGF0YS4KKwogMjAwNy0xMC0yMCAgSmFzcGVyIEJyeWFudC1HcmVlbmUgIDxtQG5pLmFjLm56 PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vRm9udC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL0ZvbnQuY3BwCmluZGV4IGNkOGMzMGYu LjkwOTdlNmQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vRm9udC5jcHAKKysrIGIvV2Vi Q29yZS9wbGF0Zm9ybS9Gb250LmNwcApAQCAtNDYxLDcgKzQ2MSw3IEBAIGNvbnN0IEdseXBoRGF0 YSYgRm9udDo6Z2x5cGhEYXRhRm9yQ2hhcmFjdGVyKFVDaGFyMzIgYywgYm9vbCBtaXJyb3IpIGNv bnN0CiAgICAgaWYgKGNoYXJhY3RlckZvbnREYXRhKSB7CiAgICAgICAgIC8vIEdvdCB0aGUgZmFs bGJhY2sgZ2x5cGggYW5kIGZvbnQuCiAgICAgICAgIEdseXBoUGFnZSogZmFsbGJhY2tQYWdlID0g R2x5cGhQYWdlVHJlZU5vZGU6OmdldFJvb3RDaGlsZChjaGFyYWN0ZXJGb250RGF0YSwgcGFnZU51 bWJlciktPnBhZ2UoKTsKLSAgICAgICAgY29uc3QgR2x5cGhEYXRhJiBkYXRhID0gZmFsbGJhY2tQ YWdlID8gZmFsbGJhY2tQYWdlLT5nbHlwaERhdGFGb3JDaGFyYWN0ZXIoYykgOiBjaGFyYWN0ZXJG b250RGF0YS0+bWlzc2luZ0dseXBoRGF0YSgpOworICAgICAgICBjb25zdCBHbHlwaERhdGEmIGRh dGEgPSBmYWxsYmFja1BhZ2UgJiYgZmFsbGJhY2tQYWdlLT5nbHlwaERhdGFGb3JDaGFyYWN0ZXIo YykuZm9udERhdGEgPyBmYWxsYmFja1BhZ2UtPmdseXBoRGF0YUZvckNoYXJhY3RlcihjKSA6IGNo YXJhY3RlckZvbnREYXRhLT5taXNzaW5nR2x5cGhEYXRhKCk7CiAgICAgICAgIC8vIENhY2hlIGl0 IHNvIHdlIGRvbid0IGhhdmUgdG8gZG8gc3lzdGVtIGZhbGxiYWNrIGFnYWluIG5leHQgdGltZS4K ICAgICAgICAgaWYgKCF1c2VTbWFsbENhcHNGb250KQogICAgICAgICAgICAgcGFnZS0+c2V0R2x5 cGhEYXRhRm9yQ2hhcmFjdGVyKGMsIGRhdGEuZ2x5cGgsIGRhdGEuZm9udERhdGEpOwo=