155834 2016-03-23 22:22:21 -0700 Web Inspector: Timeline range selection changes with ProfileView should not cause navigation bar items to flicker 2016-03-23 23:32:33 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1177619 0 joepeck 2016-03-23 22:22:21 -0700 * SUMMARY Timeline range selection changes with ProfileView should not cause navigation bar items to flicker. * STEPS TO REPRODUCE 1. Open Inspector 2. Show Timeline tab 3. Enable Scripts & Events timeline 4. Start recording a timeline with JS 5. Stop recording 6. Select Script & Events timeline 7. Make lots of Timeline Range selections in Overview => Navigation bar buttons flicker 1177620 1 webkit-bug-importer 2016-03-23 22:22:56 -0700 <rdar://problem/25332282> 1177621 2 274819 joepeck 2016-03-23 22:23:23 -0700 Created attachment 274819 [PATCH] Proposed Fix 1177629 3 274819 timothy 2016-03-23 22:41:31 -0700 Comment on attachment 274819 [PATCH] Proposed Fix This is good, but we should not flicker even if the event is over zealous. Sounds a lot like bug 149258. 1177633 4 274819 commit-queue 2016-03-23 23:32:29 -0700 Comment on attachment 274819 [PATCH] Proposed Fix Clearing flags on attachment: 274819 Committed r198618: <http://trac.webkit.org/changeset/198618> 1177634 5 commit-queue 2016-03-23 23:32:33 -0700 All reviewed patches have been landed. Closing bug. 274819 2016-03-23 22:23:23 -0700 2016-03-23 23:32:29 -0700 [PATCH] Proposed Fix recreate.patch text/plain 2299 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkwNzFiZDAuLmY2OTk4MWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTAzLTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxp bmUgcmFuZ2Ugc2VsZWN0aW9uIGNoYW5nZXMgd2l0aCBQcm9maWxlVmlldyBzaG91bGQgbm90IGNh dXNlIG5hdmlnYXRpb24gYmFyIGl0ZW1zIHRvIGZsaWNrZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTgzNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Qcm9maWxl Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlVmlldy5wcm90b3R5cGUuX3Jl Y3JlYXRlKToKKyAgICAgICAgVGhlIG9ubHkgcmVhc29uIG91ciBzZWxlY3Rpb24gcGF0aCBjb21w b25lbnRzIHdvdWxkIGNoYW5nZSBpcyBpZiB3ZQorICAgICAgICBoYWQgZm9jdXMgbm9kZXMgYmVm b3JlIGFuZCBkbyBub3QgYW55bW9yZS4KKworMjAxNi0wMy0yMyAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE1pc2NlbGxhbmVv dXMgcGVyZm9ybWFuY2UgZml4ZXMgaW4gVGltZWxpbmUgcmVjb3JkaW5nCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU4MzIKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUHJvZmlsZVZpZXcuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Qcm9maWxlVmlldy5q cwppbmRleCBmMTI5NWFkLi5mNDA4OTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9Qcm9maWxlVmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Qcm9maWxlVmlldy5qcwpAQCAtMTI5LDEzICsx MjksMTYgQEAgV2ViSW5zcGVjdG9yLlByb2ZpbGVWaWV3ID0gY2xhc3MgUHJvZmlsZVZpZXcgZXh0 ZW5kcyBXZWJJbnNwZWN0b3IuQ29udGVudFZpZXcKIAogICAgIF9yZWNyZWF0ZSgpCiAgICAgewor ICAgICAgICBsZXQgaGFkRm9jdXNOb2RlcyA9IHRoaXMuaGFzRm9jdXNOb2RlcygpOworCiAgICAg ICAgIGxldCBzb3J0Q29tcGFyYXRvciA9IFdlYkluc3BlY3Rvci5Qcm9maWxlRGF0YUdyaWRUcmVl LmJ1aWxkU29ydENvbXBhcmF0b3IodGhpcy5fZGF0YUdyaWQuc29ydENvbHVtbklkZW50aWZpZXIs IHRoaXMuX2RhdGFHcmlkLnNvcnRPcmRlcik7CiAgICAgICAgIHRoaXMuX3Byb2ZpbGVEYXRhR3Jp ZFRyZWUgPSBuZXcgV2ViSW5zcGVjdG9yLlByb2ZpbGVEYXRhR3JpZFRyZWUodGhpcy5fY2FsbGlu Z0NvbnRleHRUcmVlLCB0aGlzLl9zdGFydFRpbWUsIHRoaXMuX2VuZFRpbWUsIHNvcnRDb21wYXJh dG9yKTsKICAgICAgICAgdGhpcy5fcHJvZmlsZURhdGFHcmlkVHJlZS5hZGRFdmVudExpc3RlbmVy KFdlYkluc3BlY3Rvci5Qcm9maWxlRGF0YUdyaWRUcmVlLkV2ZW50LkZvY3VzQ2hhbmdlZCwgdGhp cy5fZGF0YUdyaWRUcmVlRm9jdXNDaGFuZ2VkLCB0aGlzKTsKICAgICAgICAgdGhpcy5fcHJvZmls ZURhdGFHcmlkVHJlZS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5Qcm9maWxlRGF0YUdy aWRUcmVlLkV2ZW50Lk1vZGlmaWVyc0NoYW5nZWQsIHRoaXMuX2RhdGFHcmlkVHJlZU1vZGlmaWVy c0NoYW5nZWQsIHRoaXMpOwogICAgICAgICB0aGlzLl9yZXBvcHVsYXRlRGF0YUdyaWRGcm9tVHJl ZSgpOwogCi0gICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rv ci5Db250ZW50Vmlldy5FdmVudC5TZWxlY3Rpb25QYXRoQ29tcG9uZW50c0RpZENoYW5nZSk7Cisg ICAgICAgIGlmIChoYWRGb2N1c05vZGVzKQorICAgICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50 VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkNvbnRlbnRWaWV3LkV2ZW50LlNlbGVjdGlvblBhdGhD b21wb25lbnRzRGlkQ2hhbmdlKTsKICAgICB9CiAKICAgICBfcmVwb3B1bGF0ZURhdGFHcmlkRnJv bVRyZWUoc2tpcFJlZnJlc2gpCg==