155829 2016-03-23 21:22:20 -0700 [ES6] Greedy unicode RegExp's don't properly backtrack past non BMP characters 2016-03-24 07:19:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 155807 1 msaboff msaboff commit-queue keith_miller mark.lam saam webkit-bug-importer oldest_to_newest 1177597 0 msaboff 2016-03-23 21:22:20 -0700 I found this while working on <https://bugs.webkit.org/show_bug.cgi?id=155807> 1177613 1 274817 msaboff 2016-03-23 22:15:17 -0700 Created attachment 274817 Patch 1177614 2 webkit-bug-importer 2016-03-23 22:15:44 -0700 <rdar://problem/25332220> 1177624 3 274817 saam 2016-03-23 22:32:20 -0700 Comment on attachment 274817 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274817&action=review > Source/JavaScriptCore/runtime/RegExpObject.cpp:194 > + size_t stringLength = s.length(); Nit: length is unsigned not size_t 1177664 4 msaboff 2016-03-24 07:19:37 -0700 Committed r198624: <http://trac.webkit.org/changeset/198624> 274817 2016-03-23 22:15:17 -0700 2016-03-23 22:32:20 -0700 Patch 155829.patch text/plain 7425 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk4NjE1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE2LTAzLTIzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFtFUzZdIEdyZWVkeSB1bmljb2RlIFJlZ0V4cCdzIGRvbid0IHByb3Blcmx5IGJhY2t0cmFj ayBwYXN0IG5vbiBCTVAgY2hhcmFjdGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU1ODI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2hlbiB3ZSBiYWNrdXAgd2hlbiBtYXRjaGluZyBwYXJ0IG9mIGEg dW5pY29kZSBwYXR0ZXJuLCB3ZSBjYW4ndCBqdXN0IGJhY2t1cCBvbmUgY2hhcmFjdGVyLgorICAg ICAgICBJbnN0ZWFkIHdlIG5lZWQgdG8gc2F2ZSBvdXIgc3RhcnQgcG9zaXRpb24gYmVmb3JlIHRy eWluZyB0byBtYXRjaCBhIGNoYXJhY3RlciBhbmQKKyAgICAgICAgcmVzdG9yZSB0aGUgcG9zaXRp b24gaWYgdGhlIG1hdGNoIGZhaWxzLiAgVGhpcyB3YXMgZG9uZSBpbiBvdGhlciBwbGFjZXMsIGJ1 dCB3YXNuJ3QKKyAgICAgICAgZG9uZSBmb3IgYWxsIGdyZWVkeSB0eXBlcy4KKworICAgICAgICBG aXhlZCBtYXRjaEdsb2JhbCgpIHRvIHByb3Blcmx5IGhhbmRsZSBhZHZhbmNpbmcgcGFzdCBub24g Qk1QIGNoYXJhY3RlcnMuCisKKyAgICAgICAgKiBydW50aW1lL1JlZ0V4cE9iamVjdC5jcHA6Cisg ICAgICAgIChKU0M6OlJlZ0V4cE9iamVjdDo6bWF0Y2hHbG9iYWwpOgorICAgICAgICAqIHJ1bnRp bWUvUmVnRXhwT2JqZWN0SW5saW5lcy5oOgorICAgICAgICAoSlNDOjpSZWdFeHBPYmplY3Q6OmFk dmFuY2VTdHJpbmdVbmljb2RlKToKKyAgICAgICAgKiB5YXJyL1lhcnJJbnRlcnByZXRlci5jcHA6 CisgICAgICAgIChKU0M6OllhcnI6OkludGVycHJldGVyOjptYXRjaENoYXJhY3RlckNsYXNzKToK KyAgICAgICAgKEpTQzo6WWFycjo6SW50ZXJwcmV0ZXI6Om1hdGNoRGlzanVuY3Rpb24pOgorCiAy MDE2LTAzLTIzICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTk4NTgyLgpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmplY3QuY3BwCShyZXZpc2lvbiAxOTg2MDkp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmplY3QuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xOTEsNiArMTkxLDcgQEAgSlNWYWx1ZSBSZWdFeHBPYmplY3Q6Om1hdGNo R2xvYmFsKEV4ZWNTdAogICAgIGNvbnN0IHNpemVfdCBtYXhpbXVtUmVhc29uYWJsZU1hdGNoU2l6 ZSA9IDEwMDAwMDAwMDA7CiAKICAgICBpZiAocmVnRXhwLT51bmljb2RlKCkpIHsKKyAgICAgICAg c2l6ZV90IHN0cmluZ0xlbmd0aCA9IHMubGVuZ3RoKCk7CiAgICAgICAgIHdoaWxlIChyZXN1bHQp IHsKICAgICAgICAgICAgIGlmIChsaXN0LnNpemUoKSA+IG1heGltdW1SZWFzb25hYmxlTWF0Y2hT aXplKSB7CiAgICAgICAgICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMpOwpAQCAt MjAxLDcgKzIwMiw3IEBAIEpTVmFsdWUgUmVnRXhwT2JqZWN0OjptYXRjaEdsb2JhbChFeGVjU3QK ICAgICAgICAgICAgIHNpemVfdCBsZW5ndGggPSBlbmQgLSByZXN1bHQuc3RhcnQ7CiAgICAgICAg ICAgICBsaXN0LmFwcGVuZChqc1N1YnN0cmluZyhleGVjLCBzLCByZXN1bHQuc3RhcnQsIGxlbmd0 aCkpOwogICAgICAgICAgICAgaWYgKCFsZW5ndGgpCi0gICAgICAgICAgICAgICAgZW5kID0gYWR2 YW5jZVN0cmluZ1VuaWNvZGUocywgbGVuZ3RoLCBlbmQpOworICAgICAgICAgICAgICAgIGVuZCA9 IGFkdmFuY2VTdHJpbmdVbmljb2RlKHMsIHN0cmluZ0xlbmd0aCwgZW5kKTsKICAgICAgICAgICAg IHJlc3VsdCA9IHJlZ0V4cENvbnN0cnVjdG9yLT5wZXJmb3JtTWF0Y2goKnZtLCByZWdFeHAsIHN0 cmluZywgcywgZW5kKTsKICAgICAgICAgfQogICAgIH0gZWxzZSB7CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmplY3RJbmxpbmVzLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwT2JqZWN0SW5saW5lcy5oCShyZXZp c2lvbiAxOTg2MDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmpl Y3RJbmxpbmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTExNyw3ICsxMTcsNyBAQCB1bnNpZ25lZCBS ZWdFeHBPYmplY3Q6OmFkdmFuY2VTdHJpbmdVbmljCiAgICAgaWYgKGZpcnN0IDwgMHhEODAwIHx8 IGZpcnN0ID4gMHhEQkZGKQogICAgICAgICByZXR1cm4gY3VycmVudEluZGV4ICsgMTsKIAotICAg IFVDaGFyIHNlY29uZCA9IHNbY3VycmVudEluZGV4XTsKKyAgICBVQ2hhciBzZWNvbmQgPSBzW2N1 cnJlbnRJbmRleCArIDFdOwogICAgIGlmIChzZWNvbmQgPCAweERDMDAgfHwgc2Vjb25kID4gMHhE RkZGKQogICAgICAgICByZXR1cm4gY3VycmVudEluZGV4ICsgMTsKIApJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL3lhcnIvWWFyckludGVycHJldGVyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJySW50ZXJwcmV0ZXIuY3BwCShyZXZpc2lvbiAxOTg2 MDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJySW50ZXJwcmV0ZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC01MDcsMTQgKzUwNywxNiBAQCBwdWJsaWM6CiAgICAgICAgIH0KIAog ICAgICAgICBjYXNlIFF1YW50aWZpZXJHcmVlZHk6IHsKLSAgICAgICAgICAgIGJhY2tUcmFjay0+ YmVnaW4gPSBpbnB1dC5nZXRQb3MoKTsKKyAgICAgICAgICAgIHVuc2lnbmVkIHBvc2l0aW9uID0g aW5wdXQuZ2V0UG9zKCk7CisgICAgICAgICAgICBiYWNrVHJhY2stPmJlZ2luID0gcG9zaXRpb247 CiAgICAgICAgICAgICB1bnNpZ25lZCBtYXRjaEFtb3VudCA9IDA7CiAgICAgICAgICAgICB3aGls ZSAoKG1hdGNoQW1vdW50IDwgdGVybS5hdG9tLnF1YW50aXR5Q291bnQpICYmIGlucHV0LmNoZWNr SW5wdXQoMSkpIHsKICAgICAgICAgICAgICAgICBpZiAoIWNoZWNrQ2hhcmFjdGVyQ2xhc3ModGVy bS5hdG9tLmNoYXJhY3RlckNsYXNzLCB0ZXJtLmludmVydCgpLCB0ZXJtLmlucHV0UG9zaXRpb24g KyAxKSkgewotICAgICAgICAgICAgICAgICAgICBpbnB1dC51bmNoZWNrSW5wdXQoMSk7CisgICAg ICAgICAgICAgICAgICAgIGlucHV0LnNldFBvcyhwb3NpdGlvbik7CiAgICAgICAgICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICArK21hdGNoQW1v dW50OworICAgICAgICAgICAgICAgIHBvc2l0aW9uID0gaW5wdXQuZ2V0UG9zKCk7CiAgICAgICAg ICAgICB9CiAgICAgICAgICAgICBiYWNrVHJhY2stPm1hdGNoQW1vdW50ID0gbWF0Y2hBbW91bnQ7 CiAKQEAgLTEyNDIsMTIgKzEyNDQsMTQgQEAgcHVibGljOgogICAgICAgICBjYXNlIEJ5dGVUZXJt OjpUeXBlUGF0dGVybkNoYXJhY3RlckdyZWVkeTogewogICAgICAgICAgICAgQmFja1RyYWNrSW5m b1BhdHRlcm5DaGFyYWN0ZXIqIGJhY2tUcmFjayA9IHJlaW50ZXJwcmV0X2Nhc3Q8QmFja1RyYWNr SW5mb1BhdHRlcm5DaGFyYWN0ZXIqPihjb250ZXh0LT5mcmFtZSArIGN1cnJlbnRUZXJtKCkuZnJh bWVMb2NhdGlvbik7CiAgICAgICAgICAgICB1bnNpZ25lZCBtYXRjaEFtb3VudCA9IDA7CisgICAg ICAgICAgICB1bnNpZ25lZCBwb3NpdGlvbiA9IGlucHV0LmdldFBvcygpOyAvLyBNYXkgbmVlZCB0 byBiYWNrIG91dCByZWFkaW5nIGEgc3Vycm9nYXRlIHBhaXIuCiAgICAgICAgICAgICB3aGlsZSAo KG1hdGNoQW1vdW50IDwgY3VycmVudFRlcm0oKS5hdG9tLnF1YW50aXR5Q291bnQpICYmIGlucHV0 LmNoZWNrSW5wdXQoMSkpIHsKICAgICAgICAgICAgICAgICBpZiAoIWNoZWNrQ2hhcmFjdGVyKGN1 cnJlbnRUZXJtKCkuYXRvbS5wYXR0ZXJuQ2hhcmFjdGVyLCBjdXJyZW50VGVybSgpLmlucHV0UG9z aXRpb24gKyAxKSkgewotICAgICAgICAgICAgICAgICAgICBpbnB1dC51bmNoZWNrSW5wdXQoMSk7 CisgICAgICAgICAgICAgICAgICAgIGlucHV0LnNldFBvcyhwb3NpdGlvbik7CiAgICAgICAgICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICArK21h dGNoQW1vdW50OworICAgICAgICAgICAgICAgIHBvc2l0aW9uID0gaW5wdXQuZ2V0UG9zKCk7CiAg ICAgICAgICAgICB9CiAgICAgICAgICAgICBiYWNrVHJhY2stPm1hdGNoQW1vdW50ID0gbWF0Y2hB bW91bnQ7CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODYwOSkKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAzLTIzICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFtFUzZdIEdyZWVkeSB1bmlj b2RlIFJlZ0V4cCdzIGRvbid0IHByb3Blcmx5IGJhY2t0cmFjayBwYXN0IG5vbiBCTVAgY2hhcmFj dGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1 ODI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk ZWQgbmV3IHRlc3QgY2FzZXMuCisKKyAgICAgICAgKiBqcy9yZWdleHAtdW5pY29kZS1leHBlY3Rl ZC50eHQ6CisgICAgICAgICoganMvc2NyaXB0LXRlc3RzL3JlZ2V4cC11bmljb2RlLmpzOgorCiAy MDE2LTAzLTIzICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTk4NTM4LgpJbmRleDogTGF5b3V0VGVzdHMv anMvcmVnZXhwLXVuaWNvZGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2pzL3JlZ2V4cC11bmljb2RlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTk4NjA5KQorKysgTGF5 b3V0VGVzdHMvanMvcmVnZXhwLXVuaWNvZGUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBA IC03Nyw2ICs3NywxMSBAQCBQQVNTICJh8JCQqPCQkKjwkJCoYyIubWF0Y2goL2FjfGHwkJCAKmNk CiBQQVNTICJhYvCQkKjwkJCo8JCQqGPwkKiBIi5tYXRjaCgvYWJjfGFi8JCQgCpjZHxhYvCQkIAr Y/CQqIFkfGFi8JCQgCtj8JCogS9pdSlbMF0gaXMgImFi8JCQqPCQkKjwkJCoY/CQqIEiCiBQQVNT ICJhYvCQkKjwkJCo8JCQqCIubWF0Y2goL2FiY3xhYvCQkKgqLi91KVswXSBpcyAiYWLwkJCo8JCQ qPCQkKgiCiBQQVNTICJhYvCQkKjwkJCo8JCQqCIubWF0Y2goL2FiY3xhYvCQkIAqLi9pdSlbMF0g aXMgImFi8JCQqPCQkKjwkJCoIgorUEFTUyAi8JCQgCIubWF0Y2goL2EqL3UpWzBdLmxlbmd0aCBp cyAwCitQQVNTICLwkJCAIi5tYXRjaCgvYSovdWkpWzBdLmxlbmd0aCBpcyAwCitQQVNTICLwkJCA Ii5tYXRjaCgvXGQqL3UpWzBdLmxlbmd0aCBpcyAwCitQQVNTICIxMjPwkJCAIi5tYXRjaCgvXGQq L3UpWzBdIGlzICIxMjMiCitQQVNTICIxMlgz8JCQgDQiLm1hdGNoKC9cZHswLDF9L3VnKSBpcyBb IjEiLCAiMiIsICIiLCAiMyIsICIiLCAiNCIsICIiXQogUEFTUyBtYXRjaDNbMF0gaXMgImHwkJCQ 8JCQkGIiCiBQQVNTIG1hdGNoM1sxXSBpcyB1bmRlZmluZWQuCiBQQVNTIG1hdGNoM1syXSBpcyAi YfCQkJDwkJCQYiIKSW5kZXg6IExheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9yZWdleHAtdW5p Y29kZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvcmVnZXhw LXVuaWNvZGUuanMJKHJldmlzaW9uIDE5ODYwOSkKKysrIExheW91dFRlc3RzL2pzL3NjcmlwdC10 ZXN0cy9yZWdleHAtdW5pY29kZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMTEzLDYgKzExMywxMSBA QCBzaG91bGRCZSgnImFcdXsxMDQyOH1cdXsxMDQyOH1cdXsxMDQyOH1jCiBzaG91bGRCZSgnImFi XHV7MTA0Mjh9XHV7MTA0Mjh9XHV7MTA0Mjh9Y1x1ezEwYTAxfSIubWF0Y2goL2FiY3xhYlx1ezEw NDAwfSpjZHxhYlx1ezEwNDAwfStjXHV7MTBhMDF9ZHxhYlx1ezEwNDAwfStjXHV7MTBhMDF9L2l1 KVswXScsICciYWJcdXsxMDQyOH1cdXsxMDQyOH1cdXsxMDQyOH1jXHV7MTBhMDF9IicpOwogc2hv dWxkQmUoJyJhYlx1ezEwNDI4fVx1ezEwNDI4fVx1ezEwNDI4fSIubWF0Y2goL2FiY3xhYlx1ezEw NDI4fSouL3UpWzBdJywgJyJhYlx1ezEwNDI4fVx1ezEwNDI4fVx1ezEwNDI4fSInKTsKIHNob3Vs ZEJlKCciYWJcdXsxMDQyOH1cdXsxMDQyOH1cdXsxMDQyOH0iLm1hdGNoKC9hYmN8YWJcdXsxMDQw MH0qLi9pdSlbMF0nLCAnImFiXHV7MTA0Mjh9XHV7MTA0Mjh9XHV7MTA0Mjh9IicpOworc2hvdWxk QmUoJyJcdXsxMDQwMH0iLm1hdGNoKC9hKi91KVswXS5sZW5ndGgnLCAnMCcpOworc2hvdWxkQmUo JyJcdXsxMDQwMH0iLm1hdGNoKC9hKi91aSlbMF0ubGVuZ3RoJywgJzAnKTsKK3Nob3VsZEJlKCci XHV7MTA0MDB9Ii5tYXRjaCgvXFxkKi91KVswXS5sZW5ndGgnLCAnMCcpOworc2hvdWxkQmUoJyIx MjNcdXsxMDQwMH0iLm1hdGNoKC9cXGQqL3UpWzBdJywgJyIxMjMiJyk7CitzaG91bGRCZSgnIjEy WDNcdXsxMDQwMH00Ii5tYXRjaCgvXFxkezAsMX0vdWcpJywgJ1siMSIsICIyIiwgIiIsICIzIiwg IiIsICI0IiwgIiJdJyk7CiAKIHZhciByZTMgPSBuZXcgUmVnRXhwKCIoYVx1ezEwNDEwfSpiYyl8 KGFcdXsxMDQxMH0qYikiLCAidSIpOwogdmFyIG1hdGNoMyA9ICJhXHV7MTA0MTB9XHV7MTA0MTB9 YiIubWF0Y2gocmUzKTsK