155827 2016-03-23 19:55:39 -0700 webkit-patch failed to open pretty diff on Windows 2016-03-24 10:10:58 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Windows 10 RESOLVED FIXED P2 Normal --- 1 mbbill webkit-unassigned achristensen commit-queue glenn lforschler ossy oldest_to_newest 1177588 0 mbbill 2016-03-23 19:55:39 -0700 file://%s % urllib.quote(pretty_diff_file.name) will not produce correct file url on windows. Should pathname2url instead. 1177589 1 274813 mbbill 2016-03-23 19:57:00 -0700 Created attachment 274813 Patch 1177615 2 274813 commit-queue 2016-03-23 22:16:58 -0700 Comment on attachment 274813 Patch Clearing flags on attachment: 274813 Committed r198617: <http://trac.webkit.org/changeset/198617> 1177616 3 commit-queue 2016-03-23 22:17:01 -0700 All reviewed patches have been landed. Closing bug. 1177635 4 ossy 2016-03-23 23:35:58 -0700 (In reply to comment #2) > Comment on attachment 274813 [details] > Patch > > Clearing flags on attachment: 274813 > > Committed r198617: <http://trac.webkit.org/changeset/198617> It broke 7 webkitpy tests. 1177636 5 mbbill 2016-03-23 23:37:51 -0700 I'll have a look 1177640 6 mbbill 2016-03-24 00:21:57 -0700 Reopening to attach new patch. 1177641 7 274824 mbbill 2016-03-24 00:22:02 -0700 Created attachment 274824 Patch 1177642 8 mbbill 2016-03-24 00:23:50 -0700 All 1452 tests passed 1177643 9 mbbill 2016-03-24 00:25:16 -0700 As the previous patch has already landed, shall I create a new patch for the test case fix? 1177694 10 274824 achristensen 2016-03-24 10:02:55 -0700 Comment on attachment 274824 Patch Usually if something breaks tests, we revert it immediately and land a new patch that doesn't break any tests. In this case, I just landed your fix in http://trac.webkit.org/changeset/198628 274813 2016-03-23 19:57:00 -0700 2016-03-24 00:21:46 -0700 Patch bug-155827-20160324105700.patch text/plain 1649 mbbill U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NjEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmExZGI4ZDhlMjQ3NjRhYTkxYmI3N2UxMjg2ODQ3MjVj OTg1MjFiMC4uZjlmZWZhZmExYWI3ODllYzE1NDJhNjNhOTVkZmZjNzAzMTMxYmM5MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTAzLTIzICBCaWxsIE1pbmcgIDxtYmJpbGxAZ21haWwuY29tPgorCisgICAgICAg IHdlYmtpdC1wYXRjaCBmYWlsZWQgdG8gb3BlbiBwcmV0dHkgZGlmZiBvbiBXaW5kb3dzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU4MjcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zdGVwcy9jb25maXJtZGlmZi5weToKKyAgICAgICAgKENvbmZpcm1EaWZmLl9z aG93X3ByZXR0eV9kaWZmKToKKwogMjAxNi0wMy0yMyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFw cGxlLmNvbT4KIAogICAgICAgICBbaW9zLXNpbV0gUmVxdWlyZXNVc2VyQWN0aW9uRm9yUGxheWJh Y2tUZXN0LkRvZXNOb3RSZXF1aXJlVXNlckFjdGlvbkZvck1lZGlhUGxheWJhY2sgYW5kIFJlcXVp cmVzVXNlckFjdGlvbkZvclZpZGVvQnV0Tm90QXVkaW9QbGF5YmFjayBmYWlsaW5nCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29uZmlybWRpZmYucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29uZmlybWRpZmYucHkKaW5kZXggODZj OGEyYzhkMmE4YmIxN2ZhNWRiZjhiMTcxOGI4YWE0MzBkYTJlMi4uNGYyODNhZmY4MzEyNDVjNjFk ZDY4ZDdlN2NhODA3MDNkMDU3NjA4MiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL3N0ZXBzL2NvbmZpcm1kaWZmLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9zdGVwcy9jb25maXJtZGlmZi5weQpAQCAtNTMsNyArNTMsNyBAQCBjbGFzcyBDb25maXJt RGlmZihBYnN0cmFjdFN0ZXApOgogICAgICAgICAgICAgcHJldHR5X3BhdGNoID0gUHJldHR5UGF0 Y2goc2VsZi5fdG9vbC5leGVjdXRpdmUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBzZWxmLl90b29sLnNjbSgpLmNoZWNrb3V0X3Jvb3QpCiAgICAgICAgICAgICBwcmV0 dHlfZGlmZl9maWxlID0gcHJldHR5X3BhdGNoLnByZXR0eV9kaWZmX2ZpbGUoZGlmZikKLSAgICAg ICAgICAgIHVybCA9ICJmaWxlOi8vJXMiICUgdXJsbGliLnF1b3RlKHByZXR0eV9kaWZmX2ZpbGUu bmFtZSkKKyAgICAgICAgICAgIHVybCA9ICJmaWxlOiVzIiAlIHVybGxpYi5wYXRobmFtZTJ1cmwo cHJldHR5X2RpZmZfZmlsZS5uYW1lKQogICAgICAgICAgICAgc2VsZi5fdG9vbC51c2VyLm9wZW5f dXJsKHVybCkKICAgICAgICAgICAgICMgV2UgcmV0dXJuIHRoZSBwcmV0dHlfZGlmZl9maWxlIGhl cmUgYmVjYXVzZSB3ZSBuZWVkIHRvIGtlZXAgdGhlCiAgICAgICAgICAgICAjIGZpbGUgYWxpdmUg dW50aWwgdGhlIHVzZXIgaGFzIGhhZCBhIGNoYW5jZSB0byBjb25maXJtIHRoZSBkaWZmLgo= 274824 2016-03-24 00:22:02 -0700 2016-03-24 10:02:55 -0700 Patch bug-155827-20160324152203.patch text/plain 1653 mbbill U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NjE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmExZGI4ZDhlMjQ3NjRhYTkxYmI3N2UxMjg2ODQ3MjVj OTg1MjFiMC4uMzNjNGQwMWI5ZWNhMTJiMGE3OWQxY2RmNjA4ZWVhMzg2NzFlYWE2NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTAzLTIzICBCaWxsIE1pbmcgIDxtYmJpbGxAZ21haWwuY29tPgorCisgICAgICAg IHdlYmtpdC1wYXRjaCBmYWlsZWQgdG8gb3BlbiBwcmV0dHkgZGlmZiBvbiBXaW5kb3dzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU4MjcKKworICAg ICAgICBSZXZpZXdlZCBieSBBbGV4IENocmlzdGVuc2VuLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS90b29sL3N0ZXBzL2NvbmZpcm1kaWZmLnB5OgorICAgICAgICAoQ29uZmlybURpZmYu X3Nob3dfcHJldHR5X2RpZmYpOgorCiAyMDE2LTAzLTIzICBKZXIgTm9ibGUgIDxqZXIubm9ibGVA YXBwbGUuY29tPgogCiAgICAgICAgIFtpb3Mtc2ltXSBSZXF1aXJlc1VzZXJBY3Rpb25Gb3JQbGF5 YmFja1Rlc3QuRG9lc05vdFJlcXVpcmVVc2VyQWN0aW9uRm9yTWVkaWFQbGF5YmFjayBhbmQgUmVx dWlyZXNVc2VyQWN0aW9uRm9yVmlkZW9CdXROb3RBdWRpb1BsYXliYWNrIGZhaWxpbmcKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb25maXJtZGlmZi5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb25maXJtZGlmZi5weQppbmRleCA4 NmM4YTJjOGQyYThiYjE3ZmE1ZGJmOGIxNzE4YjhhYTQzMGRhMmUyLi5hNDk1YzBkMmFlZGYzM2Zl OGM1YWYzZDNmMGY2MDQ5N2RiNTcxMDM2IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvc3RlcHMvY29uZmlybWRpZmYucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL3N0ZXBzL2NvbmZpcm1kaWZmLnB5CkBAIC01Myw3ICs1Myw3IEBAIGNsYXNzIENvbmZp cm1EaWZmKEFic3RyYWN0U3RlcCk6CiAgICAgICAgICAgICBwcmV0dHlfcGF0Y2ggPSBQcmV0dHlQ YXRjaChzZWxmLl90b29sLmV4ZWN1dGl2ZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHNlbGYuX3Rvb2wuc2NtKCkuY2hlY2tvdXRfcm9vdCkKICAgICAgICAgICAgIHBy ZXR0eV9kaWZmX2ZpbGUgPSBwcmV0dHlfcGF0Y2gucHJldHR5X2RpZmZfZmlsZShkaWZmKQotICAg ICAgICAgICAgdXJsID0gImZpbGU6Ly8lcyIgJSB1cmxsaWIucXVvdGUocHJldHR5X2RpZmZfZmls ZS5uYW1lKQorICAgICAgICAgICAgdXJsID0gImZpbGU6Ly8lcyIgJSB1cmxsaWIucGF0aG5hbWUy dXJsKHByZXR0eV9kaWZmX2ZpbGUubmFtZSkKICAgICAgICAgICAgIHNlbGYuX3Rvb2wudXNlci5v cGVuX3VybCh1cmwpCiAgICAgICAgICAgICAjIFdlIHJldHVybiB0aGUgcHJldHR5X2RpZmZfZmls ZSBoZXJlIGJlY2F1c2Ugd2UgbmVlZCB0byBrZWVwIHRoZQogICAgICAgICAgICAgIyBmaWxlIGFs aXZlIHVudGlsIHRoZSB1c2VyIGhhcyBoYWQgYSBjaGFuY2UgdG8gY29uZmlybSB0aGUgZGlmZi4K