155815 2016-03-23 15:50:00 -0700 Web Inspector: Allow clicking the Timeline in Editing Mode to toggle the checkbox 2016-03-23 16:47:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1177515 0 joepeck 2016-03-23 15:50:00 -0700 * SUMMARY Allow clicking the Timeline in Editing Mode to toggle the checkbox. This is a much more natural feeling then clicking on the very small checkbox. 1177516 1 webkit-bug-importer 2016-03-23 15:50:31 -0700 <rdar://problem/25326237> 1177517 2 274787 joepeck 2016-03-23 15:52:01 -0700 Created attachment 274787 [PATCH] Proposed Fix 1177532 3 274787 commit-queue 2016-03-23 16:47:39 -0700 Comment on attachment 274787 [PATCH] Proposed Fix Clearing flags on attachment: 274787 Committed r198605: <http://trac.webkit.org/changeset/198605> 1177533 4 commit-queue 2016-03-23 16:47:42 -0700 All reviewed patches have been landed. Closing bug. 274787 2016-03-23 15:52:01 -0700 2016-03-23 16:47:39 -0700 [PATCH] Proposed Fix easier-toggle.patch text/plain 2777 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkyNWIzMWYuLmFlYTFkMTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE2LTAzLTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWxsb3cg Y2xpY2tpbmcgdGhlIFRpbWVsaW5lIGluIEVkaXRpbmcgTW9kZSB0byB0b2dnbGUgdGhlIGNoZWNr Ym94CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU4 MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5UaW1lbGluZU92ZXJ2aWV3LnByb3RvdHlwZS5fc3RhcnRFZGl0aW5nSW5zdHJ1bWVudHMp OgorICAgICAgICBSZW1vdmUgdW51c2VkIHZhcmlhYmxlLgorICAgICAgICAKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuVGltZWxpbmVUcmVlRWxlbWVudC5wcm90b3R5cGUub25hdHRhY2gpOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lVHJlZUVsZW1lbnQucHJvdG90eXBlLl9jbGlja0hhbmRs ZXIpOgorICAgICAgICBNYWtlIGNsaWNraW5nIG9uIHRoZSB0cmVlIGVsZW1lbnQgdG9nZ2xlIHRo ZSBjaGVja2JveC4KKworMjAxNi0wMy0yMyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRpbWVsaW5lIFRhYiBzb21ldGltZXMg cmVzdG9yZXMgYXMgYmxhbmsKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1NTgxMQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qcwppbmRleCAyNWY5YzI3 Li4zMmRhMjcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanMKQEAgLTg2NCw3ICs4NjQsNiBA QCBXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlldyA9IGNsYXNzIFRpbWVsaW5lT3ZlcnZpZXcg ZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogCiAgICAgICAgIGZvciAobGV0IHR5cGUgb2YgdGhp cy5faW5zdHJ1bWVudFR5cGVzKSB7CiAgICAgICAgICAgICBsZXQgdHJlZUVsZW1lbnQgPSB0aGlz Ll90cmVlRWxlbWVudHNCeVR5cGVNYXAuZ2V0KHR5cGUpOwotICAgICAgICAgICAgbGV0IGNoZWNr ZWQgPSAhIXRyZWVFbGVtZW50OwogICAgICAgICAgICAgaWYgKCF0cmVlRWxlbWVudCkgewogICAg ICAgICAgICAgICAgIGxldCB0aW1lbGluZSA9IHRoaXMuX3JlY29yZGluZy50aW1lbGluZXMuZ2V0 KHR5cGUpOwogICAgICAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRpbWVsaW5lLCAiTWlzc2lu ZyB0aW1lbGluZSBmb3IgdHlwZSAiICsgdHlwZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRyZWVFbGVtZW50LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVUcmVlRWxlbWVu dC5qcwppbmRleCBjZGNhNmJlLi4wMDkzOWUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRyZWVFbGVtZW50LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVHJlZUVsZW1l bnQuanMKQEAgLTYwLDYgKzYwLDE1IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVRyZWVFbGVtZW50 ID0gY2xhc3MgVGltZWxpbmVUcmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3BlY3RvCiAgICAgICAg IHRoaXMuX3VwZGF0ZVN0YXR1c0J1dHRvbigpOwogICAgIH0KIAorICAgIC8vIFByb3RlY3RlZAor CisgICAgb25hdHRhY2goKQorICAgIHsKKyAgICAgICAgc3VwZXIub25hdHRhY2goKTsKKworICAg ICAgICB0aGlzLmxpc3RJdGVtRWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMu X2NsaWNrSGFuZGxlci5iaW5kKHRoaXMpKTsKKyAgICB9CisKICAgICAvLyBQcml2YXRlCiAKICAg ICBfc2hvd0Nsb3NlQnV0dG9uKCkKQEAgLTg4LDQgKzk3LDEyIEBAIFdlYkluc3BlY3Rvci5UaW1l bGluZVRyZWVFbGVtZW50ID0gY2xhc3MgVGltZWxpbmVUcmVlRWxlbWVudCBleHRlbmRzIFdlYklu c3BlY3RvCiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHRoaXMuX3Nob3dDbG9zZUJ1dHRvbigp OwogICAgIH0KKworICAgIF9jbGlja0hhbmRsZXIoKQorICAgIHsKKyAgICAgICAgaWYgKCF0aGlz Ll9lZGl0aW5nKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHRoaXMuc3RhdHVzLmNo ZWNrZWQgPSAhdGhpcy5zdGF0dXMuY2hlY2tlZDsKKyAgICB9CiB9Owo=