155811 2016-03-23 15:19:59 -0700 Web Inspector: Timeline Tab sometimes restores as blank 2016-03-23 16:42:23 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1177491 0 joepeck 2016-03-23 15:19:59 -0700 * SUMMARY Timeline Tab sometimes restores as blank. * STEPS TO REPRODUCE 1. Open Inspector 2. Show Timeline Tab 3. Close Timeline Tab 4. Add New Timeline Tab 5. Repeat steps 2-4 if needed => Timeline tab restores completely blank every other time * NOTES - cookie[WebInspector.TimelineTabContentView.ShowingTimelineRecordingContentViewCookieKey] is false when there was no content view. 1177492 1 webkit-bug-importer 2016-03-23 15:20:29 -0700 <rdar://problem/25325446> 1177493 2 274783 joepeck 2016-03-23 15:21:00 -0700 Created attachment 274783 [PATCH] Proposed Fix 1177494 3 joepeck 2016-03-23 15:21:13 -0700 This is noticeable when inspecting the inspector for the first time. 1177528 4 274783 commit-queue 2016-03-23 16:42:20 -0700 Comment on attachment 274783 [PATCH] Proposed Fix Clearing flags on attachment: 274783 Committed r198603: <http://trac.webkit.org/changeset/198603> 1177529 5 commit-queue 2016-03-23 16:42:23 -0700 All reviewed patches have been landed. Closing bug. 274783 2016-03-23 15:21:00 -0700 2016-03-23 16:42:20 -0700 [PATCH] Proposed Fix overview.patch text/plain 2121 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNiZTYzNjAuLjkyNWIzMWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTAzLTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxp bmUgVGFiIHNvbWV0aW1lcyByZXN0b3JlcyBhcyBibGFuaworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1ODExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5l VGFiQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVUYWJDb250 ZW50Vmlldy5wcm90b3R5cGUucmVzdG9yZUZyb21Db29raWUpOgorICAgICAgICBXaGVuIGVhcmx5 IGJhaWxpbmcgaW4gcmVzdG9yZSwgaWYgdGhlcmUgaXMgbm8gY29udGVudCB2aWV3IHRvIHJlc3Rv cmUsCisgICAgICAgIHRoZW4gYXQgbGVhc3QgZmFsbGJhY2sgdG8gc2hvd2luZyB0aGUgT3ZlcnZp ZXcuCisKKzIwMTYtMDMtMjMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K KwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBleGNlcHRpb25zIGNsb3NpbmcgVGlt ZWxpbmUgdGFiCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTU4MDUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGltZWxpbmVUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVGFiQ29udGVudFZpZXcuanMKaW5kZXggZGVh YjBiNy4uNjhjZjE3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGltZWxpbmVUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRWaWV3LmpzCkBA IC0zMDYsOCArMzA2LDExIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVRhYkNvbnRlbnRWaWV3ID0g Y2xhc3MgVGltZWxpbmVUYWJDb250ZW50VmlldyBleHRlbmRzIFdlYkluCiAgICAgICAgIGNvbnNv bGUuYXNzZXJ0KHRoaXMuX2Rpc3BsYXllZENvbnRlbnRWaWV3KTsKIAogICAgICAgICB0aGlzLl9y ZXN0b3JlZFNob3dpbmdUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3ID0gY29va2llW1dlYklu c3BlY3Rvci5UaW1lbGluZVRhYkNvbnRlbnRWaWV3LlNob3dpbmdUaW1lbGluZVJlY29yZGluZ0Nv bnRlbnRWaWV3Q29va2llS2V5XTsKLSAgICAgICAgaWYgKCF0aGlzLl9yZXN0b3JlZFNob3dpbmdU aW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3KQorICAgICAgICBpZiAoIXRoaXMuX3Jlc3RvcmVk U2hvd2luZ1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcpIHsKKyAgICAgICAgICAgIGlmICgh dGhpcy5jb250ZW50QnJvd3Nlci5jdXJyZW50Q29udGVudFZpZXcpCisgICAgICAgICAgICAgICAg dGhpcy5fc2hvd1RpbWVsaW5lVmlld0ZvclR5cGUoV2ViSW5zcGVjdG9yLlRpbWVsaW5lVGFiQ29u dGVudFZpZXcuT3ZlcnZpZXdUaW1lbGluZUlkZW50aWZpZXJDb29raWVWYWx1ZSk7CiAgICAgICAg ICAgICByZXR1cm47CisgICAgICAgIH0KIAogICAgICAgICBsZXQgc2VsZWN0ZWRUaW1lbGluZVZp ZXdJZGVudGlmaWVyID0gY29va2llW1dlYkluc3BlY3Rvci5UaW1lbGluZVRhYkNvbnRlbnRWaWV3 LlNlbGVjdGVkVGltZWxpbmVWaWV3SWRlbnRpZmllckNvb2tpZUtleV07CiAgICAgICAgIGlmIChz ZWxlY3RlZFRpbWVsaW5lVmlld0lkZW50aWZpZXIgPT09IFdlYkluc3BlY3Rvci5UaW1lbGluZVJl Y29yZC5UeXBlLlJlbmRlcmluZ0ZyYW1lICYmICFXZWJJbnNwZWN0b3IuRlBTSW5zdHJ1bWVudC5z dXBwb3J0ZWQoKSkK