155806 2016-03-23 14:04:54 -0700 Screen queries should query the exact screen, not a default 2016-03-23 14:21:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino webkit-bug-importer oldest_to_newest 1177460 0 dino 2016-03-23 14:04:54 -0700 Screen queries should query the exact screen, not a default 1177461 1 webkit-bug-importer 2016-03-23 14:05:49 -0700 <rdar://problem/25322916> 1177465 2 274776 dino 2016-03-23 14:10:41 -0700 Created attachment 274776 Patch 1177468 3 274776 thorton 2016-03-23 14:15:03 -0700 Comment on attachment 274776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274776&action=review > Source/WebCore/ChangeLog:13 > + and comment in some other helpers why a generic check it "it ok" > Source/WebCore/platform/mac/PlatformScreenMac.mm:87 > + return NSBitsPerPixelFromDepth([screen depth]); Dots, not [] 1177469 4 dino 2016-03-23 14:21:20 -0700 Committed r198595: <http://trac.webkit.org/changeset/198595> 274776 2016-03-23 14:10:41 -0700 2016-03-23 14:12:49 -0700 Patch bug-155806-20160323141042.patch text/plain 3411 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmFiNTFhODk4OGIzMDQy ZGI5OTYzOWZmZjFlNDQwZTIzNzNjNWUzOS4uYzhjOTg0ZDAzYTkzMjVlYTdjZjhlMDM2NDQyMDEx MWEzYTgyNzM2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTAzLTIzICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBTY3JlZW4gcXVlcmllcyBzaG91 bGQgcXVlcnkgdGhlIGV4YWN0IHNjcmVlbiwgbm90IGEgZGVmYXVsdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1ODA2CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8yNTMyMjkxNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTb21lIG9mIG91ciBtZWRpYSBxdWVyaWVzIHdlcmUgdXNpbmcgaGVscGVyIGZ1 bmN0aW9ucyB0aGF0CisgICAgICAgIHdvdWxkIHF1ZXJ5IHRoZSBjYXBhYmlsaXRpZXMgb2YgdGhl IGRlZXBlc3Qgc2NyZWVuLCByYXRoZXIKKyAgICAgICAgdGhhbiB0aGUgY3VycmVudGx5IHVzZWQg c2NyZWVuLiBJIGNoYW5nZWQgdGhlbSB0byB1c2UKKyAgICAgICAgdGhlIGV4aXN0aW5nIGhlbHBl ciBmdW5jdGlvbiAodGhhdCB3b3JrcyB3aXRoIFdlYktpdCAyKQorICAgICAgICBhbmQgY29tbWVu dCBpbiBzb21lIG90aGVyIGhlbHBlcnMgd2h5IGEgZ2VuZXJpYyBjaGVjayBpdAorICAgICAgICBv ay4KKworICAgICAgICBDb3ZlcmVkIGJ5IHRoZSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAq IHBsYXRmb3JtL21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OnNj cmVlbkRlcHRoKTogVXNlIHRoZSBoZWxwZXIgZnVuY3Rpb24uCisgICAgICAgIChXZWJDb3JlOjpz Y3JlZW5EZXB0aFBlckNvbXBvbmVudCk6CisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5Jc01vbm9j aHJvbWUpOiBNb3ZlIHRoZXNlIGFuZCBtYWtlIGEgY29tbWVudC4KKyAgICAgICAgKFdlYkNvcmU6 OnNjcmVlbkhhc0ludmVydGVkQ29sb3JzKToKKwogMjAxNi0wMy0yMiAgQW50dGkgS29pdmlzdG8g IDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgTm9uLWNvbnN0IERvY3VtZW50UnVsZVNldHM6 OmZlYXR1cmVzKCkgZG9lcyBub3QgY2hlY2sgZGVmYXVsdCBzdHlsZSB2ZXJzaW9uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1TY3JlZW5NYWMubW0gYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1TY3JlZW5NYWMubW0KaW5kZXggOGE0 MzEyOTM3NzI4NTAyZTg5NTllYzQyNWM3MDZkYzI5NWE4Yjg3MS4uZjAzMGMxYWNmOWQyZmU4ZWQ2 YzJlYTZmYjc5ZjM1MTA4ZjAyYzgyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbQpAQCAtNTEsMjYgKzUxLDYgQEAgc3RhdGljIE5TU2Ny ZWVuICpzY3JlZW5Gb3JEaXNwbGF5SUQoUGxhdGZvcm1EaXNwbGF5SUQgZGlzcGxheUlEKQogICAg IHJldHVybiBuaWw7CiB9CiAKLWludCBzY3JlZW5EZXB0aChXaWRnZXQqKQotewotICAgIHJldHVy biBOU0JpdHNQZXJQaXhlbEZyb21EZXB0aChbW05TU2NyZWVuIGRlZXBlc3RTY3JlZW5dIGRlcHRo XSk7Ci19Ci0KLWludCBzY3JlZW5EZXB0aFBlckNvbXBvbmVudChXaWRnZXQqKQotewotICAgIHJl dHVybiBOU0JpdHNQZXJTYW1wbGVGcm9tRGVwdGgoW1tOU1NjcmVlbiBkZWVwZXN0U2NyZWVuXSBk ZXB0aF0pOwotfQotCi1ib29sIHNjcmVlbklzTW9ub2Nocm9tZShXaWRnZXQqKQotewotICAgIHJl dHVybiBDR0Rpc3BsYXlVc2VzRm9yY2VUb0dyYXkoKTsKLX0KLQotYm9vbCBzY3JlZW5IYXNJbnZl cnRlZENvbG9ycygpCi17Ci0gICAgcmV0dXJuIENHRGlzcGxheVVzZXNJbnZlcnRlZFBvbGFyaXR5 KCk7Ci19Ci0KIC8vIFRoZXNlIGZ1bmN0aW9ucyBzY2FsZSBiZXR3ZWVuIHNjcmVlbiBhbmQgcGFn ZSBjb29yZGluYXRlcyBiZWNhdXNlIEphdmFTY3JpcHQvRE9NIG9wZXJhdGlvbnMKIC8vIGFzc3Vt ZSB0aGF0IHRoZSBzY3JlZW4gYW5kIHRoZSBwYWdlIHNoYXJlIHRoZSBzYW1lIGNvb3JkaW5hdGUg c3lzdGVtLgogCkBAIC0xMDAsNiArODAsMzQgQEAgc3RhdGljIE5TU2NyZWVuICpzY3JlZW5Gb3JX aWRnZXQoV2lkZ2V0KiB3aWRnZXQsIE5TV2luZG93ICp3aW5kb3cpCiAgICAgcmV0dXJuIHNjcmVl bkZvcldpbmRvdyhuaWwpOwogfQogCitpbnQgc2NyZWVuRGVwdGgoV2lkZ2V0KiB3aWRnZXQpCit7 CisgICAgTlNXaW5kb3cgKndpbmRvdyA9IHdpZGdldCA/IFt3aWRnZXQtPnBsYXRmb3JtV2lkZ2V0 KCkgd2luZG93XSA6IG5pbDsKKyAgICBOU1NjcmVlbiAqc2NyZWVuID0gc2NyZWVuRm9yV2lkZ2V0 KHdpZGdldCwgd2luZG93KTsKKyAgICByZXR1cm4gTlNCaXRzUGVyUGl4ZWxGcm9tRGVwdGgoW3Nj cmVlbiBkZXB0aF0pOworfQorCitpbnQgc2NyZWVuRGVwdGhQZXJDb21wb25lbnQoV2lkZ2V0KiB3 aWRnZXQpCit7CisgICAgTlNXaW5kb3cgKndpbmRvdyA9IHdpZGdldCA/IFt3aWRnZXQtPnBsYXRm b3JtV2lkZ2V0KCkgd2luZG93XSA6IG5pbDsKKyAgICBOU1NjcmVlbiAqc2NyZWVuID0gc2NyZWVu Rm9yV2lkZ2V0KHdpZGdldCwgd2luZG93KTsKKyAgICByZXR1cm4gTlNCaXRzUGVyU2FtcGxlRnJv bURlcHRoKFtzY3JlZW4gZGVwdGhdKTsKK30KKworYm9vbCBzY3JlZW5Jc01vbm9jaHJvbWUoV2lk Z2V0KikKK3sKKyAgICAvLyBBdCB0aGUgbW9tZW50IHRoaXMgaXMgYSBzeXN0ZW0td2lkZSBhY2Nl c3NpYmlsaXR5IHNldHRpbmcsCisgICAgLy8gc28gd2UgZG9uJ3QgbmVlZCB0byBjaGVjayB0aGUg c2NyZWVuIHdlJ3JlIHVzaW5nLgorICAgIHJldHVybiBDR0Rpc3BsYXlVc2VzRm9yY2VUb0dyYXko KTsKK30KKworYm9vbCBzY3JlZW5IYXNJbnZlcnRlZENvbG9ycygpCit7CisgICAgLy8gQXQgdGhl IG1vbWVudCB0aGlzIGlzIGEgc3lzdGVtLXdpZGUgYWNjZXNzaWJpbGl0eSBzZXR0aW5nLAorICAg IC8vIHNvIHdlIGRvbid0IG5lZWQgdG8gY2hlY2sgdGhlIHNjcmVlbiB3ZSdyZSB1c2luZy4KKyAg ICByZXR1cm4gQ0dEaXNwbGF5VXNlc0ludmVydGVkUG9sYXJpdHkoKTsKK30KKwogRmxvYXRSZWN0 IHNjcmVlblJlY3QoV2lkZ2V0KiB3aWRnZXQpCiB7CiAgICAgTlNXaW5kb3cgKndpbmRvdyA9IHdp ZGdldCA/IFt3aWRnZXQtPnBsYXRmb3JtV2lkZ2V0KCkgd2luZG93XSA6IG5pbDsK