155805 2016-03-23 13:43:18 -0700 Web Inspector: Uncaught exceptions closing Timeline tab 2016-03-23 15:45:21 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1177452 0 joepeck 2016-03-23 13:43:18 -0700 * SUMMARY Uncaught exceptions closing Timeline tab. * STEPS TO REPRODUCE 1. Open Inspector 2. Close Timeline Tab => exceptions 1177454 1 webkit-bug-importer 2016-03-23 13:44:33 -0700 <rdar://problem/25322225> 1177456 2 274774 joepeck 2016-03-23 13:49:32 -0700 Created attachment 274774 [PATCH] Proposed Fix 1177510 3 274774 commit-queue 2016-03-23 15:45:17 -0700 Comment on attachment 274774 [PATCH] Proposed Fix Clearing flags on attachment: 274774 Committed r198601: <http://trac.webkit.org/changeset/198601> 1177511 4 commit-queue 2016-03-23 15:45:21 -0700 All reviewed patches have been landed. Closing bug. 274774 2016-03-23 13:49:32 -0700 2016-03-23 15:45:17 -0700 [PATCH] Proposed Fix close-tab.patch text/plain 2557 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI3NjE1YWUuLmNiZTYzNjAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTAzLTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgZXhjZXB0aW9ucyBjbG9zaW5nIFRpbWVsaW5lIHRhYgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1ODA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NjcmlwdENs dXN0ZXJUaW1lbGluZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0Q2x1c3Rl clRpbWVsaW5lVmlldy5wcm90b3R5cGUuX3NjcmlwdENsdXN0ZXJWaWV3Q3VycmVudENvbnRlbnRW aWV3RGlkQ2hhbmdlKToKKyAgICAgICAgR3JhY2VmdWxseSBoYW5kbGUgaWYgdGhlcmUgaXMgbm8g Y29udGVudCB2aWV3LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJl Y29yZGluZ0NvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVj b3JkaW5nQ29udGVudFZpZXcucHJvdG90eXBlLmNsb3NlZCk6IERlbGV0ZWQuCisgICAgICAgIEZp eCB0eXBvLgorCisyMDE2LTAzLTIzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5j b20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTjogVGltZWxpbmUgUmVzZXQg ZG9lcyBub3QgY2xlYXIgZGF0YWdyaWRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTU4MDQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0Q2x1c3RlclRpbWVsaW5lVmlldy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NjcmlwdENsdXN0ZXJUaW1l bGluZVZpZXcuanMKaW5kZXggNjdlM2ExOC4uNmM0MTc4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0Q2x1c3RlclRpbWVsaW5lVmll dy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3Jp cHRDbHVzdGVyVGltZWxpbmVWaWV3LmpzCkBAIC0xODcsNiArMTg3LDkgQEAgV2ViSW5zcGVjdG9y LlNjcmlwdENsdXN0ZXJUaW1lbGluZVZpZXcgPSBjbGFzcyBTY3JpcHRDbHVzdGVyVGltZWxpbmVW aWV3IGV4dGVuZHMKICAgICBfc2NyaXB0Q2x1c3RlclZpZXdDdXJyZW50Q29udGVudFZpZXdEaWRD aGFuZ2UoZXZlbnQpCiAgICAgewogICAgICAgICBsZXQgY3VycmVudENvbnRlbnRWaWV3ID0gdGhp cy5fY29udGVudFZpZXdDb250YWluZXIuY3VycmVudENvbnRlbnRWaWV3OworICAgICAgICBpZiAo IWN1cnJlbnRDb250ZW50VmlldykKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBsZXQg cHJldmlvdXNDb250ZW50VmlldyA9IGN1cnJlbnRDb250ZW50VmlldyA9PT0gdGhpcy5fZXZlbnRz Q29udGVudFZpZXcgPyB0aGlzLl9wcm9maWxlQ29udGVudFZpZXcgOiB0aGlzLl9ldmVudHNDb250 ZW50VmlldzsKIAogICAgICAgICBjdXJyZW50Q29udGVudFZpZXcuemVyb1RpbWUgPSBwcmV2aW91 c0NvbnRlbnRWaWV3Lnplcm9UaW1lOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5n Q29udGVudFZpZXcuanMKaW5kZXggM2FlODRhZC4uMTFlZTgxMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250 ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCkBAIC0xODUsNyArMTg1LDcgQEAgV2Vi SW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcgPSBjbGFzcyBUaW1lbGluZVJl Y29yZGluZ0NvbnRlbnRWaWV3IGUKIAogICAgIGNsb3NlZCgpCiAgICAgewotICAgICAgICB0aGlz Ll90aW1lbGluQ29udGVudEJyb3dzZXIuY29udGVudFZpZXdDb250YWluZXIuY2xvc2VBbGxDb250 ZW50Vmlld3MoKTsKKyAgICAgICAgdGhpcy5fdGltZWxpbmVDb250ZW50QnJvd3Nlci5jb250ZW50 Vmlld0NvbnRhaW5lci5jbG9zZUFsbENvbnRlbnRWaWV3cygpOwogCiAgICAgICAgIHRoaXMuX3Jl Y29yZGluZy5yZW1vdmVFdmVudExpc3RlbmVyKG51bGwsIG51bGwsIHRoaXMpOwogCg==