155804 2016-03-23 13:25:18 -0700 Web Inspector: REGRESSION: Timeline Reset does not clear datagrids 2016-03-23 15:46:01 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1177447 0 joepeck 2016-03-23 13:25:18 -0700 * SUMMARY REGRESSION: Timeline Reset does not clear data grids. * STEPS TO REPRODUCE 1. Open inspector 2. Show Timeline tab 3. Start a recording 4. Include some stuff 5. Stop the recording 6. Click Reset => Datagrids in all Timelines + Overview still have data 1177448 1 webkit-bug-importer 2016-03-23 13:26:33 -0700 <rdar://problem/25321688> 1177449 2 274773 joepeck 2016-03-23 13:26:56 -0700 Created attachment 274773 [PATCH] Proposed Fix 1177512 3 274773 commit-queue 2016-03-23 15:45:56 -0700 Comment on attachment 274773 [PATCH] Proposed Fix Clearing flags on attachment: 274773 Committed r198602: <http://trac.webkit.org/changeset/198602> 1177513 4 commit-queue 2016-03-23 15:46:01 -0700 All reviewed patches have been landed. Closing bug. 274773 2016-03-23 13:26:56 -0700 2016-03-23 15:45:56 -0700 [PATCH] Proposed Fix reset.patch text/plain 4070 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk3OTc1ODEuLjI3NjE1YWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTAzLTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVT U0lPTjogVGltZWxpbmUgUmVzZXQgZG9lcyBub3QgY2xlYXIgZGF0YWdyaWRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU4MDQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmll d3MvSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldy5wcm90b3R5cGUuc2hvd24pOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldy5wcm90b3R5cGUuaGlkZGVu KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcucHJv dG90eXBlLmNsb3NlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcEFsbG9jYXRpb25zVGlt ZWxpbmVWaWV3LnByb3RvdHlwZS5yZXNldCk6CisgICAgICAgIEFsdGhvdWdoIHdlIGRvbid0IHVz ZSB0aGUgcG9wb3ZlciBmZWF0dXJlcyBvZiBUaW1lbGluZURhdGFHcmlkLAorICAgICAgICBiZSBh IGdvb2QgY2l0aXplbiBhbmQgY2FsbCBtZXRob2RzIG9uIHRoZSBkYXRhZ3JpZC4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1lbGluZVZpZXcuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuT3ZlcnZpZXdUaW1lbGluZVZpZXcucHJvdG90eXBlLnJlc2V0KToKKyAg ICAgICAgQ2xlYXIgdGhlIGRhdGFncmlkIG9uIHJlc2V0LgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9UaW1lbGluZURhdGFHcmlkLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRp bWVsaW5lRGF0YUdyaWQucHJvdG90eXBlLnJlc2V0KToKKyAgICAgICAgQ2xlYXIgdGhlIGRhdGFn cmlkIG9uIHJlc2V0LgorCiAyMDE2LTAzLTIyICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb25zaWRlciBBdXRvbWF0aW9uIHNj cmlwdCBuYW1lcyBhcyBpbnRlcm5hbCBhbmQgaGlkZSB0aGVtCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGlu ZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFw QWxsb2NhdGlvbnNUaW1lbGluZVZpZXcuanMKaW5kZXggYzM3NzI1NS4uYTAyYTdhMCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSGVhcEFsbG9j YXRpb25zVGltZWxpbmVWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldy5qcwpAQCAtMTk2LDYgKzE5 Niw4IEBAIFdlYkluc3BlY3Rvci5IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcgPSBjbGFzcyBI ZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcgZXh0CiAgICAgewogICAgICAgICBzdXBlci5zaG93 bigpOwogCisgICAgICAgIHRoaXMuX2RhdGFHcmlkLnNob3duKCk7CisKICAgICAgICAgaWYgKCF0 aGlzLl9zaG93aW5nU25hcHNob3RMaXN0KQogICAgICAgICAgICAgdGhpcy5fY29udGVudFZpZXdD b250YWluZXIuc2hvd24oKTsKICAgICB9CkBAIC0yMDQsNiArMjA2LDggQEAgV2ViSW5zcGVjdG9y LkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldyA9IGNsYXNzIEhlYXBBbGxvY2F0aW9uc1RpbWVs aW5lVmlldyBleHQKICAgICB7CiAgICAgICAgIHN1cGVyLmhpZGRlbigpOwogCisgICAgICAgIHRo aXMuX2RhdGFHcmlkLmhpZGRlbigpOworCiAgICAgICAgIGlmICghdGhpcy5fc2hvd2luZ1NuYXBz aG90TGlzdCkKICAgICAgICAgICAgIHRoaXMuX2NvbnRlbnRWaWV3Q29udGFpbmVyLmhpZGRlbigp OwogICAgIH0KQEAgLTIxMyw2ICsyMTcsOCBAQCBXZWJJbnNwZWN0b3IuSGVhcEFsbG9jYXRpb25z VGltZWxpbmVWaWV3ID0gY2xhc3MgSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3IGV4dAogICAg ICAgICBjb25zb2xlLmFzc2VydCh0aGlzLnJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2Vi SW5zcGVjdG9yLlRpbWVsaW5lKTsKICAgICAgICAgdGhpcy5yZXByZXNlbnRlZE9iamVjdC5yZW1v dmVFdmVudExpc3RlbmVyKG51bGwsIG51bGwsIHRoaXMpOwogCisgICAgICAgIHRoaXMuX2RhdGFH cmlkLmNsb3NlZCgpOworCiAgICAgICAgIHRoaXMuX2NvbnRlbnRWaWV3Q29udGFpbmVyLmNsb3Nl QWxsQ29udGVudFZpZXdzKCk7CiAgICAgfQogCkBAIC0yMzQsNiArMjQwLDggQEAgV2ViSW5zcGVj dG9yLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldyA9IGNsYXNzIEhlYXBBbGxvY2F0aW9uc1Rp bWVsaW5lVmlldyBleHQKICAgICB7CiAgICAgICAgIHN1cGVyLnJlc2V0KCk7CiAKKyAgICAgICAg dGhpcy5fZGF0YUdyaWQucmVzZXQoKTsKKwogICAgICAgICB0aGlzLnNob3dIZWFwU25hcHNob3RM aXN0KCk7CiAgICAgICAgIHRoaXMuX3BlbmRpbmdSZWNvcmRzID0gW107CiAgICAgICAgIHRoaXMu X3VwZGF0ZUNvbXBhcmVIZWFwU25hcHNob3RCdXR0b24oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL092ZXJ2aWV3VGltZWxpbmVWaWV3Lmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1l bGluZVZpZXcuanMKaW5kZXggNDRlM2EwNWYuLjViMjllYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL092ZXJ2aWV3VGltZWxpbmVWaWV3Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL092ZXJ2aWV3 VGltZWxpbmVWaWV3LmpzCkBAIC0xMTUsNiArMTE1LDggQEAgV2ViSW5zcGVjdG9yLk92ZXJ2aWV3 VGltZWxpbmVWaWV3ID0gY2xhc3MgT3ZlcnZpZXdUaW1lbGluZVZpZXcgZXh0ZW5kcyBXZWJJbnNw ZWMKICAgICB7CiAgICAgICAgIHN1cGVyLnJlc2V0KCk7CiAKKyAgICAgICAgdGhpcy5fZGF0YUdy aWQucmVtb3ZlQ2hpbGRyZW4oKTsKKwogICAgICAgICB0aGlzLl9wZW5kaW5nUmVwcmVzZW50ZWRP YmplY3RzID0gW107CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZURhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVEYXRhR3JpZC5qcwppbmRleCA1YWM4 MjgyLi4wMDAyNmM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UaW1lbGluZURhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWQuanMKQEAgLTgzLDYgKzgzLDkg QEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lRGF0YUdyaWQgPSBjbGFzcyBUaW1lbGluZURhdGFHcmlk IGV4dGVuZHMgV2ViSW5zcGVjdG9yLkRhdGEKICAgICB7CiAgICAgICAgIC8vIE1heSBiZSBvdmVy cmlkZGVuIGJ5IHN1YmNsYXNzZXMuIElmIHNvLCB0aGV5IHNob3VsZCBjYWxsIHRoZSBzdXBlcmNs YXNzLgogCisgICAgICAgIGlmICghdGhpcy5fdHJlZU91dGxpbmVEYXRhR3JpZFN5bmNocm9uaXpl cikKKyAgICAgICAgICAgIHRoaXMucmVtb3ZlQ2hpbGRyZW4oKTsKKwogICAgICAgICB0aGlzLl9o aWRlUG9wb3ZlcigpOwogICAgIH0KIAo=