155799 2016-03-23 11:50:20 -0700 Fix null dereferencing in NetworkLoad::continueCanAuthenticateAgainstProtectionSpace 2016-03-24 10:08:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1177405 0 achristensen 2016-03-23 11:50:20 -0700 Fix null dereferencing in NetworkLoad::continueCanAuthenticateAgainstProtectionSpace 1177409 1 274765 achristensen 2016-03-23 11:55:02 -0700 Created attachment 274765 Patch 1177412 2 274765 achristensen 2016-03-23 12:02:09 -0700 Comment on attachment 274765 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274765&action=review > Source/WebKit2/NetworkProcess/NetworkLoad.cpp:378 > + if (m_handle) > + m_handle->continueCanAuthenticateAgainstProtectionSpace(result); We use m_handle when using NetworkSession for blobs, and m_task for non-blob network loads. 1177444 3 274765 thorton 2016-03-23 13:21:29 -0700 Comment on attachment 274765 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274765&action=review > Source/WebKit2/NetworkProcess/NetworkLoad.cpp:351 > ASSERT(m_challengeCompletionHandler); > auto completionHandler = WTFMove(m_challengeCompletionHandler); > + if (!completionHandler) > + return; > + Please find the path that gets you here. ASSERT(x) if (!x) return; is not good WebKit happiness. >> Source/WebKit2/NetworkProcess/NetworkLoad.cpp:378 >> + m_handle->continueCanAuthenticateAgainstProtectionSpace(result); > > We use m_handle when using NetworkSession for blobs, and m_task for non-blob network loads. This part seems fine. 1177695 4 achristensen 2016-03-24 10:08:12 -0700 http://trac.webkit.org/changeset/198629 274765 2016-03-23 11:55:02 -0700 2016-03-23 13:21:29 -0700 Patch bug-155799-20160323115504.patch text/plain 2697 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODU4NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAzLTIzICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IG51bGwg ZGVyZWZlcmVuY2luZyBpbiBOZXR3b3JrTG9hZDo6Y29udGludWVDYW5BdXRoZW50aWNhdGVBZ2Fp bnN0UHJvdGVjdGlvblNwYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTU3OTkKKyAgICAgICAgcmRhcjovLzI1Mjg5MDEyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrTG9hZC5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtMb2FkOjpjb250aW51ZUNhbkF1 dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UpOgorICAgICAgICBOdWxsLWNoZWNrIGFs bCB0aGUgdGhpbmdzIQorCiAyMDE2LTAzLTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVc2UgUmVnaW9uIGluc3RlYWQgb2YgSW50UmVjdCBp biBQYWdlQ2xpZW50IGFuZCBXZWJQYWdlUHJveHkgc2V0Vmlld05lZWRzRGlzcGxheSBtZXRob2QK SW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAJ KHJldmlzaW9uIDE5ODU4NCkKKysrIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdv cmtMb2FkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQ2LDYgKzM0Niw5IEBAIHZvaWQgTmV0d29y a0xvYWQ6OmNvbnRpbnVlQ2FuQXV0aGVudGljYXQKICAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKCFt X2hhbmRsZSwgIkJsb2JzIHNob3VsZCBuZXZlciBnaXZlIGF1dGhlbnRpY2F0aW9uIGNoYWxsZW5n ZXMiKTsKICAgICBBU1NFUlQobV9jaGFsbGVuZ2VDb21wbGV0aW9uSGFuZGxlcik7CiAgICAgYXV0 byBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUobV9jaGFsbGVuZ2VDb21wbGV0aW9uSGFuZGxl cik7CisgICAgaWYgKCFjb21wbGV0aW9uSGFuZGxlcikKKyAgICAgICAgcmV0dXJuOworCiAgICAg aWYgKCFyZXN1bHQpIHsKICAgICAgICAgaWYgKG1fdGFzayAmJiBtX3Rhc2stPmFsbG93c1NwZWNp ZmljSFRUUFNDZXJ0aWZpY2F0ZUZvckhvc3QobV9jaGFsbGVuZ2UpKQogICAgICAgICAgICAgY29t cGxldGlvbkhhbmRsZXIoQXV0aGVudGljYXRpb25DaGFsbGVuZ2VEaXNwb3NpdGlvbjo6VXNlQ3Jl ZGVudGlhbCwgc2VydmVyVHJ1c3RDcmVkZW50aWFsKG1fY2hhbGxlbmdlKSk7CkBAIC0zNjQsMTMg KzM2NywxNSBAQCB2b2lkIE5ldHdvcmtMb2FkOjpjb250aW51ZUNhbkF1dGhlbnRpY2F0CiAgICAg ICAgIHJldHVybjsKICAgICB9CiAgICAgCi0gICAgaWYgKGF1dG8qIHBlbmRpbmdEb3dubG9hZCA9 IG1fdGFzay0+cGVuZGluZ0Rvd25sb2FkKCkpCi0gICAgICAgIE5ldHdvcmtQcm9jZXNzOjpzaW5n bGV0b24oKS5hdXRoZW50aWNhdGlvbk1hbmFnZXIoKS5kaWRSZWNlaXZlQXV0aGVudGljYXRpb25D aGFsbGVuZ2UoKnBlbmRpbmdEb3dubG9hZCwgbV9jaGFsbGVuZ2UsIGNvbXBsZXRpb25IYW5kbGVy KTsKLSAgICBlbHNlCi0gICAgICAgIE5ldHdvcmtQcm9jZXNzOjpzaW5nbGV0b24oKS5hdXRoZW50 aWNhdGlvbk1hbmFnZXIoKS5kaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UobV9wYXJh bWV0ZXJzLndlYlBhZ2VJRCwgbV9wYXJhbWV0ZXJzLndlYkZyYW1lSUQsIG1fY2hhbGxlbmdlLCBj b21wbGV0aW9uSGFuZGxlcik7Ci0jZWxzZQotICAgIG1faGFuZGxlLT5jb250aW51ZUNhbkF1dGhl bnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UocmVzdWx0KTsKKyAgICBpZiAobV90YXNrKSB7 CisgICAgICAgIGlmIChhdXRvKiBwZW5kaW5nRG93bmxvYWQgPSBtX3Rhc2stPnBlbmRpbmdEb3du bG9hZCgpKQorICAgICAgICAgICAgTmV0d29ya1Byb2Nlc3M6OnNpbmdsZXRvbigpLmF1dGhlbnRp Y2F0aW9uTWFuYWdlcigpLmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSgqcGVuZGlu Z0Rvd25sb2FkLCBtX2NoYWxsZW5nZSwgY29tcGxldGlvbkhhbmRsZXIpOworICAgICAgICBlbHNl CisgICAgICAgICAgICBOZXR3b3JrUHJvY2Vzczo6c2luZ2xldG9uKCkuYXV0aGVudGljYXRpb25N YW5hZ2VyKCkuZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKG1fcGFyYW1ldGVycy53 ZWJQYWdlSUQsIG1fcGFyYW1ldGVycy53ZWJGcmFtZUlELCBtX2NoYWxsZW5nZSwgY29tcGxldGlv bkhhbmRsZXIpOworICAgIH0KICNlbmRpZgorICAgIGlmIChtX2hhbmRsZSkKKyAgICAgICAgbV9o YW5kbGUtPmNvbnRpbnVlQ2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZShyZXN1 bHQpOwogfQogI2VuZGlmCiAK