15579 2007-10-20 14:29:24 -0700 stop churning identifier reference counts copying Completion objects 2007-10-20 15:49:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Enhancement --- 1 darin darin oldest_to_newest 58928 0 darin 2007-10-20 14:29:24 -0700 A simple change that gives a 2% speedup on the SunSpider benchmark. 58929 1 16745 darin 2007-10-20 14:31:25 -0700 Created attachment 16745 patch with change log 58932 2 16745 mjs 2007-10-20 14:59:56 -0700 Comment on attachment 16745 patch with change log r=me 58938 3 darin 2007-10-20 15:49:09 -0700 Committed revision 26832. 16745 2007-10-20 14:31:25 -0700 2007-10-20 14:59:56 -0700 patch with change log CompletionPatch.txt text/plain 4830 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2ODMwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMTAtMjAgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIC0gaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU1NzkKKyAgICAgICAgICBzdG9wIGNodXJuaW5nIGlkZW50aWZpZXIgcmVmZXJlbmNlIGNvdW50 cyBjb3B5aW5nIENvbXBsZXRpb24gb2JqZWN0cworCisgICAgICAgICoga2pzL2NvbXBsZXRpb24u aDogUmVwbGFjZSB0aGUgSWRlbnRpZmllciB3aXRoIGFuIElkZW50aWZpZXIqLgorICAgICAgICAq IGtqcy9ub2Rlcy5jcHA6CisgICAgICAgIChGb3JJbk5vZGU6OmV4ZWN1dGUpOiBVcGRhdGUgZm9y IGNoYW5nZSB0byBDb21wbGV0aW9uIGNvbnN0cnVjdG9yLgorICAgICAgICAoQ29udGludWVOb2Rl OjpleGVjdXRlKTogRGl0dG8uCisgICAgICAgIChCcmVha05vZGU6OmV4ZWN1dGUpOiBEaXR0by4K KwogMjAwNy0xMC0yMCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFscC4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9jb21wbGV0aW9uLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL2NvbXBsZXRpb24uaAkocmV2aXNpb24gMjY4 MjcpCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvY29tcGxldGlvbi5oCSh3b3JraW5nIGNvcHkpCkBA IC0xLDkgKzEsOCBAQAogLy8gLSotIGMtYmFzaWMtb2Zmc2V0OiAyIC0qLQogLyoKLSAqICBUaGlz IGZpbGUgaXMgcGFydCBvZiB0aGUgS0RFIGxpYnJhcmllcwogICogIENvcHlyaWdodCAoQykgMTk5 OS0yMDAxIEhhcnJpIFBvcnRlbiAocG9ydGVuQGtkZS5vcmcpCiAgKiAgQ29weXJpZ2h0IChDKSAy MDAxIFBldGVyIEtlbGx5IChwbWtAcG9zdC5jb20pCi0gKiAgQ29weXJpZ2h0IChDKSAyMDAzIEFw cGxlIENvbXB1dGVyLCBJbmMKKyAqICBDb3B5cmlnaHQgKEMpIDIwMDMsIDIwMDcgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0 d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiAgbW9kaWZ5IGl0IHVuZGVy IHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTIyLDE3ICsy MSwxNCBAQAogICoKICAqLwogCi0jaWZuZGVmIF9LSlNfQ09NUExFVElPTl9IXwotI2RlZmluZSBf S0pTX0NPTVBMRVRJT05fSF8KLQotI2luY2x1ZGUgIkNvbW1vbklkZW50aWZpZXJzLmgiCi0jaW5j bHVkZSAidmFsdWUuaCIKKyNpZm5kZWYgS0pTX0NPTVBMRVRJT05fSAorI2RlZmluZSBLSlNfQ09N UExFVElPTl9ICiAKIG5hbWVzcGFjZSBLSlMgewogCi0gIC8qKgotICAgKiBDb21wbGV0aW9uIHR5 cGVzLgotICAgKi8KKyAgY2xhc3MgSWRlbnRpZmllcjsKKyAgY2xhc3MgSlNWYWx1ZTsKKwogICBl bnVtIENvbXBsVHlwZSB7IE5vcm1hbCwgQnJlYWssIENvbnRpbnVlLCBSZXR1cm5WYWx1ZSwgVGhy b3csIEludGVycnVwdGVkIH07CiAKICAgLyoqCkBAIC00NywxOCArNDMsMjEgQEAgbmFtZXNwYWNl IEtKUyB7CiAgICAqLwogICBjbGFzcyBDb21wbGV0aW9uIHsKICAgcHVibGljOgotICAgIENvbXBs ZXRpb24oQ29tcGxUeXBlIGMgPSBOb3JtYWwsIEpTVmFsdWUgKnYgPSBOVUxMLCBjb25zdCBJZGVu dGlmaWVyICZ0ID0gQ29tbW9uSWRlbnRpZmllcnM6OnNoYXJlZCgpLT5udWxsSWRlbnRpZmllcikK LSAgICAgICAgOiBjb21wKGMpLCB2YWwodiksIHRhcih0KSB7IH0KKyAgICBDb21wbGV0aW9uKENv bXBsVHlwZSB0eXBlID0gTm9ybWFsLCBKU1ZhbHVlKiB2YWx1ZSA9IDApCisgICAgICAgIDogbV90 eXBlKHR5cGUpLCBtX3ZhbHVlKHZhbHVlKSwgbV90YXJnZXQoMCkgeyB9CisgICAgQ29tcGxldGlv bihDb21wbFR5cGUgdHlwZSwgY29uc3QgSWRlbnRpZmllciogdGFyZ2V0KQorICAgICAgICA6IG1f dHlwZSh0eXBlKSwgbV92YWx1ZSgwKSwgbV90YXJnZXQodGFyZ2V0KSB7IH0KKworICAgIENvbXBs VHlwZSBjb21wbFR5cGUoKSBjb25zdCB7IHJldHVybiBtX3R5cGU7IH0KKyAgICBKU1ZhbHVlKiB2 YWx1ZSgpIGNvbnN0IHsgcmV0dXJuIG1fdmFsdWU7IH0KKyAgICB2b2lkIHNldFZhbHVlKEpTVmFs dWUqIHYpIHsgbV92YWx1ZSA9IHY7IH0KKyAgICBjb25zdCBJZGVudGlmaWVyJiB0YXJnZXQoKSBj b25zdCB7IHJldHVybiAqbV90YXJnZXQ7IH0KKyAgICBib29sIGlzVmFsdWVDb21wbGV0aW9uKCkg Y29uc3QgeyByZXR1cm4gISFtX3ZhbHVlOyB9CiAKLSAgICBDb21wbFR5cGUgY29tcGxUeXBlKCkg Y29uc3QgeyByZXR1cm4gY29tcDsgfQotICAgIEpTVmFsdWUgKnZhbHVlKCkgY29uc3QgeyByZXR1 cm4gdmFsOyB9Ci0gICAgdm9pZCBzZXRWYWx1ZShKU1ZhbHVlKiB2KSB7IHZhbCA9IHY7IH0KLSAg ICBJZGVudGlmaWVyIHRhcmdldCgpIGNvbnN0IHsgcmV0dXJuIHRhcjsgfQotICAgIGJvb2wgaXNW YWx1ZUNvbXBsZXRpb24oKSBjb25zdCB7IHJldHVybiAhIXZhbDsgfQogICBwcml2YXRlOgotICAg IENvbXBsVHlwZSBjb21wOwotICAgIEpTVmFsdWUgKnZhbDsKLSAgICBJZGVudGlmaWVyIHRhcjsK KyAgICBDb21wbFR5cGUgbV90eXBlOworICAgIEpTVmFsdWUqIG1fdmFsdWU7CisgICAgY29uc3Qg SWRlbnRpZmllciogbV90YXJnZXQ7CiAgIH07CiAKIH0KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2tq cy9ub2Rlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL25vZGVzLmNwcAko cmV2aXNpb24gMjY4MjcpCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvbm9kZXMuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xOTk4LDkgKzE5OTgsOCBAQCBDb21wbGV0aW9uIEZvckluTm9kZTo6ZXhlY3V0 ZShFeGVjU3RhdGUgCiAgIC8vIHRoZSBsb29wIGF0IGFsbCwgYmVjYXVzZSB0aGVpciBvYmplY3Qg d3JhcHBlcnMgd2lsbCBoYXZlIGEKICAgLy8gcHJvcGVydHkgbGlzdCBidXQgd2lsbCB0aHJvdyBh biBleGNlcHRpb24gaWYgeW91IGF0dGVtcHQgdG8KICAgLy8gYWNjZXNzIGFueSBwcm9wZXJ0eS4K LSAgaWYgKGUtPmlzVW5kZWZpbmVkT3JOdWxsKCkpIHsKLSAgICByZXR1cm4gQ29tcGxldGlvbihO b3JtYWwsIDApOwotICB9CisgIGlmIChlLT5pc1VuZGVmaW5lZE9yTnVsbCgpKQorICAgIHJldHVy biBDb21wbGV0aW9uKE5vcm1hbCk7CiAKICAgS0pTX0NIRUNLRVhDRVBUSU9OCiAgIHYgPSBlLT50 b09iamVjdChleGVjKTsKQEAgLTIwOTAsMTAgKzIwODksOSBAQCBDb21wbGV0aW9uIENvbnRpbnVl Tm9kZTo6ZXhlY3V0ZShFeGVjU3RhCiAKICAgaWYgKGlkZW50LmlzRW1wdHkoKSAmJiAhZXhlYy0+ Y29udGV4dCgpLT5pbkl0ZXJhdGlvbigpKQogICAgIHJldHVybiBjcmVhdGVFcnJvckNvbXBsZXRp b24oZXhlYywgU3ludGF4RXJyb3IsICJJbnZhbGlkIGNvbnRpbnVlIHN0YXRlbWVudC4iKTsKLSAg ZWxzZSBpZiAoIWlkZW50LmlzRW1wdHkoKSAmJiAhZXhlYy0+Y29udGV4dCgpLT5zZWVuTGFiZWxz KCktPmNvbnRhaW5zKGlkZW50KSkKKyAgaWYgKCFpZGVudC5pc0VtcHR5KCkgJiYgIWV4ZWMtPmNv bnRleHQoKS0+c2VlbkxhYmVscygpLT5jb250YWlucyhpZGVudCkpCiAgICAgcmV0dXJuIGNyZWF0 ZUVycm9yQ29tcGxldGlvbihleGVjLCBTeW50YXhFcnJvciwgIkxhYmVsICVzIG5vdCBmb3VuZC4i LCBpZGVudCk7Ci0gIGVsc2UKLSAgICByZXR1cm4gQ29tcGxldGlvbihDb250aW51ZSwgMCwgaWRl bnQpOworICByZXR1cm4gQ29tcGxldGlvbihDb250aW51ZSwgJmlkZW50KTsKIH0KIAogLy8gLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tIEJyZWFrTm9kZSAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0KQEAgLTIxMDYsMTAgKzIxMDQsOSBAQCBDb21wbGV0aW9uIEJyZWFr Tm9kZTo6ZXhlY3V0ZShFeGVjU3RhdGUgCiAgIGlmIChpZGVudC5pc0VtcHR5KCkgJiYgIWV4ZWMt PmNvbnRleHQoKS0+aW5JdGVyYXRpb24oKSAmJgogICAgICAgIWV4ZWMtPmNvbnRleHQoKS0+aW5T d2l0Y2goKSkKICAgICByZXR1cm4gY3JlYXRlRXJyb3JDb21wbGV0aW9uKGV4ZWMsIFN5bnRheEVy cm9yLCAiSW52YWxpZCBicmVhayBzdGF0ZW1lbnQuIik7Ci0gIGVsc2UgaWYgKCFpZGVudC5pc0Vt cHR5KCkgJiYgIWV4ZWMtPmNvbnRleHQoKS0+c2VlbkxhYmVscygpLT5jb250YWlucyhpZGVudCkp CisgIGlmICghaWRlbnQuaXNFbXB0eSgpICYmICFleGVjLT5jb250ZXh0KCktPnNlZW5MYWJlbHMo KS0+Y29udGFpbnMoaWRlbnQpKQogICAgIHJldHVybiBjcmVhdGVFcnJvckNvbXBsZXRpb24oZXhl YywgU3ludGF4RXJyb3IsICJMYWJlbCAlcyBub3QgZm91bmQuIik7Ci0gIGVsc2UKLSAgICByZXR1 cm4gQ29tcGxldGlvbihCcmVhaywgMCwgaWRlbnQpOworICByZXR1cm4gQ29tcGxldGlvbihCcmVh aywgJmlkZW50KTsKIH0KIAogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tIFJldHVy bk5vZGUgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K