155788 2016-03-23 04:42:08 -0700 [css-grid] Remove unneeded lines in offsetAndBreadthForPositionedChild() 2016-03-28 04:22:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego commit-queue esprehn+autocc glenn jfernandez kondapallykalyan rego simon.fraser svillar oldest_to_newest 1177329 0 rego 2016-03-23 04:42:08 -0700 [css-grid] Remove unneeded lines in offsetAndBreadthForPositionedChild() 1177330 1 274744 rego 2016-03-23 04:44:19 -0700 Created attachment 274744 Patch 1178399 2 274744 svillar 2016-03-28 02:27:52 -0700 Comment on attachment 274744 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274744&action=review > Source/WebCore/rendering/RenderGrid.cpp:1520 > + LayoutUnit start = startIsAuto ? LayoutUnit() : isRowAxis ? m_columnPositions[startLine] : m_rowPositions[startLine]; Mind adding parens here too. Otherwise it's very difficult to read. 1178402 3 275020 rego 2016-03-28 03:34:28 -0700 Created attachment 275020 Patch for landing 1178403 4 rego 2016-03-28 03:35:06 -0700 Thanks for the review. (In reply to comment #2) > Comment on attachment 274744 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274744&action=review > > > Source/WebCore/rendering/RenderGrid.cpp:1520 > > + LayoutUnit start = startIsAuto ? LayoutUnit() : isRowAxis ? m_columnPositions[startLine] : m_rowPositions[startLine]; > > Mind adding parens here too. Otherwise it's very difficult to read. Done. 1178404 5 275020 commit-queue 2016-03-28 04:22:46 -0700 Comment on attachment 275020 Patch for landing Clearing flags on attachment: 275020 Committed r198732: <http://trac.webkit.org/changeset/198732> 1178405 6 commit-queue 2016-03-28 04:22:51 -0700 All reviewed patches have been landed. Closing bug. 274744 2016-03-23 04:44:19 -0700 2016-03-28 03:34:21 -0700 Patch bug-155788-20160323124419.patch text/plain 2159 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWYzNWY1MTgzMmEyNmYy MzU0NTZhZWQ5NWEyMzkyODIwNTU1MjI5ZS4uYjZjYjJmYzI0ODRjZGZhOTBjNTUyZjI5OTI3MmYz NWJjZGM4ZTExNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAzLTIzICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gUmVtb3ZlIHVubmVlZGVkIGxpbmVzIGluIG9mZnNldEFuZEJyZWFkdGhGb3JQb3NpdGlvbmVk Q2hpbGQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU1Nzg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SnVzdCByZW1vdmUgMiBsaW5lcy92YXJpYWJsZXMgdGhhdCB3ZXJlIG5vdCBuZWVkZWQgYXQgYWxs IGluCisgICAgICAgIFJlbmRlckdyaWQ6Om9mZnNldEFuZEJyZWFkdGhGb3JQb3NpdGlvbmVkQ2hp bGQoKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5nZSBvZiBiZWhhdmlvci4KKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJHcmlkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckdyaWQ6Om9mZnNldEFuZEJyZWFkdGhGb3JQb3NpdGlvbmVkQ2hpbGQpOgorCiAyMDE2LTAz LTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAg ICBVc2UgUmVnaW9uIGluc3RlYWQgb2YgSW50UmVjdCBpbiBQYWdlQ2xpZW50IGFuZCBXZWJQYWdl UHJveHkgc2V0Vmlld05lZWRzRGlzcGxheSBtZXRob2QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJHcmlkLmNwcAppbmRleCA5OTdmN2MxYWI0ZTEyYjFhMTg2ODc5NmQxYTkwZDQ2OWQwMGUy YmRlLi5mZjAyMDViZTFiZjkzNzQ0YmFjZDYzYjcxNzk3NmMyMzRhODE5MTY1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCkBAIC0xNTE3LDExICsxNTE3LDggQEAgdm9p ZCBSZW5kZXJHcmlkOjpvZmZzZXRBbmRCcmVhZHRoRm9yUG9zaXRpb25lZENoaWxkKGNvbnN0IFJl bmRlckJveCYgY2hpbGQsIEdyaWQKICAgICAgICAgfHwgKGVuZExpbmUgPCBmaXJzdEV4cGxpY2l0 TGluZSkKICAgICAgICAgfHwgKGVuZExpbmUgPiBsYXN0RXhwbGljaXRMaW5lKTsKIAotICAgIHVu c2lnbmVkIGluaXRpYWxQb3NpdGlvbiA9IHN0YXJ0SXNBdXRvID8gMCA6IHN0YXJ0TGluZTsKLSAg ICB1bnNpZ25lZCBmaW5hbFBvc2l0aW9uID0gZW5kSXNBdXRvID8gbGFzdEV4cGxpY2l0TGluZSA6 IGVuZExpbmU7Ci0KLSAgICBMYXlvdXRVbml0IHN0YXJ0ID0gc3RhcnRJc0F1dG8gPyBMYXlvdXRV bml0KCkgOiBpc1Jvd0F4aXMgPyAgbV9jb2x1bW5Qb3NpdGlvbnNbaW5pdGlhbFBvc2l0aW9uXSA6 IG1fcm93UG9zaXRpb25zW2luaXRpYWxQb3NpdGlvbl07Ci0gICAgTGF5b3V0VW5pdCBlbmQgPSBl bmRJc0F1dG8gPyAoaXNSb3dBeGlzID8gbG9naWNhbFdpZHRoKCkgOiBsb2dpY2FsSGVpZ2h0KCkp IDogKGlzUm93QXhpcyA/ICBtX2NvbHVtblBvc2l0aW9uc1tmaW5hbFBvc2l0aW9uXSA6IG1fcm93 UG9zaXRpb25zW2ZpbmFsUG9zaXRpb25dKTsKKyAgICBMYXlvdXRVbml0IHN0YXJ0ID0gc3RhcnRJ c0F1dG8gPyBMYXlvdXRVbml0KCkgOiBpc1Jvd0F4aXMgPyAgbV9jb2x1bW5Qb3NpdGlvbnNbc3Rh cnRMaW5lXSA6IG1fcm93UG9zaXRpb25zW3N0YXJ0TGluZV07CisgICAgTGF5b3V0VW5pdCBlbmQg PSBlbmRJc0F1dG8gPyAoaXNSb3dBeGlzID8gbG9naWNhbFdpZHRoKCkgOiBsb2dpY2FsSGVpZ2h0 KCkpIDogKGlzUm93QXhpcyA/ICBtX2NvbHVtblBvc2l0aW9uc1tlbmRMaW5lXSA6IG1fcm93UG9z aXRpb25zW2VuZExpbmVdKTsKIAogICAgIGJyZWFkdGggPSBlbmQgLSBzdGFydDsKIAo= 275020 2016-03-28 03:34:28 -0700 2016-03-28 04:22:46 -0700 Patch for landing bug-155788-20160328123430.patch text/plain 2166 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWYzNWY1MTgzMmEyNmYy MzU0NTZhZWQ5NWEyMzkyODIwNTU1MjI5ZS4uYTk0NTk2ZTEyMzBjM2I3Mjk5MWNhYjZmMTc3MTE4 OWQxMmU1ODIyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAzLTIzICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gUmVtb3ZlIHVubmVlZGVkIGxpbmVzIGluIG9mZnNldEFuZEJyZWFkdGhGb3JQb3NpdGlvbmVk Q2hpbGQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU1Nzg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2VyZ2lvIFZpbGxhciBTZW5pbi4KKworICAg ICAgICBKdXN0IHJlbW92ZSAyIGxpbmVzL3ZhcmlhYmxlcyB0aGF0IHdlcmUgbm90IG5lZWRlZCBh dCBhbGwgaW4KKyAgICAgICAgUmVuZGVyR3JpZDo6b2Zmc2V0QW5kQnJlYWR0aEZvclBvc2l0aW9u ZWRDaGlsZCgpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIG9mIGJlaGF2aW9y LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyR3JpZDo6b2Zmc2V0QW5kQnJlYWR0aEZvclBvc2l0aW9uZWRDaGlsZCk6CisKIDIw MTYtMDMtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFVzZSBSZWdpb24gaW5zdGVhZCBvZiBJbnRSZWN0IGluIFBhZ2VDbGllbnQgYW5kIFdl YlBhZ2VQcm94eSBzZXRWaWV3TmVlZHNEaXNwbGF5IG1ldGhvZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckdyaWQuY3BwCmluZGV4IDk5N2Y3YzFhYjRlMTJiMWExODY4Nzk2ZDFhOTBkNDY5 ZDAwZTJiZGUuLjhmMjc3NTQwZDRlNTA2OGFiYzM2Yjk2MTg3NzEyMjMwZjAxMWY3MDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKQEAgLTE1MTcsMTEgKzE1MTcsOCBA QCB2b2lkIFJlbmRlckdyaWQ6Om9mZnNldEFuZEJyZWFkdGhGb3JQb3NpdGlvbmVkQ2hpbGQoY29u c3QgUmVuZGVyQm94JiBjaGlsZCwgR3JpZAogICAgICAgICB8fCAoZW5kTGluZSA8IGZpcnN0RXhw bGljaXRMaW5lKQogICAgICAgICB8fCAoZW5kTGluZSA+IGxhc3RFeHBsaWNpdExpbmUpOwogCi0g ICAgdW5zaWduZWQgaW5pdGlhbFBvc2l0aW9uID0gc3RhcnRJc0F1dG8gPyAwIDogc3RhcnRMaW5l OwotICAgIHVuc2lnbmVkIGZpbmFsUG9zaXRpb24gPSBlbmRJc0F1dG8gPyBsYXN0RXhwbGljaXRM aW5lIDogZW5kTGluZTsKLQotICAgIExheW91dFVuaXQgc3RhcnQgPSBzdGFydElzQXV0byA/IExh eW91dFVuaXQoKSA6IGlzUm93QXhpcyA/ICBtX2NvbHVtblBvc2l0aW9uc1tpbml0aWFsUG9zaXRp b25dIDogbV9yb3dQb3NpdGlvbnNbaW5pdGlhbFBvc2l0aW9uXTsKLSAgICBMYXlvdXRVbml0IGVu ZCA9IGVuZElzQXV0byA/IChpc1Jvd0F4aXMgPyBsb2dpY2FsV2lkdGgoKSA6IGxvZ2ljYWxIZWln aHQoKSkgOiAoaXNSb3dBeGlzID8gIG1fY29sdW1uUG9zaXRpb25zW2ZpbmFsUG9zaXRpb25dIDog bV9yb3dQb3NpdGlvbnNbZmluYWxQb3NpdGlvbl0pOworICAgIExheW91dFVuaXQgc3RhcnQgPSBz dGFydElzQXV0byA/IExheW91dFVuaXQoKSA6IChpc1Jvd0F4aXMgPyAgbV9jb2x1bW5Qb3NpdGlv bnNbc3RhcnRMaW5lXSA6IG1fcm93UG9zaXRpb25zW3N0YXJ0TGluZV0pOworICAgIExheW91dFVu aXQgZW5kID0gZW5kSXNBdXRvID8gKGlzUm93QXhpcyA/IGxvZ2ljYWxXaWR0aCgpIDogbG9naWNh bEhlaWdodCgpKSA6IChpc1Jvd0F4aXMgPyAgbV9jb2x1bW5Qb3NpdGlvbnNbZW5kTGluZV0gOiBt X3Jvd1Bvc2l0aW9uc1tlbmRMaW5lXSk7CiAKICAgICBicmVhZHRoID0gZW5kIC0gc3RhcnQ7CiAK