155767 2016-03-22 13:47:20 -0700 Web Inspector: REGRESSION: Switching Timelines via Path Component does not work 2016-03-22 16:47:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1177108 0 joepeck 2016-03-22 13:47:20 -0700 * SUMMARY REGRESSION: Switching Timelines via Path Component does not work * STEPS TO REPRODUCE 1. Open inspector 2. Show Timeline tab 3. Select Network Timeline 4. Click "Network Requests" path component and select "Layout & Rendering" => Expected timeline to switch, instead nothing happened 1177109 1 webkit-bug-importer 2016-03-22 13:47:33 -0700 <rdar://problem/25298945> 1177110 2 274681 joepeck 2016-03-22 13:48:35 -0700 Created attachment 274681 [PATCH] Proposed Fix 1177198 3 274681 commit-queue 2016-03-22 16:47:14 -0700 Comment on attachment 274681 [PATCH] Proposed Fix Clearing flags on attachment: 274681 Committed r198563: <http://trac.webkit.org/changeset/198563> 1177199 4 commit-queue 2016-03-22 16:47:17 -0700 All reviewed patches have been landed. Closing bug. 274681 2016-03-22 13:48:35 -0700 2016-03-22 16:47:14 -0700 [PATCH] Proposed Fix switch-timelines.patch text/plain 2598 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMyYTNkYTMuLjY5NGUzZGUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTAzLTIyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVT U0lPTjogU3dpdGNoaW5nIFRpbWVsaW5lcyB2aWEgUGF0aCBDb21wb25lbnQgZG9lcyBub3Qgd29y aworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NzY3 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNTI5ODk0NT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxp bmVSZWNvcmRpbmdDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGlu ZVJlY29yZGluZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fdGltZWxpbmVQYXRoQ29tcG9uZW50U2Vs ZWN0ZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZp ZXcucHJvdG90eXBlLl9pbnN0cnVtZW50QWRkZWQpOgorCisyMDE2LTAzLTIyICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogU3dp dGNoaW5nIEF3YXkgYW5kIEJhY2sgdG8gVGltZWxpbmVzIFRhYiBtYXkgc2VsZWN0IGEgZGlmZmVy ZW50IFRpbWVsaW5lCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTU3NDIKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI1Mjg0MzMwPgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNv cmRpbmdDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKaW5kZXggNjRlYjdjOS4uZDFl YTQ5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3Lmpz CkBAIC0zNzUsOCArMzc1LDEwIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZGluZ0NvbnRl bnRWaWV3ID0gY2xhc3MgVGltZWxpbmVSZWNvcmRpbmdDb250ZW50VmlldyBlCiAgICAgICAgIHRo aXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5Db250ZW50Vmlldy5FdmVu dC5OYXZpZ2F0aW9uSXRlbXNEaWRDaGFuZ2UpOwogICAgIH0KIAotICAgIF9wYXRoQ29tcG9uZW50 U2VsZWN0ZWQoZXZlbnQpCisgICAgX3RpbWVsaW5lUGF0aENvbXBvbmVudFNlbGVjdGVkKGV2ZW50 KQogICAgIHsKKyAgICAgICAgbGV0IHNlbGVjdGVkVGltZWxpbmUgPSBldmVudC5kYXRhLnBhdGhD b21wb25lbnQucmVwcmVzZW50ZWRPYmplY3Q7CisgICAgICAgIHRoaXMuc2hvd1RpbWVsaW5lVmll d0ZvclRpbWVsaW5lKHNlbGVjdGVkVGltZWxpbmUpOwogICAgIH0KIAogICAgIF90aW1lUmFuZ2VQ YXRoQ29tcG9uZW50U2VsZWN0ZWQoZXZlbnQpCkBAIC02MDEsNyArNjAzLDcgQEAgV2ViSW5zcGVj dG9yLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcgPSBjbGFzcyBUaW1lbGluZVJlY29yZGlu Z0NvbnRlbnRWaWV3IGUKICAgICAgICAgbGV0IGRpc3BsYXlOYW1lID0gV2ViSW5zcGVjdG9yLlRp bWVsaW5lVGFiQ29udGVudFZpZXcuZGlzcGxheU5hbWVGb3JUaW1lbGluZSh0aW1lbGluZSk7CiAg ICAgICAgIGxldCBpY29uQ2xhc3NOYW1lID0gV2ViSW5zcGVjdG9yLlRpbWVsaW5lVGFiQ29udGVu dFZpZXcuaWNvbkNsYXNzTmFtZUZvclRpbWVsaW5lKHRpbWVsaW5lKTsKICAgICAgICAgbGV0IHBh dGhDb21wb25lbnQgPSBuZXcgV2ViSW5zcGVjdG9yLkhpZXJhcmNoaWNhbFBhdGhDb21wb25lbnQo ZGlzcGxheU5hbWUsIGljb25DbGFzc05hbWUsIHRpbWVsaW5lKTsKLSAgICAgICAgcGF0aENvbXBv bmVudC5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5IaWVyYXJjaGljYWxQYXRoQ29tcG9u ZW50LkV2ZW50LlNpYmxpbmdXYXNTZWxlY3RlZCwgdGhpcy5fcGF0aENvbXBvbmVudFNlbGVjdGVk LCB0aGlzKTsKKyAgICAgICAgcGF0aENvbXBvbmVudC5hZGRFdmVudExpc3RlbmVyKFdlYkluc3Bl Y3Rvci5IaWVyYXJjaGljYWxQYXRoQ29tcG9uZW50LkV2ZW50LlNpYmxpbmdXYXNTZWxlY3RlZCwg dGhpcy5fdGltZWxpbmVQYXRoQ29tcG9uZW50U2VsZWN0ZWQsIHRoaXMpOwogICAgICAgICB0aGlz Ll9wYXRoQ29tcG9uZW50TWFwLnNldCh0aW1lbGluZSwgcGF0aENvbXBvbmVudCk7CiAKICAgICAg ICAgdGhpcy5fdGltZWxpbmVDb3VudENoYW5nZWQoKTsK