155763 2016-03-22 12:11:04 -0700 Web Inspector: REGRESSION: Shift + Click on record button should create a new recording 2016-03-22 14:28:49 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1177074 0 joepeck 2016-03-22 12:11:04 -0700 * SUMMARY REGRESSION: Shift + Click on record button should create a new recording. * STEPS TO REPRODUCE 1. Inspect this page 2. Start + stop a Timeline recording 3. Shift + Click the record button => Expected a new recording, instead it continued the current recording 1177075 1 webkit-bug-importer 2016-03-22 12:11:35 -0700 <rdar://problem/25296624> 1177078 2 274673 joepeck 2016-03-22 12:13:13 -0700 Created attachment 274673 [PATCH] Proposed Fix 1177085 3 274673 timothy 2016-03-22 12:26:31 -0700 Comment on attachment 274673 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=274673&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:398 > + this._toggleRecording(domEvent.shiftKey); window.event.shiftKey and you can get rid of the userData 1177097 4 274677 joepeck 2016-03-22 13:18:24 -0700 Created attachment 274677 [PATCH] Proposed Fix 1177131 5 274677 commit-queue 2016-03-22 14:28:45 -0700 Comment on attachment 274677 [PATCH] Proposed Fix Clearing flags on attachment: 274677 Committed r198552: <http://trac.webkit.org/changeset/198552> 1177132 6 commit-queue 2016-03-22 14:28:49 -0700 All reviewed patches have been landed. Closing bug. 274673 2016-03-22 12:13:13 -0700 2016-03-22 13:18:24 -0700 [PATCH] Proposed Fix shift-click.patch text/plain 2360 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk4MjlkOGIuLjAwYWVmYTEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAzLTIyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVT U0lPTjogU2hpZnQgKyBDbGljayBvbiByZWNvcmQgYnV0dG9uIHNob3VsZCBjcmVhdGUgYSBuZXcg cmVjb3JkaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTU3NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQnV0dG9uTmF2aWdhdGlvbkl0ZW0uanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuQnV0dG9uTmF2aWdhdGlvbkl0ZW0ucHJvdG90eXBlLl9tb3VzZUNsaWNr ZWQpOgorICAgICAgICBJbmNsdWRlIHRoZSBET00gRXZlbnQgaW4gdGhlIFdlYkluc3BlY3RvciBF dmVudC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVUYWJDb250ZW50 Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVRhYkNvbnRlbnRWaWV3LnBy b3RvdHlwZS5fcmVjb3JkQnV0dG9uQ2xpY2tlZCk6CisgICAgICAgIFVzZSB0aGUgc2hpZnRLZXkg ZnJvbSB0aGUgRE9NIEV2ZW50LgorCiAyMDE2LTAzLTIxICBNYXR0IEJha2VyICA8bWF0dGJha2Vy QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZXcgaWNvbiBmb3IgSGVhcCBB bGxvY2F0aW9ucyB0aW1lbGluZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvQnV0dG9uTmF2aWdhdGlvbkl0ZW0uanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9CdXR0b25OYXZpZ2F0aW9uSXRlbS5qcwppbmRl eCBmZGQwNjM2Li41ZDdjYzM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9CdXR0b25OYXZpZ2F0aW9uSXRlbS5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9CdXR0b25OYXZpZ2F0aW9uSXRlbS5qcwpA QCAtMTI4LDcgKzEyOCw3IEBAIFdlYkluc3BlY3Rvci5CdXR0b25OYXZpZ2F0aW9uSXRlbSA9IGNs YXNzIEJ1dHRvbk5hdmlnYXRpb25JdGVtIGV4dGVuZHMgV2ViSW5zcGVjCiAgICAgewogICAgICAg ICBpZiAoIXRoaXMuZW5hYmxlZCkKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgdGhpcy5k aXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkJ1dHRvbk5hdmlnYXRpb25JdGVt LkV2ZW50LkNsaWNrZWQpOworICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhX ZWJJbnNwZWN0b3IuQnV0dG9uTmF2aWdhdGlvbkl0ZW0uRXZlbnQuQ2xpY2tlZCwge2V2ZW50fSk7 CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVUYWJDb250ZW50Vmlldy5qcwppbmRleCAz YjZmZmRjLi5lNmVlM2JlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVGFiQ29udGVudFZpZXcuanMK QEAgLTM5Myw4ICszOTMsOSBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVUYWJDb250ZW50VmlldyA9 IGNsYXNzIFRpbWVsaW5lVGFiQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbgogCiAgICAgX3JlY29y ZEJ1dHRvbkNsaWNrZWQoZXZlbnQpCiAgICAgeworICAgICAgICBsZXQgZG9tRXZlbnQgPSBldmVu dC5kYXRhLmV2ZW50OwogICAgICAgICB0aGlzLl9yZWNvcmRCdXR0b24udG9nZ2xlZCA9ICFXZWJJ bnNwZWN0b3IudGltZWxpbmVNYW5hZ2VyLmlzQ2FwdHVyaW5nKCk7Ci0gICAgICAgIHRoaXMuX3Rv Z2dsZVJlY29yZGluZyhldmVudC5zaGlmdEtleSk7CisgICAgICAgIHRoaXMuX3RvZ2dsZVJlY29y ZGluZyhkb21FdmVudC5zaGlmdEtleSk7CiAgICAgfQogCiAgICAgX3JlY29yZGluZ3NUcmVlU2Vs ZWN0aW9uRGlkQ2hhbmdlKGV2ZW50KQo= 274677 2016-03-22 13:18:24 -0700 2016-03-22 14:28:45 -0700 [PATCH] Proposed Fix new.patch text/plain 1548 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk4MjlkOGIuLmI0NDU4N2YgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAzLTIyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVT U0lPTjogU2hpZnQgKyBDbGljayBvbiByZWNvcmQgYnV0dG9uIHNob3VsZCBjcmVhdGUgYSBuZXcg cmVjb3JkaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTU3NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVUYWJDb250ZW50Vmlldy5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVRhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5fcmVjb3Jk QnV0dG9uQ2xpY2tlZCk6CisgICAgICAgIFVzZSB0aGUgc2hpZnRLZXkgZnJvbSB0aGUgRE9NIEV2 ZW50LgorCiAyMDE2LTAzLTIxICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZXcgaWNvbiBmb3IgSGVhcCBBbGxvY2F0aW9ucyB0aW1l bGluZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGltZWxpbmVUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVGFiQ29udGVudFZpZXcuanMKaW5kZXggM2I2ZmZkYy4u NDI3MWQ2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGltZWxpbmVUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRWaWV3LmpzCkBAIC0zOTMs OCArMzkzLDkgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lVGFiQ29udGVudFZpZXcgPSBjbGFzcyBU aW1lbGluZVRhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW4KIAogICAgIF9yZWNvcmRCdXR0b25D bGlja2VkKGV2ZW50KQogICAgIHsKKyAgICAgICAgbGV0IHNob3VsZENyZWF0ZU5ld1JlY29yZGlu ZyA9IHdpbmRvdy5ldmVudCA/IHdpbmRvdy5ldmVudC5zaGlmdEtleSA6IGZhbHNlOwogICAgICAg ICB0aGlzLl9yZWNvcmRCdXR0b24udG9nZ2xlZCA9ICFXZWJJbnNwZWN0b3IudGltZWxpbmVNYW5h Z2VyLmlzQ2FwdHVyaW5nKCk7Ci0gICAgICAgIHRoaXMuX3RvZ2dsZVJlY29yZGluZyhldmVudC5z aGlmdEtleSk7CisgICAgICAgIHRoaXMuX3RvZ2dsZVJlY29yZGluZyhzaG91bGRDcmVhdGVOZXdS ZWNvcmRpbmcpOwogICAgIH0KIAogICAgIF9yZWNvcmRpbmdzVHJlZVNlbGVjdGlvbkRpZENoYW5n ZShldmVudCkK