155758 2016-03-22 10:58:41 -0700 Add null check in CachedResourceLoader::determineRevalidationPolicy 2016-03-22 12:12:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen webkit-unassigned cdumez commit-queue japhet oldest_to_newest 1177041 0 achristensen 2016-03-22 10:58:41 -0700 Sometimes we are crashing in CachedResourceLoader::determineRevalidationPolicy after dereferencing a null pointer. There is only one uncheck pointer usage in that function. Easy fix. 1177044 1 274664 achristensen 2016-03-22 11:01:11 -0700 Created attachment 274664 patch 1177076 2 274664 commit-queue 2016-03-22 12:12:35 -0700 Comment on attachment 274664 patch Clearing flags on attachment: 274664 Committed r198542: <http://trac.webkit.org/changeset/198542> 1177077 3 commit-queue 2016-03-22 12:12:42 -0700 All reviewed patches have been landed. Closing bug. 274664 2016-03-22 11:01:11 -0700 2016-03-22 12:12:35 -0700 patch patch text/plain 1941 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODUzNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAzLTIyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIG51bGwg Y2hlY2sgaW4gQ2FjaGVkUmVzb3VyY2VMb2FkZXI6OmRldGVybWluZVJldmFsaWRhdGlvblBvbGlj eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NzU4 CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI1MTA4NDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VM b2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVkUmVzb3VyY2VMb2FkZXI6OmZyYW1l KToKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNlTG9hZGVyOjpkZXRlcm1pbmVSZXZh bGlkYXRpb25Qb2xpY3kpOgorICAgICAgICBOdWxsLWNoZWNrIGZyYW1lKCkgYmVmb3JlIGRlcmVm ZXJlbmNpbmcgaXQuCisKIDIwMTYtMDMtMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdlYkluc3BlY3RvciBicm9rZW4gYWZ0ZXIg cjE5NzYyMApJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNl TG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2Fj aGVkUmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiAxOTg0OTUpCisrKyBTb3VyY2UvV2ViQ29y ZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xNjIsNyArMTYyLDcgQEAKIAogRnJhbWUqIENhY2hlZFJlc291cmNlTG9hZGVyOjpmcmFtZSgp IGNvbnN0CiB7Ci0gICAgcmV0dXJuIG1fZG9jdW1lbnRMb2FkZXIgPyBtX2RvY3VtZW50TG9hZGVy LT5mcmFtZSgpIDogMDsKKyAgICByZXR1cm4gbV9kb2N1bWVudExvYWRlciA/IG1fZG9jdW1lbnRM b2FkZXItPmZyYW1lKCkgOiBudWxscHRyOwogfQogCiBTZXNzaW9uSUQgQ2FjaGVkUmVzb3VyY2VM b2FkZXI6OnNlc3Npb25JRCgpIGNvbnN0CkBAIC03NTUsNyArNzU1LDcgQEAKIAogICAgIC8vIEZJ WE1FOiBXZSBzaG91bGQgdXNlIHRoZSBzYW1lIGNhY2hlIHBvbGljeSBmb3IgYWxsIHJlc291cmNl IHR5cGVzLiBUaGUgcmF3IHJlc291cmNlIHBvbGljeSBpcyBvdmVybHkgc3RyaWN0CiAgICAgLy8g ICAgICAgIHdoaWxlIHRoZSBub3JtYWwgc3VicmVzb3VyY2UgcG9saWN5IGlzIHRvbyBsb29zZS4K LSAgICBpZiAoZXhpc3RpbmdSZXNvdXJjZS0+aXNNYWluT3JNZWRpYU9yUmF3UmVzb3VyY2UoKSkg eworICAgIGlmIChleGlzdGluZ1Jlc291cmNlLT5pc01haW5Pck1lZGlhT3JSYXdSZXNvdXJjZSgp ICYmIGZyYW1lKCkpIHsKICAgICAgICAgYm9vbCBzdHJpY3RQb2xpY3lEaXNhYmxlZCA9IGZyYW1l KCktPmxvYWRlcigpLmlzU3RyaWN0UmF3UmVzb3VyY2VWYWxpZGF0aW9uUG9saWN5RGlzYWJsZWRG b3JUZXN0aW5nKCk7CiAgICAgICAgIGJvb2wgY2FuUmV1c2VSYXdSZXNvdXJjZSA9IHN0cmljdFBv bGljeURpc2FibGVkIHx8IGRvd25jYXN0PENhY2hlZFJhd1Jlc291cmNlPigqZXhpc3RpbmdSZXNv dXJjZSkuY2FuUmV1c2UocmVxdWVzdCk7CiAgICAgICAgIGlmICghY2FuUmV1c2VSYXdSZXNvdXJj ZSkK