155752 2016-03-22 10:11:31 -0700 Web Inspector: String double quoting in the console and elsewhere needs to escape backslash too 2016-03-23 08:55:18 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1177012 0 timothy 2016-03-22 10:11:31 -0700 We need to escape backslash to be correct. 1177013 1 webkit-bug-importer 2016-03-22 10:12:03 -0700 <rdar://problem/25293141> 1177014 2 274658 timothy 2016-03-22 10:15:13 -0700 Created attachment 274658 Patch 1177112 3 274658 joepeck 2016-03-22 13:52:10 -0700 Comment on attachment 274658 Patch Nice. Should we just use JSON.stringify(str)? We could also test this adding a LayoutTests/inspector/unit-tests/utilities.html. 1177176 4 274658 commit-queue 2016-03-22 16:03:09 -0700 Comment on attachment 274658 Patch Rejecting attachment 274658 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 274658, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/1022960 1177208 5 274704 timothy 2016-03-22 17:00:10 -0700 Created attachment 274704 Patch for Landing 1177220 6 274704 commit-queue 2016-03-22 17:20:20 -0700 Comment on attachment 274704 Patch for Landing Rejecting attachment 274704 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 274704, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: '/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Parsed 3 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog patch: **** unexpected end of file in patch patching file Source/WebInspectorUI/UserInterface/Base/Utilities.js patching file Source/WebInspectorUI/UserInterface/Views/FormattedValue.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/1023235 1177361 7 timothy 2016-03-23 08:55:18 -0700 https://trac.webkit.org/r198585 274658 2016-03-22 10:15:13 -0700 2016-03-22 17:00:10 -0700 Patch bug-155752-20160322101514.patch text/plain 2794 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4MzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4 YWRhMGJlZjY1ODZjZGM4ODQxZTI2Y2RmMTQ0ODY5NTI2ODNkNTNmLi5hYThmM2EyYjVmMjRiZGUx ZjAxNDY0MGI5NzlhNzgzMzg5MmExNGJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOSBAQAorMjAxNi0wMy0yMiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU3RyaW5nIGRvdWJsZSBxdW90aW5nIGluIHRo ZSBjb25zb2xlIGFuZCBlbHNld2hlcmUgbmVlZHMgdG8gZXNjYXBlIGJhY2tzbGFzaCB0b28KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NzUyCisg ICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI1MjkzMTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpz OgorICAgICAgICAoZG91YmxlUXVvdGVkU3RyaW5nKTogRXNjYXBlIGJhY2tzbGFzaGVzIHRvby4K KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0Zvcm1hdHRlZFZhbHVlLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkZvcm1hdHRlZFZhbHVlLmNyZWF0ZUxpbmtpZmllZEVsZW1lbnRTdHJp bmcpOiBEaXR0by4KKworMjAxNi0wMy0yMiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBs ZS5jb20+CisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIChPT1BTISkuCisgICAg ICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanM6 CisgICAgICAgIChkb3VibGVRdW90ZWRTdHJpbmcpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvRm9ybWF0dGVkVmFsdWUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRm9ybWF0dGVk VmFsdWUuY3JlYXRlTGlua2lmaWVkRWxlbWVudFN0cmluZyk6CisKIDIwMTYtMDMtMTQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBTaG93IHBhdGggZnJvbSByb290IHRvIGluc3RhbmNlcyBpbiB0aGUgSGVhcCBTbmFwc2hvdCBj b250ZW50IHZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0Jhc2UvVXRpbGl0aWVzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQmFzZS9VdGlsaXRpZXMuanMKaW5kZXggMjBiZGJiZGNiNWFhZjYyMGM5MGY2MDM0NzcwNWM0 ZTAwMTkxM2ZmMi4uMTk5NTRlMmU0MjQ0YTdmMDIyYTJhYmVmNTllOTBiNWMwYjhjOGQwYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRp ZXMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGls aXRpZXMuanMKQEAgLTExOTgsNyArMTE5OCw3IEBAIGZ1bmN0aW9uIGlzRnVuY3Rpb25TdHJpbmdO YXRpdmVDb2RlKHN0cikKIAogZnVuY3Rpb24gZG91YmxlUXVvdGVkU3RyaW5nKHN0cikKIHsKLSAg ICByZXR1cm4gIlwiIiArIHN0ci5yZXBsYWNlKC8iL2csICJcXFwiIikgKyAiXCIiOworICAgIHJl dHVybiAiXCIiICsgc3RyLnJlcGxhY2UoL1xcL2csICJcXFxcIikucmVwbGFjZSgvIi9nLCAiXFxc IiIpICsgIlwiIjsKIH0KIAogZnVuY3Rpb24gaW5zZXJ0aW9uSW5kZXhGb3JPYmplY3RJbkxpc3RT b3J0ZWRCeUZ1bmN0aW9uKG9iamVjdCwgbGlzdCwgY29tcGFyYXRvciwgaW5zZXJ0aW9uSW5kZXhB ZnRlcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0Zvcm1hdHRlZFZhbHVlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvRm9ybWF0dGVkVmFsdWUuanMKaW5kZXggYzAzMjlkMDc4MTQwYjVlYTg5MjgwMWQy YmJjZTE1YTEzNzhmNjUzNi4uNWUxZmZhMDM2MzQ4OWIyMjA1ODYxMTc4MWI1YzVhZDlkODEwOTUw NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv Rm9ybWF0dGVkVmFsdWUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvRm9ybWF0dGVkVmFsdWUuanMKQEAgLTM5LDcgKzM5LDcgQEAgV2ViSW5zcGVjdG9y LkZvcm1hdHRlZFZhbHVlLmNyZWF0ZUxpbmtpZmllZEVsZW1lbnRTdHJpbmcgPSBmdW5jdGlvbihz dHJpbmcpCiB7CiAgICAgdmFyIHNwYW4gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzcGFuIik7 CiAgICAgc3Bhbi5jbGFzc05hbWUgPSAiZm9ybWF0dGVkLXN0cmluZyI7Ci0gICAgc3Bhbi5hcHBl bmQoIlwiIiwgV2ViSW5zcGVjdG9yLmxpbmtpZnlTdHJpbmdBc0ZyYWdtZW50KHN0cmluZy5yZXBs YWNlKC8iL2csICJcXFwiIikpLCAiXCIiKTsKKyAgICBzcGFuLmFwcGVuZCgiXCIiLCBXZWJJbnNw ZWN0b3IubGlua2lmeVN0cmluZ0FzRnJhZ21lbnQoc3RyaW5nLnJlcGxhY2UoL1xcL2csICJcXFxc IikucmVwbGFjZSgvIi9nLCAiXFxcIiIpKSwgIlwiIik7CiAgICAgcmV0dXJuIHNwYW47CiB9Owog Cg== 274704 2016-03-22 17:00:10 -0700 2016-03-22 17:20:20 -0700 Patch for Landing bug-155752-20160322101514.patch text/plain 2428 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4MzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4 YWRhMGJlZjY1ODZjZGM4ODQxZTI2Y2RmMTQ0ODY5NTI2ODNkNTNmLi5hYThmM2EyYjVmMjRiZGUx ZjAxNDY0MGI5NzlhNzgzMzg5MmExNGJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOSBAQAorMjAxNi0wMy0yMiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU3RyaW5nIGRvdWJsZSBxdW90aW5nIGluIHRo ZSBjb25zb2xlIGFuZCBlbHNld2hlcmUgbmVlZHMgdG8gZXNjYXBlIGJhY2tzbGFzaCB0b28KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NzUyCisg ICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI1MjkzMTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9z ZXBoIFBlY29yYXJvLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5q czoKKyAgICAgICAgKGRvdWJsZVF1b3RlZFN0cmluZyk6IEVzY2FwZSBiYWNrc2xhc2hlcyB0b28u CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Gb3JtYXR0ZWRWYWx1ZS5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5Gb3JtYXR0ZWRWYWx1ZS5jcmVhdGVMaW5raWZpZWRFbGVtZW50U3Ry aW5nKTogRGl0dG8uCisKIDIwMTYtMDMtMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTaG93IHBhdGggZnJvbSByb290IHRv IGluc3RhbmNlcyBpbiB0aGUgSGVhcCBTbmFwc2hvdCBjb250ZW50IHZpZXcKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMKaW5k ZXggMjBiZGJiZGNiNWFhZjYyMGM5MGY2MDM0NzcwNWM0ZTAwMTkxM2ZmMi4uMTk5NTRlMmU0MjQ0 YTdmMDIyYTJhYmVmNTllOTBiNWMwYjhjOGQwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMKQEAgLTExOTgsNyArMTE5 OCw3IEBAIGZ1bmN0aW9uIGlzRnVuY3Rpb25TdHJpbmdOYXRpdmVDb2RlKHN0cikKIAogZnVuY3Rp b24gZG91YmxlUXVvdGVkU3RyaW5nKHN0cikKIHsKLSAgICByZXR1cm4gIlwiIiArIHN0ci5yZXBs YWNlKC8iL2csICJcXFwiIikgKyAiXCIiOworICAgIHJldHVybiAiXCIiICsgc3RyLnJlcGxhY2Uo L1xcL2csICJcXFxcIikucmVwbGFjZSgvIi9nLCAiXFxcIiIpICsgIlwiIjsKIH0KIAogZnVuY3Rp b24gaW5zZXJ0aW9uSW5kZXhGb3JPYmplY3RJbkxpc3RTb3J0ZWRCeUZ1bmN0aW9uKG9iamVjdCwg bGlzdCwgY29tcGFyYXRvciwgaW5zZXJ0aW9uSW5kZXhBZnRlcikKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Zvcm1hdHRlZFZhbHVlLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRm9ybWF0dGVkVmFsdWUu anMKaW5kZXggYzAzMjlkMDc4MTQwYjVlYTg5MjgwMWQyYmJjZTE1YTEzNzhmNjUzNi4uNWUxZmZh MDM2MzQ4OWIyMjA1ODYxMTc4MWI1YzVhZDlkODEwOTUwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRm9ybWF0dGVkVmFsdWUuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRm9ybWF0dGVkVmFsdWUu anMKQEAgLTM5LDcgKzM5LDcgQEAgV2ViSW5zcGVjdG9yLkZvcm1hdHRlZFZhbHVlLmNyZWF0ZUxp bmtpZmllZEVsZW1lbnRTdHJpbmcgPSBmdW5jdGlvbihzdHJpbmcpCiB7CiAgICAgdmFyIHNwYW4g PSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzcGFuIik7CiAgICAgc3Bhbi5jbGFzc05hbWUgPSAi Zm9ybWF0dGVkLXN0cmluZyI7Ci0gICAgc3Bhbi5hcHBlbmQoIlwiIiwgV2ViSW5zcGVjdG9yLmxp bmtpZnlTdHJpbmdBc0ZyYWdtZW50KHN0cmluZy5yZXBsYWNlKC8iL2csICJcXFwiIikpLCAiXCIi KTsKKyAgICBzcGFuLmFwcGVuZCgiXCIiLCBXZWJJbnNwZWN0b3IubGlua2lmeVN0cmluZ0FzRnJh Z21lbnQoc3RyaW5nLnJlcGxhY2UoL1xcL2csICJcXFxcIikucmVwbGFjZSgvIi9nLCAiXFxcIiIp KSwgIlwiIik7CiAgICAgcmV0dXJuIHNwYW47CiB9OwogCg==