155730 2016-03-21 13:03:16 -0700 putByIndexBeyondVectorLengthWithoutAttributes should not crash if it can't ensureLength 2016-03-25 11:07:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1176822 0 keith_miller 2016-03-21 13:03:16 -0700 putByIndexBeyondVectorLength should not crash if it cannot increase the size of its butterfly 1177770 1 274856 keith_miller 2016-03-24 14:45:35 -0700 Created attachment 274856 Patch 1177789 2 274856 saam 2016-03-24 15:31:39 -0700 Comment on attachment 274856 Patch can you add a test? 1177995 3 keith_miller 2016-03-25 10:16:13 -0700 > can you add a test? I don't have a test this is just a fix to what I suspect is the cause of on of our top crashers. We hit the RELEASE_ASSERT in putByIndexBeyondVectorLengthWithoutAttributes. The only way I see to hit that assert is to fail on the reallocation of the butterfly. 1177996 4 keith_miller 2016-03-25 10:16:46 -0700 <rdar://problem/22570509> 1178024 5 274856 commit-queue 2016-03-25 11:07:38 -0700 Comment on attachment 274856 Patch Clearing flags on attachment: 274856 Committed r198676: <http://trac.webkit.org/changeset/198676> 1178025 6 commit-queue 2016-03-25 11:07:42 -0700 All reviewed patches have been landed. Closing bug. 274856 2016-03-24 14:45:35 -0700 2016-03-25 11:07:38 -0700 Patch bug-155730-20160324144537.patch text/plain 6681 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 ZTk2ZjI3ODc0YWRjNjNlMDZkMzk3MzdjYzlkMDQ1ZDQwOTBlZThjLi5lOWU2YzM1YmYxNjczZmNl M2U1NzMyNGRhNTA2OTMxMzZhOWM2MDc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNi0wMy0yNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBwdXRCeUluZGV4QmV5b25kVmVjdG9yTGVuZ3RoV2l0aG91dEF0dHJp YnV0ZXMgc2hvdWxkIG5vdCBjcmFzaCBpZiBpdCBjYW4ndCBlbnN1cmVMZW5ndGgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTczMAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMg ZW5zdXJlTGVuZ3RoIHJldHVybiBhIGJvb2xlYW4gaW5kaWNhdGluZyBpZiBpdCB3YXMgYWJsZSB0 byBzZXQgdGhlIGxlbmd0aC4KKyAgICAgICAgZW5zdXJlTGVuZ3RoIGFsc28gbm8gbG9uZ2VyIHNl dHMgdGhlIGJ1dHRlcmZseSB0byBudWxsIGlmIHRoZSBhbGxvY2F0aW9uIG9mIHRoZSBidXR0ZXJm bHkKKyAgICAgICAgZmFpbHMuIEFsbCBvZiBlbnN1cmVMZW5ndGhzIGNhbGxlcnMgaW5jbHVkaW5n IHB1dEJ5SW5kZXhCZXlvbmRWZWN0b3JMZW5ndGhXaXRob3V0QXR0cmlidXRlcworICAgICAgICBo YXZlIGJlZW4gYWRhcHRlZCB0byB0aHJvdyBhbiBvdXQgb2YgbWVtb3J5IGVycm9yIGlmIGVuc3Vy ZUxlbmd0aCBmYWlscy4KKworICAgICAgICAqIHJ1bnRpbWUvSlNBcnJheS5jcHA6CisgICAgICAg IChKU0M6OkpTQXJyYXk6OnNldExlbmd0aCk6CisgICAgICAgIChKU0M6OkpTQXJyYXk6OnVuc2hp ZnRDb3VudFdpdGhBbnlJbmRleGluZ1R5cGUpOgorICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3Qu Y3BwOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6cHV0QnlJbmRleEJleW9uZFZlY3Rvckxlbmd0 aFdpdGhvdXRBdHRyaWJ1dGVzKToKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6OmVuc3VyZUxlbmd0 aFNsb3cpOgorICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuaDoKKyAgICAgICAgKEpTQzo6SlNP YmplY3Q6OmVuc3VyZUxlbmd0aCk6CisKIDIwMTYtMDMtMTggIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIHNwZWN1bGF0aXZlIGNsb29w IGJ1aWxkZml4IGFmdGVyIHIxOTgzNjQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0FycmF5LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT QXJyYXkuY3BwCmluZGV4IDQ3Y2E1NjY1M2YxN2I5OGRiY2ZkZDFlN2MzMTkxN2ZhZDM1MDkzODku LmFmYTA2MmY5MDNiNjA2ZTViN2I1OGJhM2NiZTBmNTNhNDZjZGIwYmIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCkBAIC00MjEsNyArNDIxLDEwIEBAIGJvb2wg SlNBcnJheTo6c2V0TGVuZ3RoKEV4ZWNTdGF0ZSogZXhlYywgdW5zaWduZWQgbmV3TGVuZ3RoLCBi b29sIHRocm93RXhjZXB0aW9uCiAgICAgICAgICAgICAgICAgZW5zdXJlQXJyYXlTdG9yYWdlKGV4 ZWMtPnZtKCkpKTsKICAgICAgICAgfQogICAgICAgICBpZiAobmV3TGVuZ3RoID4gYnV0dGVyZmx5 LT5wdWJsaWNMZW5ndGgoKSkgewotICAgICAgICAgICAgZW5zdXJlTGVuZ3RoKGV4ZWMtPnZtKCks IG5ld0xlbmd0aCk7CisgICAgICAgICAgICBpZiAoIWVuc3VyZUxlbmd0aChleGVjLT52bSgpLCBu ZXdMZW5ndGgpKSB7CisgICAgICAgICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMp OworICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgIH0KICAgICAgICAg ICAgIHJldHVybiB0cnVlOwogICAgICAgICB9CiAKQEAgLTEwMTQsNyArMTAxNywxMCBAQCBib29s IEpTQXJyYXk6OnVuc2hpZnRDb3VudFdpdGhBbnlJbmRleGluZ1R5cGUoRXhlY1N0YXRlKiBleGVj LCB1bnNpZ25lZCBzdGFydEluZAogICAgICAgICBpZiAob2xkTGVuZ3RoIC0gc3RhcnRJbmRleCA+ PSBNSU5fU1BBUlNFX0FSUkFZX0lOREVYKQogICAgICAgICAgICAgcmV0dXJuIHVuc2hpZnRDb3Vu dFdpdGhBcnJheVN0b3JhZ2UoZXhlYywgc3RhcnRJbmRleCwgY291bnQsIGVuc3VyZUFycmF5U3Rv cmFnZShleGVjLT52bSgpKSk7CiAgICAgICAgIAotICAgICAgICBlbnN1cmVMZW5ndGgoZXhlYy0+ dm0oKSwgb2xkTGVuZ3RoICsgY291bnQpOworICAgICAgICBpZiAoIWVuc3VyZUxlbmd0aChleGVj LT52bSgpLCBvbGRMZW5ndGggKyBjb3VudCkpIHsKKyAgICAgICAgICAgIHRocm93T3V0T2ZNZW1v cnlFcnJvcihleGVjKTsKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgfQogICAg ICAgICBidXR0ZXJmbHkgPSBtX2J1dHRlcmZseS5nZXQoKTsKIAogICAgICAgICAvLyBXZSBoYXZl IHRvIGNoZWNrIGZvciBob2xlcyBiZWZvcmUgd2Ugc3RhcnQgbW92aW5nIHRoaW5ncyBhcm91bmQg c28gdGhhdCB3ZSBkb24ndCBnZXQgaGFsZndheSAKQEAgLTEwNDcsNyArMTA1MywxMCBAQCBib29s IEpTQXJyYXk6OnVuc2hpZnRDb3VudFdpdGhBbnlJbmRleGluZ1R5cGUoRXhlY1N0YXRlKiBleGVj LCB1bnNpZ25lZCBzdGFydEluZAogICAgICAgICBpZiAob2xkTGVuZ3RoIC0gc3RhcnRJbmRleCA+ PSBNSU5fU1BBUlNFX0FSUkFZX0lOREVYKQogICAgICAgICAgICAgcmV0dXJuIHVuc2hpZnRDb3Vu dFdpdGhBcnJheVN0b3JhZ2UoZXhlYywgc3RhcnRJbmRleCwgY291bnQsIGVuc3VyZUFycmF5U3Rv cmFnZShleGVjLT52bSgpKSk7CiAgICAgICAgIAotICAgICAgICBlbnN1cmVMZW5ndGgoZXhlYy0+ dm0oKSwgb2xkTGVuZ3RoICsgY291bnQpOworICAgICAgICBpZiAoIWVuc3VyZUxlbmd0aChleGVj LT52bSgpLCBvbGRMZW5ndGggKyBjb3VudCkpIHsKKyAgICAgICAgICAgIHRocm93T3V0T2ZNZW1v cnlFcnJvcihleGVjKTsKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgfQogICAg ICAgICBidXR0ZXJmbHkgPSBtX2J1dHRlcmZseS5nZXQoKTsKICAgICAgICAgCiAgICAgICAgIC8v IFdlIGhhdmUgdG8gY2hlY2sgZm9yIGhvbGVzIGJlZm9yZSB3ZSBzdGFydCBtb3ZpbmcgdGhpbmdz IGFyb3VuZCBzbyB0aGF0IHdlIGRvbid0IGdldCBoYWxmd2F5IApkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCmluZGV4IDU2ZDdmMWJmMmI2NDA4NTAwMjMxMjI0OGI3 YjI4MGUwMTUwNDdhODEuLjIwMDg2YzIxNmVkZjZjYTYxMjhmNzg3NGRiMzIxNjcwZDQyNjEyMzcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKQEAgLTIyMzUs NyArMjIzNSwxMCBAQCBib29sIEpTT2JqZWN0OjpwdXRCeUluZGV4QmV5b25kVmVjdG9yTGVuZ3Ro V2l0aG91dEF0dHJpYnV0ZXMoRXhlY1N0YXRlKiBleGVjLCB1bgogICAgICAgICByZXR1cm4gcmVz dWx0OwogICAgIH0KIAotICAgIGVuc3VyZUxlbmd0aCh2bSwgaSArIDEpOworICAgIGlmICghZW5z dXJlTGVuZ3RoKHZtLCBpICsgMSkpIHsKKyAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4 ZWMpOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQogICAgIGJ1dHRlcmZseSA9IG1fYnV0 dGVyZmx5LmdldCgpOwogCiAgICAgUkVMRUFTRV9BU1NFUlQoaSA8IGJ1dHRlcmZseS0+dmVjdG9y TGVuZ3RoKCkpOwpAQCAtMjc1Myw3ICsyNzU2LDcgQEAgYm9vbCBKU09iamVjdDo6aW5jcmVhc2VW ZWN0b3JMZW5ndGgoVk0mIHZtLCB1bnNpZ25lZCBuZXdMZW5ndGgpCiAgICAgcmV0dXJuIHRydWU7 CiB9CiAKLXZvaWQgSlNPYmplY3Q6OmVuc3VyZUxlbmd0aFNsb3coVk0mIHZtLCB1bnNpZ25lZCBs ZW5ndGgpCitib29sIEpTT2JqZWN0OjplbnN1cmVMZW5ndGhTbG93KFZNJiB2bSwgdW5zaWduZWQg bGVuZ3RoKQogewogICAgIEJ1dHRlcmZseSogYnV0dGVyZmx5ID0gbV9idXR0ZXJmbHkuZ2V0KCk7 CiAgICAgCkBAIC0yNzcwLDYgKzI3NzMsOCBAQCB2b2lkIEpTT2JqZWN0OjplbnN1cmVMZW5ndGhT bG93KFZNJiB2bSwgdW5zaWduZWQgbGVuZ3RoKQogICAgICAgICB2bSwgdGhpcywgc3RydWN0dXJl KCksIHN0cnVjdHVyZSgpLT5vdXRPZkxpbmVDYXBhY2l0eSgpLCB0cnVlLAogICAgICAgICBvbGRW ZWN0b3JMZW5ndGggKiBzaXplb2YoRW5jb2RlZEpTVmFsdWUpLAogICAgICAgICBuZXdWZWN0b3JM ZW5ndGggKiBzaXplb2YoRW5jb2RlZEpTVmFsdWUpKTsKKyAgICBpZiAoIWJ1dHRlcmZseSkKKyAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIG1fYnV0dGVyZmx5LnNldCh2bSwgdGhpcywgYnV0dGVy Zmx5KTsKIAogICAgIGJ1dHRlcmZseS0+c2V0VmVjdG9yTGVuZ3RoKG5ld1ZlY3Rvckxlbmd0aCk7 CkBAIC0yNzc4LDYgKzI3ODMsNyBAQCB2b2lkIEpTT2JqZWN0OjplbnN1cmVMZW5ndGhTbG93KFZN JiB2bSwgdW5zaWduZWQgbGVuZ3RoKQogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBvbGRWZWN0 b3JMZW5ndGg7IGkgPCBuZXdWZWN0b3JMZW5ndGg7ICsraSkKICAgICAgICAgICAgIGJ1dHRlcmZs eS0+Y29udGlndW91c0RvdWJsZSgpLmRhdGEoKVtpXSA9IFBOYU47CiAgICAgfQorICAgIHJldHVy biB0cnVlOwogfQogCiB2b2lkIEpTT2JqZWN0OjpyZWFsbG9jYXRlQW5kU2hyaW5rQnV0dGVyZmx5 KFZNJiB2bSwgdW5zaWduZWQgbGVuZ3RoKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNPYmplY3QuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT T2JqZWN0LmgKaW5kZXggNTQ3ZWIxZjM3MWI0NjE0ZDZkZWFhY2E5OTExNjBjMTUwZjcwZjdlZS4u ZmE0NThmYTY3OGM1ZDNhOWE0ZDhlMjZhMmFiZjE2OGUzOTk2ZThmMCAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCkBAIC04NjcsMTYgKzg2NywxOCBAQCBwcm90ZWN0 ZWQ6CiAgICAgICAgIAogICAgIC8vIENhbGwgdGhpcyBpZiB5b3Ugd2FudCBzZXRJbmRleFF1aWNr bHkgdG8gc3VjY2VlZCBhbmQgeW91J3JlIHN1cmUgdGhhdAogICAgIC8vIHRoZSBhcnJheSBpcyBj b250aWd1b3VzLgotICAgIHZvaWQgZW5zdXJlTGVuZ3RoKFZNJiB2bSwgdW5zaWduZWQgbGVuZ3Ro KQorICAgIGJvb2wgV0FSTl9VTlVTRURfUkVUVVJOIGVuc3VyZUxlbmd0aChWTSYgdm0sIHVuc2ln bmVkIGxlbmd0aCkKICAgICB7CiAgICAgICAgIEFTU0VSVChsZW5ndGggPCBNQVhfQVJSQVlfSU5E RVgpOwogICAgICAgICBBU1NFUlQoaGFzQ29udGlndW91cyhpbmRleGluZ1R5cGUoKSkgfHwgaGFz SW50MzIoaW5kZXhpbmdUeXBlKCkpIHx8IGhhc0RvdWJsZShpbmRleGluZ1R5cGUoKSkgfHwgaGFz VW5kZWNpZGVkKGluZGV4aW5nVHlwZSgpKSk7CiAKKyAgICAgICAgYm9vbCByZXN1bHQgPSB0cnVl OwogICAgICAgICBpZiAobV9idXR0ZXJmbHkuZ2V0KCktPnZlY3Rvckxlbmd0aCgpIDwgbGVuZ3Ro KQotICAgICAgICAgICAgZW5zdXJlTGVuZ3RoU2xvdyh2bSwgbGVuZ3RoKTsKKyAgICAgICAgICAg IHJlc3VsdCA9IGVuc3VyZUxlbmd0aFNsb3codm0sIGxlbmd0aCk7CiAgICAgICAgICAgICAKICAg ICAgICAgaWYgKG1fYnV0dGVyZmx5LmdldCgpLT5wdWJsaWNMZW5ndGgoKSA8IGxlbmd0aCkKICAg ICAgICAgICAgIG1fYnV0dGVyZmx5LmdldCgpLT5zZXRQdWJsaWNMZW5ndGgobGVuZ3RoKTsKKyAg ICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9CiAgICAgICAgIAogICAgIC8vIENhbGwgdGhpcyBp ZiB5b3Ugd2FudCB0byBzaHJpbmsgdGhlIGJ1dHRlcmZseSBiYWNraW5nIHN0b3JlLCBhbmQgeW91 J3JlCkBAIC05MzIsNyArOTM0LDcgQEAgcHJpdmF0ZToKICAgICBKU19FWFBPUlRfUFJJVkFURSB2 b2lkIGNvbnZlcnRJbnQzMlRvRG91YmxlT3JDb250aWd1b3VzV2hpbGVQZXJmb3JtaW5nU2V0SW5k ZXgoVk0mLCB1bnNpZ25lZCBpbmRleCwgSlNWYWx1ZSk7CiAgICAgSlNfRVhQT1JUX1BSSVZBVEUg dm9pZCBjb252ZXJ0RG91YmxlVG9Db250aWd1b3VzV2hpbGVQZXJmb3JtaW5nU2V0SW5kZXgoVk0m LCB1bnNpZ25lZCBpbmRleCwgSlNWYWx1ZSk7CiAgICAgICAgIAotICAgIHZvaWQgZW5zdXJlTGVu Z3RoU2xvdyhWTSYsIHVuc2lnbmVkIGxlbmd0aCk7CisgICAgYm9vbCBlbnN1cmVMZW5ndGhTbG93 KFZNJiwgdW5zaWduZWQgbGVuZ3RoKTsKICAgICAgICAgCiAgICAgQ29udGlndW91c0pTVmFsdWVz IGVuc3VyZUludDMyU2xvdyhWTSYpOwogICAgIENvbnRpZ3VvdXNEb3VibGVzIGVuc3VyZURvdWJs ZVNsb3coVk0mKTsK