155720 2016-03-21 08:51:16 -0700 validity assertion fails after removing a child of an <optgroup> element 2016-08-05 12:39:40 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 116980 1 rhodovan.u-szeged darin annulen bfulgham cdumez darin webkit-bug-importer zalan oldest_to_newest 1176744 0 274598 rhodovan.u-szeged 2016-03-21 08:51:16 -0700 Created attachment 274598 Test case Load the attached test with minibrowser: <script> window.onload = function() { var parent = document.getElementById('id_1'); parent.removeChild(parent.childNodes[0]); parent.removeChild(parent.childNodes[0]); document.getElementById('id_0').appendChild(document.activeElement); } </script> <template id="id_0"></template> <select required> <optgroup id="id_1"> <option></option> </optgroup> </select> OS: Mac OS X 10.11.1 (x86_64), x86_64 Checked build: ASAN debug Checked version: d52551a Backtrace: ASSERTION FAILED: m_isValid == valid() /Users/reni/work/WebKit/Source/WebCore/html/HTMLFormControlElement.cpp(495) : bool WebCore::HTMLFormControlElement::isValidFormControlElement() const 1 0x10cb7bed4 WTFCrash 2 0x11289cfca WebCore::HTMLFormControlElement::isValidFormControlElement() const 3 0x11288c4e9 WebCore::HTMLFormControlElement::removedFrom(WebCore::ContainerNode&) 4 0x1128a05be WebCore::HTMLFormControlElementWithState::removedFrom(WebCore::ContainerNode&) 5 0x11118e28a WebCore::notifyNodeRemovedFromDocument(WebCore::ContainerNode&, WebCore::Node&) 6 0x11118e339 WebCore::notifyNodeRemovedFromDocument(WebCore::ContainerNode&, WebCore::Node&) 7 0x11118e8d9 WebCore::notifyChildNodeRemoved(WebCore::ContainerNode&, WebCore::Node&) 8 0x11116f06e WebCore::ContainerNode::notifyChildRemoved(WebCore::Node&, WebCore::Node*, WebCore::Node*, WebCore::ContainerNode::ChildChangeSource) 9 0x11117070b WebCore::ContainerNode::removeChild(WebCore::Node&, int&) 10 0x11116e01e WebCore::collectChildrenAndRemoveFromOldParent(WebCore::Node&, WTF::Vector<WTF::Ref<WebCore::Node>, 11ul, WTF::CrashOnOverflow, 16ul>&, int&) 11 0x11116dcd3 WebCore::ContainerNode::appendChild(WTF::Ref<WebCore::Node>&&, int&) 12 0x114dc1353 WebCore::Node::appendChild(WTF::PassRefPtr<WebCore::Node>, int&) 13 0x113dd3679 WebCore::JSNode::appendChild(JSC::ExecState&) 14 0x113dcaf2e WebCore::jsNodePrototypeFunctionAppendChild(JSC::ExecState*) 15 0x2b4fd4a01028 16 0x10c273d7b llint_entry 17 0x10c26d3be vmEntryToJavaScript 18 0x10bcd1db0 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 19 0x10bbdd29d JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 20 0x10a6dc215 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 21 0x10a6dc68a JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) 22 0x10a6dd0e8 JSC::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) 23 0x11332f956 WebCore::JSMainThreadExecState::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) 24 0x113887f84 WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) 25 0x111f84051 WebCore::EventTarget::fireEventListeners(WebCore::Event&, WebCore::EventTargetData*, WTF::Vector<WebCore::RegisteredEventListener, 1ul, WTF::CrashOnOverflow, 16ul>&) 26 0x111f83148 WebCore::EventTarget::fireEventListeners(WebCore::Event&) 27 0x111d6c56f WebCore::DOMWindow::dispatchEvent(WebCore::Event&, WebCore::EventTarget*) 28 0x111d82cae WebCore::DOMWindow::dispatchLoadEvent() 29 0x1119c8452 WebCore::Document::dispatchWindowLoadEvent() 30 0x1119bef16 WebCore::Document::implicitClose() 31 0x1123ddf99 WebCore::FrameLoader::checkCallImplicitClose() ASAN:SIGSEGV ================================================================= ==44859==ERROR: AddressSanitizer: SEGV on unknown address 0x0000bbadbeef (pc 0x00010cb7bf0c bp 0x7fff5c1a3a30 sp 0x7fff5c1a3a20 T0) #0 0x10cb7bf0b in WTFCrash (/Users/reni/work/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore+0x2b5df0b) #1 0x11289cfc9 in WebCore::HTMLFormControlElement::isValidFormControlElement() const (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1fedfc9) #2 0x11288c4e8 in WebCore::HTMLFormControlElement::removedFrom(WebCore::ContainerNode&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1fdd4e8) #3 0x1128a05bd in WebCore::HTMLFormControlElementWithState::removedFrom(WebCore::ContainerNode&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1ff15bd) #4 0x11118e289 in WebCore::notifyNodeRemovedFromDocument(WebCore::ContainerNode&, WebCore::Node&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x8df289) #5 0x11118e338 in WebCore::notifyNodeRemovedFromDocument(WebCore::ContainerNode&, WebCore::Node&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x8df338) #6 0x11118e8d8 in WebCore::notifyChildNodeRemoved(WebCore::ContainerNode&, WebCore::Node&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x8df8d8) #7 0x11116f06d in WebCore::ContainerNode::notifyChildRemoved(WebCore::Node&, WebCore::Node*, WebCore::Node*, WebCore::ContainerNode::ChildChangeSource) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x8c006d) #8 0x11117070a in WebCore::ContainerNode::removeChild(WebCore::Node&, int&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x8c170a) #9 0x11116e01d in WebCore::collectChildrenAndRemoveFromOldParent(WebCore::Node&, WTF::Vector<WTF::Ref<WebCore::Node>, 11ul, WTF::CrashOnOverflow, 16ul>&, int&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x8bf01d) #10 0x11116dcd2 in WebCore::ContainerNode::appendChild(WTF::Ref<WebCore::Node>&&, int&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x8becd2) #11 0x114dc1352 in WebCore::Node::appendChild(WTF::PassRefPtr<WebCore::Node>, int&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x4512352) #12 0x113dd3678 in WebCore::JSNode::appendChild(JSC::ExecState&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x3524678) #13 0x113dcaf2d in WebCore::jsNodePrototypeFunctionAppendChild(JSC::ExecState*) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x351bf2d) #14 0x2b4fd4a01027 (<unknown module>) #15 0x10c273d7a in llint_entry (/Users/reni/work/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore+0x2255d7a) #16 0x10c26d3bd in vmEntryToJavaScript (/Users/reni/work/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore+0x224f3bd) #17 0x10bcd1daf in JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) (/Users/reni/work/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore+0x1cb3daf) #18 0x10bbdd29c in JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) (/Users/reni/work/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore+0x1bbf29c) #19 0x10a6dc214 in JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) (/Users/reni/work/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore+0x6be214) #20 0x10a6dc689 in JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) (/Users/reni/work/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore+0x6be689) #21 0x10a6dd0e7 in JSC::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) (/Users/reni/work/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore+0x6bf0e7) #22 0x11332f955 in WebCore::JSMainThreadExecState::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x2a80955) #23 0x113887f83 in WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x2fd8f83) #24 0x111f84050 in WebCore::EventTarget::fireEventListeners(WebCore::Event&, WebCore::EventTargetData*, WTF::Vector<WebCore::RegisteredEventListener, 1ul, WTF::CrashOnOverflow, 16ul>&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x16d5050) #25 0x111f83147 in WebCore::EventTarget::fireEventListeners(WebCore::Event&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x16d4147) #26 0x111d6c56e in WebCore::DOMWindow::dispatchEvent(WebCore::Event&, WebCore::EventTarget*) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x14bd56e) #27 0x111d82cad in WebCore::DOMWindow::dispatchLoadEvent() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x14d3cad) #28 0x1119c8451 in WebCore::Document::dispatchWindowLoadEvent() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1119451) #29 0x1119bef15 in WebCore::Document::implicitClose() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x110ff15) #30 0x1123ddf98 in WebCore::FrameLoader::checkCallImplicitClose() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1b2ef98) #31 0x1123dda7b in WebCore::FrameLoader::checkCompleted() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1b2ea7b) #32 0x1123da047 in WebCore::FrameLoader::finishedParsing() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1b2b047) #33 0x1119e2679 in WebCore::Document::finishedParsing() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1133679) #34 0x11279d7a5 in WebCore::HTMLConstructionSite::finishedParsing() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1eee7a5) #35 0x112acdd1b in WebCore::HTMLTreeBuilder::finished() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x221ed1b) #36 0x11281249b in WebCore::HTMLDocumentParser::end() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1f6349b) #37 0x11280e6a9 in WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1f5f6a9) #38 0x11280e318 in WebCore::HTMLDocumentParser::prepareToStopParsing() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1f5f318) #39 0x11281253d in WebCore::HTMLDocumentParser::attemptToEnd() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1f6353d) #40 0x112812597 in WebCore::HTMLDocumentParser::finish() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x1f63597) #41 0x111b9e08f in WebCore::DocumentWriter::end() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x12ef08f) #42 0x111af06dc in WebCore::DocumentLoader::finishedLoading(double) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x12416dc) #43 0x111af01ea in WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource*) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x12411ea) #44 0x110ec7c76 in WebCore::CachedResource::checkNotify() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x618c76) #45 0x110ec7e63 in WebCore::CachedResource::finishLoading(WebCore::SharedBuffer*) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x618e63) #46 0x110ebe1dc in WebCore::CachedRawResource::finishLoading(WebCore::SharedBuffer*) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x60f1dc) #47 0x116585100 in WebCore::SubresourceLoader::didFinishLoading(double) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore+0x5cd6100) #48 0x10558994c in WebKit::WebResourceLoader::didFinishResourceLoad(double) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x1b1894c) #49 0x10559dce2 in void IPC::callMemberFunctionImpl<WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(double), std::__1::tuple<double>, 0ul>(WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(double), std::__1::tuple<double>&&, std::index_sequence<0ul>) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x1b2cce2) #50 0x10559d961 in void IPC::callMemberFunction<WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(double), std::__1::tuple<double>, std::make_index_sequence<1ul> >(std::__1::tuple<double>&&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(double)) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x1b2c961) #51 0x105599d1e in void IPC::handleMessage<Messages::WebResourceLoader::DidFinishResourceLoad, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(double)>(IPC::MessageDecoder&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(double)) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x1b28d1e) #52 0x105596d9d in WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage(IPC::Connection&, IPC::MessageDecoder&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x1b25d9d) #53 0x10430d2e2 in WebKit::NetworkProcessConnection::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x89c2e2) #54 0x103c451e0 in IPC::Connection::dispatchMessage(IPC::MessageDecoder&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x1d41e0) #55 0x103c2c741 in IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x1bb741) #56 0x103c45fd0 in IPC::Connection::dispatchOneMessage() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x1d4fd0) #57 0x103c7571c in IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10::operator()() const (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x20471c) #58 0x103c756ec in void std::__1::__invoke_void_return_wrapper<void>::__call<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10&>(IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10&&&) (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x2046ec) #59 0x103c7550b in std::__1::__function::__func<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10, std::__1::allocator<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10>, void ()>::operator()() (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit+0x20450b) #60 0x10b9b253a in std::__1::function<void ()>::operator()() const (/Users/reni/work/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore+0x199453a) #61 0x10cc584dd in WTF::RunLoop::performWork() (/Users/reni/work/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore+0x2c3a4dd) #62 0x10cc59449 in WTF::RunLoop::performWork(void*) (/Users/reni/work/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore+0x2c3b449) #63 0x7fff888498b0 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation+0xaa8b0) #64 0x7fff888290ab in __CFRunLoopDoSources0 (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation+0x8a0ab) #65 0x7fff888285ce in __CFRunLoopRun (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation+0x895ce) #66 0x7fff88827fc7 in CFRunLoopRunSpecific (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation+0x88fc7) #67 0x7fff86540d54 in RunCurrentEventLoopInMode (/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox+0x30d54) #68 0x7fff86540b8e in ReceiveNextEventCommon (/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox+0x30b8e) #69 0x7fff865409ce in _BlockUntilNextEventMatchingListInModeWithFilter (/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox+0x309ce) #70 0x7fff97bc6d95 in _DPSNextEvent (/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit+0x49d95) #71 0x7fff97bc61c4 in -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:] (/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit+0x491c4) #72 0x7fff97bbad27 in -[NSApplication run] (/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit+0x3dd27) #73 0x7fff97b83fbd in NSApplicationMain (/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit+0x6fbd) #74 0x7fff9408b4f1 in _xpc_objc_main (/usr/lib/system/libxpc.dylib+0x114f1) #75 0x7fff94089f1d in xpc_main (/usr/lib/system/libxpc.dylib+0xff1d) #76 0x103a561cb in main (/Users/reni/work/WebKit/WebKitBuild/Debug/WebKit.framework/Versions/A/XPCServices/com.apple.WebKit.WebContent.Development.xpc/Contents/MacOS/com.apple.WebKit.WebContent.Development+0x1000021cb) #77 0x7fff908b05ac in start (/usr/lib/system/libdyld.dylib+0x35ac) #78 0x0 (<unknown module>) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV ??:0 WTFCrash ==44859==ABORTING 1177277 1 darin 2016-03-22 21:58:14 -0700 The bug here is that all calls to setRecalcListItems also need to call updateValidity and the one in HTMLOptGroupElement::recalcSelectOptions does not. Easy to fix. 1217924 2 bfulgham 2016-08-05 09:48:28 -0700 This reproduces in r204037. 1217925 3 webkit-bug-importer 2016-08-05 09:48:52 -0700 <rdar://problem/27720746> 1217976 4 285435 bfulgham 2016-08-05 11:00:00 -0700 Created attachment 285435 Patch 1217977 5 bfulgham 2016-08-05 11:01:53 -0700 I'm a little unhappy with the test case, because I cannot get it to cleanly dump as pure text output. This is because the assertion only fires when an HTML snippet is used, not if I structure it as a proper HTML document where 'dumpAsText' is able to see the simple text message. The assertion seems to only fire when the file is treated as though it's entirely in the <head> element. 1217980 6 285435 darin 2016-08-05 11:12:34 -0700 Comment on attachment 285435 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285435&action=review Three fixes, but only one test case. Seems like we need more test cases to cover all the things fixed here. > Source/WebCore/html/HTMLOptGroupElement.cpp:91 > ContainerNode* select = parentNode(); > while (select && !is<HTMLSelectElement>(*select)) > select = select->parentNode(); > - if (select) > - downcast<HTMLSelectElement>(*select).setRecalcListItems(); > + if (select) { I think there’s a new better way to write this: If (auto* selectElement = ancestorsOfType<HTMLSelectElement>(*this).first()) Maybe not for this patch. Also maybe a helper function here like the ownerSelectElement function in HTMLOptionElement? > Source/WebCore/html/HTMLOptGroupElement.cpp:94 > + selectElement.setRecalcListItems(); > + selectElement.updateValidity(); Annoying that these are two different functions rather than having one to call that does both. Annoying that the names are so different when both have the same semantic (mark something invalid to be recomputed later). Something to come back to and improve later. 1217985 7 285435 bfulgham 2016-08-05 11:29:12 -0700 Comment on attachment 285435 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285435&action=review >> Source/WebCore/html/HTMLOptGroupElement.cpp:91 >> + if (select) { > > I think there’s a new better way to write this: > > If (auto* selectElement = ancestorsOfType<HTMLSelectElement>(*this).first()) > > Maybe not for this patch. Also maybe a helper function here like the ownerSelectElement function in HTMLOptionElement? Oh! That's much cleaner. I'll switch to that. >> Source/WebCore/html/HTMLOptGroupElement.cpp:94 >> + selectElement.updateValidity(); > > Annoying that these are two different functions rather than having one to call that does both. Annoying that the names are so different when both have the same semantic (mark something invalid to be recomputed later). Something to come back to and improve later. Agreed! 1217988 8 285437 bfulgham 2016-08-05 11:30:03 -0700 Created attachment 285437 Patch for landing 1217989 9 285437 bfulgham 2016-08-05 11:30:38 -0700 Comment on attachment 285437 Patch for landing Marking r+ based on darin's review. 1218009 10 bfulgham 2016-08-05 12:39:40 -0700 Committed r204186: <http://trac.webkit.org/changeset/204186> 274598 2016-03-21 08:51:16 -0700 2016-03-21 08:51:16 -0700 Test case test.html text/html 368 rhodovan.u-szeged PHNjcmlwdD4Kd2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkgewoJdmFyIHBhcmVudCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdpZF8xJyk7CglwYXJlbnQucmVtb3ZlQ2hpbGQocGFyZW50LmNo aWxkTm9kZXNbMF0pOwoJcGFyZW50LnJlbW92ZUNoaWxkKHBhcmVudC5jaGlsZE5vZGVzWzBdKTsK CWRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdpZF8wJykuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuYWN0 aXZlRWxlbWVudCk7Cn0KPC9zY3JpcHQ+Cjx0ZW1wbGF0ZSBpZD0iaWRfMCI+PC90ZW1wbGF0ZT4K PHNlbGVjdCByZXF1aXJlZD4KCTxvcHRncm91cCBpZD0iaWRfMSI+CgkJPG9wdGlvbj48L29wdGlv bj4KCTwvb3B0Z3JvdXA+Cjwvc2VsZWN0Pgo= 285435 2016-08-05 11:00:00 -0700 2016-08-05 11:29:58 -0700 Patch bug-155720-20160805105833.patch text/plain 5713 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNDE3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA4LTA1ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIHZhbGlkaXR5IGFzc2VydGlv biBmYWlscyBhZnRlciByZW1vdmluZyBhIGNoaWxkIG9mIGFuIDxvcHRncm91cD4gZWxlbWVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NzIwCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzcyMDc0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGwgY2FsbHMgdG8gSFRNTFNlbGVjdEVsZW1lbnQ6 OnNldFJlY2FsY0xpc3RJdGVtcyBhbHNvIG5lZWQgdG8gY2FsbCBIVE1MU2VsZWN0RWxlbWVudDo6 dXBkYXRlVmFsaWRpdHkuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1l bnQvc2VsZWN0LXJlbW92ZS1mcm9tLW9wdGdyb3VwLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRN TE9wdEdyb3VwRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MT3B0R3JvdXBFbGVt ZW50OjpyZWNhbGNTZWxlY3RPcHRpb25zKTogQ2FsbCAndXBkYXRlVmFsaWRpdHknIGFmdGVyICdz ZXRSZWNhbGNMaXN0SXRlbXMnLgorICAgICAgICAqIGh0bWwvSFRNTE9wdGlvbkVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SFRNTE9wdGlvbkVsZW1lbnQ6Omluc2VydGVkSW50byk6IERp dHRvLgorICAgICAgICAqIGh0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTFNlbGVjdEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKTogRGl0dG8uCisKIDIwMTYt MDgtMDUgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMDQxNDcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxPcHRHcm91cEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE9wdEdyb3VwRWxlbWVudC5jcHAJKHJldmlzaW9uIDIwNDE3MykKKysrIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE9wdEdyb3VwRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTIsNyArMiw3IEBACiAgKiBDb3B5cmlnaHQgKEMpIDE5OTkgTGFycyBLbm9sbCAoa25vbGxAa2Rl Lm9yZykKICAqICAgICAgICAgICAoQykgMTk5OSBBbnR0aSBLb2l2aXN0byAoa29pdmlzdG9Aa2Rl Lm9yZykKICAqICAgICAgICAgICAoQykgMjAwMSBEaXJrIE11ZWxsZXIgKG11ZWxsZXJAa2RlLm9y ZykKLSAqIENvcHlyaWdodCAoQykgMjAwNCwgMjAwNSwgMjAwNiwgMjAwNywgMjAwOCwgMjAxMCBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDQtMjAx NiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKiAgICAgICAgICAgKEMpIDIwMDYg QWxleGV5IFByb3NrdXJ5YWtvdiAoYXBAbnlwb3AuY29tKQogICoKICAqIFRoaXMgbGlicmFyeSBp cyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKQEAgLTg4LDgg Kzg4LDExIEBAIHZvaWQgSFRNTE9wdEdyb3VwRWxlbWVudDo6cmVjYWxjU2VsZWN0T3AKICAgICBD b250YWluZXJOb2RlKiBzZWxlY3QgPSBwYXJlbnROb2RlKCk7CiAgICAgd2hpbGUgKHNlbGVjdCAm JiAhaXM8SFRNTFNlbGVjdEVsZW1lbnQ+KCpzZWxlY3QpKQogICAgICAgICBzZWxlY3QgPSBzZWxl Y3QtPnBhcmVudE5vZGUoKTsKLSAgICBpZiAoc2VsZWN0KQotICAgICAgICBkb3duY2FzdDxIVE1M U2VsZWN0RWxlbWVudD4oKnNlbGVjdCkuc2V0UmVjYWxjTGlzdEl0ZW1zKCk7CisgICAgaWYgKHNl bGVjdCkgeworICAgICAgICBhdXRvJiBzZWxlY3RFbGVtZW50ID0gZG93bmNhc3Q8SFRNTFNlbGVj dEVsZW1lbnQ+KCpzZWxlY3QpOworICAgICAgICBzZWxlY3RFbGVtZW50LnNldFJlY2FsY0xpc3RJ dGVtcygpOworICAgICAgICBzZWxlY3RFbGVtZW50LnVwZGF0ZVZhbGlkaXR5KCk7CisgICAgfQog fQogCiBTdHJpbmcgSFRNTE9wdEdyb3VwRWxlbWVudDo6Z3JvdXBMYWJlbFRleHQoKSBjb25zdApJ bmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MT3B0aW9uRWxlbWVudC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MT3B0aW9uRWxlbWVudC5jcHAJKHJldmlzaW9u IDIwNDE3MykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9wdGlvbkVsZW1lbnQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zMTYsNiArMzE2LDcgQEAgTm9kZTo6SW5zZXJ0aW9uTm90aWZpY2F0 aW9uUmVxdWVzdCBIVE1MTwogewogICAgIGlmIChIVE1MU2VsZWN0RWxlbWVudCogc2VsZWN0ID0g b3duZXJTZWxlY3RFbGVtZW50KCkpIHsKICAgICAgICAgc2VsZWN0LT5zZXRSZWNhbGNMaXN0SXRl bXMoKTsKKyAgICAgICAgc2VsZWN0LT51cGRhdGVWYWxpZGl0eSgpOwogICAgICAgICAvLyBEbyBu b3QgY2FsbCBzZWxlY3RlZCgpIHNpbmNlIGNhbGxpbmcgdXBkYXRlTGlzdEl0ZW1TZWxlY3RlZFN0 YXRlcygpCiAgICAgICAgIC8vIGF0IHRoaXMgdGltZSB3b24ndCBkbyB0aGUgcmlnaHQgdGhpbmcu IChXaHksIGV4YWN0bHk/KQogICAgICAgICAvLyBGSVhNRTogTWlnaHQgYmUgYmV0dGVyIHRvIGNh bGwgdGhpcyB1bmNvbmRpdGlvbmFsbHksIGFsd2F5cyBwYXNzaW5nIG1faXNTZWxlY3RlZCwKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCShyZXZpc2lvbiAy MDQxNzMpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzA1LDYgKzMwNSw3IEBAIHZvaWQgSFRNTFNlbGVjdEVsZW1lbnQ6OnBh cnNlQXR0cmlidXRlKGMKICAgICAgICAgaWYgKG1fc2l6ZSAhPSBvbGRTaXplKSB7CiAgICAgICAg ICAgICBzZXROZWVkc1N0eWxlUmVjYWxjKFJlY29uc3RydWN0UmVuZGVyVHJlZSk7CiAgICAgICAg ICAgICBzZXRSZWNhbGNMaXN0SXRlbXMoKTsKKyAgICAgICAgICAgIHVwZGF0ZVZhbGlkaXR5KCk7 CiAgICAgICAgIH0KICAgICB9IGVsc2UgaWYgKG5hbWUgPT0gbXVsdGlwbGVBdHRyKQogICAgICAg ICBwYXJzZU11bHRpcGxlQXR0cmlidXRlKHZhbHVlKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNDE3 MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3 IEBACisyMDE2LTA4LTA1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisg ICAgICAgIHZhbGlkaXR5IGFzc2VydGlvbiBmYWlscyBhZnRlciByZW1vdmluZyBhIGNoaWxkIG9m IGFuIDxvcHRncm91cD4gZWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU1NzIwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzcyMDc0Nj4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbmV3 IHRlc3QgY2FzZSB0aGF0IHRyaWdnZXJzIGEgZGVidWcgYXNzZXJ0aW9uIHdoZW4gdGhlIEhUTUxT ZWxlY3RFbGVtZW50IHN0YXRlCisgICAgICAgIGlzIG5vdCB1cGRhdGVkIHByb3Blcmx5LgorCisg ICAgICAgICogZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvc2VsZWN0LXJlbW92ZS1mcm9tLW9w dGdyb3VwLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTFNlbGVj dEVsZW1lbnQvc2VsZWN0LXJlbW92ZS1mcm9tLW9wdGdyb3VwLmh0bWw6IEFkZGVkLgorCiAyMDE2 LTA4LTA1ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjAzOTM1LgpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvc2VsZWN0LXJlbW92ZS1mcm9tLW9wdGdyb3VwLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MU2VsZWN0RWxl bWVudC9zZWxlY3QtcmVtb3ZlLWZyb20tb3B0Z3JvdXAtZXhwZWN0ZWQudHh0CShub25leGlzdGVu dCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L3NlbGVjdC1yZW1v dmUtZnJvbS1vcHRncm91cC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw0 IEBACitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBz aXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJCbG9jayB7 SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9I VE1MU2VsZWN0RWxlbWVudC9zZWxlY3QtcmVtb3ZlLWZyb20tb3B0Z3JvdXAuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVudC9zZWxlY3QtcmVt b3ZlLWZyb20tb3B0Z3JvdXAuaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2RvbS9IVE1MU2VsZWN0RWxlbWVudC9zZWxlY3QtcmVtb3ZlLWZyb20tb3B0Z3JvdXAuaHRtbAko d29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE1IEBACis8c2NyaXB0Pgord2luZG93Lm9ubG9hZCA9 IGZ1bmN0aW9uKCkgeworCXZhciBwYXJlbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnaWRf MScpOworCXBhcmVudC5yZW1vdmVDaGlsZChwYXJlbnQuY2hpbGROb2Rlc1swXSk7CisJcGFyZW50 LnJlbW92ZUNoaWxkKHBhcmVudC5jaGlsZE5vZGVzWzBdKTsKKwlkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnaWRfMCcpLmFwcGVuZENoaWxkKGRvY3VtZW50LmFjdGl2ZUVsZW1lbnQpOworfQorPC9z Y3JpcHQ+Cis8dGVtcGxhdGUgaWQ9ImlkXzAiPjwvdGVtcGxhdGU+Cis8c2VsZWN0IHJlcXVpcmVk PgorCTxvcHRncm91cCBpZD0iaWRfMSI+CisJCTxvcHRpb24+PC9vcHRpb24+CisJPC9vcHRncm91 cD4KKzwvc2VsZWN0PgorVGhlIHRlc3QgcGFzc2VzIGlmIHRoaXMgZG9lcyBub3QgY2F1c2UgYSBk ZWJ1ZyBhc3NlcnQuCg== 285437 2016-08-05 11:30:03 -0700 2016-08-05 11:30:38 -0700 Patch for landing bug-155720-20160805112836.patch text/plain 5966 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNDE3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA4LTA1ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIHZhbGlkaXR5IGFzc2VydGlv biBmYWlscyBhZnRlciByZW1vdmluZyBhIGNoaWxkIG9mIGFuIDxvcHRncm91cD4gZWxlbWVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NzIwCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzcyMDc0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGwgY2FsbHMgdG8gSFRNTFNlbGVjdEVsZW1lbnQ6 OnNldFJlY2FsY0xpc3RJdGVtcyBhbHNvIG5lZWQgdG8gY2FsbCBIVE1MU2VsZWN0RWxlbWVudDo6 dXBkYXRlVmFsaWRpdHkuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1l bnQvc2VsZWN0LXJlbW92ZS1mcm9tLW9wdGdyb3VwLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRN TE9wdEdyb3VwRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MT3B0R3JvdXBFbGVt ZW50OjpyZWNhbGNTZWxlY3RPcHRpb25zKTogQ2FsbCAndXBkYXRlVmFsaWRpdHknIGFmdGVyICdz ZXRSZWNhbGNMaXN0SXRlbXMnLgorICAgICAgICAqIGh0bWwvSFRNTE9wdGlvbkVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SFRNTE9wdGlvbkVsZW1lbnQ6Omluc2VydGVkSW50byk6IERp dHRvLgorICAgICAgICAqIGh0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTFNlbGVjdEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKTogRGl0dG8uCisKIDIwMTYt MDgtMDUgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMDQxNDcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxPcHRHcm91cEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE9wdEdyb3VwRWxlbWVudC5jcHAJKHJldmlzaW9uIDIwNDE3MykKKysrIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE9wdEdyb3VwRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTIsNyArMiw3IEBACiAgKiBDb3B5cmlnaHQgKEMpIDE5OTkgTGFycyBLbm9sbCAoa25vbGxAa2Rl Lm9yZykKICAqICAgICAgICAgICAoQykgMTk5OSBBbnR0aSBLb2l2aXN0byAoa29pdmlzdG9Aa2Rl Lm9yZykKICAqICAgICAgICAgICAoQykgMjAwMSBEaXJrIE11ZWxsZXIgKG11ZWxsZXJAa2RlLm9y ZykKLSAqIENvcHlyaWdodCAoQykgMjAwNCwgMjAwNSwgMjAwNiwgMjAwNywgMjAwOCwgMjAxMCBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDQtMjAx NiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKiAgICAgICAgICAgKEMpIDIwMDYg QWxleGV5IFByb3NrdXJ5YWtvdiAoYXBAbnlwb3AuY29tKQogICoKICAqIFRoaXMgbGlicmFyeSBp cyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKQEAgLTI2LDYg KzI2LDcgQEAKICNpbmNsdWRlICJIVE1MT3B0R3JvdXBFbGVtZW50LmgiCiAKICNpbmNsdWRlICJE b2N1bWVudC5oIgorI2luY2x1ZGUgIkVsZW1lbnRBbmNlc3Rvckl0ZXJhdG9yLmgiCiAjaW5jbHVk ZSAiSFRNTE5hbWVzLmgiCiAjaW5jbHVkZSAiSFRNTFNlbGVjdEVsZW1lbnQuaCIKICNpbmNsdWRl ICJSZW5kZXJNZW51TGlzdC5oIgpAQCAtODUsMTEgKzg2LDEwIEBAIHZvaWQgSFRNTE9wdEdyb3Vw RWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUKIAogdm9pZCBIVE1MT3B0R3JvdXBFbGVtZW50OjpyZWNh bGNTZWxlY3RPcHRpb25zKCkKIHsKLSAgICBDb250YWluZXJOb2RlKiBzZWxlY3QgPSBwYXJlbnRO b2RlKCk7Ci0gICAgd2hpbGUgKHNlbGVjdCAmJiAhaXM8SFRNTFNlbGVjdEVsZW1lbnQ+KCpzZWxl Y3QpKQotICAgICAgICBzZWxlY3QgPSBzZWxlY3QtPnBhcmVudE5vZGUoKTsKLSAgICBpZiAoc2Vs ZWN0KQotICAgICAgICBkb3duY2FzdDxIVE1MU2VsZWN0RWxlbWVudD4oKnNlbGVjdCkuc2V0UmVj YWxjTGlzdEl0ZW1zKCk7CisgICAgaWYgKGF1dG8qIHNlbGVjdEVsZW1lbnQgPSBhbmNlc3RvcnNP ZlR5cGU8SFRNTFNlbGVjdEVsZW1lbnQ+KCp0aGlzKS5maXJzdCgpKSB7CisgICAgICAgIHNlbGVj dEVsZW1lbnQtPnNldFJlY2FsY0xpc3RJdGVtcygpOworICAgICAgICBzZWxlY3RFbGVtZW50LT51 cGRhdGVWYWxpZGl0eSgpOworICAgIH0KIH0KIAogU3RyaW5nIEhUTUxPcHRHcm91cEVsZW1lbnQ6 Omdyb3VwTGFiZWxUZXh0KCkgY29uc3QKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9w dGlvbkVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9w dGlvbkVsZW1lbnQuY3BwCShyZXZpc2lvbiAyMDQxNzMpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxPcHRpb25FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE2LDYgKzMxNiw3IEBA IE5vZGU6Okluc2VydGlvbk5vdGlmaWNhdGlvblJlcXVlc3QgSFRNTE8KIHsKICAgICBpZiAoSFRN TFNlbGVjdEVsZW1lbnQqIHNlbGVjdCA9IG93bmVyU2VsZWN0RWxlbWVudCgpKSB7CiAgICAgICAg IHNlbGVjdC0+c2V0UmVjYWxjTGlzdEl0ZW1zKCk7CisgICAgICAgIHNlbGVjdC0+dXBkYXRlVmFs aWRpdHkoKTsKICAgICAgICAgLy8gRG8gbm90IGNhbGwgc2VsZWN0ZWQoKSBzaW5jZSBjYWxsaW5n IHVwZGF0ZUxpc3RJdGVtU2VsZWN0ZWRTdGF0ZXMoKQogICAgICAgICAvLyBhdCB0aGlzIHRpbWUg d29uJ3QgZG8gdGhlIHJpZ2h0IHRoaW5nLiAoV2h5LCBleGFjdGx5PykKICAgICAgICAgLy8gRklY TUU6IE1pZ2h0IGJlIGJldHRlciB0byBjYWxsIHRoaXMgdW5jb25kaXRpb25hbGx5LCBhbHdheXMg cGFzc2luZyBtX2lzU2VsZWN0ZWQsCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxl Y3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxl Y3RFbGVtZW50LmNwcAkocmV2aXNpb24gMjA0MTczKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MU2VsZWN0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwNSw2ICszMDUsNyBAQCB2 b2lkIEhUTUxTZWxlY3RFbGVtZW50OjpwYXJzZUF0dHJpYnV0ZShjCiAgICAgICAgIGlmIChtX3Np emUgIT0gb2xkU2l6ZSkgewogICAgICAgICAgICAgc2V0TmVlZHNTdHlsZVJlY2FsYyhSZWNvbnN0 cnVjdFJlbmRlclRyZWUpOwogICAgICAgICAgICAgc2V0UmVjYWxjTGlzdEl0ZW1zKCk7CisgICAg ICAgICAgICB1cGRhdGVWYWxpZGl0eSgpOwogICAgICAgICB9CiAgICAgfSBlbHNlIGlmIChuYW1l ID09IG11bHRpcGxlQXR0cikKICAgICAgICAgcGFyc2VNdWx0aXBsZUF0dHJpYnV0ZSh2YWx1ZSk7 CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiAyMDQxNzMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxNi0wOC0wNSAgQnJlbnQgRnVsZ2hhbSAg PGJmdWxnaGFtQGFwcGxlLmNvbT4KKworICAgICAgICB2YWxpZGl0eSBhc3NlcnRpb24gZmFpbHMg YWZ0ZXIgcmVtb3ZpbmcgYSBjaGlsZCBvZiBhbiA8b3B0Z3JvdXA+IGVsZW1lbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTcyMAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjc3MjA3NDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIG5ldyB0ZXN0IGNhc2UgdGhhdCB0cmlnZ2VycyBhIGRlYnVn IGFzc2VydGlvbiB3aGVuIHRoZSBIVE1MU2VsZWN0RWxlbWVudCBzdGF0ZQorICAgICAgICBpcyBu b3QgdXBkYXRlZCBwcm9wZXJseS4KKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxTZWxlY3RFbGVt ZW50L3NlbGVjdC1yZW1vdmUtZnJvbS1vcHRncm91cC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L3NlbGVjdC1yZW1vdmUtZnJvbS1vcHRn cm91cC5odG1sOiBBZGRlZC4KKwogMjAxNi0wOC0wNSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1 ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIwMzkz NS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L3NlbGVjdC1y ZW1vdmUtZnJvbS1vcHRncm91cC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvc2VsZWN0LXJlbW92ZS1mcm9tLW9wdGdyb3Vw LWV4cGVjdGVkLnR4dAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1M U2VsZWN0RWxlbWVudC9zZWxlY3QtcmVtb3ZlLWZyb20tb3B0Z3JvdXAtZXhwZWN0ZWQudHh0CSh3 b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNCBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAw CisgIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXpl IDgwMHg2MDAKKyAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMApJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvc2VsZWN0LXJlbW92ZS1m cm9tLW9wdGdyb3VwLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRN TFNlbGVjdEVsZW1lbnQvc2VsZWN0LXJlbW92ZS1mcm9tLW9wdGdyb3VwLmh0bWwJKG5vbmV4aXN0 ZW50KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvc2VsZWN0LXJl bW92ZS1mcm9tLW9wdGdyb3VwLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxNSBAQAor PHNjcmlwdD4KK3dpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKwl2YXIgcGFyZW50ID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lkXzEnKTsKKwlwYXJlbnQucmVtb3ZlQ2hpbGQocGFyZW50 LmNoaWxkTm9kZXNbMF0pOworCXBhcmVudC5yZW1vdmVDaGlsZChwYXJlbnQuY2hpbGROb2Rlc1sw XSk7CisJZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lkXzAnKS5hcHBlbmRDaGlsZChkb2N1bWVu dC5hY3RpdmVFbGVtZW50KTsKK30KKzwvc2NyaXB0PgorPHRlbXBsYXRlIGlkPSJpZF8wIj48L3Rl bXBsYXRlPgorPHNlbGVjdCByZXF1aXJlZD4KKwk8b3B0Z3JvdXAgaWQ9ImlkXzEiPgorCQk8b3B0 aW9uPjwvb3B0aW9uPgorCTwvb3B0Z3JvdXA+Cis8L3NlbGVjdD4KK1RoZSB0ZXN0IHBhc3NlcyBp ZiB0aGlzIGRvZXMgbm90IGNhdXNlIGEgZGVidWcgYXNzZXJ0Lgo=