155716 2016-03-21 07:06:23 -0700 [WinCairo][MediaFoundation] Crash when media player is destroyed. 2016-03-21 11:03:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen commit-queue oldest_to_newest 1176722 0 peavo 2016-03-21 07:06:23 -0700 Sometimes I get a crash in the MediaPlayerPrivateMediaFoundation destructor when trying to release the custom video presenter member, which already has been released. This is because we have forgotten to call AddRef in the ActivateObject method. According to the documentation in https://msdn.microsoft.com/en-us/library/windows/desktop/ms694292(v=vs.85).aspx, the caller is responsible for releasing the returned object, which means we have to call AddRef. 1176726 1 274590 peavo 2016-03-21 07:14:37 -0700 Created attachment 274590 Patch 1176772 2 274590 commit-queue 2016-03-21 10:54:21 -0700 Comment on attachment 274590 Patch Clearing flags on attachment: 274590 Committed r198493: <http://trac.webkit.org/changeset/198493> 1176773 3 commit-queue 2016-03-21 10:54:25 -0700 All reviewed patches have been landed. Closing bug. 1176779 4 peavo 2016-03-21 11:03:13 -0700 Thanks for reviewing :) 274590 2016-03-21 07:14:37 -0700 2016-03-21 10:54:21 -0700 Patch bug-155716-20160321151442.patch text/plain 1491 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODQ4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAzLTIxICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dW01lZGlh Rm91bmRhdGlvbl0gQ3Jhc2ggd2hlbiBtZWRpYSBwbGF5ZXIgaXMgZGVzdHJveWVkLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NzE2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5jcmVhc2UgdGhlIHJl ZmVyZW5jZSBjb3VudCBvbiB0aGUgdmlkZW8gcHJlc2VudGVyIG9iamVjdCBpbiB0aGUgQWN0aXZh dGVPYmplY3QgbWV0aG9kCisgICAgICAgIHRvIGF2b2lkIHJlZmVyZW5jaW5nIGEgZGVsZXRlZCBv YmplY3Qgd2hlbiB0aGUgbWVkaWEgcGxheWVyIGlzIGRlc3Ryb3llZC4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpD dXN0b21WaWRlb1ByZXNlbnRlcjo6QWN0aXZhdGVPYmplY3QpOgorCiAyMDE2LTAyLTAzICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtjc3MtZ3Jp ZF0gRml4IHBlcmNlbnRhZ2UgdHJhY2tzJyBzaXplIGNvbXB1dGF0aW9uIGluIGdyaWRzIHdpdGgg Z3V0dGVycwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlh UGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRh dGlvbi5jcHAJKHJldmlzaW9uIDE5ODQ2OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMTY3LDYgKzExNjcsNyBAQCBIUkVTVUxUIE1lZGlhUGxheWVyUHJpdmF0ZU1l ZGlhRm91bmRhdGlvCiAKICAgICBpZiAocmlpZCA9PSBJSURfSU1GVmlkZW9QcmVzZW50ZXIpIHsK ICAgICAgICAgKnBwdiA9IHN0YXRpY19jYXN0PElNRlZpZGVvUHJlc2VudGVyKj4odGhpcyk7Cisg ICAgICAgIEFkZFJlZigpOwogICAgICAgICByZXR1cm4gU19PSzsKICAgICB9CiAgICAgcmV0dXJu IEVfRkFJTDsK