155698 2016-03-20 10:05:17 -0700 Fixed compilation with GCC 4.8. 2016-03-21 10:17:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned ap benjamin commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1176592 0 annulen 2016-03-20 10:05:17 -0700 GCC 4.8 does not allow aggregate initialization for type with deleted constructor, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52707. 1176593 1 274541 annulen 2016-03-20 10:08:30 -0700 Created attachment 274541 Patch 1176679 2 274541 ap 2016-03-20 22:34:26 -0700 Comment on attachment 274541 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274541&action=review > Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:59 > + ImpureDataSlot(HeapLocation _key, LazyNode _value, unsigned _hash) > + : key(_key), value(_value), hash(_hash) There is no need to add leading underscores here. The following is valid C++ that implements the same behavior: ImpureDataSlot(HeapLocation key, LazyNode value, unsigned hash) : key(key), value(value), hash(hash) 1176708 3 274583 annulen 2016-03-21 06:21:27 -0700 Created attachment 274583 Patch 1176761 4 274583 commit-queue 2016-03-21 10:17:32 -0700 Comment on attachment 274583 Patch Clearing flags on attachment: 274583 Committed r198490: <http://trac.webkit.org/changeset/198490> 1176762 5 commit-queue 2016-03-21 10:17:36 -0700 All reviewed patches have been landed. Closing bug. 274541 2016-03-20 10:08:30 -0700 2016-03-21 06:21:18 -0700 Patch bug-155698-20160320200829.patch text/plain 1500 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy YjUzMzcwOTIzYmNkNThjZDA3YmE5YWRmNjcwZGVhNjgzNjQxOTBjLi5kMTMxM2FlNjFmNTAyZTA2 MjI3ZDI3NjY1YThlMjYzNTU2ZDk2OGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNi0wMy0yMCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgRml4ZWQgY29tcGlsYXRpb24gd2l0aCBHQ0MgNC44LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1Njk4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR0NDIDQuOCBkb2VzIG5v dCBhbGxvdyBhZ2dyZWdhdGUgaW5pdGlhbGl6YXRpb24gZm9yIHR5cGUgd2l0aCBkZWxldGVkCisg ICAgICAgIGNvbnN0cnVjdG9yLCBzZWUgaHR0cHM6Ly9nY2MuZ251Lm9yZy9idWd6aWxsYS9zaG93 X2J1Zy5jZ2k/aWQ9NTI3MDcuCisKKyAgICAgICAgKiBkZmcvREZHQ1NFUGhhc2UuY3BwOiBBZGRl ZCBjdG9yIGZvciBJbXB1cmVEYXRhU2xvdC4KKwogMjAxNi0wMy0xOSAgU2thY2hrb3YgT2xla3Nh bmRyICA8Z3NrYWNoa292QGdtYWlsLmNvbT4KIAogICAgICAgICBbRVM2XSBBcnJvdyBmdW5jdGlv biBzeW50YXguIFVwZGF0ZSBzeW50YXggZXJyb3IgdGV4dCAnc3VwZXIgaXMgb25seSB2YWxpZCBp bnNpZGUgZnVuY3Rpb25zJyB0byBtb3JlIHN1aXRhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0NTRVBoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQ1NFUGhhc2UuY3BwCmluZGV4IDQwMjNmNmIxNzJjMWQyMmI2MDk5ZDQ2YjBkOGI2ZTM2 NTkyZTU1YjYuLjFhMDllNDFlNWIzZTZhZjBlN2VjZGI1YTU4OTllZjdiNWEzMjVhOTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ1NFUGhhc2UuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ1NFUGhhc2UuY3BwCkBAIC01NSw2ICs1NSwxMCBA QCBjbGFzcyBJbXB1cmVEYXRhU2xvdCB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoSW1wdXJl RGF0YVNsb3QpOwogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgorICAgIElt cHVyZURhdGFTbG90KEhlYXBMb2NhdGlvbiBfa2V5LCBMYXp5Tm9kZSBfdmFsdWUsIHVuc2lnbmVk IF9oYXNoKQorICAgICAgICA6IGtleShfa2V5KSwgdmFsdWUoX3ZhbHVlKSwgaGFzaChfaGFzaCkK KyAgICB7IH0KKwogICAgIEhlYXBMb2NhdGlvbiBrZXk7CiAgICAgTGF6eU5vZGUgdmFsdWU7CiAg ICAgdW5zaWduZWQgaGFzaDsK 274583 2016-03-21 06:21:27 -0700 2016-03-21 10:17:32 -0700 Patch bug-155698-20160321162127.patch text/plain 1494 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy YjUzMzcwOTIzYmNkNThjZDA3YmE5YWRmNjcwZGVhNjgzNjQxOTBjLi5kMTMxM2FlNjFmNTAyZTA2 MjI3ZDI3NjY1YThlMjYzNTU2ZDk2OGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNi0wMy0yMCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgRml4ZWQgY29tcGlsYXRpb24gd2l0aCBHQ0MgNC44LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1Njk4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR0NDIDQuOCBkb2VzIG5v dCBhbGxvdyBhZ2dyZWdhdGUgaW5pdGlhbGl6YXRpb24gZm9yIHR5cGUgd2l0aCBkZWxldGVkCisg ICAgICAgIGNvbnN0cnVjdG9yLCBzZWUgaHR0cHM6Ly9nY2MuZ251Lm9yZy9idWd6aWxsYS9zaG93 X2J1Zy5jZ2k/aWQ9NTI3MDcuCisKKyAgICAgICAgKiBkZmcvREZHQ1NFUGhhc2UuY3BwOiBBZGRl ZCBjdG9yIGZvciBJbXB1cmVEYXRhU2xvdC4KKwogMjAxNi0wMy0xOSAgU2thY2hrb3YgT2xla3Nh bmRyICA8Z3NrYWNoa292QGdtYWlsLmNvbT4KIAogICAgICAgICBbRVM2XSBBcnJvdyBmdW5jdGlv biBzeW50YXguIFVwZGF0ZSBzeW50YXggZXJyb3IgdGV4dCAnc3VwZXIgaXMgb25seSB2YWxpZCBp bnNpZGUgZnVuY3Rpb25zJyB0byBtb3JlIHN1aXRhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0NTRVBoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQ1NFUGhhc2UuY3BwCmluZGV4IDQwMjNmNmIxNzJjMWQyMmI2MDk5ZDQ2YjBkOGI2ZTM2 NTkyZTU1YjYuLmU5ZDljMzMzMGY5YjY2ZjI1OWJiNTY4ODc1MzhkYTZlOWZiYjg5ZTcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ1NFUGhhc2UuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ1NFUGhhc2UuY3BwCkBAIC01NSw2ICs1NSwxMCBA QCBjbGFzcyBJbXB1cmVEYXRhU2xvdCB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoSW1wdXJl RGF0YVNsb3QpOwogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgorICAgIElt cHVyZURhdGFTbG90KEhlYXBMb2NhdGlvbiBrZXksIExhenlOb2RlIHZhbHVlLCB1bnNpZ25lZCBo YXNoKQorICAgICAgICA6IGtleShrZXkpLCB2YWx1ZSh2YWx1ZSksIGhhc2goaGFzaCkKKyAgICB7 IH0KKwogICAgIEhlYXBMb2NhdGlvbiBrZXk7CiAgICAgTGF6eU5vZGUgdmFsdWU7CiAgICAgdW5z aWduZWQgaGFzaDsK