155674 2016-03-18 17:17:05 -0700 Enable preview of images as attachments 2016-03-21 12:29:07 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica bdakin sam thorton oldest_to_newest 1176395 0 enrica 2016-03-18 17:17:05 -0700 If the client can handle attachments, it can decide to handle images as attachments as well. rdar://problem/25242656 1176396 1 274483 enrica 2016-03-18 17:19:47 -0700 Created attachment 274483 Patch 1176459 2 274483 darin 2016-03-18 22:27:22 -0700 Comment on attachment 274483 Patch Would be nice to have some regression test coverage for this. 1176818 3 enrica 2016-03-21 12:29:07 -0700 Committed revision 198496. 274483 2016-03-18 17:19:47 -0700 2016-03-18 22:27:22 -0700 Patch images-as-attachments.txt text/plain 3047 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODQ1NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAzLTE4ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIHByZXZpZXcgb2Yg aW1hZ2VzIGFzIGF0dGFjaG1lbnRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU1Njc0CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI1MjQyNjU2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIGNs aWVudCBjYW5ub3QgaGFuZGxlIGltYWdlIHByZXZpZXcsIGJ1dCBjYW4gaGFuZGxlIGF0dGFjaG1l bnRzLAorICAgICAgICBsZXQgdGhlbSBoYW5kbGUgaW1hZ2VzIGFzIGF0dGFjaG1lbnRzLgorCisg ICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAg ICAgICgtW1dLQ29udGVudFZpZXcgX2RhdGFGb3JQcmV2aWV3SXRlbUNvbnRyb2xsZXI6YXRQb3Np dGlvbjp0eXBlOl0pOgorCiAyMDE2LTAzLTE4ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgR2l2ZSBOU1VSTFNlc3Npb25Db25maWd1cmF0aW9u IGluZm9ybWF0aW9uIGFib3V0IHBhcmVudCBwcm9jZXNzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQko cmV2aXNpb24gMTk4NDQ2KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTM4MjcsNyArMzgyNyw3IEBA IC0gKE5TRGljdGlvbmFyeSAqKV9kYXRhRm9yUHJldmlld0l0ZW1Db24KICAgICBCT09MIGNhblNo b3dMaW5rUHJldmlldyA9IF9wb3NpdGlvbkluZm9ybWF0aW9uLmlzTGluayB8fCBjYW5TaG93SW1h Z2VQcmV2aWV3OwogICAgIEJPT0wgdXNlSW1hZ2VVUkxGb3JMaW5rID0gTk87CiAgICAgQk9PTCBz dXBwb3J0c0F0dGFjaG1lbnRQcmV2aWV3ID0gW3VpRGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9y OkBzZWxlY3RvcihfYXR0YWNobWVudExpc3RGb3JXZWJWaWV3OildICYmIFt1aURlbGVnYXRlIHJl c3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlZpZXc6aW5kZXhJbnRvQXR0YWNobWVudExp c3RGb3JFbGVtZW50OildOwotICAgIEJPT0wgY2FuU2hvd0F0dGFjaG1lbnRQcmV2aWV3ID0gX3Bv c2l0aW9uSW5mb3JtYXRpb24uaXNBdHRhY2htZW50ICYmIHN1cHBvcnRzQXR0YWNobWVudFByZXZp ZXc7CisgICAgQk9PTCBjYW5TaG93QXR0YWNobWVudFByZXZpZXcgPSAoX3Bvc2l0aW9uSW5mb3Jt YXRpb24uaXNBdHRhY2htZW50IHx8IF9wb3NpdGlvbkluZm9ybWF0aW9uLmlzSW1hZ2UpICYmIHN1 cHBvcnRzQXR0YWNobWVudFByZXZpZXc7CiAKICAgICBpZiAoY2FuU2hvd0ltYWdlUHJldmlldyAm JiBfcG9zaXRpb25JbmZvcm1hdGlvbi5pc0FuaW1hdGVkSW1hZ2UpIHsKICAgICAgICAgY2FuU2hv d0ltYWdlUHJldmlldyA9IE5POwpAQCAtMzg4Niw4ICszODg2LDExIEBAIC0gKE5TRGljdGlvbmFy eSAqKV9kYXRhRm9yUHJldmlld0l0ZW1Db24KICAgICAgICAgZW51bSB7IFdLVUlQcmV2aWV3SXRl bVR5cGVBdHRhY2htZW50ID0gNSB9OwogICAgICAgICAqdHlwZSA9IHN0YXRpY19jYXN0PFVJUHJl dmlld0l0ZW1UeXBlPihXS1VJUHJldmlld0l0ZW1UeXBlQXR0YWNobWVudCk7CiAgICAgICAgIGNv bnN0IGF1dG8mIGVsZW1lbnQgPSBbW19XS0FjdGl2YXRlZEVsZW1lbnRJbmZvIGFsbG9jXSBfaW5p dFdpdGhUeXBlOl9XS0FjdGl2YXRlZEVsZW1lbnRUeXBlQXR0YWNobWVudCBVUkw6W05TVVJMIF93 ZWJfVVJMV2l0aFdURlN0cmluZzpfcG9zaXRpb25JbmZvcm1hdGlvbi51cmxdIGxvY2F0aW9uOl9w b3NpdGlvbkluZm9ybWF0aW9uLnBvaW50IHRpdGxlOl9wb3NpdGlvbkluZm9ybWF0aW9uLnRpdGxl IElEOl9wb3NpdGlvbkluZm9ybWF0aW9uLmlkQXR0cmlidXRlIHJlY3Q6X3Bvc2l0aW9uSW5mb3Jt YXRpb24uYm91bmRzIGltYWdlOm5pbF07Ci0gICAgICAgIGRhdGFGb3JQcmV2aWV3W0AiVUlQcmV2 aWV3RGF0YUF0dGFjaG1lbnRMaXN0Il0gPSBbdWlEZWxlZ2F0ZSBfYXR0YWNobWVudExpc3RGb3JX ZWJWaWV3Ol93ZWJWaWV3XTsKLSAgICAgICAgZGF0YUZvclByZXZpZXdbQCJVSVByZXZpZXdEYXRh QXR0YWNobWVudEluZGV4Il0gPSBbTlNOdW1iZXIgbnVtYmVyV2l0aFVuc2lnbmVkSW50ZWdlcjpb dWlEZWxlZ2F0ZSBfd2ViVmlldzpfd2ViVmlldyBpbmRleEludG9BdHRhY2htZW50TGlzdEZvckVs ZW1lbnQ6ZWxlbWVudF1dOworICAgICAgICBOU1VJbnRlZ2VyIGluZGV4ID0gW3VpRGVsZWdhdGUg X3dlYlZpZXc6X3dlYlZpZXcgaW5kZXhJbnRvQXR0YWNobWVudExpc3RGb3JFbGVtZW50OmVsZW1l bnRdOworICAgICAgICBpZiAoaW5kZXggIT0gTlNOb3RGb3VuZCkgeworICAgICAgICAgICAgZGF0 YUZvclByZXZpZXdbQCJVSVByZXZpZXdEYXRhQXR0YWNobWVudExpc3QiXSA9IFt1aURlbGVnYXRl IF9hdHRhY2htZW50TGlzdEZvcldlYlZpZXc6X3dlYlZpZXddOworICAgICAgICAgICAgZGF0YUZv clByZXZpZXdbQCJVSVByZXZpZXdEYXRhQXR0YWNobWVudEluZGV4Il0gPSBbTlNOdW1iZXIgbnVt YmVyV2l0aFVuc2lnbmVkSW50ZWdlcjppbmRleF07CisgICAgICAgIH0KICAgICB9CiAgICAgCiAg ICAgcmV0dXJuIGRhdGFGb3JQcmV2aWV3Owo=