155671 2016-03-18 16:30:15 -0700 Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._treeOutlineDataGridSynchronizer.treeElementForDataGridNode') 2016-03-18 17:56:04 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1176362 0 joepeck 2016-03-18 16:30:15 -0700 Uncaught exceptions: - TypeError: undefined is not an object (evaluating 'this._treeOutlineDataGridSynchronizer.treeElementForDataGridNode') (at TimelineDataGrid.js:318:72) * STEPS TO REPRODUCE 1. Open Inspector 2. Record a timeline with some data 3. Stop the recording 4. Show a Timeline Data Grid (Scripts / Layout & Rendering) 5. Attempt to change sort of a column => Exception 1176364 1 joepeck 2016-03-18 16:30:25 -0700 <rdar://problem/25249401> 1176370 2 274476 joepeck 2016-03-18 16:42:51 -0700 Created attachment 274476 [PATCH] Proposed Fix Handle sorting when there is no this._treeOutlineDataGridSynchronizer. 1176402 3 274476 commit-queue 2016-03-18 17:56:02 -0700 Comment on attachment 274476 [PATCH] Proposed Fix Clearing flags on attachment: 274476 Committed r198459: <http://trac.webkit.org/changeset/198459> 1176403 4 commit-queue 2016-03-18 17:56:04 -0700 All reviewed patches have been landed. Closing bug. 274476 2016-03-18 16:42:51 -0700 2016-03-18 17:56:02 -0700 [PATCH] Proposed Fix fix-sort.patch text/plain 2704 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg5YzRjYTAuLjhmODQxN2YgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTAzLTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBU eXBlRXJyb3I6IHVuZGVmaW5lZCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICd0aGlzLl90 cmVlT3V0bGluZURhdGFHcmlkU3luY2hyb25pemVyLnRyZWVFbGVtZW50Rm9yRGF0YUdyaWROb2Rl JykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTY3 MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjUyNDk0MDE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVs aW5lRGF0YUdyaWQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVEYXRhR3JpZC5w cm90b3R5cGUuX3NvcnQpOgorCisyMDE2LTAzLTE4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogQnVsbGV0IG1pc2FsaWduZWQg d2hlbiBleHBhbmRpbmcgY29uc29sZSBsb2cgbWVzc2FnZQogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NjY5CiAgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8yNTI1MDcyMT4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UaW1lbGluZURhdGFHcmlkLmpzCmluZGV4IDQyMmY5YzkuLjVhYzgy ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RpbWVsaW5lRGF0YUdyaWQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGltZWxpbmVEYXRhR3JpZC5qcwpAQCAtMzE1LDE3ICszMTUsMTkgQEAgV2Vi SW5zcGVjdG9yLlRpbWVsaW5lRGF0YUdyaWQgPSBjbGFzcyBUaW1lbGluZURhdGFHcmlkIGV4dGVu ZHMgV2ViSW5zcGVjdG9yLkRhdGEKICAgICAgICAgICAgIGNoaWxkRGF0YUdyaWROb2Rlcy5zb3J0 KHRoaXMuX3NvcnRDb21wYXJhdG9yLmJpbmQodGhpcykpOwogCiAgICAgICAgICAgICBmb3IgKGxl dCBkYXRhR3JpZE5vZGUgb2YgY2hpbGREYXRhR3JpZE5vZGVzKSB7Ci0gICAgICAgICAgICAgICAg bGV0IHRyZWVFbGVtZW50ID0gdGhpcy5fdHJlZU91dGxpbmVEYXRhR3JpZFN5bmNocm9uaXplci50 cmVlRWxlbWVudEZvckRhdGFHcmlkTm9kZShkYXRhR3JpZE5vZGUpOwotICAgICAgICAgICAgICAg IGNvbnNvbGUuYXNzZXJ0KHRyZWVFbGVtZW50KTsKKyAgICAgICAgICAgICAgICBpZiAodGhpcy5f dHJlZU91dGxpbmVEYXRhR3JpZFN5bmNocm9uaXplcikgeworICAgICAgICAgICAgICAgICAgICBs ZXQgdHJlZUVsZW1lbnQgPSB0aGlzLl90cmVlT3V0bGluZURhdGFHcmlkU3luY2hyb25pemVyLnRy ZWVFbGVtZW50Rm9yRGF0YUdyaWROb2RlKGRhdGFHcmlkTm9kZSk7CisgICAgICAgICAgICAgICAg ICAgIGNvbnNvbGUuYXNzZXJ0KHRyZWVFbGVtZW50KTsKIAotICAgICAgICAgICAgICAgIGlmIChw YXJlbnRUcmVlRWxlbWVudCkKLSAgICAgICAgICAgICAgICAgICAgcGFyZW50VHJlZUVsZW1lbnQu YXBwZW5kQ2hpbGQodHJlZUVsZW1lbnQpOworICAgICAgICAgICAgICAgICAgICBpZiAocGFyZW50 VHJlZUVsZW1lbnQpCisgICAgICAgICAgICAgICAgICAgICAgICBwYXJlbnRUcmVlRWxlbWVudC5h cHBlbmRDaGlsZCh0cmVlRWxlbWVudCk7CisKKyAgICAgICAgICAgICAgICAgICAgLy8gQWRkaW5n IHRoZSB0cmVlIGVsZW1lbnQgYmFjayB0byB0aGUgdHJlZSBvdXRsaW5lIHN1YmplY3RzIGl0IHRv IGZpbHRlcnMuCisgICAgICAgICAgICAgICAgICAgIC8vIE1ha2Ugc3VyZSB3ZSBrZWVwIHRoZSBo aWRkZW4gc3RhdGUgaW4tc3luYyB3aGlsZSB0aGUgc3luY2hyb25pemVyIGlzIGRpc2FibGVkLgor ICAgICAgICAgICAgICAgICAgICBkYXRhR3JpZE5vZGUuZWxlbWVudC5jbGFzc0xpc3QudG9nZ2xl KCJoaWRkZW4iLCB0cmVlRWxlbWVudC5oaWRkZW4pOworICAgICAgICAgICAgICAgIH0KIAogICAg ICAgICAgICAgICAgIHBhcmVudERhdGFHcmlkTm9kZS5hcHBlbmRDaGlsZChkYXRhR3JpZE5vZGUp OwotCi0gICAgICAgICAgICAgICAgLy8gQWRkaW5nIHRoZSB0cmVlIGVsZW1lbnQgYmFjayB0byB0 aGUgdHJlZSBvdXRsaW5lIHN1YmplY3RzIGl0IHRvIGZpbHRlcnMuCi0gICAgICAgICAgICAgICAg Ly8gTWFrZSBzdXJlIHdlIGtlZXAgdGhlIGhpZGRlbiBzdGF0ZSBpbi1zeW5jIHdoaWxlIHRoZSBz eW5jaHJvbml6ZXIgaXMgZGlzYWJsZWQuCi0gICAgICAgICAgICAgICAgZGF0YUdyaWROb2RlLmVs ZW1lbnQuY2xhc3NMaXN0LnRvZ2dsZSgiaGlkZGVuIiwgdHJlZUVsZW1lbnQuaGlkZGVuKTsKICAg ICAgICAgICAgIH0KICAgICAgICAgfQogCg==