155668 2016-03-18 15:51:31 -0700 Web Inspector: Fix ObjectTree Map styling, key/value look cramped 2016-03-18 16:50:21 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1176336 0 joepeck 2016-03-18 15:51:31 -0700 * SUMMARY Fix ObjectTree Map styling, key/value look cramped. * TEST <script> var map = new Map; map.set("HTMLFooElement", {className:"HTMLElement", size:1234, count:120}); map.set("HTMLBarElement", {className:"HTMLElement", size:1234, count:120}); map.set("HTMLDivElement", {className:"HTMLElement", size:1234, count:120}); map.set("HTMLSpanElement", {className:"HTMLElement", size:1234, count:120}); map.set("HTMLAnchorElement", {className:"HTMLElement", size:1234, count:120}); map.set("HTMLArticleElement", {className:"HTMLElement", size:1234, count:120}); console.log(map); </script> * STEPS TO REPRODUCE 1. Load test case 2. Show console 3. Expand Map => "key" and "value" look cramped 1176337 1 webkit-bug-importer 2016-03-18 15:52:25 -0700 <rdar://problem/25250519> 1176338 2 274464 joepeck 2016-03-18 15:52:50 -0700 Created attachment 274464 [PATCH] Proposed Fix 1176376 3 274464 commit-queue 2016-03-18 16:50:18 -0700 Comment on attachment 274464 [PATCH] Proposed Fix Clearing flags on attachment: 274464 Committed r198452: <http://trac.webkit.org/changeset/198452> 1176377 4 commit-queue 2016-03-18 16:50:21 -0700 All reviewed patches have been landed. Closing bug. 274464 2016-03-18 15:52:50 -0700 2016-03-18 16:50:18 -0700 [PATCH] Proposed Fix object-tree.patch text/plain 2217 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUyMzlmOTUuLjI3ZThiOWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTAzLTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IE9i amVjdFRyZWUgTWFwIHN0eWxpbmcsIGtleS92YWx1ZSBsb29rIGNyYW1wZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTY2OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9PYmplY3RUcmVlQXJyYXlJbmRleFRyZWVFbGVtZW50LmNzczoKKyAgICAgICAgKC50cmVlLW91 dGxpbmUgLml0ZW0ub2JqZWN0LXRyZWUtYXJyYXktaW5kZXgpOgorICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvT2JqZWN0VHJlZU1hcEVudHJ5VHJlZUVsZW1lbnQuY3NzOgorICAgICAgICAo LnRyZWUtb3V0bGluZSAuaXRlbS5vYmplY3QtdHJlZS1tYXAtZW50cnkpOgorICAgICAgICBXaGVu IGNyZWF0aW5nIGdlbmVyaWMgdHJlZSBvdXRsaW5lIHN0eWxlcyBnZW5lcmljIG9iamVjdCB0cmVl CisgICAgICAgIHN0eWxlcyB3ZXJlIGdldHRpbmcgb3ZlcnJpZGVuIGJ5IGdlbmVyaWMgdHJlZSBv dXRsaW5lIHN0eWxlcworICAgICAgICB3aXRoIGhpZ2hlciBzcGVjaWZpY2l0eS4KKworMjAxNi0w My0xOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFRpbWVsaW5lIHJlc2V0IGlzc3VlcyBhZnRlciBOYXZpZ2F0aW9uIFNpZGVi YXIgcmVtb3ZhbAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU1NjU4CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNTI0NTI5Mj4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVBcnJh eUluZGV4VHJlZUVsZW1lbnQuY3NzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvT2JqZWN0VHJlZUFycmF5SW5kZXhUcmVlRWxlbWVudC5jc3MKaW5kZXggZDY3OGM1 Yi4uMWY0YjQwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvT2JqZWN0VHJlZUFycmF5SW5kZXhUcmVlRWxlbWVudC5jc3MKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZUFycmF5SW5kZXhU cmVlRWxlbWVudC5jc3MKQEAgLTIzLDcgKzIzLDcgQEAKICAqIFRIRSBQT1NTSUJJTElUWSBPRiBT VUNIIERBTUFHRS4KICAqLwogCi0ub2JqZWN0LXRyZWUtYXJyYXktaW5kZXggeworLnRyZWUtb3V0 bGluZSAuaXRlbS5vYmplY3QtdHJlZS1hcnJheS1pbmRleCB7CiAgICAgcG9zaXRpb246IHJlbGF0 aXZlOwogICAgIGxlZnQ6IC0xMnB4OwogICAgIG1hcmdpbi10b3A6IDJweDsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVNYXBF bnRyeVRyZWVFbGVtZW50LmNzcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL09iamVjdFRyZWVNYXBFbnRyeVRyZWVFbGVtZW50LmNzcwppbmRleCBiOGE4MjFiLi45 NjQ0N2EyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9PYmplY3RUcmVlTWFwRW50cnlUcmVlRWxlbWVudC5jc3MKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZU1hcEVudHJ5VHJlZUVsZW1l bnQuY3NzCkBAIC0zMiw5ICszMiw4IEBACiAgICAgYm9yZGVyLXRvcDogMXB4IHNvbGlkIGhzbGEo MCwgMCUsIDAlLCAwLjA1KTsKIH0KIAotLm9iamVjdC10cmVlLW1hcC1lbnRyeSB7CisudHJlZS1v dXRsaW5lIC5pdGVtLm9iamVjdC10cmVlLW1hcC1lbnRyeSB7CiAgICAgcGFkZGluZy10b3A6IDJw eDsKLSAgICBwYWRkaW5nLWJvdHRvbTogMnB4OwogICAgIGxlZnQ6IC0ycHg7CiB9CiAK