15564 2007-10-19 09:54:59 -0700 HitTesting is incorrect for test-anchor: middle 2007-11-25 05:06:01 -0800 1 1 1 Unclassified WebKit SVG 523.x (Safari 3) All All RESOLVED FIXED http://www.humanracetrack.com/misc/webkit_bug.svg P2 Normal --- 1 good4me zimmermann zimmermann oldest_to_newest 58856 0 good4me 2007-10-19 09:54:59 -0700 When text-anchor="middle" occurs, this causes the glyphs to not be rendered that occur before the path (which is correct behavior). When this happens, however, the entire X and Y domain less than the fallen-off text is treated (with onMouseOver) as if the text were covering the entire area. This is not the case in other SVG viewers. 58872 1 eric 2007-10-19 12:12:27 -0700 We'll need to build a DRT compatible test, but the attached reduction is great, thanks! 58874 2 zimmermann 2007-10-19 13:50:21 -0700 Hi Adam, thanks a lot for the nice report. I'm aware of the bug, it's especially nicely visible in Web Inspector (the <textPath> x/y origin starts at 0x0, when text-anchor is not "start". The reduction looks excellent, I'm going to make a DRT compatible layout test out of it! Greetings, Niko 62270 3 17503 zimmermann 2007-11-25 03:14:48 -0800 Created attachment 17503 Initial patch Bug fixed, contains a DRT compatible reduction of Adams nice testcase! 62271 4 17504 zimmermann 2007-11-25 03:16:42 -0800 Created attachment 17504 DRT reduction 62273 5 17503 aroben 2007-11-25 04:08:07 -0800 Comment on attachment 17503 Initial patch + it++; We normally use the prefix increment operator on iterators, for efficiency. + if (pathData) + return pathData->hidden; + + return false; This can just be return pathData && pathData->hidden; Make sure you land the layout test and results with it. r=me 62274 6 zimmermann 2007-11-25 05:06:01 -0800 Landed in r28015. Incorported all of Adams comments. 17503 2007-11-25 03:14:48 -0800 2007-11-25 04:08:07 -0800 Initial patch FixTextAnchorOnTextPathProblems.diff text/plain 6714 zimmermann SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI3OTcz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMDctMTEt MjIgIE5pa29sYXMgWmltbWVybWFubiAgPHppbW1lcm1hbm5Aa2RlLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlczogaHR0cDovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzOTMKKworICAgICAgICBGaXggcHJvYmxlbXMg d2l0aCBoaWRkZW4gZ2x5cGhzLiBUaGV5IHdlcmUgdGFrZW4gaW50byBhY2NvdW50IGZvciBxdWl0 ZQorICAgICAgICBzb21lIG9wZXJhdGlvbnMgKGhpdCB0ZXN0aW5nLCBsZW5ndGggY2FsdWxjYXRp b25zIGV0Yy4uKSBleGNlcHQgcGFpbnRpbmcuCisgICAgICAgIEVzcGVjaWFsbHkgZml4ZXMgYm91 bmRhcmllcyBvZiA8dGV4dFBhdGg+IChzZWUgdXNpbmcgV2ViIEluc3BlY3RvcikgaWYKKyAgICAg ICAgdGV4dC1hbmNob3IgaXNuJ3QgZXF1YWwgdG8gJ3N0YXJ0Jy4KKworICAgICAgICBBZGRlZCB0 ZXN0Y2FzZToKKyAgICAgICAgc3ZnL3RleHQvdGV4dFBhdGhCb3VuZHNCdWcuc3ZnCisKKyAgICAg ICAgRml4ZWQgdGVzdGNhc2U6IChhbGwgc2hvd2VkIHRleHQgc2VsZWN0aW9uIHByb2JsZW1zIG9u IHRleHQgcGF0aHMpCisgICAgICAgIHN2Zy9iYXRpay90ZXh0L3RleHRHbHlwaE9yaWVudGF0aW9u SG9yaXpvbnRhbC5zdmcKKyAgICAgICAgc3ZnL2JhdGlrL3RleHQvdGV4dE9uUGF0aC5zdmcKKyAg ICAgICAgc3ZnL2JhdGlrL3RleHQvdGV4dE9uUGF0aDMuc3ZnCisgICAgICAgIHN2Zy9iYXRpay90 ZXh0L3ZlcnRpY2FsVGV4dE9uUGF0aC5zdmcKKyAgICAgICAgc3ZnL3RleHQvdGV4dC1hbGlnbi0w NC1iLnN2ZworICAgICAgICBzdmcvVzNDLVNWRy0xLjEvdGV4dC1hbGlnbi0wNC1iLnN2ZworCisg ICAgICAgICogcmVuZGVyaW5nL1NWR1Jvb3RJbmxpbmVCb3guY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U1ZHUm9vdElubGluZUJveDo6bGF5b3V0SW5saW5lQm94ZXMpOgorCiAyMDA3LTExLTIyICBM YXN6bG8gR29tYm9zICA8bGFzemxvLmdvbWJvc0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQWxwIFRva2VyLgpJbmRleDogcmVuZGVyaW5nL1NWR1Jvb3RJbmxpbmVCb3guY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIHJlbmRlcmluZy9TVkdSb290SW5saW5lQm94LmNwcAkocmV2aXNpb24gMjc4 NTApCisrKyByZW5kZXJpbmcvU1ZHUm9vdElubGluZUJveC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTMwMyw2ICszMDMsOSBAQAogewogICAgIGZsb2F0IGxvd1ggPSBGTFRfTUFYLCBsb3dZID0gRkxU X01BWDsKICAgICBmb3IgKDsgaXQgIT0gZW5kOyArK2l0KSB7CisgICAgICAgIGlmIChpdC0+aXNI aWRkZW4oKSkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAgIGZsb2F0IHggPSAoKml0 KS54OwogICAgICAgICBmbG9hdCB5ID0gKCppdCkueTsKIApAQCAtNDk5LDEzICs1MDIsMTMgQEAK ICAgICAgICAgICAgIG1fcGFpbnRJbmZvLmNvbnRleHQtPmNvbmNhdENUTShjaHVua0N0bSk7CiAK ICAgICAgICAgZm9yIChWZWN0b3I8U1ZHQ2hhcj46Oml0ZXJhdG9yIGl0ID0gc3RhcnQ7IGl0ICE9 IGVuZDsgKytpdCkgewotICAgICAgICAgICAgaWYgKCgqaXQpLnBhdGhEYXRhICYmICEoKml0KS5w YXRoRGF0YS0+dmlzaWJsZSkKKyAgICAgICAgICAgIGlmIChpdC0+aXNIaWRkZW4oKSkKICAgICAg ICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICAgICAgLy8gRGV0ZXJtaW5lIGhvdyBtYW55 IGNoYXJhY3RlcnMgLSBzdGFydGluZyBmcm9tIHRoZSBjdXJyZW50IC0gY2FuIGJlIGRyYXduIGF0 IG9uY2UuCiAgICAgICAgICAgICBWZWN0b3I8U1ZHQ2hhcj46Oml0ZXJhdG9yIGl0U2VhcmNoID0g aXQgKyAxOwogICAgICAgICAgICAgd2hpbGUgKGl0U2VhcmNoICE9IGVuZCkgewotICAgICAgICAg ICAgICAgIGlmICgoKml0U2VhcmNoKS5kcmF3blNlcGVyYXRlZCkKKyAgICAgICAgICAgICAgICBp ZiAoaXRTZWFyY2gtPmRyYXduU2VwZXJhdGVkIHx8IGl0U2VhcmNoLT5pc0hpZGRlbigpKQogICAg ICAgICAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICAgICAgICAgIGl0U2VhcmNoKys7CkBA IC02NzAsNyArNjczLDggQEAKICAgICAgICAgICAgIFZlY3RvcjxTVkdDaGFyPjo6aXRlcmF0b3Ig aXRTZWFyY2ggPSBjaGFySXQgKyAxOwogICAgICAgICAgICAgVmVjdG9yPFNWR0NoYXI+OjppdGVy YXRvciBlbmRTZWFyY2ggPSBjaGFySXQgKyByYW5nZS5lbmRPZmZzZXQgLSBpOwogICAgICAgICAg ICAgd2hpbGUgKGl0U2VhcmNoICE9IGVuZFNlYXJjaCkgewotICAgICAgICAgICAgICAgIGlmICgo Kml0U2VhcmNoKS5kcmF3blNlcGVyYXRlZCkKKyAgICAgICAgICAgICAgICAvLyBObyBuZWVkIHRv IGNoZWNrIGZvciAnaXNIaWRkZW4oKScgaGVyZSBhcyB0aGlzIGZ1bmN0aW9uIGlzIG5vdCBjYWxs ZWQgZm9yIHRleHQgcGF0aHMuCisgICAgICAgICAgICAgICAgaWYgKGl0U2VhcmNoLT5kcmF3blNl cGVyYXRlZCkKICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAKICAgICAgICAgICAgICAgICBp dFNlYXJjaCsrOwpAQCAtNzQ2LDYgKzc1MCw5IEBACiAKIHN0YXRpYyB2b2lkIGFwcGx5VGV4dEFu Y2hvclRvVGV4dENodW5rKFNWR1RleHRDaHVuayYgY2h1bmspCiB7CisgICAgLy8gVGhpcyBtZXRo b2QgaXMgbm90IGNhbGxlZCBmb3IgY2h1bmtzIGNvbnRhaW5pbmcgY2hhcnMgYWxpZ25lZCBvbiBh IHBhdGguCisgICAgLy8gLT4gYWxsIGNoYXJhY3RlcnMgYXJlIHZpc2libGUsIG5vIG5lZWQgdG8g Y2hlY2sgZm9yICJpc1Zpc2libGUoKSIgYW55d2hlcmUuCisKICAgICBpZiAoY2h1bmsuYW5jaG9y ID09IFRBX1NUQVJUKQogICAgICAgICByZXR1cm47CiAKQEAgLTgxMiw2ICs4MTksOSBAQAogCiBz dGF0aWMgdm9pZCBhcHBseVRleHRMZW5ndGhDb3JyZWN0aW9uVG9UZXh0Q2h1bmsoU1ZHVGV4dENo dW5rJiBjaHVuaykKIHsKKyAgICAvLyBUaGlzIG1ldGhvZCBpcyBub3QgY2FsbGVkIGZvciBjaHVu a3MgY29udGFpbmluZyBjaGFycyBhbGlnbmVkIG9uIGEgcGF0aC4KKyAgICAvLyAtPiBhbGwgY2hh cmFjdGVycyBhcmUgdmlzaWJsZSwgbm8gbmVlZCB0byBjaGVjayBmb3IgImlzVmlzaWJsZSgpIiBh bnl3aGVyZS4KKwogICAgIC8vIGxlbmd0aEFkanVzdD0ic3BhY2luZ0FuZEdseXBocyIgaXMgaGFu ZGxlZCBieSBtb2RpZnlpbmcgY2h1bmsuY3RtCiAgICAgZmxvYXQgY29tcHV0ZWRMZW5ndGggPSAw LjBmOwogICAgIGZsb2F0IHNwYWNpbmdUb0FwcGx5ID0gY2FsY3VsYXRlVGV4dExlbmd0aENvcnJl Y3Rpb25Gb3JUZXh0Q2h1bmsoY2h1bmssIGNodW5rLmxlbmd0aEFkanVzdCwgY29tcHV0ZWRMZW5n dGgpOwpAQCAtOTk0LDYgKzEwMDQsMTEgQEAKICAgICAgICAgICAgIGZvciAodW5zaWduZWQgaSA9 IDA7IGkgPCBsZW5ndGg7ICsraSkgewogICAgICAgICAgICAgICAgIEFTU0VSVChpdCAhPSBtX3N2 Z0NoYXJzLmVuZCgpKTsKIAorICAgICAgICAgICAgICAgIGlmIChpdC0+aXNIaWRkZW4oKSkgewor ICAgICAgICAgICAgICAgICAgICBpdCsrOworICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsK KyAgICAgICAgICAgICAgICB9CisKICAgICAgICAgICAgICAgICBzdHJpbmdSZWN0LnVuaXRlKHRl eHRCb3gtPmNhbGN1bGF0ZUdseXBoQm91bmRhcmllcyhzdHlsZSwgdGV4dEJveC0+c3RhcnQoKSAr IGksICppdCkpOwogICAgICAgICAgICAgICAgIGl0Kys7CiAgICAgICAgICAgICB9CkBAIC0xMjEy LDcgKzEyMjcsNyBAQAogICAgICAgICAgICAgZmxvYXQgcGF0aEV4dHJhQWR2YW5jZSA9IGluZm8u cGF0aEV4dHJhQWR2YW5jZTsKICAgICAgICAgICAgIGluZm8ucGF0aEV4dHJhQWR2YW5jZSArPSBz cGFjaW5nOwogCi0gICAgICAgICAgICBzdmdDaGFyLnBhdGhEYXRhLT52aXNpYmxlID0gaW5mby5u ZXh0UGF0aExheW91dFBvaW50QW5kQW5nbGUoY29ycmVjdGVkR2x5cGhBZHZhbmNlLCBleHRyYUFk dmFuY2UsIG5ld09mZnNldCk7CisgICAgICAgICAgICBzdmdDaGFyLnBhdGhEYXRhLT5oaWRkZW4g PSAhaW5mby5uZXh0UGF0aExheW91dFBvaW50QW5kQW5nbGUoY29ycmVjdGVkR2x5cGhBZHZhbmNl LCBleHRyYUFkdmFuY2UsIG5ld09mZnNldCk7CiAgICAgICAgICAgICBzdmdDaGFyLmRyYXduU2Vw ZXJhdGVkID0gdHJ1ZTsKIAogICAgICAgICAgICAgaW5mby5wYXRoRXh0cmFBZHZhbmNlID0gcGF0 aEV4dHJhQWR2YW5jZTsKSW5kZXg6IHJlbmRlcmluZy9TVkdJbmxpbmVUZXh0Qm94LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSByZW5kZXJpbmcvU1ZHSW5saW5lVGV4dEJveC5jcHAJKHJldmlzaW9uIDI3ODUw KQorKysgcmVuZGVyaW5nL1NWR0lubGluZVRleHRCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MzQsNiArMTM0LDkgQEAKICAgICAgICAgdW5zaWduZWQgaW50IGNsb3Nlc3RPZmZzZXQgPSBVSU5U X01BWDsKIAogICAgICAgICBmb3IgKFZlY3RvcjxTVkdDaGFyPjo6aXRlcmF0b3IgaXQgPSBzdGFy dDsgaXQgIT0gZW5kOyArK2l0KSB7CisgICAgICAgICAgICBpZiAoaXQtPmlzSGlkZGVuKCkpCisg ICAgICAgICAgICAgICAgY29udGludWU7CisKICAgICAgICAgICAgIHVuc2lnbmVkIGludCBuZXdP ZmZzZXQgPSB0ZXh0Qm94LT5zdGFydCgpICsgKGl0IC0gc3RhcnQpICsgc3RhcnRPZmZzZXQ7CiAg ICAgICAgICAgICBGbG9hdFJlY3QgZ2x5cGhSZWN0ID0gY2h1bmtDdG0ubWFwUmVjdCh0ZXh0Qm94 LT5jYWxjdWxhdGVHbHlwaEJvdW5kYXJpZXMoc3R5bGUsIG5ld09mZnNldCwgKml0KSk7CiAKQEAg LTE5NSw2ICsxOTgsOSBAQAogICAgICAgICBSZW5kZXJTdHlsZSogc3R5bGUgPSB0ZXh0Qm94LT50 ZXh0T2JqZWN0KCktPnN0eWxlKCk7CiAKICAgICAgICAgZm9yIChWZWN0b3I8U1ZHQ2hhcj46Oml0 ZXJhdG9yIGl0ID0gc3RhcnQ7IGl0ICE9IGVuZDsgKytpdCkgeworICAgICAgICAgICAgaWYgKGl0 LT5pc0hpZGRlbigpKQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAgICAgICB1 bnNpZ25lZCBpbnQgbmV3T2Zmc2V0ID0gdGV4dEJveC0+c3RhcnQoKSArIChpdCAtIHN0YXJ0KSAr IHN0YXJ0T2Zmc2V0OwogICAgICAgICAgICAgbV9zZWxlY3Rpb25SZWN0LnVuaXRlKHRleHRCb3gt PmNhbGN1bGF0ZUdseXBoQm91bmRhcmllcyhzdHlsZSwgbmV3T2Zmc2V0LCAqaXQpKTsKICAgICAg ICAgfQpJbmRleDogcmVuZGVyaW5nL1NWR0NoYXJhY3RlckxheW91dEluZm8uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIHJlbmRlcmluZy9TVkdDaGFyYWN0ZXJMYXlvdXRJbmZvLmNwcAkocmV2aXNpb24gMjc4 NTApCisrKyByZW5kZXJpbmcvU1ZHQ2hhcmFjdGVyTGF5b3V0SW5mby5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTUwNyw2ICs1MDcsMTQgQEAKICAgICB9CiB9CiAKK2Jvb2wgU1ZHQ2hhcjo6aXNIaWRk ZW4oKSBjb25zdAoreworICAgIGlmIChwYXRoRGF0YSkKKyAgICAgICAgcmV0dXJuIHBhdGhEYXRh LT5oaWRkZW47CisKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKIEFmZmluZVRyYW5zZm9ybSBTVkdD aGFyOjpjaGFyYWN0ZXJUcmFuc2Zvcm0oKSBjb25zdAogewogICAgIEFmZmluZVRyYW5zZm9ybSBj dG07CkluZGV4OiByZW5kZXJpbmcvU1ZHQ2hhcmFjdGVyTGF5b3V0SW5mby5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIHJlbmRlcmluZy9TVkdDaGFyYWN0ZXJMYXlvdXRJbmZvLmgJKHJldmlzaW9uIDI3ODUwKQor KysgcmVuZGVyaW5nL1NWR0NoYXJhY3RlckxheW91dEluZm8uaAkod29ya2luZyBjb3B5KQpAQCAt MTg0LDcgKzE4NCw3IEBACiAgICAgICAgICwgeFNoaWZ0KDAuMGYpCiAgICAgICAgICwgeVNoaWZ0 KDAuMGYpCiAgICAgICAgICwgb3JpZW50YXRpb25BbmdsZSgwLjBmKQotICAgICAgICAsIHZpc2li bGUodHJ1ZSkKKyAgICAgICAgLCBoaWRkZW4oZmFsc2UpCiAgICAgewogICAgIH0KIApAQCAtMTk2 LDggKzE5Niw3IEBACiAKICAgICBmbG9hdCBvcmllbnRhdGlvbkFuZ2xlOwogCi0gICAgLy8gRGV0 ZXJtaW5lcyB3aGV0ZXIgdGhpcyBjaGFyIGlzIHZpc2libGUgKGllLiBmYWxzZSBmb3IgY2hhcnMg Im9mZiIgdGhlIHRleHQgbGF5b3V0IHBhdGgpCi0gICAgYm9vbCB2aXNpYmxlIDogMTsKKyAgICBi b29sIGhpZGRlbiA6IDE7CiB9OwogCiBzdHJ1Y3QgU1ZHQ2hhciB7CkBAIC0yMzIsNyArMjMxLDgg QEAKICAgICAvLyBEZXRlcm1pbmVzIHdoZXRlciB0aGlzIGNoYXIgc3RhcnRzIGEgbmV3IGNodW5r CiAgICAgYm9vbCBuZXdUZXh0Q2h1bmsgOiAxOwogCi0gICAgLy8gSGVscGVyIG1ldGhvZAorICAg IC8vIEhlbHBlciBtZXRob2RzCisgICAgYm9vbCBpc0hpZGRlbigpIGNvbnN0OwogICAgIEFmZmlu ZVRyYW5zZm9ybSBjaGFyYWN0ZXJUcmFuc2Zvcm0oKSBjb25zdDsKIH07CiAK 17504 2007-11-25 03:16:42 -0800 2007-11-25 03:16:42 -0800 DRT reduction textPathBoundsBug.svg image/svg+xml 551 zimmermann PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iaXNvLTg4NTktMSIgc3RhbmRhbG9uZT0ibm8i Pz4KPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJo dHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiB4bWxuczpldj0iaHR0cDovL3d3dy53My5vcmcv MjAwMS94bWwtZXZlbnRzIiB3aWR0aD0iMTAwJSIgaGVpZ2h0PSIxMDAlIj4KPHBhdGggaWQ9Ik15 UGF0aCIgZD0iTSAxMDAgMTAwIEwgMjAwIDEwMCIgc3Ryb2tlPSJwdXJwbGUiIC8+IAo8dGV4dCBm b250LWZhbWlseT0iQXJpYWwiIGZvbnQtc2l6ZT0iMTJweCIgdGV4dC1hbmNob3I9Im1pZGRsZSI+ Cgk8dGV4dFBhdGggeGxpbms6aHJlZj0iI015UGF0aCI+MTIzNDU2Nzg8L3RleHRQYXRoPgo8L3Rl eHQ+Cgo8c2NyaXB0PgppZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgd2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyLmR1bXBTZWxlY3Rpb25SZWN0KCk7CmRvY3VtZW50LmV4ZWND b21tYW5kKCJTZWxlY3RBbGwiKTsKPC9zY3JpcHQ+Cjwvc3ZnPgo=