155630 2016-03-18 01:09:52 -0700 [OS X] Scrollbars are sometimes erroneously reported as overlay 2016-03-18 14:14:45 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield darin oldest_to_newest 1176108 0 mmaxfield 2016-03-18 01:09:52 -0700 Scrollbars are sometimes erroneously reported as overlay 1176112 1 274393 mmaxfield 2016-03-18 01:30:09 -0700 Created attachment 274393 Patch 1176176 2 274393 darin 2016-03-18 08:54:59 -0700 Comment on attachment 274393 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274393&action=review > Source/WebCore/ChangeLog:26 > + An alternative similar approach would be for ScrollbarThemeMac to listen to the > + NSPreferredScrollerStyleDidChangeNotification. Why didn’t you chose that approach? > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:635 > + if (auto* macTheme = macScrollbarTheme()) > + macTheme->usesOverlayScrollbarsChanged(); I’d just call the super-local variable "theme". 1176177 3 darin 2016-03-18 08:55:09 -0700 No regression test? 1176303 4 mmaxfield 2016-03-18 14:14:45 -0700 Committed r198444: <http://trac.webkit.org/changeset/198444> 274393 2016-03-18 01:30:09 -0700 2016-03-18 08:54:59 -0700 Patch bug-155630-20160318013009.patch text/plain 3013 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4MzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2IwZGY5NWQyMDdiOTUx MjEwN2U1N2UyNWJjMzZjZDhmYTViYzc0My4uNWUyYTI4YjgzYWMzNWJlMmZjN2NmODcwNjc2ZmJk N2Q0NDQwZDg1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDE2LTAzLTE4ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW09TIFhdIFNj cm9sbGJhcnMgYXJlIHNvbWV0aW1lcyBlcnJvbmVvdXNseSByZXBvcnRlZCBhcyBvdmVybGF5Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU2MzAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIEFwcEtp dCBib290cyB1cCwgaWYgdGhlIHN5c3RlbSBwcmVmZXJlbmNlIGlzIHNldCB0byBkZXRlcm1pbmUg YXQgcnVudGltZSB3aGV0aGVyCisgICAgICAgIHNjcm9sbGJhcnMgc2hvdWxkIGJlIG92ZXJsYXkg b3IgYWx3YXlzLW9uLCBBcHBLaXQgbXVzdCBkbyBzb21lIHByb2Nlc3NpbmcgdG8gZGV0ZXJtaW5l CisgICAgICAgIHRoaXMgc2Nyb2xsYmFyIHN0YXRlLiBXZSBsaXN0ZW4gZm9yIHRoZSByZXN1bHRz IGJ5IHVzaW5nIE5TU2Nyb2xsZXJJbXBQYWlyRGVsZWdhdGUncworICAgICAgICBzY3JvbGxlcklt cFBhaXI6dXBkYXRlU2Nyb2xsZXJTdHlsZUZvck5ld1JlY29tbWVuZGVkU2Nyb2xsZXJTdHlsZTog bWV0aG9kLgorCisgICAgICAgIEhvd2V2ZXIsIG91ciBOU1Njcm9sbGVySW1wUGFpckRlbGVnYXRl cyBhcmUgb3duZWQgYnkgdGhlIEZyYW1lVmlldywgYW5kIHdoZW4gbG9hZGluZworICAgICAgICBh IHBhZ2UsIHRoZXJlIGlzIGEgc2hvcnQgYW1vdW50IG9mIHRpbWUgd2hlbiBubyBGcmFtZVZpZXdz IGFyZSBhbGl2ZS4gVGhpcyBtZWFucyB0aGF0CisgICAgICAgIHRoZXJlIGlzIGEgcG9pbnQgaW4g dGltZSB3aGVuIHdlIGRvbid0IGhhdmUgYW55IE5TU2Nyb2xsZXJJbXBQYWlycyBhbGl2ZS4gVW5m b3J0dW5hdGVseSwKKyAgICAgICAgdGhlIHByb2Nlc3Nlc2luZyB0aGF0IEFwcEtpdCBkb2VzIHRv IGRldGVybWluZSB0aGUgc2Nyb2xsYmFyIHN0YXRlIGlzIGRvbmUKKyAgICAgICAgYXN5bmNocm9u b3VzbHksIGFuZCB0aGUgcmVzdWx0cyBtYXkgYmUgcmVwb3J0ZWQgd2l0aGluIHRoaXMgc2hvcnQg d2luZG93LiBJbiB0aGlzIGNhc2UsCisgICAgICAgIHdlIGRvbid0IHJlY2VpdmUgdGhlIG5vdGlm aWNhdGlvbiB0aGF0IHRoZSBzY3JvbGxiYXIgc2hvdWxkIGJlIG5vbi1vdmVybGF5LCBhbmQgb3Vy CisgICAgICAgIGludGVybmFsIHN0YXRlIChnVXNlc092ZXJsYXlTY3JvbGxiYXJzIGluIFNjcm9s bGJhclRoZW1lTWFjKSBiZWNvbWVzIHN0YWxlLgorCisgICAgICAgIFRoZSBzb2x1dGlvbiBpcyB0 byBzaW1wbHkgYWx3YXlzIGNoZWNrIHdoYXQgdGhlIHNjcm9sbGJhciBzdGF0ZSBpcyB1cG9uIGNy ZWF0aW9uIG9mIGEKKyAgICAgICAgTlNTY3JvbGxlckltcFBhaXIuIFRoYXQgd2F5LCBhcyBzb29u IGFzIHRoZSBzZWNvbmQgRnJhbWVWaWV3IGlzIGNyZWF0ZWQsIHRoZSBzY3JvbGxiYXIKKyAgICAg ICAgc3RhdGUgd2lsbCBiZSBjb3JyZWN0bHkgdXBkYXRlZCBpbW1lZGlhdGVseS4KKworICAgICAg ICBBbiBhbHRlcm5hdGl2ZSBzaW1pbGFyIGFwcHJvYWNoIHdvdWxkIGJlIGZvciBTY3JvbGxiYXJU aGVtZU1hYyB0byBsaXN0ZW4gdG8gdGhlCisgICAgICAgIE5TUHJlZmVycmVkU2Nyb2xsZXJTdHls ZURpZENoYW5nZU5vdGlmaWNhdGlvbi4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIChS VEwgU2Nyb2xsYmFyKSB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3JvbGxBbmlt YXRvck1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbEFuaW1hdG9yTWFjOjpTY3JvbGxB bmltYXRvck1hYyk6CisKIDIwMTYtMDMtMTcgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxk QGFwcGxlLmNvbT4KIAogICAgICAgICBbUlRMIFNjcm9sbGJhcnNdIFBvc2l0aW9uOiBhYnNvbHV0 ZSBkaXZzIGFyZSBjb3ZlcmVkIGJ5IHZlcnRpY2FsIHNjcm9sbGJhcgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCmluZGV4IDc1ZDY5MTZlZTll OGRmYzEzMmZiNThjZjhjZjVjYTg0ZTA2MWQyNGQuLmFmZGZiN2VkMjA3ODIwYWIzODhmMzdiOTE1 YWRmNTk4ODJjYmMxOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9T Y3JvbGxBbmltYXRvck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Ny b2xsQW5pbWF0b3JNYWMubW0KQEAgLTYzMCw2ICs2MzAsOSBAQCBTY3JvbGxBbmltYXRvck1hYzo6 U2Nyb2xsQW5pbWF0b3JNYWMoU2Nyb2xsYWJsZUFyZWEmIHNjcm9sbGFibGVBcmVhKQogICAgIG1f c2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXIgPSBhZG9wdE5TKFtbTlNTY3JvbGxlckltcFBhaXIg YWxsb2NdIGluaXRdKTsKICAgICBbbV9zY3JvbGxiYXJQYWludGVyQ29udHJvbGxlciBzZXREZWxl Z2F0ZTptX3Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyRGVsZWdhdGUuZ2V0KCldOwogICAgIFtt X3Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyIHNldFNjcm9sbGVyU3R5bGU6cmVjb21tZW5kZWRT Y3JvbGxlclN0eWxlKCldOworCisgICAgaWYgKGF1dG8qIG1hY1RoZW1lID0gbWFjU2Nyb2xsYmFy VGhlbWUoKSkKKyAgICAgICAgbWFjVGhlbWUtPnVzZXNPdmVybGF5U2Nyb2xsYmFyc0NoYW5nZWQo KTsKIH0KIAogU2Nyb2xsQW5pbWF0b3JNYWM6On5TY3JvbGxBbmltYXRvck1hYygpCg==