155613 2016-03-17 17:22:59 -0700 AX: Typing broken on form input field while using VoiceOver 2016-03-18 10:44:03 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 n_wang webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario n_wang samuel_white webkit-bug-importer oldest_to_newest 1175927 0 n_wang 2016-03-17 17:22:59 -0700 When navigating to the form elements with VO + the arrow keys and then stopping at a input field, the cursor jumps and there's no way to type. 1175928 1 webkit-bug-importer 2016-03-17 17:23:30 -0700 <rdar://problem/25230574> 1175948 2 274349 n_wang 2016-03-17 17:47:59 -0700 Created attachment 274349 patch Spent quite a long time trying to figure out a way to test. Was adding the AXSelectedTextMarkerRange notification to the test and getting the TextMarkerRange when input field is focused. But even we get the TextMarkerRange for that selection, it's difficult to determine which node the TextMarker is associated with. Or we can expose some function to get the Range object from TextMarkerRange, then check the node in it. Seems there's no easy way to do this. So I'd rather put the fix here first. 1175970 3 274349 cfleizach 2016-03-17 18:20:46 -0700 Comment on attachment 274349 patch View in context: https://bugs.webkit.org/attachment.cgi?id=274349&action=review it seems like we could write a test with "a <div contenteditable="true"></div> b" and get the range of the whole content there and then verify that the length is correct or that it has the right embedded elements > Source/WebCore/ChangeLog:8 > + The div element inside the INPUT element gives a collapsed TextMarkerRange which then creates why does this break typing with VO? 1175973 4 274349 n_wang 2016-03-17 18:30:16 -0700 Comment on attachment 274349 patch View in context: https://bugs.webkit.org/attachment.cgi?id=274349&action=review >> Source/WebCore/ChangeLog:8 >> + The div element inside the INPUT element gives a collapsed TextMarkerRange which then creates > > why does this break typing with VO? I think VO is asking for a textMarkerRange of the input field, without this fix the contenteditable div is not included in the range. So VO had no idea what's inside the input field. 1176033 5 274371 n_wang 2016-03-17 22:00:23 -0700 Created attachment 274371 patch added layout test 1176040 6 274374 n_wang 2016-03-17 22:43:38 -0700 Created attachment 274374 patch Fixed test expectation 1176100 7 274374 commit-queue 2016-03-18 00:36:10 -0700 Comment on attachment 274374 patch Rejecting attachment 274374 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 274374, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ubmit return self.open(self.click(*args, **kwds)) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://webkit-queues.webkit.org/results/998051 1176218 8 n_wang 2016-03-18 10:44:03 -0700 Committed r198426: <http://trac.webkit.org/changeset/198426> 274349 2016-03-17 17:47:59 -0700 2016-03-17 22:00:23 -0700 patch patch.txt text/plain 2215 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODM2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTAzLTE3ICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFR5cGluZyBicm9rZW4gb24gZm9y bSBpbnB1dCBmaWVsZCB3aGlsZSB1c2luZyBWb2ljZU92ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTYxMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBkaXYgZWxlbWVudCBpbnNpZGUgdGhlIElO UFVUIGVsZW1lbnQgZ2l2ZXMgYSBjb2xsYXBzZWQgVGV4dE1hcmtlclJhbmdlIHdoaWNoIHRoZW4g Y3JlYXRlcworICAgICAgICBhIGNvbGxhcHNlZCBSYW5nZS4gRml4ZWQgaXQgYnkgdXNpbmcgdGhl IHBhcmVudCBub2RlIHRvIGNyZWF0ZSB0aGUgUmFuZ2Ugd2hlbiB0aGUgZGl2IG5vZGUgaGFzIAor ICAgICAgICBubyBjaGlsZHJlbi4KKworICAgICAgICBUcmllZCBteSBiZXN0IGFuZCBjb3VsZG4n dCBmaWd1cmUgb3V0IGFuIGVhc3kgd2F5IHRvIHdyaXRlIGEgbGF5b3V0IHRlc3QuCisKKyAgICAg ICAgKiBhY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 c2V0UmFuZ2VTdGFydE9yRW5kV2l0aENoYXJhY3Rlck9mZnNldCk6CisKIDIwMTYtMDMtMTcgIEJy YWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIERvbid0IHRyeSB0byBy ZXN0b3JlIGRlbGV0ZWQgTWVtb3J5SW5kZXhlcyBpZiB0aGVpciBvd25pbmcgb2JqZWN0IHN0b3Jl IGlzIG5vdCByZXN0b3JlZC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhP YmplY3RDYWNoZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BWE9iamVjdENhY2hlLmNwcAkocmV2aXNpb24gMTk4MzM4KQorKysgU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYzMCw4 ICsxNjMwLDE1IEBAIHN0YXRpYyB2b2lkIHNldFJhbmdlU3RhcnRPckVuZFdpdGhDaGFyYWMKICAg ICAKICAgICBpbnQgb2Zmc2V0ID0gY2hhcmFjdGVyT2Zmc2V0LnN0YXJ0SW5kZXggKyBjaGFyYWN0 ZXJPZmZzZXQub2Zmc2V0OwogICAgIE5vZGUqIG5vZGUgPSBjaGFyYWN0ZXJPZmZzZXQubm9kZTsK LSAgICBpZiAoaXNSZXBsYWNlZE5vZGVPckJSKG5vZGUpKQotICAgICAgICBub2RlID0gcmVzZXRO b2RlQW5kT2Zmc2V0Rm9yUmVwbGFjZWROb2RlKG5vZGUsIG9mZnNldCwgY2hhcmFjdGVyT2Zmc2V0 Lm9mZnNldCk7CisgICAgCisgICAgYm9vbCByZXBsYWNlZE5vZGVPckJSID0gaXNSZXBsYWNlZE5v ZGVPckJSKG5vZGUpOworICAgIC8vIEZvciB0aGUgbm9uIHRleHQgbm9kZSB0aGF0IGhhcyBubyBj aGlsZHJlbiwgd2Ugc2hvdWxkIGNyZWF0ZSB0aGUgcmFuZ2Ugd2l0aCBpdHMgcGFyZW50LCBvdGhl cndpc2UgdGhlIHJhbmdlIHdvdWxkIGJlIGNvbGxhcHNlZC4KKyAgICAvLyBFeGFtcGxlOiA8ZGl2 IGNvbnRlbnRlZGl0YWJsZT0idHJ1ZSI+PC9kaXY+LCB3ZSB3YW50IHRoZSByYW5nZSB0byBpbmNs dWRlIHRoZSBkaXYgZWxlbWVudC4KKyAgICBib29sIG5vQ2hpbGRyZW4gPSAhcmVwbGFjZWROb2Rl T3JCUiAmJiAhbm9kZS0+aXNUZXh0Tm9kZSgpICYmICFub2RlLT5oYXNDaGlsZE5vZGVzKCk7Cisg ICAgaW50IGNoYXJhY3RlckNvdW50ID0gbm9DaGlsZHJlbiA/IChpc1N0YXJ0ID8gMCA6IDEpIDog Y2hhcmFjdGVyT2Zmc2V0Lm9mZnNldDsKKyAgICAKKyAgICBpZiAocmVwbGFjZWROb2RlT3JCUiB8 fCBub0NoaWxkcmVuKQorICAgICAgICBub2RlID0gcmVzZXROb2RlQW5kT2Zmc2V0Rm9yUmVwbGFj ZWROb2RlKG5vZGUsIG9mZnNldCwgY2hhcmFjdGVyQ291bnQpOwogICAgIAogICAgIGlmIChpc1N0 YXJ0KQogICAgICAgICByYW5nZS0+c2V0U3RhcnQobm9kZSwgb2Zmc2V0LCBlYyk7Cg== 274371 2016-03-17 22:00:23 -0700 2016-03-17 22:41:41 -0700 patch patch.txt text/plain 5443 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODM3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTAzLTE3ICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFR5cGluZyBicm9rZW4gb24gZm9y bSBpbnB1dCBmaWVsZCB3aGlsZSB1c2luZyBWb2ljZU92ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTYxMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBkaXYgZWxlbWVudCBpbnNpZGUgdGhlIElO UFVUIGVsZW1lbnQgZ2l2ZXMgYSBjb2xsYXBzZWQgVGV4dE1hcmtlclJhbmdlIHdoaWNoIHRoZW4g Y3JlYXRlcworICAgICAgICBhIGNvbGxhcHNlZCBSYW5nZS4gRml4ZWQgaXQgYnkgdXNpbmcgdGhl IHBhcmVudCBub2RlIHRvIGNyZWF0ZSB0aGUgUmFuZ2Ugd2hlbiB0aGUgZGl2IG5vZGUgaGFzCisg ICAgICAgIG5vIGNoaWxkcmVuLgorCisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkvbWFjL3Rl eHQtbWFya2VyLXJhbmdlLWZvci1ub2RlLXdpdGhvdXQtY2hpbGRyZW4uaHRtbAorCisgICAgICAg ICogYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNl dFJhbmdlU3RhcnRPckVuZFdpdGhDaGFyYWN0ZXJPZmZzZXQpOgorCiAyMDE2LTAzLTE3ICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtYU1MgQXVkaXRvcl0g T2ZmIGJ5IG9uZSBpbiBYU1NBdWRpdG9yOjpjYW5vbmljYWxpemVkU25pcHBldEZvckphdmFTY3Jp cHQoKQpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2Fj aGUuY3BwCShyZXZpc2lvbiAxOTgzMzgpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FYT2JqZWN0Q2FjaGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjMwLDggKzE2MzAsMTUgQEAg c3RhdGljIHZvaWQgc2V0UmFuZ2VTdGFydE9yRW5kV2l0aENoYXJhYwogICAgIAogICAgIGludCBv ZmZzZXQgPSBjaGFyYWN0ZXJPZmZzZXQuc3RhcnRJbmRleCArIGNoYXJhY3Rlck9mZnNldC5vZmZz ZXQ7CiAgICAgTm9kZSogbm9kZSA9IGNoYXJhY3Rlck9mZnNldC5ub2RlOwotICAgIGlmIChpc1Jl cGxhY2VkTm9kZU9yQlIobm9kZSkpCi0gICAgICAgIG5vZGUgPSByZXNldE5vZGVBbmRPZmZzZXRG b3JSZXBsYWNlZE5vZGUobm9kZSwgb2Zmc2V0LCBjaGFyYWN0ZXJPZmZzZXQub2Zmc2V0KTsKKyAg ICAKKyAgICBib29sIHJlcGxhY2VkTm9kZU9yQlIgPSBpc1JlcGxhY2VkTm9kZU9yQlIobm9kZSk7 CisgICAgLy8gRm9yIHRoZSBub24gdGV4dCBub2RlIHRoYXQgaGFzIG5vIGNoaWxkcmVuLCB3ZSBz aG91bGQgY3JlYXRlIHRoZSByYW5nZSB3aXRoIGl0cyBwYXJlbnQsIG90aGVyd2lzZSB0aGUgcmFu Z2Ugd291bGQgYmUgY29sbGFwc2VkLgorICAgIC8vIEV4YW1wbGU6IDxkaXYgY29udGVudGVkaXRh YmxlPSJ0cnVlIj48L2Rpdj4sIHdlIHdhbnQgdGhlIHJhbmdlIHRvIGluY2x1ZGUgdGhlIGRpdiBl bGVtZW50LgorICAgIGJvb2wgbm9DaGlsZHJlbiA9ICFyZXBsYWNlZE5vZGVPckJSICYmICFub2Rl LT5pc1RleHROb2RlKCkgJiYgIW5vZGUtPmhhc0NoaWxkTm9kZXMoKTsKKyAgICBpbnQgY2hhcmFj dGVyQ291bnQgPSBub0NoaWxkcmVuID8gKGlzU3RhcnQgPyAwIDogMSkgOiBjaGFyYWN0ZXJPZmZz ZXQub2Zmc2V0OworICAgIAorICAgIGlmIChyZXBsYWNlZE5vZGVPckJSIHx8IG5vQ2hpbGRyZW4p CisgICAgICAgIG5vZGUgPSByZXNldE5vZGVBbmRPZmZzZXRGb3JSZXBsYWNlZE5vZGUobm9kZSwg b2Zmc2V0LCBjaGFyYWN0ZXJDb3VudCk7CiAgICAgCiAgICAgaWYgKGlzU3RhcnQpCiAgICAgICAg IHJhbmdlLT5zZXRTdGFydChub2RlLCBvZmZzZXQsIGVjKTsKSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5 ODMzOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDEzIEBACisyMDE2LTAzLTE3ICBOYW4gV2FuZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAg ICAgQVg6IFR5cGluZyBicm9rZW4gb24gZm9ybSBpbnB1dCBmaWVsZCB3aGlsZSB1c2luZyBWb2lj ZU92ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NTYxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog YWNjZXNzaWJpbGl0eS9tYWMvdGV4dC1tYXJrZXItcmFuZ2UtZm9yLW5vZGUtd2l0aG91dC1jaGls ZHJlbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL3Rl eHQtbWFya2VyLXJhbmdlLWZvci1ub2RlLXdpdGhvdXQtY2hpbGRyZW4uaHRtbDogQWRkZWQuCisK IDIwMTYtMDMtMTYgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAg ICAgICBBWDogSW1wbGVtZW50IEF1dG9GaWxsIEF2YWlsYWJsZSBhdHRyaWJ1dGUgZm9yIGEgdGV4 dCBmaWVsZApJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvdGV4dC1tYXJrZXIt cmFuZ2UtZm9yLW5vZGUtd2l0aG91dC1jaGlsZHJlbi1leHBlY3RlZC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvdGV4dC1tYXJrZXItcmFuZ2UtZm9yLW5v ZGUtd2l0aG91dC1jaGlsZHJlbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy90ZXh0LW1hcmtlci1yYW5nZS1mb3Itbm9kZS13aXRob3V0 LWNoaWxkcmVuLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEyIEBACitD T05TT0xFIE1FU1NBR0U6IGxpbmUgMjA6IFR5cGVFcnJvcjogbnVsbCBpcyBub3QgYW4gb2JqZWN0 IChldmFsdWF0aW5nICdjb250YWluZXIudGV4dE1hcmtlclJhbmdlRm9yRWxlbWVudCcpCithCiti CitUaGlzIHRlc3RzIHRoYXQgZW5kVGV4dE1hcmtlckZvckJvdW5kcyBhbmQgc3RhcnRUZXh0TWFy a2VyRm9yQm91bmRzIHdvcmsgY29ycmVjdGx5LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUg YSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIu CisKKworRkFJTCBzdWNjZXNzZnVsbHlQYXJzZWQgc2hvdWxkIGJlIHRydWUgKG9mIHR5cGUgYm9v bGVhbikuIFdhcyB1bmRlZmluZWQgKG9mIHR5cGUgdW5kZWZpbmVkKS4KKworVEVTVCBDT01QTEVU RQorCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy90ZXh0LW1hcmtlci1yYW5n ZS1mb3Itbm9kZS13aXRob3V0LWNoaWxkcmVuLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvYWNjZXNzaWJpbGl0eS9tYWMvdGV4dC1tYXJrZXItcmFuZ2UtZm9yLW5vZGUtd2l0aG91dC1j aGlsZHJlbi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9t YWMvdGV4dC1tYXJrZXItcmFuZ2UtZm9yLW5vZGUtd2l0aG91dC1jaGlsZHJlbi5odG1sCSh3b3Jr aW5nIGNvcHkpCkBAIC0wLDAgKzEsMzQgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVh ZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0 PgorPC9oZWFkPgorPGJvZHk+CisKKzxkaXYgaWQ9ImNvbnRhaW5lciIgYXJpYS1sYWJlbD0icGFy ZW50IGxldmVsIj4KK2EgPGRpdiBpZD0idGV4dGJveCIgYXJpYS1sYWJlbD0iY2hpbGQgbGV2ZWwi IGNvbnRlbnRlZGl0YWJsZT0idHJ1ZSI+PC9kaXY+IGIKKzwvZGl2PgorCis8cCBpZD0iZGVzY3Jp cHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorICAgIGRl c2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgY3JlYXRpbmcgVGV4dE1hcmtlclJhbmdlIGZyb20g bm9kZXMgdGhhdCBoYXZlIG5vIGNoaWxkcmVuIHdvbid0IGNvbGxhcHNlIHRvIG9uZSBzaWRlLiIp OworICAgIAorICAgIGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICAg ICAgdmFyIHRleHRib3ggPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVu dEJ5SWQoInRleHRib3giKTsKKyAgICAgICAgdmFyIHRleHRib3hSYW5nZSA9IHRleHRib3gudGV4 dE1hcmtlclJhbmdlRm9yRWxlbWVudCh0ZXh0Ym94KTsKKyAgICAgICAgLy8gVGhlIHJhbmdlIHNo b3VsZCBpbmNsdWRlIHRoZSBkaXYgZWxlbWVudC4gCisgICAgICAgIHNob3VsZEJlVHJ1ZSgidGV4 dGJveC50ZXh0TWFya2VyUmFuZ2VMZW5ndGgodGV4dGJveFJhbmdlKSA9PSAxIik7CisgICAgICAg IAorICAgICAgICAvLyBNYWtlIHN1cmUgdGhlIG5vZGUgdGhhdCBhc3NvY2lhdGVzIHdpdGggdGhl IHRleHQgbWFya2VyIGlzIHRoZSBwYXJlbnQgZGl2IGVsZW1lbnQuCisgICAgICAgIHZhciBzdGFy dE1hcmtlciA9IHRleHRib3guc3RhcnRUZXh0TWFya2VyRm9yVGV4dE1hcmtlclJhbmdlKHRleHRi b3hSYW5nZSk7CisgICAgICAgIHZhciBlbmRNYXJrZXIgPSB0ZXh0Ym94LmVuZFRleHRNYXJrZXJG b3JUZXh0TWFya2VyUmFuZ2UodGV4dGJveFJhbmdlKTsKKyAgICAgICAgc2hvdWxkQmUoInRleHRi b3guYWNjZXNzaWJpbGl0eUVsZW1lbnRGb3JUZXh0TWFya2VyKHN0YXJ0TWFya2VyKS5kZXNjcmlw dGlvbiIsICInQVhEZXNjcmlwdGlvbjogcGFyZW50IGxldmVsJyIpOworICAgICAgICBzaG91bGRC ZSgidGV4dGJveC5hY2Nlc3NpYmlsaXR5RWxlbWVudEZvclRleHRNYXJrZXIoZW5kTWFya2VyKS5k ZXNjcmlwdGlvbiIsICInQVhEZXNjcmlwdGlvbjogcGFyZW50IGxldmVsJyIpOworICAgIH0KKzwv c2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+ PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg== 274374 2016-03-17 22:43:38 -0700 2016-03-18 00:36:10 -0700 patch patch.txt text/plain 5562 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODM3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTAzLTE3ICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFR5cGluZyBicm9rZW4gb24gZm9y bSBpbnB1dCBmaWVsZCB3aGlsZSB1c2luZyBWb2ljZU92ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTYxMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBkaXYgZWxlbWVudCBpbnNpZGUgdGhlIElO UFVUIGVsZW1lbnQgZ2l2ZXMgYSBjb2xsYXBzZWQgVGV4dE1hcmtlclJhbmdlIHdoaWNoIHRoZW4g Y3JlYXRlcworICAgICAgICBhIGNvbGxhcHNlZCBSYW5nZS4gRml4ZWQgaXQgYnkgdXNpbmcgdGhl IHBhcmVudCBub2RlIHRvIGNyZWF0ZSB0aGUgUmFuZ2Ugd2hlbiB0aGUgZGl2IG5vZGUgaGFzCisg ICAgICAgIG5vIGNoaWxkcmVuLgorCisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkvbWFjL3Rl eHQtbWFya2VyLXJhbmdlLWZvci1ub2RlLXdpdGhvdXQtY2hpbGRyZW4uaHRtbAorCisgICAgICAg ICogYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNl dFJhbmdlU3RhcnRPckVuZFdpdGhDaGFyYWN0ZXJPZmZzZXQpOgorCiAyMDE2LTAzLTE3ICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtYU1MgQXVkaXRvcl0g T2ZmIGJ5IG9uZSBpbiBYU1NBdWRpdG9yOjpjYW5vbmljYWxpemVkU25pcHBldEZvckphdmFTY3Jp cHQoKQpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2Fj aGUuY3BwCShyZXZpc2lvbiAxOTgzMzgpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FYT2JqZWN0Q2FjaGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjMwLDggKzE2MzAsMTUgQEAg c3RhdGljIHZvaWQgc2V0UmFuZ2VTdGFydE9yRW5kV2l0aENoYXJhYwogICAgIAogICAgIGludCBv ZmZzZXQgPSBjaGFyYWN0ZXJPZmZzZXQuc3RhcnRJbmRleCArIGNoYXJhY3Rlck9mZnNldC5vZmZz ZXQ7CiAgICAgTm9kZSogbm9kZSA9IGNoYXJhY3Rlck9mZnNldC5ub2RlOwotICAgIGlmIChpc1Jl cGxhY2VkTm9kZU9yQlIobm9kZSkpCi0gICAgICAgIG5vZGUgPSByZXNldE5vZGVBbmRPZmZzZXRG b3JSZXBsYWNlZE5vZGUobm9kZSwgb2Zmc2V0LCBjaGFyYWN0ZXJPZmZzZXQub2Zmc2V0KTsKKyAg ICAKKyAgICBib29sIHJlcGxhY2VkTm9kZU9yQlIgPSBpc1JlcGxhY2VkTm9kZU9yQlIobm9kZSk7 CisgICAgLy8gRm9yIHRoZSBub24gdGV4dCBub2RlIHRoYXQgaGFzIG5vIGNoaWxkcmVuLCB3ZSBz aG91bGQgY3JlYXRlIHRoZSByYW5nZSB3aXRoIGl0cyBwYXJlbnQsIG90aGVyd2lzZSB0aGUgcmFu Z2Ugd291bGQgYmUgY29sbGFwc2VkLgorICAgIC8vIEV4YW1wbGU6IDxkaXYgY29udGVudGVkaXRh YmxlPSJ0cnVlIj48L2Rpdj4sIHdlIHdhbnQgdGhlIHJhbmdlIHRvIGluY2x1ZGUgdGhlIGRpdiBl bGVtZW50LgorICAgIGJvb2wgbm9DaGlsZHJlbiA9ICFyZXBsYWNlZE5vZGVPckJSICYmICFub2Rl LT5pc1RleHROb2RlKCkgJiYgIW5vZGUtPmhhc0NoaWxkTm9kZXMoKTsKKyAgICBpbnQgY2hhcmFj dGVyQ291bnQgPSBub0NoaWxkcmVuID8gKGlzU3RhcnQgPyAwIDogMSkgOiBjaGFyYWN0ZXJPZmZz ZXQub2Zmc2V0OworICAgIAorICAgIGlmIChyZXBsYWNlZE5vZGVPckJSIHx8IG5vQ2hpbGRyZW4p CisgICAgICAgIG5vZGUgPSByZXNldE5vZGVBbmRPZmZzZXRGb3JSZXBsYWNlZE5vZGUobm9kZSwg b2Zmc2V0LCBjaGFyYWN0ZXJDb3VudCk7CiAgICAgCiAgICAgaWYgKGlzU3RhcnQpCiAgICAgICAg IHJhbmdlLT5zZXRTdGFydChub2RlLCBvZmZzZXQsIGVjKTsKSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5 ODMzOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDEzIEBACisyMDE2LTAzLTE3ICBOYW4gV2FuZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAg ICAgQVg6IFR5cGluZyBicm9rZW4gb24gZm9ybSBpbnB1dCBmaWVsZCB3aGlsZSB1c2luZyBWb2lj ZU92ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NTYxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog YWNjZXNzaWJpbGl0eS9tYWMvdGV4dC1tYXJrZXItcmFuZ2UtZm9yLW5vZGUtd2l0aG91dC1jaGls ZHJlbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL3Rl eHQtbWFya2VyLXJhbmdlLWZvci1ub2RlLXdpdGhvdXQtY2hpbGRyZW4uaHRtbDogQWRkZWQuCisK IDIwMTYtMDMtMTYgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAg ICAgICBBWDogSW1wbGVtZW50IEF1dG9GaWxsIEF2YWlsYWJsZSBhdHRyaWJ1dGUgZm9yIGEgdGV4 dCBmaWVsZApJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvdGV4dC1tYXJrZXIt cmFuZ2UtZm9yLW5vZGUtd2l0aG91dC1jaGlsZHJlbi1leHBlY3RlZC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvdGV4dC1tYXJrZXItcmFuZ2UtZm9yLW5v ZGUtd2l0aG91dC1jaGlsZHJlbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy90ZXh0LW1hcmtlci1yYW5nZS1mb3Itbm9kZS13aXRob3V0 LWNoaWxkcmVuLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE0IEBACith CitiCitUaGlzIHRlc3RzIHRoYXQgY3JlYXRpbmcgVGV4dE1hcmtlclJhbmdlIGZyb20gbm9kZXMg dGhhdCBoYXZlIG5vIGNoaWxkcmVuIHdvbid0IGNvbGxhcHNlIHRvIG9uZSBzaWRlLgorCitPbiBz dWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dl ZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyB0ZXh0Ym94LnRleHRNYXJrZXJSYW5nZUxl bmd0aCh0ZXh0Ym94UmFuZ2UpID09IDEgaXMgdHJ1ZQorUEFTUyB0ZXh0Ym94LmFjY2Vzc2liaWxp dHlFbGVtZW50Rm9yVGV4dE1hcmtlcihzdGFydE1hcmtlcikuZGVzY3JpcHRpb24gaXMgJ0FYRGVz Y3JpcHRpb246IHBhcmVudCBsZXZlbCcKK1BBU1MgdGV4dGJveC5hY2Nlc3NpYmlsaXR5RWxlbWVu dEZvclRleHRNYXJrZXIoZW5kTWFya2VyKS5kZXNjcmlwdGlvbiBpcyAnQVhEZXNjcmlwdGlvbjog cGFyZW50IGxldmVsJworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENP TVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL3RleHQtbWFya2Vy LXJhbmdlLWZvci1ub2RlLXdpdGhvdXQtY2hpbGRyZW4uaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy90ZXh0LW1hcmtlci1yYW5nZS1mb3Itbm9kZS13aXRo b3V0LWNoaWxkcmVuLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L21hYy90ZXh0LW1hcmtlci1yYW5nZS1mb3Itbm9kZS13aXRob3V0LWNoaWxkcmVuLmh0bWwJ KHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzNCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4K KzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9z Y3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKworPGRpdiBpZD0iY29udGFpbmVyIiBhcmlhLWxhYmVs PSJwYXJlbnQgbGV2ZWwiPgorYSA8ZGl2IGlkPSJ0ZXh0Ym94IiBhcmlhLWxhYmVsPSJjaGlsZCBs ZXZlbCIgY29udGVudGVkaXRhYmxlPSJ0cnVlIj48L2Rpdj4gYgorPC9kaXY+CisKKzxwIGlkPSJk ZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+Cisg ICAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCBjcmVhdGluZyBUZXh0TWFya2VyUmFuZ2Ug ZnJvbSBub2RlcyB0aGF0IGhhdmUgbm8gY2hpbGRyZW4gd29uJ3QgY29sbGFwc2UgdG8gb25lIHNp ZGUuIik7CisgICAgCisgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgewor ICAgICAgICB2YXIgdGV4dGJveCA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmFjY2Vzc2libGVF bGVtZW50QnlJZCgidGV4dGJveCIpOworICAgICAgICB2YXIgdGV4dGJveFJhbmdlID0gdGV4dGJv eC50ZXh0TWFya2VyUmFuZ2VGb3JFbGVtZW50KHRleHRib3gpOworICAgICAgICAvLyBUaGUgcmFu Z2Ugc2hvdWxkIGluY2x1ZGUgdGhlIGRpdiBlbGVtZW50LiAKKyAgICAgICAgc2hvdWxkQmVUcnVl KCJ0ZXh0Ym94LnRleHRNYXJrZXJSYW5nZUxlbmd0aCh0ZXh0Ym94UmFuZ2UpID09IDEiKTsKKyAg ICAgICAgCisgICAgICAgIC8vIE1ha2Ugc3VyZSB0aGUgbm9kZSB0aGF0IGFzc29jaWF0ZXMgd2l0 aCB0aGUgdGV4dCBtYXJrZXIgaXMgdGhlIHBhcmVudCBkaXYgZWxlbWVudC4KKyAgICAgICAgdmFy IHN0YXJ0TWFya2VyID0gdGV4dGJveC5zdGFydFRleHRNYXJrZXJGb3JUZXh0TWFya2VyUmFuZ2Uo dGV4dGJveFJhbmdlKTsKKyAgICAgICAgdmFyIGVuZE1hcmtlciA9IHRleHRib3guZW5kVGV4dE1h cmtlckZvclRleHRNYXJrZXJSYW5nZSh0ZXh0Ym94UmFuZ2UpOworICAgICAgICBzaG91bGRCZSgi dGV4dGJveC5hY2Nlc3NpYmlsaXR5RWxlbWVudEZvclRleHRNYXJrZXIoc3RhcnRNYXJrZXIpLmRl c2NyaXB0aW9uIiwgIidBWERlc2NyaXB0aW9uOiBwYXJlbnQgbGV2ZWwnIik7CisgICAgICAgIHNo b3VsZEJlKCJ0ZXh0Ym94LmFjY2Vzc2liaWxpdHlFbGVtZW50Rm9yVGV4dE1hcmtlcihlbmRNYXJr ZXIpLmRlc2NyaXB0aW9uIiwgIidBWERlc2NyaXB0aW9uOiBwYXJlbnQgbGV2ZWwnIik7CisgICAg fQorPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0 LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K