155612 2016-03-17 17:18:26 -0700 SpeculativeLoad needs to continue NetworkLoad when it receives a redirect response 2016-03-18 10:53:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=155254 P2 Normal --- 1 achristensen achristensen cdumez cgarcia commit-queue koivisto oldest_to_newest 1175926 0 achristensen 2016-03-17 17:18:26 -0700 SpeculativeLoad needs to continue NetworkLoad when it receives a redirect response 1175996 1 274361 achristensen 2016-03-17 19:54:31 -0700 Created attachment 274361 Patch 1175997 2 274361 cdumez 2016-03-17 19:59:35 -0700 Comment on attachment 274361 Patch lgtm. Antti, can you please use your new WK2 owner powers? 1176004 3 274361 sam 2016-03-17 20:11:09 -0700 Comment on attachment 274361 Patch What is the testing strategy for this? 1176007 4 cdumez 2016-03-17 20:26:06 -0700 (In reply to comment #3) > Comment on attachment 274361 [details] > Patch > > What is the testing strategy for this? Layout testing speculative loading is currently not easy but I filed: https://bugs.webkit.org/show_bug.cgi?id=155254 and am planning to work on adding test support very soon. 1176008 5 274361 cdumez 2016-03-17 20:26:33 -0700 Comment on attachment 274361 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274361&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:69 > + m_networkLoad->continueWillSendRequest(newRequest); this does not even build :D 1176010 6 274363 achristensen 2016-03-17 20:30:52 -0700 Created attachment 274363 Patch 1176049 7 achristensen 2016-03-17 23:13:06 -0700 http://trac.webkit.org/changeset/198378 1176226 8 achristensen 2016-03-18 10:53:48 -0700 rdar://problem/24843454 274361 2016-03-17 19:54:31 -0700 2016-03-17 20:30:48 -0700 Patch bug-155612-20160317195430.patch text/plain 1892 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODM3NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAzLTE3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU3BlY3VsYXRp dmVMb2FkIG5lZWRzIHRvIGNvbnRpbnVlIE5ldHdvcmtMb2FkIHdoZW4gaXQgcmVjZWl2ZXMgYSBy ZWRpcmVjdCByZXNwb25zZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU1NjEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxv YWQuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OlNwZWN1bGF0aXZlTG9hZDo6 d2lsbFNlbmRSZWRpcmVjdGVkUmVxdWVzdCk6CisgICAgICAgIENhbGwgY29udGludWVXaWxsU2Vu ZFJlcXVlc3QuICBPdGhlcndpc2UsIHdlIHdpbGwgaGFuZyBhIHRocmVhZCBpbiB0aGUgTmV0d29y a1Byb2Nlc3MKKyAgICAgICAgaWYgd2UgYXJlIHVzaW5nIFJlc291cmNlSGFuZGxlIG9yIHdlIHdp bGwgbm90IGNhbGwgdGhlIHdpbGxQZXJmb3JtSFRUUFJlZGlyZWN0aW9uIAorICAgICAgICBjb21w bGV0aW9uIGhhbmRsZXIgaWYgd2UgYXJlIHVzaW5nIE5ldHdvcmtTZXNzaW9uLiAgVGhpcyB3aWxs IGNhdXNlIHVzIHRvIHN0b3AgbG9hZGluZworICAgICAgICBmcm9tIHRoZSBzZXJ2ZXIgYWZ0ZXIg dGhlIG1heGltdW0gbnVtYmVyIG9mIGNvbm5lY3Rpb25zIGlzIHJlYWNoZWQuCisKIDIwMTYtMDMt MTcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRmlu ZC1pbi1wYWdlIGluZGljYXRvciBpbiBNYWlsIHZpZXdlciBpcyB0aGUgd3Jvbmcgc2NhbGUgYW5k IGN1dCBvZmYKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv cmtDYWNoZVNwZWN1bGF0aXZlTG9hZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmNwcAkocmV2 aXNpb24gMTk4Mzc1KQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0 d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjYsNiArNjYs NyBAQCBTcGVjdWxhdGl2ZUxvYWQ6On5TcGVjdWxhdGl2ZUxvYWQoKQogdm9pZCBTcGVjdWxhdGl2 ZUxvYWQ6OndpbGxTZW5kUmVkaXJlY3RlZFJlcXVlc3QoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiBy ZXF1ZXN0LCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlZGlyZWN0UmVxdWVzdCwgY29uc3QgUmVz b3VyY2VSZXNwb25zZSYgcmVkaXJlY3RSZXNwb25zZSkKIHsKICAgICB1cGRhdGVSZWRpcmVjdENo YWluU3RhdHVzKG1fcmVkaXJlY3RDaGFpbkNhY2hlU3RhdHVzLCByZWRpcmVjdFJlc3BvbnNlKTsK KyAgICBtX25ldHdvcmtMb2FkLT5jb250aW51ZVdpbGxTZW5kUmVxdWVzdChuZXdSZXF1ZXN0KTsK IH0KIAogYXV0byBTcGVjdWxhdGl2ZUxvYWQ6OmRpZFJlY2VpdmVSZXNwb25zZShjb25zdCBSZXNv dXJjZVJlc3BvbnNlJiByZWNlaXZlZFJlc3BvbnNlKSAtPiBTaG91bGRDb250aW51ZURpZFJlY2Vp dmVSZXNwb25zZQo= 274363 2016-03-17 20:30:52 -0700 2016-03-17 23:12:04 -0700 Patch bug-155612-20160317203051.patch text/plain 2087 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODM3NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAzLTE3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU3BlY3VsYXRp dmVMb2FkIG5lZWRzIHRvIGNvbnRpbnVlIE5ldHdvcmtMb2FkIHdoZW4gaXQgcmVjZWl2ZXMgYSBy ZWRpcmVjdCByZXNwb25zZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU1NjEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxv YWQuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OlNwZWN1bGF0aXZlTG9hZDo6 d2lsbFNlbmRSZWRpcmVjdGVkUmVxdWVzdCk6CisgICAgICAgIENhbGwgY29udGludWVXaWxsU2Vu ZFJlcXVlc3QuICBPdGhlcndpc2UsIHdlIHdpbGwgaGFuZyBhIHRocmVhZCBpbiB0aGUgTmV0d29y a1Byb2Nlc3MKKyAgICAgICAgaWYgd2UgYXJlIHVzaW5nIFJlc291cmNlSGFuZGxlIG9yIHdlIHdp bGwgbm90IGNhbGwgdGhlIHdpbGxQZXJmb3JtSFRUUFJlZGlyZWN0aW9uIAorICAgICAgICBjb21w bGV0aW9uIGhhbmRsZXIgaWYgd2UgYXJlIHVzaW5nIE5ldHdvcmtTZXNzaW9uLiAgVGhpcyB3aWxs IGNhdXNlIHVzIHRvIHN0b3AgbG9hZGluZworICAgICAgICBmcm9tIHRoZSBzZXJ2ZXIgYWZ0ZXIg dGhlIG1heGltdW0gbnVtYmVyIG9mIGNvbm5lY3Rpb25zIGlzIHJlYWNoZWQuCisKIDIwMTYtMDMt MTcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRmlu ZC1pbi1wYWdlIGluZGljYXRvciBpbiBNYWlsIHZpZXdlciBpcyB0aGUgd3Jvbmcgc2NhbGUgYW5k IGN1dCBvZmYKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv cmtDYWNoZVNwZWN1bGF0aXZlTG9hZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmNwcAkocmV2 aXNpb24gMTk4Mzc1KQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0 d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjMsOSArNjMs MTAgQEAgU3BlY3VsYXRpdmVMb2FkOjp+U3BlY3VsYXRpdmVMb2FkKCkKICAgICBBU1NFUlQoIW1f bmV0d29ya0xvYWQpOwogfQogCi12b2lkIFNwZWN1bGF0aXZlTG9hZDo6d2lsbFNlbmRSZWRpcmVj dGVkUmVxdWVzdChjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIGNvbnN0IFJlc291cmNl UmVxdWVzdCYgcmVkaXJlY3RSZXF1ZXN0LCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZWRpcmVj dFJlc3BvbnNlKQordm9pZCBTcGVjdWxhdGl2ZUxvYWQ6OndpbGxTZW5kUmVkaXJlY3RlZFJlcXVl c3QoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZWRpcmVj dFJlcXVlc3QsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlZGlyZWN0UmVzcG9uc2UpCiB7CiAg ICAgdXBkYXRlUmVkaXJlY3RDaGFpblN0YXR1cyhtX3JlZGlyZWN0Q2hhaW5DYWNoZVN0YXR1cywg cmVkaXJlY3RSZXNwb25zZSk7CisgICAgbV9uZXR3b3JrTG9hZC0+Y29udGludWVXaWxsU2VuZFJl cXVlc3QocmVkaXJlY3RSZXF1ZXN0KTsKIH0KIAogYXV0byBTcGVjdWxhdGl2ZUxvYWQ6OmRpZFJl Y2VpdmVSZXNwb25zZShjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZWNlaXZlZFJlc3BvbnNlKSAt PiBTaG91bGRDb250aW51ZURpZFJlY2VpdmVSZXNwb25zZQo=