155610 2016-03-17 16:56:59 -0700 Web Inspector: protocol generator shouldn't generate enums for parameters with non-anonymous enum types 2016-03-17 18:43:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue graouts joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1175915 0 bburg 2016-03-17 16:56:59 -0700 These enums are completely redundant and clutter up the generated header. 1175916 1 webkit-bug-importer 2016-03-17 16:57:22 -0700 <rdar://problem/25229878> 1175921 2 274342 bburg 2016-03-17 17:01:57 -0700 Created attachment 274342 Proposed Fix 1175923 3 commit-queue 2016-03-17 17:02:48 -0700 This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) 1175953 4 274342 joepeck 2016-03-17 17:53:28 -0700 Comment on attachment 274342 Proposed Fix r=me 1175975 5 274342 commit-queue 2016-03-17 18:43:10 -0700 Comment on attachment 274342 Proposed Fix Clearing flags on attachment: 274342 Committed r198373: <http://trac.webkit.org/changeset/198373> 1175976 6 commit-queue 2016-03-17 18:43:16 -0700 All reviewed patches have been landed. Closing bug. 274342 2016-03-17 17:01:57 -0700 2016-03-17 18:43:10 -0700 Proposed Fix bug-155610-20160317170156.patch text/plain 5491 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4MzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy YzcyMDUyMDUwYjRhYTg4ZDI0NTk3NmI3MWZmYThiYTI4NzJhMjY3Li5hYzg5ZTk3ZDk4YzMyN2Qx ZGFiNzdhY2I2ZTlhMDgzNzZiYjk1MWY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNi0wMy0xNyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBwcm90b2NvbCBnZW5lcmF0b3Igc2hvdWxkbid0IGdlbmVy YXRlIGVudW1zIGZvciBwYXJhbWV0ZXJzIHdpdGggbm9uLWFub255bW91cyBlbnVtIHR5cGVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU2MTAKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI1MjI5ODc4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIGEgY29tbWFuZCBwYXJhbWV0ZXIgaGFzIGFuIGFu b255bW91cyBlbnVtIHR5cGUsIHRoZSBiYWNrZW5kIGRpc3BhdGNoZXIgZ2VuZXJhdG9yCisgICAg ICAgIG1ha2VzIGEgQysrIGVudW0gZm9yIHRoZSBwYXJhbWV0ZXIuIEhvd2V2ZXIsIGlmIHRoZSBw YXJhbWV0ZXIgcmVmZXJlbmNlcyBhIG5hbWVkIGVudW0KKyAgICAgICAgdHlwZSBzcGVjaWZpZWQg aW4gYSBkb21haW4ncyAndHlwZScgc2VjdGlvbiwgdGhlbiB0aGVyZSdzIG5vIG5lZWQgdG8gZ2Vu ZXJhdGUgYW4gZW51bS4KKworICAgICAgICAqIGluc3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vZ2Vu ZXJhdGVfY3BwX2JhY2tlbmRfZGlzcGF0Y2hlcl9oZWFkZXIucHk6CisgICAgICAgIChDcHBCYWNr ZW5kRGlzcGF0Y2hlckhlYWRlckdlbmVyYXRvci5fZ2VuZXJhdGVfaGFuZGxlcl9kZWNsYXJhdGlv bl9mb3JfY29tbWFuZCk6CisgICAgICAgIEFkZCBhIG1pc3NpbmcgY2hlY2sgZm9yIHRoZSBpc19h bm9ueW1vdXMgZmxhZy4gVHlwZSByZWZlcmVuY2VzIHRvIG5hbWVkIGVudW1zIGFyZSByZXNvbHZl ZAorICAgICAgICB0byB0aGUgdW5kZXJseWluZyBhbGlhc2VkIEVudW1UeXBlIGluc3RlYWQgb2Yg YW4gQWxpYXNlZFR5cGUsIHNvIHdlIGhhdmUgdG8gY2hlY2sgdGhlIGZsYWcuCisKKyAgICAgICAg UmViYXNlbGluZSB0ZXN0cy4KKworICAgICAgICAqIGluc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2V4 cGVjdGVkL2NvbW1hbmRzLXdpdGgtYXN5bmMtYXR0cmlidXRlLmpzb24tcmVzdWx0OgorICAgICAg ICAqIGluc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2V4cGVjdGVkL2NvbW1hbmRzLXdpdGgtb3B0aW9u YWwtY2FsbC1yZXR1cm4tcGFyYW1ldGVycy5qc29uLXJlc3VsdDoKKwogMjAxNi0wMy0xNSAgRmls aXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6 ICFlZGdlLT5pc1BoYW50b21BbGxvY2F0aW9uKCkgaW4gcmVncmVzcy9zY3JpcHQtdGVzdHMvc2lu ay1odWdlLWFjdGl2YXRpb24uanMuZnRsLWVhZ2VyIGluIGRlYnVnIG1vZGUKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy9jb2RlZ2VuL2dlbmVyYXRl X2NwcF9iYWNrZW5kX2Rpc3BhdGNoZXJfaGVhZGVyLnB5IGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vZ2VuZXJhdGVfY3BwX2JhY2tlbmRfZGlzcGF0Y2hl cl9oZWFkZXIucHkKaW5kZXggMTdjODEwMmMwOGM5YTQxN2ZhODEzZTdmMzc0Zjg4Zjc1MTZiODZl OC4uNWViZDgyZmJkNzZjOTFkYmJkNjdkOTlmZTc5MDE5NGE4NjlmMmNiNyAxMDA3NTUKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vZ2VuZXJhdGVf Y3BwX2JhY2tlbmRfZGlzcGF0Y2hlcl9oZWFkZXIucHkKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2luc3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vZ2VuZXJhdGVfY3BwX2JhY2tlbmRfZGlzcGF0 Y2hlcl9oZWFkZXIucHkKQEAgLTEzNCw3ICsxMzQsNyBAQCBjbGFzcyBDcHBCYWNrZW5kRGlzcGF0 Y2hlckhlYWRlckdlbmVyYXRvcihHZW5lcmF0b3IpOgogCiAgICAgICAgICAgICBwYXJhbWV0ZXJz LmFwcGVuZCgiJXMgJXMiICUgKENwcEdlbmVyYXRvci5jcHBfdHlwZV9mb3JfdW5jaGVja2VkX2Zv cm1hbF9pbl9wYXJhbWV0ZXIoX3BhcmFtZXRlciksIHBhcmFtZXRlcl9uYW1lKSkKIAotICAgICAg ICAgICAgaWYgaXNpbnN0YW5jZShfcGFyYW1ldGVyLnR5cGUsIEVudW1UeXBlKSBhbmQgX3BhcmFt ZXRlci5wYXJhbWV0ZXJfbmFtZSBub3QgaW4gdXNlZF9lbnVtX25hbWVzOgorICAgICAgICAgICAg aWYgaXNpbnN0YW5jZShfcGFyYW1ldGVyLnR5cGUsIEVudW1UeXBlKSBhbmQgX3BhcmFtZXRlci50 eXBlLmlzX2Fub255bW91cyBhbmQgX3BhcmFtZXRlci5wYXJhbWV0ZXJfbmFtZSBub3QgaW4gdXNl ZF9lbnVtX25hbWVzOgogICAgICAgICAgICAgICAgIGxpbmVzLmFwcGVuZChzZWxmLl9nZW5lcmF0 ZV9hbm9ueW1vdXNfZW51bV9mb3JfcGFyYW1ldGVyKF9wYXJhbWV0ZXIsIGNvbW1hbmQpKQogICAg ICAgICAgICAgICAgIHVzZWRfZW51bV9uYW1lcy5hZGQoX3BhcmFtZXRlci5wYXJhbWV0ZXJfbmFt ZSkKIApAQCAtMTQ0LDcgKzE0NCw3IEBAIGNsYXNzIENwcEJhY2tlbmREaXNwYXRjaGVySGVhZGVy R2VuZXJhdG9yKEdlbmVyYXRvcik6CiAgICAgICAgICAgICAgICAgcGFyYW1ldGVyX25hbWUgPSAn b3B0XycgKyBwYXJhbWV0ZXJfbmFtZQogICAgICAgICAgICAgcGFyYW1ldGVycy5hcHBlbmQoIiVz ICVzIiAlIChDcHBHZW5lcmF0b3IuY3BwX3R5cGVfZm9yX2Zvcm1hbF9vdXRfcGFyYW1ldGVyKF9w YXJhbWV0ZXIpLCBwYXJhbWV0ZXJfbmFtZSkpCiAKLSAgICAgICAgICAgIGlmIGlzaW5zdGFuY2Uo X3BhcmFtZXRlci50eXBlLCBFbnVtVHlwZSkgYW5kIF9wYXJhbWV0ZXIucGFyYW1ldGVyX25hbWUg bm90IGluIHVzZWRfZW51bV9uYW1lczoKKyAgICAgICAgICAgIGlmIGlzaW5zdGFuY2UoX3BhcmFt ZXRlci50eXBlLCBFbnVtVHlwZSkgYW5kIF9wYXJhbWV0ZXIudHlwZS5pc19hbm9ueW1vdXMgYW5k IF9wYXJhbWV0ZXIucGFyYW1ldGVyX25hbWUgbm90IGluIHVzZWRfZW51bV9uYW1lczoKICAgICAg ICAgICAgICAgICBsaW5lcy5hcHBlbmQoc2VsZi5fZ2VuZXJhdGVfYW5vbnltb3VzX2VudW1fZm9y X3BhcmFtZXRlcihfcGFyYW1ldGVyLCBjb21tYW5kKSkKICAgICAgICAgICAgICAgICB1c2VkX2Vu dW1fbmFtZXMuYWRkKF9wYXJhbWV0ZXIucGFyYW1ldGVyX25hbWUpCiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9leHBlY3RlZC9jb21t YW5kcy13aXRoLWFzeW5jLWF0dHJpYnV0ZS5qc29uLXJlc3VsdCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9leHBlY3RlZC9jb21tYW5kcy13aXRoLWFzeW5j LWF0dHJpYnV0ZS5qc29uLXJlc3VsdAppbmRleCA5N2I3NGE0MTE4M2I2M2Q2ZjFkMGJkZmY5NWNi YTQ1MDU0ZTZiNGE3Li41YjNiZTA0ZGQ0YzZlYmMzY2JjYTU0OTY3ZWZjZTNkMzIyYmZhNmRjIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMv ZXhwZWN0ZWQvY29tbWFuZHMtd2l0aC1hc3luYy1hdHRyaWJ1dGUuanNvbi1yZXN1bHQKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2V4cGVjdGVkL2Nv bW1hbmRzLXdpdGgtYXN5bmMtYXR0cmlidXRlLmpzb24tcmVzdWx0CkBAIC0xNTQsMTIgKzE1NCw2 IEBAIGNsYXNzIEFsdGVybmF0ZURhdGFiYXNlQmFja2VuZERpc3BhdGNoZXI7CiAKIGNsYXNzIERh dGFiYXNlQmFja2VuZERpc3BhdGNoZXJIYW5kbGVyIHsKIHB1YmxpYzoKLSAgICAvLyBOYW1lZCBh ZnRlciBwYXJhbWV0ZXIgJ3NjcmVlbkNvbG9yJyB3aGlsZSBnZW5lcmF0aW5nIGNvbW1hbmQvZXZl bnQgZXhlY3V0ZVNRTFN5bmNPcHRpb25hbFJldHVyblZhbHVlcy4KLSAgICBlbnVtIGNsYXNzIFNj cmVlbkNvbG9yIHsKLSAgICAgICAgUmVkID0gMCwKLSAgICAgICAgR3JlZW4gPSAxLAotICAgICAg ICBCbHVlID0gMiwKLSAgICB9OyAvLyBlbnVtIGNsYXNzIFNjcmVlbkNvbG9yCiAgICAgLy8gTmFt ZWQgYWZ0ZXIgcGFyYW1ldGVyICdwcmludENvbG9yJyB3aGlsZSBnZW5lcmF0aW5nIGNvbW1hbmQv ZXZlbnQgZXhlY3V0ZVNRTFN5bmNPcHRpb25hbFJldHVyblZhbHVlcy4KICAgICBlbnVtIGNsYXNz IFByaW50Q29sb3IgewogICAgICAgICBDeWFuID0gMywKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9leHBlY3RlZC9jb21tYW5kcy13aXRo LW9wdGlvbmFsLWNhbGwtcmV0dXJuLXBhcmFtZXRlcnMuanNvbi1yZXN1bHQgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQvY29tbWFuZHMtd2l0 aC1vcHRpb25hbC1jYWxsLXJldHVybi1wYXJhbWV0ZXJzLmpzb24tcmVzdWx0CmluZGV4IGUxYzhi YzQ1OWU4NjQ5MDI4NzgzMzFmNTlhODA5M2I0ZTI5YWE3YzYuLjk2OGNjZWRmNzM1YjBhODNmMTJk NDRlZmY2MGUxZDAxNTEwMTc3NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9leHBlY3RlZC9jb21tYW5kcy13aXRoLW9wdGlvbmFsLWNh bGwtcmV0dXJuLXBhcmFtZXRlcnMuanNvbi1yZXN1bHQKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2luc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2V4cGVjdGVkL2NvbW1hbmRzLXdpdGgtb3B0aW9u YWwtY2FsbC1yZXR1cm4tcGFyYW1ldGVycy5qc29uLXJlc3VsdApAQCAtMTQ5LDEyICsxNDksNiBA QCBjbGFzcyBBbHRlcm5hdGVEYXRhYmFzZUJhY2tlbmREaXNwYXRjaGVyOwogCiBjbGFzcyBEYXRh YmFzZUJhY2tlbmREaXNwYXRjaGVySGFuZGxlciB7CiBwdWJsaWM6Ci0gICAgLy8gTmFtZWQgYWZ0 ZXIgcGFyYW1ldGVyICdzY3JlZW5Db2xvcicgd2hpbGUgZ2VuZXJhdGluZyBjb21tYW5kL2V2ZW50 IGV4ZWN1dGVBbGxPcHRpb25hbFBhcmFtZXRlcnMuCi0gICAgZW51bSBjbGFzcyBTY3JlZW5Db2xv ciB7Ci0gICAgICAgIFJlZCA9IDAsCi0gICAgICAgIEdyZWVuID0gMSwKLSAgICAgICAgQmx1ZSA9 IDIsCi0gICAgfTsgLy8gZW51bSBjbGFzcyBTY3JlZW5Db2xvcgogICAgIC8vIE5hbWVkIGFmdGVy IHBhcmFtZXRlciAncHJpbnRDb2xvcicgd2hpbGUgZ2VuZXJhdGluZyBjb21tYW5kL2V2ZW50IGV4 ZWN1dGVBbGxPcHRpb25hbFBhcmFtZXRlcnMuCiAgICAgZW51bSBjbGFzcyBQcmludENvbG9yIHsK ICAgICAgICAgQ3lhbiA9IDMsCg==