155599 2016-03-17 14:44:36 -0700 Media elements allowed to play without a user gesture, but requiring fullscreen playback, should not be allowed to autoplay. 2016-03-23 17:43:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=155764 P2 Normal --- 155819 1 jer.noble jer.noble commit-queue oldest_to_newest 1175860 0 jer.noble 2016-03-17 14:44:36 -0700 Media elements allowed to play without a user gesture, but requiring fullscreen playback, should not be allowed to autoplay. 1175861 1 274325 jer.noble 2016-03-17 14:47:52 -0700 Created attachment 274325 Patch 1176079 2 274325 darin 2016-03-17 23:52:58 -0700 Comment on attachment 274325 Patch It’s unlikely this will all work well long term if we have no regression tests. Please figure out a way to write a regression test for this. 1176232 3 jer.noble 2016-03-18 11:03:18 -0700 (In reply to comment #2) > Comment on attachment 274325 [details] > Patch > > It’s unlikely this will all work well long term if we have no regression > tests. Please figure out a way to write a regression test for this. Sure thing. I think it should be pretty easy, actually, to test this in LayoutTests. 1176239 4 274434 jer.noble 2016-03-18 11:15:48 -0700 Created attachment 274434 Patch for landing 1177047 5 274434 commit-queue 2016-03-22 11:04:02 -0700 Comment on attachment 274434 Patch for landing Clearing flags on attachment: 274434 Committed r198538: <http://trac.webkit.org/changeset/198538> 1177539 6 ap 2016-03-23 17:09:50 -0700 This broke two tests on iOS Simulator: https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/4266/steps/run-api-tests/logs/stdio Will roll out, as discussed in person. 1177541 7 commit-queue 2016-03-23 17:10:44 -0700 Re-opened since this is blocked by bug 155819 1177546 8 ap 2016-03-23 17:21:48 -0700 Jer followed up explaining that a patch has already been posted elsewhere. I haven't seen it. 1177547 9 jer.noble 2016-03-23 17:25:48 -0700 Alexey, you sent me a link to the bug on IRC. 1177548 10 jer.noble 2016-03-23 17:27:12 -0700 https://bugs.webkit.org/show_bug.cgi?id=155764 1177555 11 jer.noble 2016-03-23 17:43:43 -0700 Committed r198609: <http://trac.webkit.org/changeset/198609> 274325 2016-03-17 14:47:52 -0700 2016-03-17 23:52:58 -0700 Patch bug-155599-20160317144752.patch text/plain 1778 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4MzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTY1YzFlZTUxMGUxYmVm NWZlNTE5MDE4NDNiOTEyM2Y3M2FhYjJhNi4uYTE0M2NhNmNmOGQ1NjRmY2U5NjMxNDU1ODE4ZjZk NDliMjE4MmQyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTAzLTE3ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIE1lZGlhIGVsZW1lbnRzIGFs bG93ZWQgdG8gcGxheSB3aXRob3V0IGEgdXNlciBnZXN0dXJlLCBidXQgcmVxdWlyaW5nIGZ1bGxz Y3JlZW4gcGxheWJhY2ssIHNob3VsZCBub3QgYmUgYWxsb3dlZCB0byBhdXRvcGxheS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTU5OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVudGVyaW5nIGZ1bGxz Y3JlZW4gc2hvdWxkIGFsd2F5cyByZXF1aXJlIGEgdXNlciBnZXN0dXJlLgorCisgICAgICAgICog aHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRWxl bWVudFNlc3Npb246OnBsYXliYWNrUGVybWl0dGVkKToKKworMjAxNi0wMy0xNyAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKwogICAgICAgICBDYWNoZWRSZXNvdXJjZTo6TWVkaWFS ZXNvdXJjZSB0eXBlcyBzaG91bGRuJ3QgYmUgYmxvY2tlZCBkdWUgdG8gbWl4ZWQtY29udGVudC4K ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTU4OAog ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjUxNzc3OTU+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9N ZWRpYUVsZW1lbnRTZXNzaW9uLmNwcAppbmRleCAxYjEwYmQyNDk5ZjU0YzBmMjcxYzZlZWUxMjhi NmYwNDQ3ZjM0MzY0Li4zNTFkNTlhYmU2MmI1N2U0ZTZiZTQ4OTI5ZTQwMTJiMWQ0M2Y0ZWI2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAKQEAgLTE0Niw2 ICsxNDYsMTEgQEAgYm9vbCBNZWRpYUVsZW1lbnRTZXNzaW9uOjpwbGF5YmFja1Blcm1pdHRlZChj b25zdCBIVE1MTWVkaWFFbGVtZW50JiBlbGVtZW50KSBjb24KICAgICBpZiAocGFnZUV4cGxpY2l0 bHlBbGxvd3NFbGVtZW50VG9BdXRvcGxheUlubGluZShlbGVtZW50KSkKICAgICAgICAgcmV0dXJu IHRydWU7CiAKKyAgICBpZiAocmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlkZW9QbGF5YmFjayhlbGVt ZW50KSAmJiAhU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2luZ1VzZXJHZXN0dXJlRm9yTWVkaWEo KSkgeworICAgICAgICBMT0coTWVkaWEsICJNZWRpYUVsZW1lbnRTZXNzaW9uOjpwbGF5YmFja1Bl cm1pdHRlZCAtIHJldHVybmluZyBGQUxTRSIpOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg fQorCiAgICAgaWYgKG1fcmVzdHJpY3Rpb25zICYgT3ZlcnJpZGVVc2VyR2VzdHVyZVJlcXVpcmVt ZW50Rm9yTWFpbkNvbnRlbnQgJiYgdXBkYXRlSXNNYWluQ29udGVudCgpKQogICAgICAgICByZXR1 cm4gdHJ1ZTsKIAo= 274434 2016-03-18 11:15:48 -0700 2016-03-22 11:04:02 -0700 Patch for landing bug-155599-20160318111548.patch text/plain 3590 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzg0OGUzOGI3MmY5YmNi MWVhMjkyMDFmMDkwN2E3Njc3ZWI5MzM4OS4uNDgzMWNjY2IzN2YyY2MyMWQ1NTU1YTlmNmJmZDNm N2QxZWY1NjI5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTAzLTE3ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIE1lZGlhIGVsZW1lbnRzIGFs bG93ZWQgdG8gcGxheSB3aXRob3V0IGEgdXNlciBnZXN0dXJlLCBidXQgcmVxdWlyaW5nIGZ1bGxz Y3JlZW4gcGxheWJhY2ssIHNob3VsZCBub3QgYmUgYWxsb3dlZCB0byBhdXRvcGxheS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTU5OQorCisgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIFRlc3Q6IG1lZGlhL3ZpZGVv LWF1dG9wbGF5LWFsbG93ZWQtYnV0LWZ1bGxzY3JlZW4tcmVxdWlyZWQuaHRtbAorCisgICAgICAg IEVudGVyaW5nIGZ1bGxzY3JlZW4gc2hvdWxkIGFsd2F5cyByZXF1aXJlIGEgdXNlciBnZXN0dXJl LgorCisgICAgICAgICogaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhRWxlbWVudFNlc3Npb246OnBsYXliYWNrUGVybWl0dGVkKToKKworMjAxNi0w My0xNyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKwogICAgICAgICBDYWNoZWRS ZXNvdXJjZTo6TWVkaWFSZXNvdXJjZSB0eXBlcyBzaG91bGRuJ3QgYmUgYmxvY2tlZCBkdWUgdG8g bWl4ZWQtY29udGVudC4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1NTU4OAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjUxNzc3OTU+CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcAppbmRleCAxYjEwYmQyNDk5ZjU0 YzBmMjcxYzZlZWUxMjhiNmYwNDQ3ZjM0MzY0Li4zNTFkNTlhYmU2MmI1N2U0ZTZiZTQ4OTI5ZTQw MTJiMWQ0M2Y0ZWI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVu dFNlc3Npb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lv bi5jcHAKQEAgLTE0Niw2ICsxNDYsMTEgQEAgYm9vbCBNZWRpYUVsZW1lbnRTZXNzaW9uOjpwbGF5 YmFja1Blcm1pdHRlZChjb25zdCBIVE1MTWVkaWFFbGVtZW50JiBlbGVtZW50KSBjb24KICAgICBp ZiAocGFnZUV4cGxpY2l0bHlBbGxvd3NFbGVtZW50VG9BdXRvcGxheUlubGluZShlbGVtZW50KSkK ICAgICAgICAgcmV0dXJuIHRydWU7CiAKKyAgICBpZiAocmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlk ZW9QbGF5YmFjayhlbGVtZW50KSAmJiAhU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2luZ1VzZXJH ZXN0dXJlRm9yTWVkaWEoKSkgeworICAgICAgICBMT0coTWVkaWEsICJNZWRpYUVsZW1lbnRTZXNz aW9uOjpwbGF5YmFja1Blcm1pdHRlZCAtIHJldHVybmluZyBGQUxTRSIpOworICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgfQorCiAgICAgaWYgKG1fcmVzdHJpY3Rpb25zICYgT3ZlcnJpZGVVc2Vy R2VzdHVyZVJlcXVpcmVtZW50Rm9yTWFpbkNvbnRlbnQgJiYgdXBkYXRlSXNNYWluQ29udGVudCgp KQogICAgICAgICByZXR1cm4gdHJ1ZTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEv dmlkZW8tYXV0b3BsYXktYWxsb3dlZC1idXQtZnVsbHNjcmVlbi1yZXF1aXJlZC1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1hdXRvcGxheS1hbGxvd2VkLWJ1dC1mdWxsc2Ny ZWVuLXJlcXVpcmVkLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lMzEzMTEzMGQzYzBiZDM4M2Nl MDUxYmY3MTE5Mjk0MTBkYzgzMzE1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVk aWEvdmlkZW8tYXV0b3BsYXktYWxsb3dlZC1idXQtZnVsbHNjcmVlbi1yZXF1aXJlZC1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSw1IEBACitSVU4oaW50ZXJuYWxzLnNldHRpbmdzLnNldEFsbG93c0lu bGluZU1lZGlhUGxheWJhY2soZmFsc2UpKQorRVZFTlQoY2FucGxheXRocm91Z2gpCitWaWRlbyBk aWQgbm90IGJlZ2luIHBsYXlpbmcgT0sKK0VORCBPRiBURVNUCisKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL21lZGlhL3ZpZGVvLWF1dG9wbGF5LWFsbG93ZWQtYnV0LWZ1bGxzY3JlZW4tcmVxdWly ZWQuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWF1dG9wbGF5LWFsbG93ZWQtYnV0LWZ1 bGxzY3JlZW4tcmVxdWlyZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yMGE1NTRiZDY4NTliNGQ2NzA5ZDM4 ODllMzcwY2Q5NTBjNjg4NGY2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEv dmlkZW8tYXV0b3BsYXktYWxsb3dlZC1idXQtZnVsbHNjcmVlbi1yZXF1aXJlZC5odG1sCkBAIC0w LDAgKzEsMzEgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8dGl0bGU+ dmlkZW8tbWFpbi1jb250ZW50LWFsbG93PC90aXRsZT4KKyAgICA8c2NyaXB0IHNyYz0idmlkZW8t dGVzdC5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Im1lZGlhLWZpbGUuanMiPjwvc2Ny aXB0PgorICAgIDxzY3JpcHQ+CisgICAgZnVuY3Rpb24gZ28oKSB7CisgICAgICAgIHJ1bignaW50 ZXJuYWxzLnNldHRpbmdzLnNldEFsbG93c0lubGluZU1lZGlhUGxheWJhY2soZmFsc2UpJyk7Cisg ICAgICAgIHZpZGVvID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgndmlkZW8nKTsKKyAgICAgICAg ZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZCh2aWRlbyk7CisKKyAgICAgICAgdmlkZW8uc3JjID0g ZmluZE1lZGlhRmlsZSgndmlkZW8nLCAnY29udGVudC90ZXN0Jyk7CisgICAgICAgIHdhaXRGb3JF dmVudCgnY2FucGxheXRocm91Z2gnLCBjYW5QbGF5VGhyb3VnaCk7CisgICAgfQorCisgICAgZnVu Y3Rpb24gY2FuUGxheVRocm91Z2goKSB7CisgICAgICAgIHZpZGVvLnBsYXkoKTsKKyAgICAgICAg d2FpdEZvckV2ZW50QW5kRmFpbCgncGxheWluZycpOworICAgICAgICBzZXRUaW1lb3V0KGRpZE5v dFBsYXksIDEwMCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gZGlkTm90UGxheSgpIHsKKyAgICAg ICAgbG9nUmVzdWx0KHRydWUsICJWaWRlbyBkaWQgbm90IGJlZ2luIHBsYXlpbmciKTsKKyAgICAg ICAgZW5kVGVzdCgpOworICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9h ZD0iZ28oKSI+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=