155591 2016-03-17 11:33:42 -0700 We should have a DFG intrinsic for the construct case of the Object constructor 2021-01-05 11:55:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Enhancement --- 1 keith_miller ashvayka ashvayka ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1175786 0 keith_miller 2016-03-17 11:33:42 -0700 ... 1717303 1 417003 ashvayka 2021-01-05 07:27:57 -0800 Created attachment 417003 Patch 1717304 2 ashvayka 2021-01-05 07:42:47 -0800 (In reply to Alexey Shvayka from comment #1) > Created attachment 417003 [details] > Patch r270932 patch new-object-no-expected-function 29.9128+-0.8178 ^ 7.1561+-0.4640 ^ definitely 4.1800x faster 1717409 3 417003 ysuzuki 2021-01-05 11:50:45 -0800 Comment on attachment 417003 Patch r=me 1717412 4 ews-feeder 2021-01-05 11:54:22 -0800 Committed r271164: <https://trac.webkit.org/changeset/271164> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417003. 1717414 5 webkit-bug-importer 2021-01-05 11:55:16 -0800 <rdar://problem/72823189> 417003 2021-01-05 07:27:57 -0800 2021-01-05 11:54:23 -0800 Patch bug-155591-20210105172756.patch text/plain 5031 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzExNDYpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDIxLTAxLTA1ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBXZSBzaG91bGQgaGF2ZSBhIERGRyBpbnRyaW5zaWMgZm9y IHRoZSBjb25zdHJ1Y3QgY2FzZSBvZiB0aGUgT2JqZWN0IGNvbnN0cnVjdG9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU1OTEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1pY3JvYmVuY2htYXJrcy9u ZXctb2JqZWN0LW5vLWV4cGVjdGVkLWZ1bmN0aW9uLmpzOiBBZGRlZC4KKyAgICAgICAgKiBzdHJl c3MvY2FsbC1vYmplY3QtY29uc3RydWN0b3Itd2l0aC1uZXcuanM6IEFkZGVkLgorICAgICAgICAq IHN0cmVzcy9kZmctYnVpbHRpbi1jb25zdHJ1Y3Rvci1jcm9zcy1yZWFsbS5qczogQWRkZWQuCisK IDIwMjEtMDEtMDUgIERtaXRyeSBCZXpoZXRza292ICA8ZGJlemhldHNrb3ZAaWdhbGlhLmNvbT4K IAogICAgICAgICBbV0FTTS1SZWZlcmVuY2VzXSBBZGRlZCBmZXcgdW5yZWFjaGVkLWludmFsaWQg dGVzdHMKSW5kZXg6IEpTVGVzdHMvbWljcm9iZW5jaG1hcmtzL25ldy1vYmplY3Qtbm8tZXhwZWN0 ZWQtZnVuY3Rpb24uanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9taWNyb2JlbmNobWFya3MvbmV3 LW9iamVjdC1uby1leHBlY3RlZC1mdW5jdGlvbi5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3Rz L21pY3JvYmVuY2htYXJrcy9uZXctb2JqZWN0LW5vLWV4cGVjdGVkLWZ1bmN0aW9uLmpzCSh3b3Jr aW5nIGNvcHkpCkBAIC0wLDAgKzEsMTEgQEAKK2NvbnN0IHdpbmRvdyA9IHRoaXM7CisKKyhmdW5j dGlvbigpIHsKKyAgICB2YXIgb2JqOworCisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCAxZTY7IGkr KykKKyAgICAgICAgb2JqID0gbmV3IHdpbmRvdy5PYmplY3QoKTsKKworICAgIGlmIChvYmouY29u c3RydWN0b3IgIT09IE9iamVjdCkKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJCYWQgYXNzZXJ0 ISIpOworfSkoKTsKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2NhbGwtb2JqZWN0LWNvbnN0cnVjdG9y LXdpdGgtbmV3LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2NhbGwtb2JqZWN0LWNv bnN0cnVjdG9yLXdpdGgtbmV3LmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2Nh bGwtb2JqZWN0LWNvbnN0cnVjdG9yLXdpdGgtbmV3LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAg KzEsMTkgQEAKK2Z1bmN0aW9uIHRlc3QobikgeworICAgIHJldHVybiBuID09PSBuZXcgT2JqZWN0 KG4pOworfQorbm9JbmxpbmUodGVzdCk7CisKK2Z1bmN0aW9uIGFzc2VydChjb25kaXRpb24pIHsK KyAgICBpZiAoIWNvbmRpdGlvbikKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJhc3NlcnRpb24g ZmFpbGVkIik7Cit9CisKK2ZvciAobGV0IGkgPSAwOyBpIDwgMWU1OyBpKyspIHsKKyAgICBhc3Nl cnQoIXRlc3QobnVsbCkpOworICAgIGFzc2VydCghdGVzdCh1bmRlZmluZWQpKTsKKyAgICBhc3Nl cnQoIXRlc3QoMSkpOworICAgIGFzc2VydCghdGVzdCgiIikpOworICAgIGFzc2VydCghdGVzdChT eW1ib2wuaXRlcmF0b3IpKTsKKyAgICBhc3NlcnQodGVzdCh7fSkpOworICAgIGFzc2VydCh0ZXN0 KFtdKSk7Cit9CkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9kZmctYnVpbHRpbi1jb25zdHJ1Y3Rvci1j cm9zcy1yZWFsbS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9kZmctYnVpbHRpbi1j b25zdHJ1Y3Rvci1jcm9zcy1yZWFsbS5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVz cy9kZmctYnVpbHRpbi1jb25zdHJ1Y3Rvci1jcm9zcy1yZWFsbS5qcwkod29ya2luZyBjb3B5KQpA QCAtMCwwICsxLDMzIEBACitmdW5jdGlvbiBzaG91bGRCZShhY3R1YWwsIGV4cGVjdGVkKSB7Cisg ICAgaWYgKGFjdHVhbCAhPT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93IG5ldyBFcnJvcihgQmFk IHZhbHVlOiAke2FjdHVhbH0hYCk7Cit9Citub0lubGluZShzaG91bGRCZSk7CisKK2NvbnN0IHsK KyAgICBBcnJheTogT3RoZXJBcnJheSwKKyAgICBTdHJpbmc6IE90aGVyU3RyaW5nLAorICAgIE9i amVjdDogT3RoZXJPYmplY3QsCisgICAgSW50OEFycmF5OiBPdGhlckludDhBcnJheSwKK30gPSBj cmVhdGVHbG9iYWxPYmplY3QoKTsKKworZnVuY3Rpb24gbmV3QXJyYXkoKSB7IHJldHVybiBuZXcg T3RoZXJBcnJheSg0KTsgfQorbm9JbmxpbmUobmV3QXJyYXkpOworCitmdW5jdGlvbiBuZXdTdHJp bmcoKSB7IHJldHVybiBuZXcgT3RoZXJTdHJpbmcoImZvbyIpOyB9Citub0lubGluZShuZXdTdHJp bmcpOworCitmdW5jdGlvbiBuZXdPYmplY3QoKSB7IHJldHVybiBuZXcgT3RoZXJPYmplY3QoKTsg fQorbm9JbmxpbmUobmV3T2JqZWN0KTsKKworZnVuY3Rpb24gbmV3SW50OEFycmF5KCkgeyByZXR1 cm4gbmV3IE90aGVySW50OEFycmF5KDQpOyB9Citub0lubGluZShuZXdJbnQ4QXJyYXkpOworCiso ZnVuY3Rpb24oKSB7CisgICAgZm9yIChsZXQgaSA9IDA7IGkgPCAxZTU7IGkrKykgeworICAgICAg ICBzaG91bGRCZShuZXdBcnJheSgpLmNvbnN0cnVjdG9yLCBPdGhlckFycmF5KTsKKyAgICAgICAg c2hvdWxkQmUobmV3U3RyaW5nKCkuY29uc3RydWN0b3IsIE90aGVyU3RyaW5nKTsKKyAgICAgICAg c2hvdWxkQmUobmV3T2JqZWN0KCkuY29uc3RydWN0b3IsIE90aGVyT2JqZWN0KTsKKyAgICAgICAg c2hvdWxkQmUobmV3SW50OEFycmF5KCkuY29uc3RydWN0b3IsIE90aGVySW50OEFycmF5KTsKKyAg ICB9Cit9KSgpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzExMzEp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMjIgQEAKKzIwMjEtMDEtMDUgIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21h aWwuY29tPgorCisgICAgICAgIFdlIHNob3VsZCBoYXZlIGEgREZHIGludHJpbnNpYyBmb3IgdGhl IGNvbnN0cnVjdCBjYXNlIG9mIHRoZSBPYmplY3QgY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTU5MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdpdmVuIHRoYXQgYSkgT2JqZWN0Q29u c3RydWN0b3IgYmVoYXZlcyBpZGVudGljYWxseSBmb3IgW1tDYWxsXV0gYW5kIFtbQ29uc3RydWN0 XV0gd2l0aCBpdHNlbGYKKyAgICAgICAgYXMgTmV3VGFyZ2V0IFsxXSBhbmQgYikgaGFuZGxlQ29u c3RhbnRJbnRlcm5hbEZ1bmN0aW9uKCkgcmV0dXJucyBlYXJseSBpZiBOZXdUYXJnZXQgaXMgYWx0 ZXJlZCwKKyAgICAgICAgdGhpcyBwYXRjaCBzaW1wbHkgcmVtb3ZlcyBDb2RlRm9yQ2FsbCBndWFy ZC4KKworICAgICAgICBXaGlsZSBgbmV3IE9iamVjdCgpYCBpcyBhbHJlYWR5IG9wdGltaXplZCB2 aWEgQnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRFeHBlY3RlZEZ1bmN0aW9uU25pcHBldCgpLAorICAg ICAgICB0aGlzIGNoYW5nZSBpcyBhIDR4IHNwZWVkdXAgZm9yIHJhdGhlciByYXJlIHVzYWdlcyBs aWtlIGBuZXcgd2luZG93Lk9iamVjdCgpYC4KKworICAgICAgICBbMV06IGh0dHBzOi8vdGMzOS5l cy9lY21hMjYyLyNzZWMtb2JqZWN0LXZhbHVlIChzdGVwIDEpCisKKyAgICAgICAgKiBkZmcvREZH Qnl0ZUNvZGVQYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVDb2RlUGFyc2VyOjpo YW5kbGVDb25zdGFudEludGVybmFsRnVuY3Rpb24pOgorCiAyMDIxLTAxLTA0ICBKZWZmIE1pbGxl ciAgPGplZmZtQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgdXNlci12aXNpYmxlIGNvcHly aWdodCBzdHJpbmdzIHRvIGluY2x1ZGUgMjAyMQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHJldmlzaW9uIDI3MTEzMSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00MDk0LDggKzQwOTQsNyBAQCBib29sIEJ5dGVDb2RlUGFyc2VyOjpoYW5kbGVDb25z dGFudEludGVyCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIAotICAgIC8vIEZJWE1FOiBU aGlzIHNob3VsZCBoYW5kbGUgY29uc3RydWN0aW9uIGFzIHdlbGwuIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU1OTEKLSAgICBpZiAoZnVuY3Rpb24tPmNsYXNzSW5m bygqbV92bSkgPT0gT2JqZWN0Q29uc3RydWN0b3I6OmluZm8oKSAmJiBraW5kID09IENvZGVGb3JD YWxsKSB7CisgICAgaWYgKGZ1bmN0aW9uLT5jbGFzc0luZm8oKm1fdm0pID09IE9iamVjdENvbnN0 cnVjdG9yOjppbmZvKCkpIHsKICAgICAgICAgaW5zZXJ0Q2hlY2tzKCk7CiAKICAgICAgICAgTm9k ZSogcmVzdWx0Tm9kZTsK