155574 2016-03-16 18:55:57 -0700 [iOS] Allow clients to hide the accessory view on a form input session 2016-04-21 11:10:20 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 cpugh webkit-unassigned adele commit-queue cpugh enrica mitz oldest_to_newest 1175602 0 cpugh 2016-03-16 18:55:57 -0700 Allow clients to hide the accessory view on a form input session. Patch forthcoming. 1175604 1 274253 cpugh 2016-03-16 19:03:54 -0700 Created attachment 274253 patch v1 1175640 2 274253 mitz 2016-03-16 22:18:28 -0700 Comment on attachment 274253 patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=274253&action=review r=me I am not setting cq+, in case you are inspired to change the name before committing this, but I’m fine with going with this name, and possibly changing it later. > Source/WebKit2/UIProcess/API/Cocoa/_WKFormInputSession.h:45 > +@property (nonatomic) BOOL hidesAccessoryView WK_AVAILABLE(NA, WK_IOS_TBA); This can be named better, but I don’t have a great suggestion. The things that I don’t like about this name are (a) an input session isn’t really a thing that hides (or shows) the accessory view (b) it’s strange to treat the accessory view as something that’s there by default and the input session can hide, but I understand how it would be misleading to name this property showsAccessoryView, because the accessory view isn’t shown for all input types. Here’s a not-so-great suggestion: // Defaults to YES. @property BOOL accessoryViewMayShow; 1185650 3 276882 cpugh 2016-04-20 18:54:44 -0700 Created attachment 276882 patch v2 with name change 1185851 4 276882 commit-queue 2016-04-21 11:10:15 -0700 Comment on attachment 276882 patch v2 with name change Clearing flags on attachment: 276882 Committed r199823: <http://trac.webkit.org/changeset/199823> 1185852 5 commit-queue 2016-04-21 11:10:20 -0700 All reviewed patches have been landed. Closing bug. 274253 2016-03-16 19:03:54 -0700 2016-04-20 18:54:44 -0700 patch v1 patch.txt text/plain 2970 cpugh SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODMxMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAzLTE2ICBDaGVsc2Vh IFB1Z2ggIDxjcHVnaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQWxsb3cgY2xpZW50cyB0 byBoaWRlIHRoZSBhY2Nlc3NvcnkgdmlldyBvbiBhIGZvcm0gaW5wdXQgc2Vzc2lvbiAgICAgICAg CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU1NzQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvQ29jb2EvX1dLRm9ybUlucHV0U2Vzc2lvbi5oOgorICAgICAgICAqIFVJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0Zvcm1JbnB1 dFNlc3Npb24gaGlkZXNBY2Nlc3NvcnlWaWV3XSk6IEdldHRlciBmb3IgaGlkZXNBY2Nlc3NvcnlW aWV3LgorICAgICAgICAoLVtXS0Zvcm1JbnB1dFNlc3Npb24gc2V0SGlkZXNBY2Nlc3NvcnlWaWV3 Ol0pOiBTZXQgaGlkZXNBY2Nlc3NvcnlWaWV3IGFuZCByZWxvYWQgaW5wdXQgdmlld3MuCisgICAg ICAgICgtW1dLQ29udGVudFZpZXcgcmVxdWlyZXNBY2Nlc3NvcnlWaWV3XSk6IElmIHRoZSBhY2Nl c3NvcnkgdmlldyBzaG91bGQgYmUgaGlkZGVuLCBkbyBub3QgcmVxdWlyZSB0aGUgYWNjZXNzb3J5 IHZpZXcuCisKIDIwMTYtMDMtMTYgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFByb3ZpZGUgTlNTcGVsbENoZWNrZXIgc3BlbGxDaGVja2luZyBtZXRob2RzIHdpdGgg dGhlIGN1cnJlbnQgaW5zZXJ0aW9uIHBvaW50CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL19XS0Zvcm1JbnB1dFNlc3Npb24uaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0Zvcm1JbnB1dFNlc3Npb24uaAkocmV2aXNp b24gMTk4MzA4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tGb3Jt SW5wdXRTZXNzaW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTQyLDYgKzQyLDcgQEAKIEBwcm9wZXJ0 eSAobm9uYXRvbWljLCBjb3B5KSBOU1N0cmluZyAqYWNjZXNzb3J5Vmlld0N1c3RvbUJ1dHRvblRp dGxlOwogQHByb3BlcnR5IChub25hdG9taWMsIHN0cm9uZykgVUlWaWV3ICpjdXN0b21JbnB1dFZp ZXcgV0tfQVZBSUxBQkxFKE5BLCBXS19JT1NfVEJBKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBj b3B5KSBOU0FycmF5PFVJVGV4dFN1Z2dlc3Rpb24gKj4gKnN1Z2dlc3Rpb25zIFdLX0FWQUlMQUJM RShOQSwgV0tfSU9TX1RCQSk7CitAcHJvcGVydHkgKG5vbmF0b21pYykgQk9PTCBoaWRlc0FjY2Vz c29yeVZpZXcgV0tfQVZBSUxBQkxFKE5BLCBXS19JT1NfVEJBKTsKICNlbmRpZgogCiBAZW5kCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMTk4MzA4KQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29weSkK QEAgLTI2MSw2ICsyNjEsNyBAQAogICAgIFJldGFpblB0cjxXS0ZvY3VzZWRFbGVtZW50SW5mbz4g X2ZvY3VzZWRFbGVtZW50SW5mbzsKICAgICBSZXRhaW5QdHI8VUlWaWV3PiBfY3VzdG9tSW5wdXRW aWV3OwogICAgIFJldGFpblB0cjxOU0FycmF5PFVJVGV4dFN1Z2dlc3Rpb24gKj4+IF9zdWdnZXN0 aW9uczsKKyAgICBCT09MIF9oaWRlc0FjY2Vzc29yeVZpZXc7CiB9CiAKIC0gKGluc3RhbmNldHlw ZSlpbml0V2l0aENvbnRlbnRWaWV3OihXS0NvbnRlbnRWaWV3ICopdmlldyBmb2N1c2VkRWxlbWVu dEluZm86KFdLRm9jdXNlZEVsZW1lbnRJbmZvICopZWxlbWVudEluZm8gdXNlck9iamVjdDooTlNP YmplY3QgPE5TU2VjdXJlQ29kaW5nPiAqKXVzZXJPYmplY3QKQEAgLTMwNSw2ICszMDYsMjAgQEAK ICAgICAgICAgW19jb250ZW50VmlldyByZWxvYWRJbnB1dFZpZXdzXTsKIH0KIAorLSAoQk9PTClo aWRlc0FjY2Vzc29yeVZpZXcKK3sKKyAgICByZXR1cm4gX2hpZGVzQWNjZXNzb3J5VmlldzsKK30K KworLSAodm9pZClzZXRIaWRlc0FjY2Vzc29yeVZpZXc6KEJPT0wpaGlkZXNBY2Nlc3NvcnlWaWV3 Cit7CisgICAgaWYgKF9oaWRlc0FjY2Vzc29yeVZpZXcgPT0gaGlkZXNBY2Nlc3NvcnlWaWV3KQor ICAgICAgICByZXR1cm47CisKKyAgICBfaGlkZXNBY2Nlc3NvcnlWaWV3ID0gaGlkZXNBY2Nlc3Nv cnlWaWV3OworICAgIFtfY29udGVudFZpZXcgcmVsb2FkSW5wdXRWaWV3c107Cit9CisKIC0gKFVJ VmlldyAqKWN1c3RvbUlucHV0VmlldwogewogICAgIHJldHVybiBfY3VzdG9tSW5wdXRWaWV3Lmdl dCgpOwpAQCAtMTU0Niw2ICsxNTYxLDkgQEAKIAogLSAoQk9PTClyZXF1aXJlc0FjY2Vzc29yeVZp ZXcKIHsKKyAgICBpZiAoW19mb3JtSW5wdXRTZXNzaW9uIGhpZGVzQWNjZXNzb3J5Vmlld10pCisg ICAgICAgIHJldHVybiBOTzsKKwogICAgIHN3aXRjaCAoX2Fzc2lzdGVkTm9kZUluZm9ybWF0aW9u LmVsZW1lbnRUeXBlKSB7CiAgICAgY2FzZSBJbnB1dFR5cGU6Ok5vbmU6CiAgICAgICAgIHJldHVy biBOTzsK 276882 2016-04-20 18:54:44 -0700 2016-04-21 11:10:15 -0700 patch v2 with name change patch v2.txt text/plain 3164 cpugh SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTgwMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA0LTIwICBDaGVsc2Vh IFB1Z2ggIDxjcHVnaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQWxsb3cgY2xpZW50cyB0 byBoaWRlIHRoZSBhY2Nlc3NvcnkgdmlldyBvbiBhIGZvcm0gaW5wdXQgc2Vzc2lvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NTc0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL19XS0Zvcm1JbnB1dFNlc3Npb24uaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tGb3JtSW5wdXRTZXNzaW9u IGFjY2Vzc29yeVZpZXdTaG91bGROb3RTaG93XSk6IEdldHRlciBmb3IgYWNjZXNzb3J5Vmlld1No b3VsZE5vdFNob3cuCisgICAgICAgICgtW1dLRm9ybUlucHV0U2Vzc2lvbiBzZXRBY2Nlc3NvcnlW aWV3U2hvdWxkTm90U2hvdzpdKTogU2V0IGFjY2Vzc29yeVZpZXdTaG91bGROb3RTaG93IGFuZCBy ZWxvYWQgaW5wdXQgdmlld3MuCisgICAgICAgICgtW1dLQ29udGVudFZpZXcgcmVxdWlyZXNBY2Nl c3NvcnlWaWV3XSk6IElmIHRoZSBhY2Nlc3NvcnkgdmlldyBzaG91bGQgYmUgbm90IGJlIHNob3du LCBkbyBub3QgcmVxdWlyZQorICAgICAgICB0aGUgYWNjZXNzb3J5IHZpZXcuCisKIDIwMTYtMDQt MjAgIER1c3RpbiBGYWxnb3V0ICA8ZHVzdGluQGZhbGdvdXQudXM+CiAKICAgICAgICAgW0dUS10g RXhwb3NlIEFsbG93VW5pdmVyc2FsQWNjZXNzRnJvbUZpbGVVUkxzIHByZWZlcmVuY2Ugbm93IHRo YXQgY2FsbGluZyBsb2NhbFN0b3JhZ2UuZ2V0SXRlbSgpIHJlc3VsdHMgaW4gU2VjdXJpdHlFcnJv cjogRE9NIEV4Y2VwdGlvbiAxOApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9fV0tGb3JtSW5wdXRTZXNzaW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tGb3JtSW5wdXRTZXNzaW9uLmgJKHJldmlzaW9uIDE5OTc3 NCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRm9ybUlucHV0U2Vz c2lvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0Miw3IEBACiBAcHJvcGVydHkgKG5vbmF0 b21pYywgY29weSkgTlNTdHJpbmcgKmFjY2Vzc29yeVZpZXdDdXN0b21CdXR0b25UaXRsZTsKIEBw cm9wZXJ0eSAobm9uYXRvbWljLCBzdHJvbmcpIFVJVmlldyAqY3VzdG9tSW5wdXRWaWV3IFdLX0FW QUlMQUJMRShOQSwgV0tfSU9TX1RCQSk7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgY29weSkgTlNB cnJheTxVSVRleHRTdWdnZXN0aW9uICo+ICpzdWdnZXN0aW9ucyBXS19BVkFJTEFCTEUoTkEsIFdL X0lPU19UQkEpOworQHByb3BlcnR5IChub25hdG9taWMpIEJPT0wgYWNjZXNzb3J5Vmlld1Nob3Vs ZE5vdFNob3cgV0tfQVZBSUxBQkxFKE5BLCBXS19JT1NfVEJBKTsKICNlbmRpZgogCiBAZW5kCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMTk5Nzc0KQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29weSkK QEAgLTI2Myw2ICsyNjMsNyBAQAogICAgIFJldGFpblB0cjxXS0ZvY3VzZWRFbGVtZW50SW5mbz4g X2ZvY3VzZWRFbGVtZW50SW5mbzsKICAgICBSZXRhaW5QdHI8VUlWaWV3PiBfY3VzdG9tSW5wdXRW aWV3OwogICAgIFJldGFpblB0cjxOU0FycmF5PFVJVGV4dFN1Z2dlc3Rpb24gKj4+IF9zdWdnZXN0 aW9uczsKKyAgICBCT09MIF9hY2Nlc3NvcnlWaWV3U2hvdWxkTm90U2hvdzsKIH0KIAogLSAoaW5z dGFuY2V0eXBlKWluaXRXaXRoQ29udGVudFZpZXc6KFdLQ29udGVudFZpZXcgKil2aWV3IGZvY3Vz ZWRFbGVtZW50SW5mbzooV0tGb2N1c2VkRWxlbWVudEluZm8gKillbGVtZW50SW5mbyB1c2VyT2Jq ZWN0OihOU09iamVjdCA8TlNTZWN1cmVDb2Rpbmc+ICopdXNlck9iamVjdApAQCAtMzA3LDYgKzMw OCwyMCBAQAogICAgICAgICBbX2NvbnRlbnRWaWV3IHJlbG9hZElucHV0Vmlld3NdOwogfQogCist IChCT09MKWFjY2Vzc29yeVZpZXdTaG91bGROb3RTaG93Cit7CisgICAgcmV0dXJuIF9hY2Nlc3Nv cnlWaWV3U2hvdWxkTm90U2hvdzsKK30KKworLSAodm9pZClzZXRBY2Nlc3NvcnlWaWV3U2hvdWxk Tm90U2hvdzooQk9PTClhY2Nlc3NvcnlWaWV3U2hvdWxkTm90U2hvdworeworICAgIGlmIChfYWNj ZXNzb3J5Vmlld1Nob3VsZE5vdFNob3cgPT0gYWNjZXNzb3J5Vmlld1Nob3VsZE5vdFNob3cpCisg ICAgICAgIHJldHVybjsKKworICAgIF9hY2Nlc3NvcnlWaWV3U2hvdWxkTm90U2hvdyA9IGFjY2Vz c29yeVZpZXdTaG91bGROb3RTaG93OworICAgIFtfY29udGVudFZpZXcgcmVsb2FkSW5wdXRWaWV3 c107Cit9CisKIC0gKFVJVmlldyAqKWN1c3RvbUlucHV0VmlldwogewogICAgIHJldHVybiBfY3Vz dG9tSW5wdXRWaWV3LmdldCgpOwpAQCAtMTU1MCw2ICsxNTY1LDkgQEAKIAogLSAoQk9PTClyZXF1 aXJlc0FjY2Vzc29yeVZpZXcKIHsKKyAgICBpZiAoW19mb3JtSW5wdXRTZXNzaW9uIGFjY2Vzc29y eVZpZXdTaG91bGROb3RTaG93XSkKKyAgICAgICAgcmV0dXJuIE5POworCiAgICAgc3dpdGNoIChf YXNzaXN0ZWROb2RlSW5mb3JtYXRpb24uZWxlbWVudFR5cGUpIHsKICAgICBjYXNlIElucHV0VHlw ZTo6Tm9uZToKICAgICAgICAgcmV0dXJuIE5POwo=