155570 2016-03-16 17:48:05 -0700 Add a new benchmark test 2016-03-16 19:49:09 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jonlee jonlee cdumez commit-queue rniwa sabouhallawa simon.fraser oldest_to_newest 1175585 0 jonlee 2016-03-16 17:48:05 -0700 A harder version of leaves combines opacity and size. 1175586 1 274246 jonlee 2016-03-16 17:54:27 -0700 Created attachment 274246 Patch 1175593 2 274246 sabouhallawa 2016-03-16 18:13:28 -0700 Comment on attachment 274246 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274246&action=review > PerformanceTests/Animometer/tests/dom/resources/leaves.js:6 > + stage.element.appendChild(this.element); Utilities.createElement()? > PerformanceTests/Animometer/tests/dom/resources/leaves.js:21 > + this._position = new Point(Stage.random(-this.size.width, this.maxPosition.x), Stage.random(-this.size.height, this.maxPosition.y)); I am not sure why you choose the range for the position to be [-particle.size .. stage.size - particle.size]. We allow the starting point to out of the stage from one limit but not from the other. I would expect the range to be: [-particle.size .. stage.size] or [(0,0) .. stage.size - particle.size]. 1175614 3 274246 jonlee 2016-03-16 19:45:02 -0700 Comment on attachment 274246 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274246&action=review >> PerformanceTests/Animometer/tests/dom/resources/leaves.js:6 >> + stage.element.appendChild(this.element); > > Utilities.createElement()? Sure. >> PerformanceTests/Animometer/tests/dom/resources/leaves.js:21 >> + this._position = new Point(Stage.random(-this.size.width, this.maxPosition.x), Stage.random(-this.size.height, this.maxPosition.y)); > > I am not sure why you choose the range for the position to be [-particle.size .. stage.size - particle.size]. We allow the starting point to out of the stage from one limit but not from the other. I would expect the range to be: > > [-particle.size .. stage.size] or [(0,0) .. stage.size - particle.size]. You're right it should be 0,0 to stage.size - particle.size. Except in the case of the y-axis, the particles fall, so when they start they can be just above the top, so it should be -size.height. 1175616 4 jonlee 2016-03-16 19:49:09 -0700 Committed r198315: <http://trac.webkit.org/changeset/198315> 274246 2016-03-16 17:54:27 -0700 2016-03-16 17:57:43 -0700 Patch bug-155570-20160316175416.patch text/plain 6299 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4MzEwCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0FuaW1vbWV0ZXIvcmVzb3VyY2VzL2RlYnVnLXJ1bm5lci90ZXN0cy5qcyBiL1BlcmZvcm1hbmNl VGVzdHMvQW5pbW9tZXRlci9yZXNvdXJjZXMvZGVidWctcnVubmVyL3Rlc3RzLmpzCmluZGV4IDg1 OWMzMmRlYjJiYjRlZTFlNGRkNTNjM2Q3YjZjZjA4OTU3NTI0YjQuLjBkY2Q0YzI0NmQ3YjdjOTE1 YWZiODI5YmQ3NjNmYzA5ZGM4ZTE4YTAgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQW5p bW9tZXRlci9yZXNvdXJjZXMvZGVidWctcnVubmVyL3Rlc3RzLmpzCisrKyBiL1BlcmZvcm1hbmNl VGVzdHMvQW5pbW9tZXRlci9yZXNvdXJjZXMvZGVidWctcnVubmVyL3Rlc3RzLmpzCkBAIC0xNjQs NiArMTY0LDEwIEBAIFN1aXRlcy5wdXNoKG5ldyBTdWl0ZSgiSFRNTCBzdWl0ZSIsCiAgICAgICAg IHsKICAgICAgICAgICAgIHVybDogImJvdW5jaW5nLXBhcnRpY2xlcy9ib3VuY2luZy10YWdnZWQt aW1hZ2VzLmh0bWw/cGFydGljbGVXaWR0aD0xMDAmcGFydGljbGVIZWlnaHQ9MTAwIiwKICAgICAg ICAgICAgIG5hbWU6ICJDU1MgYm91bmNpbmcgdGFnZ2VkIGltYWdlcyIKKyAgICAgICAgfSwKKyAg ICAgICAgeworICAgICAgICAgICAgdXJsOiAiZG9tL2xlYXZlcy5odG1sIiwKKyAgICAgICAgICAg IG5hbWU6ICJMZWF2ZXMgMi4wIgogICAgICAgICB9CiAgICAgXQogKSk7CmRpZmYgLS1naXQgYS9Q ZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvdGVzdHMvZG9tL2xlYXZlcy5odG1sIGIvUGVyZm9y bWFuY2VUZXN0cy9Bbmltb21ldGVyL3Rlc3RzL2RvbS9sZWF2ZXMuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42 MjU4ODJlYmVmNDExYjdhNTU4MzIzZTZmOGE5NmIyM2M0NzVkYzY5Ci0tLSAvZGV2L251bGwKKysr IGIvUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVyL3Rlc3RzL2RvbS9sZWF2ZXMuaHRtbApAQCAt MCwwICsxLDI2IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+CisgICAgPG1ldGEg Y2hhcnNldD0idXRmLTgiPgorICAgIDxsaW5rIHJlbD0ic3R5bGVzaGVldCIgdHlwZT0idGV4dC9j c3MiIGhyZWY9Ii4uL3Jlc291cmNlcy9zdGFnZS5jc3MiPgorICAgIDxzdHlsZT4KKyAgICAgICAg I3N0YWdlIHsKKyAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6ICMyMzI4MkI7CisgICAgICAg IH0KKyAgICAgICAgI3N0YWdlIGltZyB7CisgICAgICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7 CisgICAgICAgIH0KKyAgICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CisgICAgPGRpdiBpZD0i c3RhZ2UiPjwvZGl2PgorICAgIDxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvc3RyaW5ncy5q cyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9leHRlbnNpb25z LmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL3N0YXRpc3Rp Y3MuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvbWF0aC5qcyI+ PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9tYWluLmpzIj48L3Njcmlw dD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vbWFzdGVyL3Jlc291cmNlcy9wYXJ0aWNsZXMuanMiPjwv c2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIuLi9tYXN0ZXIvcmVzb3VyY2VzL2xlYXZlcy5qcyI+ PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9InJlc291cmNlcy9sZWF2ZXMuanMiPjwvc2NyaXB0 PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21l dGVyL3Rlc3RzL2RvbS9yZXNvdXJjZXMvbGVhdmVzLmpzIGIvUGVyZm9ybWFuY2VUZXN0cy9Bbmlt b21ldGVyL3Rlc3RzL2RvbS9yZXNvdXJjZXMvbGVhdmVzLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjE1MDQwMGRi NmRhZDUzMjc3MmYyMjY3ZjhkMWY3ZWNhODAxYzBhNmQKLS0tIC9kZXYvbnVsbAorKysgYi9QZXJm b3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvdGVzdHMvZG9tL3Jlc291cmNlcy9sZWF2ZXMuanMKQEAg LTAsMCArMSw0OCBAQAorTGVhZiA9IFV0aWxpdGllcy5jcmVhdGVTdWJjbGFzcyhQYXJ0aWNsZSwK KyAgICBmdW5jdGlvbihzdGFnZSkKKyAgICB7CisgICAgICAgIHRoaXMuZWxlbWVudCA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoImltZyIpOworICAgICAgICB0aGlzLmVsZW1lbnQuc2V0QXR0cmli dXRlKCJzcmMiLCBzdGFnZS5pbWFnZXNbU3RhZ2UucmFuZG9tSW50KDAsIHN0YWdlLmltYWdlcy5s ZW5ndGggLSAxKV0uc3JjKTsKKyAgICAgICAgc3RhZ2UuZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlz LmVsZW1lbnQpOworCisgICAgICAgIFBhcnRpY2xlLmNhbGwodGhpcywgc3RhZ2UpOworICAgIH0s IHsKKworICAgIHNpemVNaW5pbXVtOiAyMCwKKyAgICBzaXplUmFuZ2U6IDQwLAorCisgICAgcmVz ZXQ6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIFBhcnRpY2xlLnByb3RvdHlwZS5yZXNldC5j YWxsKHRoaXMpOworICAgICAgICB0aGlzLmVsZW1lbnQuc3R5bGUud2lkdGggPSB0aGlzLnNpemUu eCArICJweCI7CisgICAgICAgIHRoaXMuZWxlbWVudC5zdHlsZS5oZWlnaHQgPSB0aGlzLnNpemUu eSArICJweCI7CisgICAgICAgIHRoaXMuX29wYWNpdHkgPSAuMDE7CisgICAgICAgIHRoaXMuX29w YWNpdHlSYXRlID0gMC4wMiAqIFN0YWdlLnJhbmRvbSgxLCA2KTsKKyAgICAgICAgdGhpcy5fcG9z aXRpb24gPSBuZXcgUG9pbnQoU3RhZ2UucmFuZG9tKC10aGlzLnNpemUud2lkdGgsIHRoaXMubWF4 UG9zaXRpb24ueCksIFN0YWdlLnJhbmRvbSgtdGhpcy5zaXplLmhlaWdodCwgdGhpcy5tYXhQb3Np dGlvbi55KSk7CisgICAgICAgIHRoaXMuX3ZlbG9jaXR5ID0gbmV3IFBvaW50KFN0YWdlLnJhbmRv bSgtNiwgLTIpLCAuMSAqIHRoaXMuc2l6ZS55ICsgU3RhZ2UucmFuZG9tKC0xLCAxKSk7CisgICAg fSwKKworICAgIGFuaW1hdGU6IGZ1bmN0aW9uKHRpbWVEZWx0YSkKKyAgICB7CisgICAgICAgIHRo aXMucm90YXRlci5uZXh0KHRpbWVEZWx0YSk7CisKKyAgICAgICAgdGhpcy5fcG9zaXRpb24ueCAr PSB0aGlzLl92ZWxvY2l0eS54ICsgOCAqIHRoaXMuc3RhZ2UuZm9jdXNYOworICAgICAgICB0aGlz Ll9wb3NpdGlvbi55ICs9IHRoaXMuX3ZlbG9jaXR5Lnk7CisgICAgICAgIHRoaXMuX29wYWNpdHkg Kz0gdGhpcy5fb3BhY2l0eVJhdGU7CisgICAgICAgIGlmICh0aGlzLl9vcGFjaXR5ID4gMSkgewor ICAgICAgICAgICAgdGhpcy5fb3BhY2l0eSA9IDE7CisgICAgICAgICAgICB0aGlzLl9vcGFjaXR5 UmF0ZSAqPSAtMTsKKyAgICAgICAgfSBlbHNlIGlmICh0aGlzLl9vcGFjaXR5IDwgMCB8fCB0aGlz Ll9wb3NpdGlvbi55ID4gdGhpcy5zdGFnZS5zaXplLnkpCisgICAgICAgICAgICB0aGlzLnJlc2V0 KCk7CisKKyAgICAgICAgaWYgKHRoaXMuX3Bvc2l0aW9uLnggPCAtdGhpcy5zaXplLndpZHRoIHx8 IHRoaXMuX3Bvc2l0aW9uLnggPiB0aGlzLm1heFBvc2l0aW9uLngpCisgICAgICAgICAgICB0aGlz Ll9wb3NpdGlvbi54ID0gKHRoaXMuX3Bvc2l0aW9uLnggKyB0aGlzLm1heFBvc2l0aW9uLngpICUg dGhpcy5tYXhQb3NpdGlvbi54OworICAgICAgICB0aGlzLm1vdmUoKTsKKyAgICB9LAorCisgICAg bW92ZTogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgdGhpcy5lbGVtZW50LnN0eWxlLnRyYW5z Zm9ybSA9ICJ0cmFuc2xhdGUoIiArIHRoaXMuX3Bvc2l0aW9uLnggKyAicHgsICIgKyB0aGlzLl9w b3NpdGlvbi55ICsgInB4KSIgKyB0aGlzLnJvdGF0ZXIucm90YXRlWigpOworICAgICAgICB0aGlz LmVsZW1lbnQuc3R5bGUub3BhY2l0eSA9IHRoaXMuX29wYWNpdHk7CisgICAgfQorfSk7CmRpZmYg LS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvdGVzdHMvbWFzdGVyL3Jlc291cmNl cy9sZWF2ZXMuanMgYi9QZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvdGVzdHMvbWFzdGVyL3Jl c291cmNlcy9sZWF2ZXMuanMKaW5kZXggNTJkNDgxMTcxYThmMzAxOGE5ZWE2ZjJjYmE1ZDQ1OWQw OWUwMGE1ZS4uMmJlZjk1OTE2MzgzNTA4Y2UzOTVhZTFlMzhjMzQwODU0MGFjNmZjMCAxMDA2NDQK LS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVyL3Rlc3RzL21hc3Rlci9yZXNvdXJjZXMv bGVhdmVzLmpzCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci90ZXN0cy9tYXN0ZXIv cmVzb3VyY2VzL2xlYXZlcy5qcwpAQCAtMSw1ICsxLDMgQEAKLShmdW5jdGlvbigpIHsKLQogTGVh ZiA9IFV0aWxpdGllcy5jcmVhdGVTdWJjbGFzcyhQYXJ0aWNsZSwKICAgICBmdW5jdGlvbihzdGFn ZSkKICAgICB7CkBAIC03Miw3ICs3MCw3IEBAIFV0aWxpdGllcy5leHRlbmRPYmplY3QoUGFydGlj bGVzU3RhZ2UucHJvdG90eXBlLCB7CiAgICAgICAgIHZhciBsYXN0UHJvbWlzZTsKICAgICAgICAg dmFyIGltYWdlcyA9IHRoaXMuaW1hZ2VzOwogICAgICAgICB0aGlzLmltYWdlU3Jjcy5mb3JFYWNo KGZ1bmN0aW9uKGltYWdlU3JjKSB7Ci0gICAgICAgICAgICB2YXIgcHJvbWlzZSA9IHRoaXMuX2xv YWRJbWFnZSgicmVzb3VyY2VzLyIgKyBpbWFnZVNyYyArICIxMDAucG5nIik7CisgICAgICAgICAg ICB2YXIgcHJvbWlzZSA9IHRoaXMuX2xvYWRJbWFnZSgiLi4vbWFzdGVyL3Jlc291cmNlcy8iICsg aW1hZ2VTcmMgKyAiMTAwLnBuZyIpOwogICAgICAgICAgICAgaWYgKCFsYXN0UHJvbWlzZSkKICAg ICAgICAgICAgICAgICBsYXN0UHJvbWlzZSA9IHByb21pc2U7CiAgICAgICAgICAgICBlbHNlIHsK QEAgLTEzNSw1ICsxMzMsMyBAQCBMZWF2ZXNCZW5jaG1hcmsgPSBVdGlsaXRpZXMuY3JlYXRlU3Vi Y2xhc3MoQmVuY2htYXJrLAogfSk7CiAKIHdpbmRvdy5iZW5jaG1hcmtDbGFzcyA9IExlYXZlc0Jl bmNobWFyazsKLQotfSkoKTsKZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9n IGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWVlNGY0NGIwOWQyYjc0NDUyZjZj YmJlYTNiOTQxMmYyZWJkM2ZmZi4uMDczMjYwMDdmMjJiMThhZmFjMTgwMTlkOWFkNGU0NzI3Mjlj MzEwMyAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKKysrIGIvUGVyZm9y bWFuY2VUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxNi0wMy0xNiAgSm9uIExl ZSAgPGpvbmxlZUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgbmV3IGJlbmNobWFyayB0ZXN0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU1NzAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZXcgTGVh dmVzIHRlc3QgaW5jbHVkZXMgdmFyaW91cyBpbWFnZSBzaXplcyBhbmQgb3BhY2l0eS4KKworICAg ICAgICAqIEFuaW1vbWV0ZXIvcmVzb3VyY2VzL2RlYnVnLXJ1bm5lci90ZXN0cy5qczogQWRkIGl0 IHRvIHRoZSBIVE1MIHRlc3Qgc3VpdGUuCisgICAgICAgICogQW5pbW9tZXRlci90ZXN0cy9kb20v bGVhdmVzLmh0bWw6IEFkZGVkLgorICAgICAgICAqIEFuaW1vbWV0ZXIvdGVzdHMvZG9tL3Jlc291 cmNlcy9sZWF2ZXMuanM6IEFkZGVkLiBPdmVycmlkZSB0aGUKKyAgICAgICAgKFBhcnRpY2xlLmNh bGwucmVzZXQpOiBVc2VzIGEgcmFuZ2Ugb2Ygc2l6ZXMsIGFuZCBvcGFjaXR5LgorICAgICAgICAo UGFydGljbGUuY2FsbC5hbmltYXRlKTogT3BhY2l0eSBnb2VzIHVwIHRoZW4gZG93bi4gV2hlbiBp dCBoaXRzIDAsIHJlc2V0IHRoZSBwYXJ0aWNsZS4KKyAgICAgICAgKFBhcnRpY2xlLmNhbGwubW92 ZSk6IFNldCB0cmFuc2Zvcm0gYW5kIG9wYWNpdHkuCisgICAgICAgICogQW5pbW9tZXRlci90ZXN0 cy9tYXN0ZXIvcmVzb3VyY2VzL2xlYXZlcy5qczogR2V0IHJpZCBvZiB0aGUgY2xvc3VyZSBzbyB0 aGF0IGl0CisgICAgICAgIGNhbiBiZSB1c2VkIGluIHRoaXMgdGVzdC4gVXBkYXRlIHRoZSByZWxh dGl2ZSBwYXRoIHNvIHRoYXQgaXQgd29ya3MgaW4gYm90aCB0aGUgbWFzdGVyCisgICAgICAgIGFu ZCBkb20gdGVzdCBzdWl0ZS4KKwogMjAxNi0wMy0xNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgZGV2ZWxvcGVyIEFuaW1vbWV0ZXIgdGVzdCB0 aGF0IGJvdW5jZXMgUDMtdGFnZ2VkIGltYWdlcwo=