155550 2016-03-16 11:26:06 -0700 REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank 2016-03-16 13:16:50 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca commit-queue mitz sam simon.fraser oldest_to_newest 1175407 0 thorton 2016-03-16 11:26:06 -0700 Need to keep _setDrawsTransparentBackground: around and working for now 1175412 1 274201 thorton 2016-03-16 11:33:19 -0700 Created attachment 274201 Patch 1175413 2 274201 mitz 2016-03-16 11:35:14 -0700 Comment on attachment 274201 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review > Source/WebKit2/ChangeLog:3 > + Need to keep _setDrawsTransparentBackground: around and working for now A better title here would be “REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank” 1175415 3 274201 mitz 2016-03-16 11:36:12 -0700 Comment on attachment 274201 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4188 > + static bool hasLoggedDeprecationWarning; Strange mix of C bool… > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4191 > + hasLoggedDeprecationWarning = YES; …with Objective-C YES. 1175417 4 274201 thorton 2016-03-16 11:37:59 -0700 Comment on attachment 274201 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review >> Source/WebKit2/ChangeLog:3 >> + Need to keep _setDrawsTransparentBackground: around and working for now > > A better title here would be “REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank” OK! >> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4191 >> + hasLoggedDeprecationWarning = YES; > > …with Objective-C YES. Fair! 1175420 5 274202 thorton 2016-03-16 11:40:45 -0700 Created attachment 274202 Patch 1175422 6 274202 mitz 2016-03-16 11:42:31 -0700 Comment on attachment 274202 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274202&action=review > Source/WebKit2/ChangeLog:8 > + Might be useful to explain here how this fixes the bug. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4188 > + static BOOL hasLoggedDeprecationWarning; Would be good to have a comment referencing this bug here so that people can easily answer the question why this is here and whether it’s OK to remove it. 1175437 7 274207 thorton 2016-03-16 12:15:07 -0700 Created attachment 274207 Patch 1175466 8 274207 commit-queue 2016-03-16 13:16:46 -0700 Comment on attachment 274207 Patch Clearing flags on attachment: 274207 Committed r198298: <http://trac.webkit.org/changeset/198298> 1175467 9 commit-queue 2016-03-16 13:16:50 -0700 All reviewed patches have been landed. Closing bug. 274201 2016-03-16 11:33:19 -0700 2016-03-16 11:40:41 -0700 Patch bug-155550-20160316113308.patch text/plain 1752 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4Mjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODY3Yjc1Y2JhMDM1OTZh MjI5YmNiYzkxZjRkM2NiZTYwYmY2NDkxYy4uMDZlNjI2NTIzODMzNjhlM2Q5NWYzYWY3NDZjNTIx NTg2NmI4Mjc0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAzLTE2ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIE5lZWQgdG8ga2Vl cCBfc2V0RHJhd3NUcmFuc3BhcmVudEJhY2tncm91bmQ6IGFyb3VuZCBhbmQgd29ya2luZyBmb3Ig bm93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU1 NTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0MjUwNjg5PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dl YlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmlldyBfc2V0RHJhd3NUcmFuc3BhcmVudEJhY2tn cm91bmQ6XSk6CisgICAgICAgIExvZyBvbmNlIHRoYXQgdGhpcyBpcyBkZXByZWNhdGVkICguLi4g aXQncyBhbHNvIFNQSSkgYW5kIHRoZW4gZm9yd2FyZCB0byBzZXREcmF3c0JhY2tncm91bmQuCisK IDIwMTYtMDMtMTYgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxOTY4MDMuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IGY0ZmMwZDIzYTYyZTE4 OTc1ODc3NDI5MGM1NTVmODAwZTVhMmNhMmIuLjc2MDI2M2U0ZmQzMzAwNGRjZGQxNTY1YWVhZDFl ZTAxM2U5ODIwZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Lm1tCkBAIC00MTgzLDYgKzQxODMsMTYgQEAgc3RhdGljIGlubGluZSBXZWJLaXQ6 OkZpbmRPcHRpb25zIHRvRmluZE9wdGlvbnMoX1dLRmluZE9wdGlvbnMgd2tGaW5kT3B0aW9ucykK ICAgICBfaW1wbC0+c2V0RHJhd3NCYWNrZ3JvdW5kKGRyYXdzQmFja2dyb3VuZCk7CiB9CiAKKy0g KHZvaWQpX3NldERyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kOihCT09MKWRyYXdzVHJhbnNwYXJl bnRCYWNrZ3JvdW5kCit7CisgICAgc3RhdGljIGJvb2wgaGFzTG9nZ2VkRGVwcmVjYXRpb25XYXJu aW5nOworICAgIGlmICghaGFzTG9nZ2VkRGVwcmVjYXRpb25XYXJuaW5nKSB7CisgICAgICAgIE5T TG9nKEAiLVtXS1dlYlZpZXcgX3NldERyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kOl0gaXMgZGVw cmVjYXRlZCBhbmQgc2hvdWxkIG5vdCBiZSB1c2VkLiIpOworICAgICAgICBoYXNMb2dnZWREZXBy ZWNhdGlvbldhcm5pbmcgPSBZRVM7CisgICAgfQorICAgIFtzZWxmIF9zZXREcmF3c0JhY2tncm91 bmQ6IWRyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kXTsKK30KKwogI2lmIFdLX0FQSV9FTkFCTEVE CiAtIChOU1ZpZXcgKilfaW5zcGVjdG9yQXR0YWNobWVudFZpZXcKIHsK 274202 2016-03-16 11:40:45 -0700 2016-03-16 12:15:03 -0700 Patch bug-155550-20160316114034.patch text/plain 1744 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4Mjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODY3Yjc1Y2JhMDM1OTZh MjI5YmNiYzkxZjRkM2NiZTYwYmY2NDkxYy4uMmE3NjJhYTI5NTJlY2FkYzE2ZTA5ZGUwYjEyZWZl NjgyNDdiNjNhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAzLTE2ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIxOTIxODQpOiBDbGVhbk15RHJpdmUgMidzIHR1dG9yaWFsIHdpbmRvdyBpcyBibGFuaworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NTUwCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8yNDI1MDY4OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1t OgorICAgICAgICAoLVtXS1dlYlZpZXcgX3NldERyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kOl0p OgorICAgICAgICBMb2cgb25jZSB0aGF0IHRoaXMgaXMgZGVwcmVjYXRlZCAoLi4uIGl0J3MgYWxz byBTUEkpIGFuZCB0aGVuIGZvcndhcmQgdG8gc2V0RHJhd3NCYWNrZ3JvdW5kLgorCiAyMDE2LTAz LTE2ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByMTk2ODAzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQppbmRleCBmNGZjMGQyM2E2MmUxODk3NTg3NzQy OTBjNTU1ZjgwMGU1YTJjYTJiLi5jNzJjZjNkNzYyNDVjNGU2M2I1YjhmMzQ3NmNlYTJhMDYyZjNh MGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5tbQpAQCAtNDE4Myw2ICs0MTgzLDE2IEBAIHN0YXRpYyBpbmxpbmUgV2ViS2l0OjpGaW5kT3B0 aW9ucyB0b0ZpbmRPcHRpb25zKF9XS0ZpbmRPcHRpb25zIHdrRmluZE9wdGlvbnMpCiAgICAgX2lt cGwtPnNldERyYXdzQmFja2dyb3VuZChkcmF3c0JhY2tncm91bmQpOwogfQogCistICh2b2lkKV9z ZXREcmF3c1RyYW5zcGFyZW50QmFja2dyb3VuZDooQk9PTClkcmF3c1RyYW5zcGFyZW50QmFja2dy b3VuZAoreworICAgIHN0YXRpYyBCT09MIGhhc0xvZ2dlZERlcHJlY2F0aW9uV2FybmluZzsKKyAg ICBpZiAoIWhhc0xvZ2dlZERlcHJlY2F0aW9uV2FybmluZykgeworICAgICAgICBOU0xvZyhAIi1b V0tXZWJWaWV3IF9zZXREcmF3c1RyYW5zcGFyZW50QmFja2dyb3VuZDpdIGlzIGRlcHJlY2F0ZWQg YW5kIHNob3VsZCBub3QgYmUgdXNlZC4iKTsKKyAgICAgICAgaGFzTG9nZ2VkRGVwcmVjYXRpb25X YXJuaW5nID0gWUVTOworICAgIH0KKyAgICBbc2VsZiBfc2V0RHJhd3NCYWNrZ3JvdW5kOiFkcmF3 c1RyYW5zcGFyZW50QmFja2dyb3VuZF07Cit9CisKICNpZiBXS19BUElfRU5BQkxFRAogLSAoTlNW aWV3ICopX2luc3BlY3RvckF0dGFjaG1lbnRWaWV3CiB7Cg== 274207 2016-03-16 12:15:07 -0700 2016-03-16 13:16:46 -0700 Patch bug-155550-20160316121456.patch text/plain 1955 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4Mjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODY3Yjc1Y2JhMDM1OTZh MjI5YmNiYzkxZjRkM2NiZTYwYmY2NDkxYy4uOTFlZjhlMzc4YTJhZDBmOWM1ZGMxZDQ0ZDExOThl ZmNhMDNkZTAwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAzLTE2ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIxOTIxODQpOiBDbGVhbk15RHJpdmUgMidzIHR1dG9yaWFsIHdpbmRvdyBpcyBibGFuaworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NTUwCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8yNDI1MDY4OT4KKworICAgICAgICBSZXZpZXdlZCBieSBEYW4g QmVybnN0ZWluLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06 CisgICAgICAgICgtW1dLV2ViVmlldyBfc2V0RHJhd3NUcmFuc3BhcmVudEJhY2tncm91bmQ6XSk6 CisgICAgICAgIFRoZSBhcHAgaXMgdXNpbmcgdGhpcyBTUEkgdmlhIGtleS12YWx1ZSBjb2Rpbmcs IHNvIGp1c3Qga2VlcGluZyB0aGUgaW1wbGVtZW50YXRpb24KKyAgICAgICAgaXMgc3VmZmljaWVu dCB0byBtYWtlIEFwcEtpdCBzdG9wIHRocm93aW5nIGFuIHVuZGVmaW5lZCBrZXkgZXhjZXB0aW9u LgorICAgICAgICBMb2cgb25jZSB0aGF0IHRoaXMgaXMgZGVwcmVjYXRlZCAoLi4uIGl0J3MgYWxz byBTUEkpIGFuZCB0aGVuIGZvcndhcmQgdG8gc2V0RHJhd3NCYWNrZ3JvdW5kLgorCiAyMDE2LTAz LTE2ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByMTk2ODAzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQppbmRleCBmNGZjMGQyM2E2MmUxODk3NTg3NzQy OTBjNTU1ZjgwMGU1YTJjYTJiLi41M2UwZjMwNmRjZDIzMGQyOGRhNWYxZTcwMjI5ODgwNzI2NWJk NmM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5tbQpAQCAtNDE4Myw2ICs0MTgzLDE3IEBAIHN0YXRpYyBpbmxpbmUgV2ViS2l0OjpGaW5kT3B0 aW9ucyB0b0ZpbmRPcHRpb25zKF9XS0ZpbmRPcHRpb25zIHdrRmluZE9wdGlvbnMpCiAgICAgX2lt cGwtPnNldERyYXdzQmFja2dyb3VuZChkcmF3c0JhY2tncm91bmQpOwogfQogCistICh2b2lkKV9z ZXREcmF3c1RyYW5zcGFyZW50QmFja2dyb3VuZDooQk9PTClkcmF3c1RyYW5zcGFyZW50QmFja2dy b3VuZAoreworICAgIHN0YXRpYyBCT09MIGhhc0xvZ2dlZERlcHJlY2F0aW9uV2FybmluZzsKKyAg ICBpZiAoIWhhc0xvZ2dlZERlcHJlY2F0aW9uV2FybmluZykgeworICAgICAgICAvLyBTZWUgYnVn IDE1NTU1MCBmb3IgZGV0YWlscy4KKyAgICAgICAgTlNMb2coQCItW1dLV2ViVmlldyBfc2V0RHJh d3NUcmFuc3BhcmVudEJhY2tncm91bmQ6XSBpcyBkZXByZWNhdGVkIGFuZCBzaG91bGQgbm90IGJl IHVzZWQuIik7CisgICAgICAgIGhhc0xvZ2dlZERlcHJlY2F0aW9uV2FybmluZyA9IFlFUzsKKyAg ICB9CisgICAgW3NlbGYgX3NldERyYXdzQmFja2dyb3VuZDohZHJhd3NUcmFuc3BhcmVudEJhY2tn cm91bmRdOworfQorCiAjaWYgV0tfQVBJX0VOQUJMRUQKIC0gKE5TVmlldyAqKV9pbnNwZWN0b3JB dHRhY2htZW50Vmlldwogewo=