155543 2016-03-16 08:50:54 -0700 [mac] Printing test snapshots are upside-down after r198242 2016-03-16 14:31:08 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton ap commit-queue lforschler ryanhaddad simon.fraser oldest_to_newest 1175358 0 thorton 2016-03-16 08:50:54 -0700 Printing seems to use software snapshotting, and is for some reason flipped (meaning I must have missed a hisorical step in r198242's changelog. Here are the failing tests: Regressions: Unexpected image-only failures (3) printing/quirks-percentage-height-body.html [ ImageOnlyFailure ] printing/quirks-percentage-height.html [ ImageOnlyFailure ] printing/standards-percentage-heights.html [ ImageOnlyFailure ] 1175360 1 thorton 2016-03-16 08:56:09 -0700 When these tests were added (r141459), we were in the same state we are in today (no flipping in WKTR). Something must have regressed elsewhere in the meantime, or something. 1175361 2 thorton 2016-03-16 08:59:10 -0700 http://trac.webkit.org/changeset/190306 looks highly suspicious to me. 1175363 3 thorton 2016-03-16 09:02:56 -0700 > When these tests were added (r141459), we were in the same state we are in today (no flipping in WKTR). Something must have regressed elsewhere in the meantime, or something. ACTUALLY, when these tests were added they were immediately skipped in Mac WebKit2 and then not unskipped until r190306 (by which time the WKTR flipping logic had been broken, and they were only passing because of that). 1175376 4 ryanhaddad 2016-03-16 09:58:35 -0700 I have temporarily skipped these tests in <http://trac.webkit.org/projects/webkit/changeset/198285> 1175478 5 274217 thorton 2016-03-16 13:35:33 -0700 Created attachment 274217 Patch 1175500 6 274217 commit-queue 2016-03-16 14:31:04 -0700 Comment on attachment 274217 Patch Clearing flags on attachment: 274217 Committed r198302: <http://trac.webkit.org/changeset/198302> 1175501 7 commit-queue 2016-03-16 14:31:08 -0700 All reviewed patches have been landed. Closing bug. 274217 2016-03-16 13:35:33 -0700 2016-03-16 14:31:04 -0700 Patch bug-155543-20160316133522.patch text/plain 4907 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4Mjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGI0YzljZWU4Nzk3NTEw OGNjNzczZWQxYTAwZmVkN2UzNDM2ZjI5YS4uMWI5N2U4YTBkNDYzNDQyZWY5YTE4NmRlYTE2YTUx NjUyNjBjZmZjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAzLTE2ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNdIFByaW50 aW5nIHRlc3Qgc25hcHNob3RzIGFyZSB1cHNpZGUtZG93biBhZnRlciByMTk4MjQyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU1NDMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvUHJpbnRDb250 ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlByaW50Q29udGV4dDo6c3Bvb2xBbGxQYWdlc1dp dGhCb3VuZGFyaWVzKToKKyAgICAgICAgU3RvcCBQTEFURk9STShDT0NPQSktY29uZGl0aW9uYWxs eSBmbGlwcGluZyBoZXJlLiBKdXN0IHBhaW50LgorICAgICAgICBUaGlzIGZ1bmN0aW9uIGlzIG9u bHkgdXNlZCBieSB0aGUgdGVzdCBydW5uZXJzIHNvIHRoaXMgZG9lc24ndCBoYXZlIGEKKyAgICAg ICAgaHVnZSBpbXBhY3Qgb24gYW55dGhpbmcgZWxzZS4KKwogMjAxNi0wMy0xNiAgQW50dGkgS29p dmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRG9uJ3QgaW52YWxpZGF0ZSBzdHls ZSB1bm5lY2Vzc2FyaWx5IHdoZW4gc2V0dGluZyBpbmxpbmUgc3R5bGUgY3NzVGV4dApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QcmludENvbnRleHQuY3BwIGIvU291cmNlL1dlYkNv cmUvcGFnZS9QcmludENvbnRleHQuY3BwCmluZGV4IDAzNDY4OWFjYjdmOTA5MWQ5MDM3MWQ3MzBk ZjkxOWIxNzY0ZGRkZWYuLjk2MTQ1NjQwOWRmN2Y1NWVmMzRkMjc5MDc0NzI3ZTI5MTg4OGYwYzkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUHJpbnRDb250ZXh0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL1ByaW50Q29udGV4dC5jcHAKQEAgLTM0MSwxMCArMzQxLDYgQEAg dm9pZCBQcmludENvbnRleHQ6OnNwb29sQWxsUGFnZXNXaXRoQm91bmRhcmllcyhGcmFtZSYgZnJh bWUsIEdyYXBoaWNzQ29udGV4dCYgZ3IKICAgICBncmFwaGljc0NvbnRleHQuZmlsbFJlY3QoRmxv YXRSZWN0KDAsIDAsIHBhZ2VXaWR0aCwgdG90YWxIZWlnaHQpKTsKIAogICAgIGdyYXBoaWNzQ29u dGV4dC5zYXZlKCk7Ci0jaWYgUExBVEZPUk0oQ09DT0EpCi0gICAgZ3JhcGhpY3NDb250ZXh0LnRy YW5zbGF0ZSgwLCB0b3RhbEhlaWdodCk7Ci0gICAgZ3JhcGhpY3NDb250ZXh0LnNjYWxlKEZsb2F0 U2l6ZSgxLCAtMSkpOwotI2VuZGlmCiAKICAgICBpbnQgY3VycmVudEhlaWdodCA9IDA7CiAgICAg Zm9yIChzaXplX3QgcGFnZUluZGV4ID0gMDsgcGFnZUluZGV4IDwgcGFnZVJlY3RzLnNpemUoKTsg cGFnZUluZGV4KyspIHsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n ZUxvZwppbmRleCA0MDFiM2NiNDFhYmQxYzI5ZTk0YzdkODFlYWQ3NTI0MzJkNTU5NTMzLi5mYTVh M2ZmNTE1NjIwODAxMTQzYjc4MGQzNDA5OWNjZTY1NTU2ZGQxIDEwMDY0NAotLS0gYS9Ub29scy9D aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDMt MTYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW21h Y10gUHJpbnRpbmcgdGVzdCBzbmFwc2hvdHMgYXJlIHVwc2lkZS1kb3duIGFmdGVyIHIxOTgyNDIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTU0Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvbWFjL1BpeGVsRHVtcFN1cHBvcnRNYWMubW06CisgICAgICAgIChjcmVhdGVQYWdl ZEJpdG1hcENvbnRleHQpOgorICAgICAgICBGbGlwIHByaW50aW5nIHNuYXBzaG90cyBpbiBEUlQg c28gdGhhdCBldmVyeXRoaW5nIGlzIHJpZ2h0LXNpZGUtdXAuCisKIDIwMTYtMDMtMTUgIFRpbSBI b3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPUyBTaW11bGF0 b3JdIFRlc3QgcmVzdWx0IHNuYXBzaG90cyBhcmUgdXBzaWRlIGRvd24KZGlmZiAtLWdpdCBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL21hYy9QaXhlbER1bXBTdXBwb3J0TWFjLm1tIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvbWFjL1BpeGVsRHVtcFN1cHBvcnRNYWMubW0KaW5kZXggYjc4ODE0ZTA2NmUx ODhkYTEzZWRjYzBlNmM3OGIzNGE4MDdhYzI5ZC4uZTMzMzRlZmU1MzI5MGMzZGRkYzVmNWFlYTU0 ODg3MWE3NmRmYWJmMSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL1BpeGVs RHVtcFN1cHBvcnRNYWMubW0KKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL1BpeGVsRHVt cFN1cHBvcnRNYWMubW0KQEAgLTIwNSw3ICsyMDUsMTIgQEAgUGFzc1JlZlB0cjxCaXRtYXBDb250 ZXh0PiBjcmVhdGVQYWdlZEJpdG1hcENvbnRleHQoKQogICAgIHNpemVfdCByb3dCeXRlcyA9IDA7 CiAgICAgdm9pZCogYnVmZmVyID0gMDsKIAotICAgIFJlZlB0cjxCaXRtYXBDb250ZXh0PiBiaXRt YXBDb250ZXh0ID0gY3JlYXRlQml0bWFwQ29udGV4dChwYWdlV2lkdGhJblBpeGVscywgbnVtYmVy T2ZQYWdlcyAqIChwYWdlSGVpZ2h0SW5QaXhlbHMgKyAxKSAtIDEsIHJvd0J5dGVzLCBidWZmZXIp OwotICAgIFttYWluRnJhbWUgcHJpbnRUb0NHQ29udGV4dDpiaXRtYXBDb250ZXh0LT5jZ0NvbnRl eHQoKSBwYWdlV2lkdGg6cGFnZVdpZHRoSW5QaXhlbHMgcGFnZUhlaWdodDpwYWdlSGVpZ2h0SW5Q aXhlbHNdOworICAgIGludCB0b3RhbEhlaWdodCA9IG51bWJlck9mUGFnZXMgKiAocGFnZUhlaWdo dEluUGl4ZWxzICsgMSkgLSAxOworCisgICAgUmVmUHRyPEJpdG1hcENvbnRleHQ+IGJpdG1hcENv bnRleHQgPSBjcmVhdGVCaXRtYXBDb250ZXh0KHBhZ2VXaWR0aEluUGl4ZWxzLCB0b3RhbEhlaWdo dCwgcm93Qnl0ZXMsIGJ1ZmZlcik7CisgICAgQ0dDb250ZXh0UmVmIGNvbnRleHQgPSBiaXRtYXBD b250ZXh0LT5jZ0NvbnRleHQoKTsKKyAgICBDR0NvbnRleHRUcmFuc2xhdGVDVE0oY29udGV4dCwg MCwgdG90YWxIZWlnaHQpOworICAgIENHQ29udGV4dFNjYWxlQ1RNKGNvbnRleHQsIDEsIC0xKTsK KyAgICBbbWFpbkZyYW1lIHByaW50VG9DR0NvbnRleHQ6Y29udGV4dCBwYWdlV2lkdGg6cGFnZVdp ZHRoSW5QaXhlbHMgcGFnZUhlaWdodDpwYWdlSGVpZ2h0SW5QaXhlbHNdOwogICAgIHJldHVybiBi aXRtYXBDb250ZXh0LnJlbGVhc2UoKTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkMjBhM2Q3YWVmOTllZjg3ODVlNWY3 NGUwMjRjZWE4ODU3N2JjNWNjLi42NGMxMTE1OGJmNWJhOTA5NGMzMjRlMTFlNTNkZGU0N2ZjYzVk MTMwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDMtMTYgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY10gUHJpbnRpbmcgdGVzdCBzbmFw c2hvdHMgYXJlIHVwc2lkZS1kb3duIGFmdGVyIHIxOTgyNDIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTU0MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAg UmUtdW4tc2tpcCB0aGVzZSB0ZXN0cy4KKwogMjAxNi0wMy0xNiAgUnlhbiBIYWRkYWQgIDxyeWFu aGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBNYXJraW5nIGltcG9ydGVkL2JsaW5rL2Zhc3Qv bXVsdGljb2wvZHluYW1pYy9yZWxheW91dC1hYnNwb3MtaW4tcmVscG9zLXNwYW5uZXIuaHRtbCBh cyBmbGFreSBvbiBpb3Mtc2ltCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRp b25zIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBmMmM2ZDM0M2VhM2Y3YTQx NTBmYmRlMjVkNzcyNTMzMDc3YWJjNGNhLi45N2NhYzYzNThlZTlhNTc2MjJiYTViNjk2NmYzOTg2 MmUyN2Q2NjRlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCisrKyBi L0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTg5NywxMCArODk3LDYgQEAgZmFzdC9t dWx0aWNvbC9tdWx0aWNvbC13aXRoLWNoaWxkLXJlbmRlckxheWVyLWZvci1pbnB1dC5odG1sIFsg SW1hZ2VPbmx5RmFpbHVyZQogCiB3ZWJraXQub3JnL2IvOTQ0NTggaHR0cC90ZXN0cy9zZWN1cml0 eS9hYm91dEJsYW5rL3NlY3VyaXR5LWNvbnRleHQtd3JpdGUuaHRtbCBbIFNraXAgXQogCi13ZWJr aXQub3JnL2IvMTU1NTQzIHByaW50aW5nL3F1aXJrcy1wZXJjZW50YWdlLWhlaWdodC1ib2R5Lmh0 bWwgWyBTa2lwIF0KLXdlYmtpdC5vcmcvYi8xNTU1NDMgcHJpbnRpbmcvcXVpcmtzLXBlcmNlbnRh Z2UtaGVpZ2h0Lmh0bWwgWyBTa2lwIF0KLXdlYmtpdC5vcmcvYi8xNTU1NDMgcHJpbnRpbmcvc3Rh bmRhcmRzLXBlcmNlbnRhZ2UtaGVpZ2h0cy5odG1sIFsgU2tpcCBdCi0KICMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMKICMjIyBTVEFSVCBPRiBJbmRleGVkREIgZmFpbHVy ZXMKIAo=