155519 2016-03-15 16:25:58 -0700 Follow up to r195769 2016-03-15 17:02:04 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica sam thorton oldest_to_newest 1175181 0 enrica 2016-03-15 16:25:58 -0700 For some types of data detector links we choose not to perform the default action. Therefore we don't generate a synthetic click on tap. There are to code paths that lead to calling handleSyntheticClick that need to be guarded with this logic. Only one was covered in r195769. rdar://problem/25146483 1175183 1 274152 enrica 2016-03-15 16:33:21 -0700 Created attachment 274152 Patch 1175187 2 274152 thorton 2016-03-15 16:44:43 -0700 Comment on attachment 274152 Patch Is this testable? 1175197 3 enrica 2016-03-15 16:57:24 -0700 (In reply to comment #2) > Comment on attachment 274152 [details] > Patch > > Is this testable? I wouldn't know how. The two code paths are triggered depending on the duration of the tap vs touch. 1175203 4 enrica 2016-03-15 17:02:04 -0700 Committed revision 198245. 274152 2016-03-15 16:33:21 -0700 2016-03-15 16:44:43 -0700 Patch dd-default-action.txt text/plain 2385 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODI0MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE2LTAzLTE1ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgRm9sbG93IHVwIHRvIHIxOTU3 NjkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU1 MTkKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjUxNDY0ODMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBhcmUgdHdvIGNvZGUgcGF0aHMgdGhh dCBsZWFkIHRvIGNhbGxpbmcgaGFuZGxlU3ludGhldGljQ2xpY2soKQorICAgICAgICB3aGVyZSB3 ZSBuZWVkIHRvIGNoZWNrIGlmIHRoZSBkZWZhdWx0IGFjdGlvbiBjYW4gYmUgcGVyZm9ybWVkIG9u IHRoZQorICAgICAgICBkYXRhIGRldGVjdG9yIGxpbmsuCisgICAgICAgIE9ubHkgb25lIHdhcyBj b3ZlcmVkIGluIHIxOTU3NjkgYW5kIHRoaXMgcGF0Y2ggYWRkcmVzc2VzIHRoZSBtaXNzaW5nIG9u ZS4KKyAgICAgICAgSSd2ZSBhbHNvIGRpc2NvdmVyZWQgdGhhdCB0aGUgcG9pbnQgcmVwb3J0ZWQg aW4gRGlkTm90SGFuZGxlVGFwQXNDbGljayB3YXMKKyAgICAgICAgaW5jb3JyZWN0bHkgYWx3YXlz ICgwLCAwKSBhbmQgSSd2ZSBmaXhlZCBpdC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6aGFuZGxlVGFw KToKKwogMjAxNi0wMy0xNSAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTk4MjMwLgpJbmRleDogU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkocmV2 aXNpb24gMTk4MjQxKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9X ZWJQYWdlSU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01OTUsMTAgKzU5NSwxNCBAQCB2b2lkIFdl YlBhZ2U6OmhhbmRsZVRhcChjb25zdCBJbnRQb2ludCYgCiAgICAgRmxvYXRQb2ludCBhZGp1c3Rl ZFBvaW50OwogICAgIE5vZGUqIG5vZGVSZXNwb25kaW5nVG9DbGljayA9IG1fcGFnZS0+bWFpbkZy YW1lKCkubm9kZVJlc3BvbmRpbmdUb0NsaWNrRXZlbnRzKHBvaW50LCBhZGp1c3RlZFBvaW50KTsK ICAgICBGcmFtZSogZnJhbWVSZXNwb25kaW5nVG9DbGljayA9IG5vZGVSZXNwb25kaW5nVG9DbGlj ayA/IG5vZGVSZXNwb25kaW5nVG9DbGljay0+ZG9jdW1lbnQoKS5mcmFtZSgpIDogbnVsbHB0cjsK KyAgICBJbnRQb2ludCBhZGp1c3RlZEludFBvaW50ID0gcm91bmRlZEludFBvaW50KGFkanVzdGVk UG9pbnQpOwogCiAgICAgaWYgKCFmcmFtZVJlc3BvbmRpbmdUb0NsaWNrIHx8IGxhc3RMYXllclRy ZWVUcmFuc2FjdGlvbklkIDwgV2ViRnJhbWU6OmZyb21Db3JlRnJhbWUoKmZyYW1lUmVzcG9uZGlu Z1RvQ2xpY2spLT5maXJzdExheWVyVHJlZVRyYW5zYWN0aW9uSURBZnRlckRpZENvbW1pdExvYWQo KSkKLSAgICAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpEaWROb3RIYW5kbGVUYXBB c0NsaWNrKHJvdW5kZWRJbnRQb2ludChtX3BvdGVudGlhbFRhcExvY2F0aW9uKSkpOwotICAgIGVs c2UKKyAgICAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpEaWROb3RIYW5kbGVUYXBB c0NsaWNrKGFkanVzdGVkSW50UG9pbnQpKTsKKyAgICBlbHNlIGlmIChpczxFbGVtZW50Pigqbm9k ZVJlc3BvbmRpbmdUb0NsaWNrKSAmJiBEYXRhRGV0ZWN0aW9uOjpzaG91bGRDYW5jZWxEZWZhdWx0 QWN0aW9uKCZkb3duY2FzdDxFbGVtZW50Pigqbm9kZVJlc3BvbmRpbmdUb0NsaWNrKSkpIHsKKyAg ICAgICAgcmVxdWVzdFBvc2l0aW9uSW5mb3JtYXRpb24oYWRqdXN0ZWRJbnRQb2ludCk7CisgICAg ICAgIHNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6RGlkTm90SGFuZGxlVGFwQXNDbGljayhh ZGp1c3RlZEludFBvaW50KSk7CisgICAgfSBlbHNlCiAgICAgICAgIGhhbmRsZVN5bnRoZXRpY0Ns aWNrKG5vZGVSZXNwb25kaW5nVG9DbGljaywgYWRqdXN0ZWRQb2ludCk7CiB9CiAK